Re: [dpdk-dev] 17.11.4 patches review and test

["Mody, Rasesh" <Rasesh.Mody@cavium.com>]

>From: dev <dev-bounces@dpdk.org> On Behalf Of Marco Varlese
>Sent: Monday, August 20, 2018 2:21 AM
>
>Hi,
>
>The code in 17.11.4-rc1 does not compile for me.

This needs to be fixed for 17.11.4 as rte_eth_linkstatus_set() is not available in DPDK 17.11.x. Will send a patch with fix.

Thanks!
-Rasesh

>Please, see below what I get:
>
>[  100s] gcc -m64 -DVERSION="17.11.4" -
>L/home/abuild/rpmbuild/BUILD/dpdk-stable-
>17.11.4-rc1/x86_64-native-linuxapp-gcc-default/lib -Wl,--version-
>script=/home/abuild/rpmbuild/BUILD/dpdk-stable-17.11.4-
>rc1/drivers/net/bnx2x/rte_pmd_bnx2x_version.map  -shared bnx2x.o
>bnx2x_rxtx.o bnx2x_stats.o bnx2x_ethdev.o ecore_sp.o elink.o bnx2x_vfpf.o
>-z defs -lz -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -lrte_ethdev -
>lrte_net -lrte_kvargs -lrte_bus_pci -Wl,-soname,librte_pmd_bnx2x.so.17.11.4
>-o
>librte_pmd_bnx2x.so.17.11.4
>[  100s] bnx2x_ethdev.o: In function `bnx2x_periodic_start':
>[  100s] bnx2x_ethdev.c:(.text+0x5ce): undefined reference to
>`rte_eth_linkstatus_set'
>[  100s] bnx2x_ethdev.o: In function `bnx2x_dev_link_update':
>[  100s] bnx2x_ethdev.c:(.text+0x94f): undefined reference to
>`rte_eth_linkstatus_set'
>[  100s] bnx2x_ethdev.o: In function `bnx2xvf_dev_link_update':
>[  100s] bnx2x_ethdev.c:(.text+0x9f0): undefined reference to
>`rte_eth_linkstatus_set'
>[  100s] bnx2x_ethdev.o: In function `bnx2x_interrupt_handler':
>[  100s] bnx2x_ethdev.c:(.text+0xb1b): undefined reference to
>`rte_eth_linkstatus_set'
>[  100s] collect2: error: ld returned 1 exit status [  100s] make[5]: ***
>[/home/abuild/rpmbuild/BUILD/dpdk-stable-17.11.4-
>rc1/mk/rte.lib.mk:128: librte_pmd_bnx2x.so.17.11.4] Error 1 [  100s] make[4]:
>*** [/home/abuild/rpmbuild/BUILD/dpdk-stable-17.11.4-
>rc1/mk/rte.subdir.mk:65: bnx2x] Error 2
>[  100s] make[4]: *** Waiting for unfinished jobs....
>
>
>Cheers,
>Marco
>
>On Thu, 2018-08-16 at 11:18 -0700, Yongseok Koh wrote:
>> Hi all,
>>
>> Here is a list of patches targeted for LTS release 17.11.4. Please
>> help review and test. The planned date for the final release is August
>> 23. Before that, please shout if anyone has objections with these patches
>being applied.
>>
>> Also for the companies committed to running regression tests, please
>> run the tests and report any issue before the release date.
>>
>> A release candidate tarball can be found at:
>>
>>     https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.4-rc1
>>
>> These patches are located at branch 17.11 of dpdk-stable repo:
>>     https://dpdk.org/browse/dpdk-stable/
>>
>> Thanks,
>> Yongseok
>>
>> ---
>> Adrien Mazarguil (2):
>>       maintainers: update for Mellanox PMDs
>>       net/mlx4: fix minor resource leak during init
>>
>> Ajit Khaparde (7):
>>       net/bnxt: fix HW Tx checksum offload check
>>       net/bnxt: fix set MTU
>>       net/bnxt: fix Rx ring count limitation
>>       net/bnxt: fix memory leaks in NVM commands
>>       net/bnxt: fix lock release on NVM write failure
>>       net/bnxt: check access denied for HWRM commands
>>       net/bnxt: fix RETA size
>>
>> Alejandro Lucero (1):
>>       net/nfp: fix field initialization in Tx descriptor
>>
>> Alok Makhariya (1):
>>       bus/dpaa: fix phandle support for Linux 4.16
>>
>> Anatoly Burakov (8):
>>       eal/linux: fix invalid syntax in interrupts
>>       eal/linux: fix uninitialized value
>>       test: fix EAL flags autotest on FreeBSD
>>       test: fix result printing
>>       test: fix code on report
>>       test: make autotest runner python 2/3 compliant
>>       test: print autotest categories
>>       test: improve filtering
>>
>> Andrew Rybchenko (2):
>>       net/sfc: cut non VLAN ID bits from TCI
>>       net/sfc: fix assert in set multicast address list
>>
>> Andy Green (1):
>>       ring: fix sign conversion warning
>>
>> Beilei Xing (3):
>>       net/i40e: fix shifts of 32-bit value
>>       net/i40e: fix packet type parsing with DDP
>>       net/i40e: fix setting TPID with AQ command
>>
>> Bruce Richardson (2):
>>       examples/exception_path: fix out-of-bounds read
>>       mk: fix permissions when using make install
>>
>> Chas Williams (2):
>>       net/bonding: always update bonding link status
>>       net/bonding: do not clear active slave count
>>
>> Dan Gora (1):
>>       kni: fix crash with null name
>>
>> Daria Kolistratova (1):
>>       net/ena: fix SIGFPE with 0 Rx queue
>>
>> Dariusz Stojaczyk (1):
>>       eal: fix return codes on thread naming failure
>>
>> David Marchand (1):
>>       net/bnxt: add missing ids in xstats
>>
>> Drocula Lambda (1):
>>       kni: fix build on RHEL 7.5
>>
>> Ferruh Yigit (2):
>>       kni: fix build with gcc 8.1
>>       net/thunderx: fix build with gcc optimization on
>>
>> Gavin Hu (3):
>>       mk: fix cross build
>>       net/dpaa2: remove loop for unused pool entries
>>       maintainers: claim maintainership for ARM v7 and v8
>>
>> Haiyue Wang (1):
>>       net/i40e: workaround performance degradation
>>
>> Harry van Haaren (1):
>>       event: fix ring init failure handling
>>
>> Hemant Agrawal (2):
>>       test/crypto: fix device id when stopping port
>>       bus/dpaa: fix buffer offset setting in FMAN
>>
>> Hyong Youb Kim (1):
>>       net/enic: do not overwrite admin Tx queue limit
>>
>> Ido Goshen (1):
>>       net/pcap: fix multiple queues
>>
>> Jananee Parthasarathy (1):
>>       mk: update targets for classified tests
>>
>> Jay Ding (1):
>>       net/bnxt: check for invalid vNIC id
>>
>> Jerin Jacob (2):
>>       ethdev: fix queue statistics mapping documentation
>>       eal: fix bitmap documentation
>>
>> Kiran Kumar (2):
>>       net/bonding: fix MAC address reset
>>       net/thunderx: avoid sq door bell write on zero packet
>>
>> Konstantin Ananyev (3):
>>       examples/ipsec-secgw: fix IPv4 checksum at Tx
>>       examples/ipsec-secgw: fix bypass rule processing
>>       app/testpmd: fix DCB config
>>
>> Maxime Coquelin (4):
>>       vhost: improve dirty pages logging performance
>>       vhost: fix missing increment of log cache count
>>       vhost: flush IOTLB cache on new mem table handling
>>       vhost: retranslate vring addr when memory table changes
>>
>> Moti Haimovsky (2):
>>       net/mlx5: fix build with old kernels
>>       net/mlx4: check RSS queues number limitation
>>
>> Nelio Laranjeiro (1):
>>       net/mlx5: fix TCI mask filter
>>
>> Nikhil Rao (5):
>>       eventdev: fix port in Rx adapter internal function
>>       eventdev: fix missing update to Rx adaper WRR position
>>       eventdev: add event buffer flush in Rx adapter
>>       eventdev: fix internal port logic in Rx adapter
>>       eventdev: fix Rx SW adapter stop
>>
>> Nithin Dabilpuram (1):
>>       app/testpmd: fix buffer leak in TM command
>>
>> Ophir Munk (1):
>>       net/mlx5: fix secondary process resource leakage
>>
>> Pablo de Lara (7):
>>       examples/l2fwd-crypto: fix digest with AEAD algo
>>       examples/l2fwd-crypto: check return value on IV size check
>>       examples/l2fwd-crypto: skip device not supporting operation
>>       test/hash: fix multiwriter with non consecutive cores
>>       test/hash: fix potential memory leak
>>       app/crypto-perf: fix auth IV offset
>>       hash: fix doxygen of return values
>>
>> Pavan Nikhilesh (2):
>>       event/octeontx: remove unnecessary port start and stop
>>       net/octeontx: fix stop clearing Rx/Tx functions
>>
>> Qi Zhang (1):
>>       vfio: fix PCI address comparison
>>
>> Radu Nicolau (3):
>>       security: fix crash on destroy null session
>>       test: fix uninitialized port configuration
>>       net/bonding: fix race condition
>>
>> Rafal Kozik (4):
>>       net/ena: fix GENMASK_ULL macro
>>       net/ena: set link speed as none
>>       net/ena: check pointer before memset
>>       net/ena: change memory type
>>
>> Rahul Lakkireddy (1):
>>       net/cxgbe: fix init failure due to new flash parts
>>
>> Rami Rosen (2):
>>       examples/l3fwd: remove useless include
>>       ethdev: fix a doxygen comment for port allocation
>>
>> Rasesh Mody (9):
>>       net/qede: fix VF MTU update
>>       net/qede: remove primary MAC removal
>>       net/qede: fix for devargs
>>       net/qede: fix default extended VLAN offload config
>>       doc: update qede management firmware guide
>>       net/qede/base: fix GRC attention callback
>>       net/bnx2x: fix FW command timeout during stop
>>       net/bnx2x: fix poll link status
>>       net/qede/base: fix to clear HW indication
>>
>> Remy Horton (4):
>>       bitrate: add sanity check on parameters
>>       metrics: add check for invalid key
>>       metrics: do not fail silently when uninitialised
>>       metrics: disallow null as metric name
>>
>> Reshma Pattan (2):
>>       test/flow_classify: fix return types
>>       mk: remove unnecessary test rules
>>
>> Rosen Xu (1):
>>       examples/flow_filtering: add flow director config for i40e
>>
>> Shahaf Shuler (1):
>>       net/mlx5: fix compilation for rdma-core v19
>>
>> Shahed Shaikh (7):
>>       net/qede: fix link change event notification
>>       net/qede: fix legacy interrupt mode
>>       net/qede: fix incorrect link status update
>>       net/qede: fix unicast MAC address handling in VF
>>       net/qede: fix interrupt handler unregister
>>       net/qede: fix MAC address removal failure message
>>       net/qede: fix ntuple filter configuration
>>
>> Shreyansh Jain (1):
>>       doc: fix bonding command in testpmd
>>
>> Somnath Kotur (3):
>>       net/bnxt: fix to move a flow to a different queue
>>       net/bnxt: use correct flags during VLAN configuration
>>       net/bnxt: fix filter freeing
>>
>> Thomas Monjalon (1):
>>       bus/dpaa: fix build
>>
>> Tomasz Duszynski (1):
>>       net/mvpp2: check pointer before using it
>>
>> Wei Zhao (7):
>>       net/ixgbe: add support for VLAN in IP mode FDIR
>>       net/ixgbe: fix tunnel id format error for FDIR
>>       net/ixgbe: fix tunnel type set error for FDIR
>>       net/ixgbe: fix mask bits register set error for FDIR
>>       app/testpmd: fix VLAN TCI mask set error for FDIR
>>       net/i40e: fix check of flow director programming status
>>       net/i40e: revert fix of flow director check
>>
>> Xiaoyun Li (1):
>>       net/i40e: fix link speed
>>
>> Xueming Li (1):
>>       net/mlx5: fix crash in device probe
>>
>> Yipeng Wang (3):
>>       hash: fix multiwriter lock memory allocation
>>       hash: fix a multi-writer race condition
>>       hash: fix key slot size accuracy
>>
>> Yongseok Koh (7):
>>       net/mlx5: fix Rx buffer replenishment threshold
>>       net/mlx5: add missing sanity checks for Tx completion queue
>>       net/mlx5: fix assert for Tx completion queue count
>>       net/mlx5: fix queue rollback when starting device
>>       net/mlx5: fix error number handling
>>       net/mlx5: preserve promiscuous flag for flow isolation mode
>>       net/mlx5: preserve allmulticast flag for flow isolation mode