From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E387FA0577; Tue, 7 Apr 2020 12:43:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 39EDA2BE9; Tue, 7 Apr 2020 12:43:24 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EB38D2B96 for ; Tue, 7 Apr 2020 12:43:21 +0200 (CEST) IronPort-SDR: +Bs7kWVq3Me0agOSNV0w1e1glQ4RSg7k6TK8q4MEuWlKmrSV4DnE/72Jx8yfBxCM6vmVWDugTs QEbhBDP5Jsqw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2020 03:43:21 -0700 IronPort-SDR: E04sRpbdCAViROrpWHp67pupVG6jYS02czKWyUeVGoWOSEYMXaNEHrzs8pEkx7y2QoBLucac+4 V8UShIecH0kA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,353,1580803200"; d="scan'208";a="451179619" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 07 Apr 2020 03:43:20 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Apr 2020 03:43:20 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 7 Apr 2020 03:43:20 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 7 Apr 2020 03:43:20 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Apr 2020 03:43:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FDpLeP3SHf+/goyCuuK/dMxKXZu8di5UxRmPFIaovVc1kdyO2njoTvlQbtvl2s9zedj1KSH/uQZn44by/2OXGfulDtuBqspLhYJlGDGyGndHkZDoLi9n1/H8wVyyRzfkQLJQle5YsljGbETFUIaTKpody959cmWP7J/Ock/Jtkas/W8dgCX77Oh/qoLKkQSI1qFIj1Xpa19BbbXp5Xejtij3LD2Qi06OWzciacf2FVhGiimPX4ijZrL0Lf/Sh0vEiHnHVAnMLslaefhpeBL6PTDXx3xA4U9VWeZ0BsqHQ/LpvOtSaeU2LFMeXuz/EII44310iLquln8QJZqNLMEV5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CWkcCWm5qqMHdy/DrdxeHmyjTlrUakRS0APe0BcVVu4=; b=Zb/pb+lT89+ns4islOoW3zjM8bIe/UTv9C5vU8lB/9PIzxGZ4be13bHeFdpPdeRor8Rk92ykP8eYIysg2ArpO7nTyW6nX7MjTOhZWIFM8z1H5ms++6gTfKhBB1rerC6ukjRPum+MwlsZ/q0FiIzWciu8lcU5NMcqghfCq3jDgOamVUa1XKvjlx2o5zFASjtry4RPzrSCEGJFSMtnc/RSm9Al0Q67DmYJYqlq9b9I0gF2SFCbk5ZD5eXa2sJm4hjtoObQfLuUuaWenU1RPx5ERZC14d0E/AgQ8V6MkRXg9mO/NQWMYfTi50hcWuEGGokMCJUwwYLey8YAqEoUZ6qnTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CWkcCWm5qqMHdy/DrdxeHmyjTlrUakRS0APe0BcVVu4=; b=K7Yko49hyKRbBLWNS39GC7XQGIqEI/7ZSEy0GuSzRta/60FCbuKA12axXtsOiEpooit29jsm4BHUAy4YT+C2TcB17PsVEDMLzvjAwM9iRve7a27Tip+G/n7xcYMluoZPxgHwJckww01hyPvrJjlO2LUbch0xdPoUgDoZK1tEge4= Received: from BYAPR11MB2549.namprd11.prod.outlook.com (2603:10b6:a02:c4::33) by BYAPR11MB2806.namprd11.prod.outlook.com (2603:10b6:a02:c7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Tue, 7 Apr 2020 10:43:16 +0000 Received: from BYAPR11MB2549.namprd11.prod.outlook.com ([fe80::141d:cf28:589e:5f49]) by BYAPR11MB2549.namprd11.prod.outlook.com ([fe80::141d:cf28:589e:5f49%4]) with mapi id 15.20.2878.018; Tue, 7 Apr 2020 10:43:16 +0000 From: "Ananyev, Konstantin" To: Aaron Conole , "dev@dpdk.org" CC: Sunil Kumar Kori , "Burakov, Anatoly" , Chas Williams , "Richardson, Bruce" , David Marchand Thread-Topic: [PATCH v3 3/4] ip_frag: ipv6 fragments must not be resubmitted to fragmentation Thread-Index: AQHWCFT8dAuMqAV7kUCuja5f6Jh1P6htgSVw Date: Tue, 7 Apr 2020 10:43:15 +0000 Message-ID: References: <20200401131849.2209336-1-aconole@redhat.com> <20200401183917.3620845-1-aconole@redhat.com> <20200401183917.3620845-4-aconole@redhat.com> In-Reply-To: <20200401183917.3620845-4-aconole@redhat.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a086687-2b22-4b3c-31f9-08d7dae07aa1 x-ms-traffictypediagnostic: BYAPR11MB2806: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 036614DD9C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2549.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(136003)(366004)(396003)(39860400002)(376002)(346002)(6506007)(8676002)(66476007)(81156014)(71200400001)(81166006)(8936002)(66556008)(64756008)(478600001)(316002)(86362001)(4326008)(66946007)(76116006)(110136005)(54906003)(33656002)(9686003)(186003)(7696005)(66446008)(5660300002)(2906002)(55016002)(26005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1bSvx/K6JF16jfK4azcRI8iZ/wSPF67SMPDCJag/Z6Fiov5oejLAr1ccNGxrMsXNuJrncYKeDvafJ7gp2XUmE/07q0zVz4ysm28LlIyJHo6C60OLSCDxM2kOujr5M7pTNjW7kUfvrvdWDW26j1kTG6/wFrmY3gIg+kxz8/1sI3CQXDIbjvrTKRBiTUvtrpJN1wo5W/A1wl0YX8e7gbomkbBP0UbnEYMmQbU0Ly/5q6/XLPPifs82HDDZ13T6EVkAPraP3o1Bhhu5/f5uhKt0UAvvYaNVfgkIzPkUemj7IfD+8pX+QpAB+L8HaG55z51+xvOJqZ32wsCSefpV3qzzkuUl9GcYmg/8als0AkS/slm+uEOofk4dNiFsPKK3/poS6y1mL2gugh+QA+l+u1nfctV3CCqvsXePQPCnE62widexcNWWubMklvycuY4JnvuL x-ms-exchange-antispam-messagedata: 0K2sBdVRDxr0cIiYaCuRlR2p7L34cEt4l5xxNN8xMAWaaikJVPDzO2yu8g8yhYhhw24Ks0ogd4shwDxP4qqwI0izdhj9BAPX0O05LoTVtNJjALZ7+2VUYvj3IKSoQK082UZwabe/Io5T7ipJ/qdx6g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5a086687-2b22-4b3c-31f9-08d7dae07aa1 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2020 10:43:15.9359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XvEhApA+f7/fxKdnC/FSaJpTHYzD3SVig9IFhJMp7CP3YVm8P2MWCFZG5LbGmcORE2eyu14DwI1ycqprJ8WSirOA2faSlpPirObXn9q7jBc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2806 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 3/4] ip_frag: ipv6 fragments must not be resubmitted to fragmentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > IPv6 only allows traffic source nodes to fragment, Yes. > so submitting > a packet with next header of IPPROTO_FRAGMENT would be invalid. If only source is allowed to fragment packet, then this check seems redunda= nt, no? I can't imagine source calling fragment() twice for the same packet, and I don't see any point for us to check such situations. Besides, strictly speaking the check below is insufficient, as fragmentation ext header could be not the first one.=20 Konstantin >=20 > Signed-off-by: Aaron Conole > --- > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.c b/lib/librte_ip_= frag/rte_ipv6_fragmentation.c > index 820a5dc725..aebcfa4325 100644 > --- a/lib/librte_ip_frag/rte_ipv6_fragmentation.c > +++ b/lib/librte_ip_frag/rte_ipv6_fragmentation.c > @@ -106,6 +106,10 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in, >=20 > in_hdr =3D rte_pktmbuf_mtod(pkt_in, struct rte_ipv6_hdr *); >=20 > + /* Fragmenting a fragmented packet?! */ > + if (unlikely(in_hdr->proto =3D=3D IPPROTO_FRAGMENT)) > + return -ENOTSUP; > + > in_seg =3D pkt_in; > in_seg_data_pos =3D sizeof(struct rte_ipv6_hdr); > out_pkt_pos =3D 0; > -- > 2.25.1