From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04A82A0577; Tue, 7 Apr 2020 12:48:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 895191BE90; Tue, 7 Apr 2020 12:48:42 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 76A682BE9 for ; Tue, 7 Apr 2020 12:48:40 +0200 (CEST) IronPort-SDR: 7nmCdxoK89ymi8oGLmb1Q34S8QNMaS7JzCnepYwgifnO63gwJ4q5Pw6kybG2X/7odLmSQw0pZM dKA3l9HJl96A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2020 03:48:39 -0700 IronPort-SDR: OOOL7mRW04al3e9Ct8u/IxFgneRjxtgrki4sRlJhAMwl91EBUeJBYHVKYBasUr3G12heFjWYkz jCyvg0Os1z8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,353,1580803200"; d="scan'208";a="452387786" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 07 Apr 2020 03:48:39 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Apr 2020 03:48:38 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Apr 2020 03:48:38 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Apr 2020 03:48:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YF5y1nJvnMBFmxORbYaOgkK/2YGRdwkPAhNmcR+4CF0BzWCuHuhrl8aijAmE7lE2mpl2PY1nOHYdZWp2YxYUBGL5On5yKlejwDGmqRoL7MJj2TnIKZyiRUM9nO3nyWi+UpXlp2aHadZc8PVxT/hNPHcxHBu26PHq63Jtr1/zKLtX9sY0cCUFVA+N043G/aE8CA56f5qr0kyKXE8BcBD8mDTQ7u8AmYb3bPlGFlEjFECblduK47YfJ5Dk01O7h4PawoqWk2F66IU5IwqVQxbfpskxCHAYFy+zleUCMVwtj/38UQN8Hng/rLdzrEN+eb2rjBmRjWvFW8jR+W4UTX/xug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vxdSXTRtDYy8oW0/KlYqtQRIzBNw+xv2+MVaWKoqsyo=; b=Omr1eRMeaPPyTJffnhs9b+tddKEG+/gNC31zmUQpt8qCA3x7NeCjThTzyv2rr9mKT0T+nuhtPewwoYFGdWJipElcNDTvmtvX0ly26ilcKpOp1o6Ymvq9v44YheBlKi+1ATxsOXqv2ibZFYPjHFno+C9SaY1bcFAYzYOpP7zWkwXaefdU7Dgq5SPYfRQ0XEiEO079SnTaHYQDn8FiIkdc7oz10dWKIsUGgwkO2lcjBCLsBB1D7ekKWbjMp9n2IQZJNGGoPDHxx/tDsoHo4pnNqA3kCU7bcke8UoLgMblq23CBlzGzWMca/Wj2HPXSJax7qqDSOwxzsIOlcRgqH0KXpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vxdSXTRtDYy8oW0/KlYqtQRIzBNw+xv2+MVaWKoqsyo=; b=hzT6UYvGzpNNl/C7Ey9v2jMHpv2F7XKwcjvcff16LYs7lxOTOaBtqoRm5EWO+ZFYHCgEaLSVA6y+yTPoGlFJvaKc2LFQmT3G/7ragCjhargYADTWaTXPNmeNHXyW8T4Ma7UW5PVAOz0zR43U3ZH2HH9tTxJnf2sH5VNmD2x31t0= Received: from BYAPR11MB2549.namprd11.prod.outlook.com (2603:10b6:a02:c4::33) by BYAPR11MB3656.namprd11.prod.outlook.com (2603:10b6:a03:f8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.16; Tue, 7 Apr 2020 10:48:35 +0000 Received: from BYAPR11MB2549.namprd11.prod.outlook.com ([fe80::141d:cf28:589e:5f49]) by BYAPR11MB2549.namprd11.prod.outlook.com ([fe80::141d:cf28:589e:5f49%4]) with mapi id 15.20.2878.018; Tue, 7 Apr 2020 10:48:35 +0000 From: "Ananyev, Konstantin" To: Aaron Conole , "dev@dpdk.org" CC: Sunil Kumar Kori , "Burakov, Anatoly" , Chas Williams , "Richardson, Bruce" , David Marchand Thread-Topic: [PATCH v3 2/4] ip_frag: ensure minimum v6 fragmentation length Thread-Index: AQHWCFT7AoWeGwdtIEOGwCRiRNW6+ahtgg7g Date: Tue, 7 Apr 2020 10:48:35 +0000 Message-ID: References: <20200401131849.2209336-1-aconole@redhat.com> <20200401183917.3620845-1-aconole@redhat.com> <20200401183917.3620845-3-aconole@redhat.com> In-Reply-To: <20200401183917.3620845-3-aconole@redhat.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 867b2de5-ea06-4e8e-a8fe-08d7dae138fe x-ms-traffictypediagnostic: BYAPR11MB3656: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 036614DD9C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2549.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(39860400002)(136003)(376002)(346002)(396003)(366004)(4326008)(8936002)(55016002)(33656002)(9686003)(86362001)(186003)(26005)(2906002)(478600001)(66476007)(66556008)(64756008)(66446008)(7696005)(6506007)(54906003)(76116006)(8676002)(81156014)(81166006)(5660300002)(71200400001)(66946007)(110136005)(316002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hu15hn51A3l3hSjTIJHDYHsOJnvjpvAG8G0tfy7tqGmDI7/JfEC5ZyaY/a2Yvv0lwRHMwWTUfbNuwn+Gp0IVnZp43Aug978GXk5L9UHx8wEfomY97IS6nrqL5twG66ArtQtuhjPfp4Ia5/SMJs9ZHOo7y5cZVa+T0jdUYBi7nkLKW1ObkExrBgG1ML+mFfEb/+gmsC6a20GB0AoB/z5WO8PP5wSx8Z+zjMr5hUcHrQqtQaVAfW212Mcwb6PcxDleMSEXgk2ul7K9F+OGs3Qsu9vRDVZVbjDmGftajqZMDL9RyxCwCkO1M864wHhH2UJLY3YEvMTii+KQ4KM2IVX7LD92gk1UMqIb4VAAHG4zVDBiF5OmBp5rmqF97bifHdvrPRyNDt+EWhyODBupGPwPVblm3oNIz9eFdqqYvdJLU5cigH4T5499sPu7wqEtCIaA x-ms-exchange-antispam-messagedata: ivr2lKvUBScIAsL4n+oh0GmtjZ2f5SxtWo5cAoTRpYdO+gOwQB8mgt8SsjfgDRYBoeSlovzdc9XBR/CTETqaqHOhi2y7elt/BbLsmV2fb1G78kLwzA7lLDIuoez2klheJIR6Qn6u0HfCaw1tcVop3A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 867b2de5-ea06-4e8e-a8fe-08d7dae138fe X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2020 10:48:35.3725 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VcJRkyih/vTzOeaWkYcr6T0Q3jqbNHexoTKdo2yo/t0GRx9kRWv+1C9ZXx8yEv8XyZjgg/r7bsGpf+N7zlvag9aUjC7tPsAk9c5beeM8tCQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3656 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/4] ip_frag: ensure minimum v6 fragmentation length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Similar to v4, we should ensure that at least a minimum fragmentation > length can be achieved. >=20 > Signed-off-by: Aaron Conole > --- > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.c b/lib/librte_ip_= frag/rte_ipv6_fragmentation.c > index 43449970e5..820a5dc725 100644 > --- a/lib/librte_ip_frag/rte_ipv6_fragmentation.c > +++ b/lib/librte_ip_frag/rte_ipv6_fragmentation.c > @@ -79,6 +79,17 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in, > uint16_t fragment_offset, frag_size; > uint64_t frag_bytes_remaining; >=20 > + /* > + * The rules on ipv6 fragmentation means we need at least to be > + * greater than the smallest fragment possible - ipv6hdr + frag header > + * + min octets. We rely on the ipv6_extension_fragment header to > + * include 'data' octets. > + */ > + if (unlikely(mtu_size < > + (sizeof(struct rte_ipv6_hdr) + > + sizeof(struct ipv6_extension_fragment)))) > + return -EINVAL; > + =09 Don't know where it comes from. Reading RFC 8200, it clearly states that min MTU for ipv6 is 1280B. In fact, I don't see much point in these extra checking. > /* > * Ensure the IP payload length of all fragments (except the > * the last fragment) are a multiple of 8 bytes per RFC2460. > -- > 2.25.1