From: "Liu, Yongxin" <Yongxin.Liu@windriver.com> To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net" <thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v3] usertools/devbind: fix binding for built-in kernel drivers Date: Fri, 20 Nov 2020 02:30:13 +0000 Message-ID: <BYAPR11MB26009DD267BC0364E78923D9E5FF0@BYAPR11MB2600.namprd11.prod.outlook.com> (raw) In-Reply-To: <f47ad3ed-9801-ad4f-64c5-b533ee7d5007@intel.com> > -----Original Message----- > From: Burakov, Anatoly <anatoly.burakov@intel.com> > Sent: Thursday, November 19, 2020 20:19 > To: Liu, Yongxin <Yongxin.Liu@windriver.com>; dev@dpdk.org; > thomas@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v3] usertools/devbind: fix binding for > built-in kernel drivers > > > On 19-Nov-20 7:16 AM, Yongxin Liu wrote: > > A driver can be loaded as a dynamic module or a built-in module. > > In commit 681a67288655 ("usertools: check if module is loaded before > > binding"), script only checks modules in /sys/module/. > > > > However, for built-in kernel driver, it only shows up in /sys/module/, > > if it has a version or at least one parameter. So add check for > > modules in /lib/modules/$(uname -r)/modules.builtin. > > > > Thanks for Anatoly Burakov's advice. > > > > Signed-off-by: Yongxin Liu <yongxin.liu@windriver.com> > > --- > > > > v3: > > - Add built-in module list in loaded_modules for checking > > instead of removing error check. > > > > v2: > > - fix git commit description style in commit log > > - fix typo spelling > > > > --- > > usertools/dpdk-devbind.py | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > > index 99112b7ab..5b34ccd2a 100755 > > --- a/usertools/dpdk-devbind.py > > +++ b/usertools/dpdk-devbind.py > > @@ -181,7 +181,13 @@ def module_is_loaded(module): > > > > loaded_modules = sysfs_mods > > > > - return module in sysfs_mods > > + # add built-in modules as loaded > > + builtin_mods = subprocess.check_output(["cat /lib/modules/$(uname > > + -r)/modules.builtin"], shell=True).splitlines() > > I'd rather not call shell directly, it's bad practice and is potentially > unsafe. The $(uname -r) can be replaced with: > > import platform > release = platform.uname().release # equivalent to $(uname -r) > > The rest can follow: > > filename = os.path.join("/lib/modules/", release, > "modules.builtin") > # read the file contents, split lines, etc. > > Also, please check if file exists to ensure we don't crash the script. > > > + for mod in builtin_mods: > > + mod_name = os.path.basename(mod.decode("utf8")).split(".ko", > > + 1) > > os.path.splitext(os.path.basename(...))? Thanks Anatoly for your detailed instruction. v4 has been sent. /Yongxin > > > + loaded_modules.append(mod_name[0]) > > + > > + return module in loaded_modules > > > > > > def check_modules(): > > > > > -- > Thanks, > Anatoly
next prev parent reply other threads:[~2020-11-20 2:30 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-18 2:58 [dpdk-dev] [PATCH v2] usertools/devbind: fix binding for built-in 1kernel drivers Yongxin Liu 2020-11-18 16:27 ` Burakov, Anatoly 2020-11-19 7:24 ` Liu, Yongxin 2020-11-19 7:16 ` [dpdk-dev] [PATCH v3] usertools/devbind: fix binding for built-in kernel drivers Yongxin Liu 2020-11-19 12:18 ` Burakov, Anatoly 2020-11-20 2:30 ` Liu, Yongxin [this message] 2020-11-20 2:22 ` [dpdk-dev] [PATCH v4] " Yongxin Liu 2020-11-20 10:49 ` Burakov, Anatoly 2020-11-20 11:38 ` Burakov, Anatoly 2020-11-23 3:05 ` [dpdk-dev] [PATCH v5] " Yongxin Liu 2020-12-03 8:25 ` Liu, Yongxin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BYAPR11MB26009DD267BC0364E78923D9E5FF0@BYAPR11MB2600.namprd11.prod.outlook.com \ --to=yongxin.liu@windriver.com \ --cc=anatoly.burakov@intel.com \ --cc=dev@dpdk.org \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git