From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD023A0556; Thu, 20 Feb 2020 16:47:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9155C1BFA0; Thu, 20 Feb 2020 16:47:04 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C76F81BF98 for ; Thu, 20 Feb 2020 16:47:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 07:47:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,464,1574150400"; d="scan'208";a="315768661" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 20 Feb 2020 07:47:01 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 07:47:01 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 07:47:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V4Y0mi0TEbnAvfHfx1kgR1aRikITLJoXgqzdI3+aAuUD0WnIBmKohTQi9IMWw9KXhgk2AOrY4LLdeU7GShMpJu8vatTjhTfCIoNEAUb2m1XygXpY7OhJ4pcHIod48qhVop5ws7bgkF4cmurlggsiM0mTJjK9IB9qfKR0wOsksLU+4FWvyt9oVWELpR1HikN2Rjq/XpTdVLKRoP4xa6rWuzBvGSG/MUxkL7XT9YAI5FaCfafJx+KnQ8IFLtaA1EcWz8hPwUoL+7hPW45eE5sWwaCWO2wgEkJketbIhS2ebs+JbcUZfhYdI5bqaf4USK8Xn0d23rPkGjz/E2NqzL41cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7n462djBzTf/L/7oIsrwR4JVShVVjhqqg9AVZAj3qws=; b=lsO1ESYmn/zEPkLsJ10UPTLLeJ81VN/iwnXa5tVU7Bvy579NnY0lTWwGoiFyjRfZ6qM7hXIMCUMshL1faujOrKyIdo82EZH3Tax34rI/oIhKs+QAPBYdLzLe4lkg3RBK7DHSouYB5qq6ZwqoIkaYWKvXRmP2VqzySPkRmQhGFaZJK2L+2fTkkQdGfrtb8IkJKfMoxsU9zLSPy0lsPEwPf1+4wRRmUvohwhhGfxOE62YfiRDN6NkDdP+AijDYkxAiwsKM5iZgcTgLgS19EP8b1T/O/daKleTrSQQatEzHzMcqVy4LvqU+9cViRkCcWxOLeDYBAq7VVsryvURpS6vyQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7n462djBzTf/L/7oIsrwR4JVShVVjhqqg9AVZAj3qws=; b=cbyzNOdBgI2Hd9Xnn7xTVCGl3UJnV2+111KhUummT7GpFMdyX1NHiYoCbOXx1PmWIY8ocKjv5H/peyCpQcGCBUs7aNJ+mjWapAIMyZj9m/KlFwhPHRuEKs8t0JZa+6M2oY4L2A/3WzemyYCcwFrK961tIrTuUDjBgXcoR4DYc8M= Received: from BYAPR11MB2648.namprd11.prod.outlook.com (2603:10b6:a02:c7::10) by BYAPR11MB3304.namprd11.prod.outlook.com (2603:10b6:a03:7a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18; Thu, 20 Feb 2020 15:46:57 +0000 Received: from BYAPR11MB2648.namprd11.prod.outlook.com ([fe80::d0d2:ce29:adf5:f6a5]) by BYAPR11MB2648.namprd11.prod.outlook.com ([fe80::d0d2:ce29:adf5:f6a5%7]) with mapi id 15.20.2729.033; Thu, 20 Feb 2020 15:46:57 +0000 From: "Govindharajan, Hariprasad" To: "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "stephen@networkplumber.org" , "david.marchand@redhat.com" Thread-Topic: [PATCH v2] app/testpmd: fix return value in portlist parser Thread-Index: AQHV6ASUzrj61LRrI0G7g+X/c5yKf6gkOVaA Date: Thu, 20 Feb 2020 15:46:57 +0000 Message-ID: References: <1582205191-14105-1-git-send-email-hariprasad.govindharajan@intel.com> <1582213402-18941-1-git-send-email-hariprasad.govindharajan@intel.com> In-Reply-To: <1582213402-18941-1-git-send-email-hariprasad.govindharajan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTA2MTdiMDgtYzY5NS00ZmQzLTg3M2MtYzI0ZGE1MmRiYWNlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRWwrTVlFMUcyNlJkTFlyOUNOTzFZOGczb3pwK1hFbFR2cHNiSmtDVWxGV0tyR2RlSUltUDkweGd6dEdadTYwaiJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=hariprasad.govindharajan@intel.com; x-originating-ip: [192.198.151.166] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: add8d395-bd44-4130-8b33-08d7b61c1e1e x-ms-traffictypediagnostic: BYAPR11MB3304: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(136003)(39860400002)(366004)(396003)(376002)(199004)(189003)(8936002)(7696005)(52536014)(8676002)(81166006)(186003)(81156014)(71200400001)(26005)(6636002)(55016002)(9686003)(53546011)(6506007)(5660300002)(64756008)(110136005)(2906002)(478600001)(66476007)(4326008)(66446008)(66946007)(86362001)(316002)(33656002)(66556008)(76116006)(54906003); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR11MB3304; H:BYAPR11MB2648.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IlxW899grOoquDBwFue4e6DffulkRVzBnhbKS0Wlm8gmyguKDTgunn4eo8uTfkfwiaerZewj6fJFqtOHL8BPY6sac2STLgvR4CtVCUj3V1anmYcsGlIQEYs4kW620l46STsW/B8OW/Esfx9ar8e60WZWIrDJ1H9XHGRwozclqHwuq86MBysrq0Si8Hvv3VIqrYoyXeS+DGGtGL7Ws7lwD3SrO9bNIDIN5aFx17sWhMUJ+Efq7G8Y1aKpDhQZ6xXncZhPAjnPgirYJG/npP4Tm/+dKCSO7xS+RcHkZ/X5VbRYJOAiJL1+mp9GsbNgfzCSwNlpKLOplnPuHJNF0YuvbI0Yi7W/+ys9qcY0sRIRJAWSySB0wecbZui1Zuhn8ocvHAeZ5aSIt+M8Z11PD+utFHOVumRzVC1hKa6Ko6VJ6exvavQup/nqObMwWY0AZj41 x-ms-exchange-antispam-messagedata: uD7LcyxXLoTd71E2JtPUGZc4cyFzY4oUtYRpVWEkuYe59pjNe7JkXRUldab4LnJWezC8qXZqlGPHYtjltt6shZs/yc3usohvXFreiwiGZgaYNmjZVOnFcy3F2Ah/eyDCCUG7WRg3ds+qUJriPoutWg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: add8d395-bd44-4130-8b33-08d7b61c1e1e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 15:46:57.5243 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UvAK6kgsw3/LmcL0OjvkzwTZRy9Gbe1IkxzB4IgojUhj++srpFnujv6O8ZBbLr6kMBuI1MuF3yIaITEFGICi2JlGdtLzKgIcWc8x7PeO5EiEcXO98l0obWlMTQNDuvJX X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3304 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Govindharajan, Hariprasad > Sent: Thursday, February 20, 2020 3:43 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Yigit, Ferruh ; > stephen@networkplumber.org; david.marchand@redhat.com; > Govindharajan, Hariprasad > Subject: [PATCH v2] app/testpmd: fix return value in portlist parser >=20 > The function parse_port_list() is designed to return unsigned int value. = After > sanitizing the inputs, it is returning -1. Changed it to return 0. >=20 > Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") > Cc: hariprasad.govindharajan@intel.com >=20 > Signed-off-by: Hariprasad Govindharajan > > --- > app/test-pmd/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > 9d95202..91db508 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2642,7 +2642,7 @@ parse_port_list(const char *list, unsigned int > *values, unsigned int maxsize) > unsigned int marked[maxsize]; >=20 > if (list =3D=3D NULL || values =3D=3D NULL) > - return -1; > + return 0; >=20 > for (i =3D 0; i < (int)maxsize; i++) > marked[i] =3D 0; > -- > 2.7.4 This patch was acked previously by Bernard Iremonger. Just changed the patch head line to correct format. Acked-by: Bernard Iremonger