DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jiang, YuX" <yux.jiang@intel.com>
To: "Li, WeiyuanX" <weiyuanx.li@intel.com>,
	Huisong Li <lihuisong@huawei.com>,
	 "ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
	"huangdaode@huawei.com" <huangdaode@huawei.com>,
	"liudongdong3@huawei.com" <liudongdong3@huawei.com>
Subject: RE: [PATCH V2] app/testpmd: fix display types failure when query RSS rule
Date: Fri, 8 Jul 2022 08:15:47 +0000	[thread overview]
Message-ID: <BYAPR11MB27110357AAB7E3899EA493D7FE829@BYAPR11MB2711.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BN6PR11MB3923BB6BA1D266DDC35379E8E4829@BN6PR11MB3923.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Li, WeiyuanX <weiyuanx.li@intel.com>
> Sent: Friday, July 8, 2022 1:32 PM
> To: Huisong Li <lihuisong@huawei.com>; ferruh.yigit@xilinx.com;
> andrew.rybchenko@oktetlabs.ru; dev@dpdk.org
> Cc: thomas@monjalon.net; huangdaode@huawei.com;
> liudongdong3@huawei.com
> Subject: RE: [PATCH V2] app/testpmd: fix display types failure when query
> RSS rule
> 
> > -----Original Message-----
> > From: Huisong Li <lihuisong@huawei.com>
> > Sent: Friday, July 8, 2022 9:42 AM
> > To: ferruh.yigit@xilinx.com; andrew.rybchenko@oktetlabs.ru;
> > dev@dpdk.org
> > Cc: thomas@monjalon.net; Li, WeiyuanX <weiyuanx.li@intel.com>;
> > huangdaode@huawei.com; liudongdong3@huawei.com;
> lihuisong@huawei.com
> > Subject: [PATCH V2] app/testpmd: fix display types failure when query
> > RSS rule
> >
> > Now testpmd fails to display types when query RSS rule. The failure is
> > because the '\n' character is missing at the end of the function
> > 'rss_config_display()'. Actually, all places calling 'xxx_types_display()'
> > need to '\n'. So this patch moves '\n' to the inside of these function.
> >
> > Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
> > Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output")
> >
> > ---
> > v2:
> >  - move '\n' to the inside of 'xxx_types_display()'.
> >
> > Signed-off-by: Huisong Li <lihuisong@huawei.com>
> 
> Tested-by: Weiyuan Li <weiyuanx.li@intel.com>

Thanks Huisong.

Hi Huisong, Ferruh,

May I know that this patch can be merged into RC4?

Best regards,
Yu Jiang

  reply	other threads:[~2022-07-08  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 10:50 [PATCH] " Huisong Li
2022-07-07 12:22 ` Ferruh Yigit
2022-07-07 12:42   ` lihuisong (C)
2022-07-07 13:12     ` Ferruh Yigit
2022-07-08  1:21       ` lihuisong (C)
2022-07-08  1:41 ` [PATCH V2] " Huisong Li
2022-07-08  5:32   ` Li, WeiyuanX
2022-07-08  8:15     ` Jiang, YuX [this message]
2022-07-08 10:31     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB27110357AAB7E3899EA493D7FE829@BYAPR11MB2711.namprd11.prod.outlook.com \
    --to=yux.jiang@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=huangdaode@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=liudongdong3@huawei.com \
    --cc=thomas@monjalon.net \
    --cc=weiyuanx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).