From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E508AA00C2; Wed, 2 Nov 2022 06:20:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D6F140693; Wed, 2 Nov 2022 06:20:21 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8BB2840223 for ; Wed, 2 Nov 2022 06:20:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667366419; x=1698902419; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AsIHuNkv0fdsurDNO8RODhzNsaObHZC7vvg2PRG0hNA=; b=dPBAAc+2+lTYeTqGl5xFjj41I43izQF4lUAGyppaKC7CyQW+GaNqCqc2 xWXzoOrWxUsUL+qnsxeCiLB4GIA6p9S7KSL4bxaPzslXDz1kp9DT9Xmv+ Xh/nDFxN10IIg5SzK7h5Hx+dT5lRyS+xJn+U8i2qt2USymY4kaM0w1EtM zSeHKGQ1zurk0QIj5QP7qcB6LHi3fOwUhKfCCbB0ik4f+1UgTvnzl26UD h25PjhjqJ0r07dVO/QBz9Wh0a4ATfTsBsRky/NsxJO4DxZmYVkXGJtspl QquMFsDWXbS1iRtbXXFdKzBJ+4DI33UO02Pi6Cpln+tbBP+j/fJVJ8W+t A==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="309313393" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="309313393" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 22:20:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="612104198" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="612104198" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 01 Nov 2022 22:20:18 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 22:20:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 22:20:16 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 1 Nov 2022 22:20:16 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 1 Nov 2022 22:20:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ngWQsdvFomSN0c0c7YgW6KG/YfYPpJbkFfdgck7+EoAEWHfSyyDSYhVqpSf/yQFcgpAaHX9ycShIls+o5qh89S7Zi66AmjeYdM3FQ+9gUjAANFWFQWbSmiAJ6EhTHcpvxhtCAJ2dQN9e3LqnkO2Qyqqnrz4PTcYhCfrgbkKs7TvDK5wbdkc/1t5zGs1A6FFij1vfxGEXkSlgFkpSGjI7oZoYqEex8FoSAINsL9vrdqumDYs2bFq8XqQUI53h301w+FHQNJ7VUGlRZjgrO4iUEs6YUoBGmZtgFHtg+1H36bM5KLNHuZdPI1P6pFDZyV2sQntpKjpf4EwQ4bZ26FQiGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7WRT5UX1vzT3u/ehZ9panmCojCdmky+iPp5WhqP3jQ=; b=mRGVYD09V4Zt+C6hR2XPpkYvkOrWXEaatPJ/F+O3ywDsiL1p7A8hCE/WgoRICNd32JFyHubuUNWczBDg94XVpl0dAwYNCGGdM6z1YMFkec0B5kZ93v6VAvxmOxzZfTKXYVQg5lOoNWsNeWC25BRB+442IW6T26F93bWyxODkLAqvHXRpJ9tICxqDvk65RJmYpth+WN3cO7HL5xe3ghjqBMem25ojAw9guWW9/4SWIWplvDH9/WwZ3nUvSIu7AoPTcSwJaX0jhTv031fSBI97RkpBU8JB/ur31cNvBPbxbn7T1k6ZHzPpJmLF1Lc3mrgTkujrbCTYMq3niqWoS9UOCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB2711.namprd11.prod.outlook.com (2603:10b6:a02:c2::30) by MW3PR11MB4668.namprd11.prod.outlook.com (2603:10b6:303:54::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21; Wed, 2 Nov 2022 05:20:14 +0000 Received: from BYAPR11MB2711.namprd11.prod.outlook.com ([fe80::b95b:ac1f:484:c589]) by BYAPR11MB2711.namprd11.prod.outlook.com ([fe80::b95b:ac1f:484:c589%4]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 05:20:14 +0000 From: "Jiang, YuX" To: Ivan Malov CC: "dev@dpdk.org" , Chas Williams <3chas3@gmail.com>, "Min Hu (Connor)" , Andrew Rybchenko , Chas Williams , "Burakov, Anatoly" Subject: RE: [PATCH v2] net/bonding: make bonded device configure method re-entrant Thread-Topic: [PATCH v2] net/bonding: make bonded device configure method re-entrant Thread-Index: AQHY4ypJVGQo8+t7V06MozjDyNHajq4p+ewwgABfOgCAANUecA== Date: Wed, 2 Nov 2022 05:20:13 +0000 Message-ID: References: <20220911122405.3995083-1-ivan.malov@oktetlabs.ru> <20221018194549.635113-1-ivan.malov@oktetlabs.ru> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB2711:EE_|MW3PR11MB4668:EE_ x-ms-office365-filtering-correlation-id: 084e3c3b-e03c-4552-8861-08dabc91ebe9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tonZnKTln2dXYhn+qsEqLqDV742ukxK/ezuyA3+VNjs2PRbuWcAQKBVWX6xHGgT0KhlVEKqx7cQErjG/Wvk99XVcHOb7GVoz1n88kV4BbWXuLGT2A6/sFo91ZdLwkyzQOm/eHk6WjYAyqa2zC01XSN75NUB+ae1G5VqZLyZUT2wiTrNi9l59rJ3z/9FYlqzHoFH98d+pXTgZHKRyjNhnis+fhaJN3UTrmFrJHkW7UQkSXEQYXLDqTM+sCX5kxFsUYUr3EzUauOej7nBo+iZMlA+47jYXJpdGHiJSBOCDdkFcppjETVmS4Xu3UtYF8RarUJjecTlmFIqo1bNouEZRrIQYyluaZFWH/QdGj/5DoJVTmwwXthBFxYXmiZbu1SJvf+ntaLkQS4zs/lErda6SE4VoOoleaoyNOseopiAnZ30JF/7LE3JeMia5iMZ+e3i8x7zYg6JZZXcqw98APYZwuAdIn3w4Kb54Z6+Jp2/BSy5goMYC5Ozl0Lo2onxGyYd0RVi7ER8ekb6dLOP8eDBf5uXJY0kqDrTsdbnnHlSxEdJAhWX5YvFLUgMgyyszZ+U6PGBR2Eep955ZN0ypEd5526rLuFkaDSr1LdrS9utPfXEEAXJP1JN55JVzjyQUk4G+MoRekXm+KgmODeVhX1JW++6saUsVpEnDrAr++Ze7M8pmqYon1+52iVwP2Fsiko5z6RlswP4u/wH3vQYGr3LquPA3ctX3YirKeKzxqaRwkRMJt4uf9EFAfhsutfSQPzzhlAS4zFgnIInGvmpmn4Qrm3M0IHJI0fmd1OLsF/edcAFxHWcaEQHNZ+8+WBhajrNpTv4+ODxPehkhoSjPYfJaAA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2711.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(136003)(39860400002)(376002)(366004)(451199015)(83380400001)(38070700005)(86362001)(33656002)(66556008)(82960400001)(38100700002)(122000001)(2906002)(5660300002)(4326008)(66476007)(53546011)(64756008)(8676002)(66446008)(66946007)(52536014)(8936002)(76116006)(6506007)(107886003)(9686003)(186003)(26005)(6916009)(316002)(54906003)(7696005)(966005)(41300700001)(478600001)(71200400001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?K1aAnNDx1lN0nL1WYWaASbBd8ezyL7hMppPOXelGtKoDf9JMoQxlbihu6BAr?= =?us-ascii?Q?WmNd1A7raBwj+Kw6jhtgUp3DH5NMkkwtKk73CzyXtC17HUh+52qM0nllZOKH?= =?us-ascii?Q?MmIX93HaTb9rCTFaFOkv054TcsBe0pmSI4qovd38tkxqSukvWcxKLR9poEjY?= =?us-ascii?Q?jqaLx7Ravc+TZC69j4UFHBVh4iJy1+PpbCt6TNTOREAT5GnyxCilh0iJs/cR?= =?us-ascii?Q?fC1SoH60fhkHd1JedzFSJL75KlUpZN8K0YHnwrFiZ7uyvei+tdBNrDfZ0+8S?= =?us-ascii?Q?o9XzLqpr9K/ydCHPLVib2Y9qd0+tIV8z24vEpdHIuM6MUCU//DW771MjufwF?= =?us-ascii?Q?ei8OB3mMxqQNozQAZE/aAZZ4KyEqk6YiXY1d4giqIGGvA9MUYfWByol6gX31?= =?us-ascii?Q?ppXnJ03ZLUUW23Zwmi3PXwaJeGlRUGR0M8xUpmjd+E0INdY7sgfAoyYkrDc1?= =?us-ascii?Q?LUB54WAJG/+WPnpg1XUXRZ77y/uPzBeMXUsSOYuViCtevKC3KieWCkrowNmL?= =?us-ascii?Q?NU/+iRKF5B17FYBZATpka4gpiILrd3R4M+96P5cuDHhFipGwlLvEVugYcuaD?= =?us-ascii?Q?HNP1tTHrTrPjox7mNtrM/Mz22MmP1XqlS27mNzboOR97fLmTIMzcaqWkb6Lo?= =?us-ascii?Q?IGElJ9SR1z4R+7JOBVcSIaPttQx8i3Fz1juHxPHgUXtszxO1tw+eRFYhFM5n?= =?us-ascii?Q?uSrZsjC2nNTyzT9BCkJq120pLpA/I0A7LwDHCVxBxnVyA0Yk0SQoeM0do3LS?= =?us-ascii?Q?PVj5Z3KCrsGNhcCkW/FO14FIykc1dGoTZL5St7tRWexw3F4k3qevQMG+QVR2?= =?us-ascii?Q?QHA3shTNFsn79lpLV86kxpzT5NzIukYYhdiN1LCW5Rlo8ljiwpIQgfH5/2fO?= =?us-ascii?Q?0ayEsxOX5uxudjNdlZcPy/TteDrhHSJ+nMK8n01ar7NdZ9tl2SfFdVipaWE5?= =?us-ascii?Q?WBeBvYxqomVEMpBAVzTXmiYuurg9LN1KWJxgmsVpCGvMJbvLrg1AimwL/mpa?= =?us-ascii?Q?/KTAp6TFhkIwOK88Ja2BqlguTA2ycCBLONmnvYghHEMkOCuTC9q0+RTnv9dk?= =?us-ascii?Q?Q7QfdgG3lrac7M8UL/LF98E7mqFxXzZEWlWdW5Thk368JkqwkGXkeWPyctTz?= =?us-ascii?Q?AKuR8DYkFn8h21SOZkycrKbvCakV+W5VIim+7a7hTXS6R2/goFRI+byR2kiU?= =?us-ascii?Q?WeHNtrrFmw3IgSS9FSfSuXuWP2Jp9/l4ih6UjmlU6ZtmM4bhNuHJzV1zH/aI?= =?us-ascii?Q?Q+lZwRZyz2xBUIwUNoRyXP27dEblprvZeXWSJdhp1FySKq4LhVTlWlJpAHoe?= =?us-ascii?Q?0fKq2ROEWc1K35sdXRm/podXvN1ZVW4fQ8vT8Zpfv/uVPPOfSb7QKU+zAF6+?= =?us-ascii?Q?aWlKuILm5l/PptrAw2lHflWi+vwXMnQQCd8umOGpybDBmdpDiCWoHq/V3yDq?= =?us-ascii?Q?c9fPkXpJAiMXbiCbgUrJL9Pl/gptjUdDWfAKGND7KFNy21bdMU87qMsHdamt?= =?us-ascii?Q?rFfln6TYhvAYeHbHW8EW+reUjRM4pkiM7CNUYVMNVmDRcd9RTbnhgsIkrflW?= =?us-ascii?Q?pVq538WcOFV9x5uRtbLVRQUPyGNcZNZYnbICA2kn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2711.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 084e3c3b-e03c-4552-8861-08dabc91ebe9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 05:20:14.0264 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gba7XsJbraOH0Ka8ZFgumhBYYlsGUBGLDT64CHuBJbrnth4/nvAyvjhG9M/iKwrquWUukqLhmv94x0EMktLA4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4668 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ivan, https://bugs.dpdk.org/show_bug.cgi?id=3D1119 https://bugs.dpdk.org/show_bug.cgi?id=3D1118 Can be fixed by patches:=20 https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.= malov@oktetlabs.ru/ https://patches.dpdk.org/project/dpdk/patch/20221031131744.2340150-1-ivan.= malov@oktetlabs.ru/ Best regards, Yu Jiang > -----Original Message----- > From: Ivan Malov > Sent: Wednesday, November 2, 2022 12:34 AM > To: Jiang, YuX > Cc: dev@dpdk.org; Chas Williams <3chas3@gmail.com>; Min Hu (Connor) > ; Andrew Rybchenko > ; Chas Williams ; Burakov, > Anatoly > Subject: RE: [PATCH v2] net/bonding: make bonded device configure method > re-entrant >=20 > Hi, >=20 > Thanks for noticing the bug. A fix has been proposed already: > https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1- > ivan.malov@oktetlabs.ru/ >=20 > With the fix applied, does the problem still manifest itself? > Please let me know. >=20 > Thank you. >=20 > On Tue, 1 Nov 2022, Jiang, YuX wrote: >=20 > > Hi Ivan, > > > > This patch introduces a bug https://bugs.dpdk.org/show_bug.cgi?id=3D111= 9, can > you pls have a look quickly? > > > > Best regards, > > Yu Jiang > > > >> -----Original Message----- > >> From: Ivan Malov > >> Sent: Wednesday, October 19, 2022 3:46 AM > >> To: dev@dpdk.org > >> Cc: Chas Williams <3chas3@gmail.com>; Min Hu (Connor) > >> ; Andrew Rybchenko > >> ; Chas Williams ; > >> Burakov, Anatoly > >> Subject: [PATCH v2] net/bonding: make bonded device configure method > >> re- entrant > >> > >> According to the documentation, rte_eth_dev_configure() can be > >> invoked repeatedly while in stopped state. > >> The current implementation in the bonding driver allows for that > >> (technically), but the user sees warnings which say that back-end > >> devices have already been harnessed. Re-factor the code to have cleanu= p > before each (re-)configure. > >> > >> Signed-off-by: Ivan Malov > >> Reviewed-by: Andrew Rybchenko > >> Acked-by: Chas Williams <3chas3@gmail.com> > >> --- > > > >