Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator

["Xu, Rosen" <rosen.xu@intel.com>]

Hi Thomas and Ferruh,

I just back from my Labor Day Holiday. I have checked there is no usage in ifpga bus.

Thanks,
Rosen

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, May 04, 2021 23:50
> To: hemant.agrawal@nxp.com; Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; stephen@networkplumber.org;
> longli@microsoft.com; Xu, Rosen <rosen.xu@intel.com>
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: add missing buses in
> dev iterator
> 
> 04/05/2021 14:49, Ferruh Yigit:
> > On 4/29/2021 9:01 AM, Hemant Agrawal wrote:
> > >
> > > On 4/29/2021 1:26 PM, Thomas Monjalon wrote:
> > >> 29/04/2021 07:55, Hemant Agrawal:
> > >>> This patch fixes issue with OVS 2.15 not working on DPAA/FSLMC
> > >>> based platform due to missing support for these busses in
> > >>> dev_iterate.
> > >>> This patch adds dpaa_bus and fslmc to dev iterator for bus
> > >>> arguments.
> > >> I think we should add VMBus as well.
> > > They are 2 buses remaining vmbus and ifpga. However I don't know, if
> > > they use args as vdev or as pci?
> >
> > cc Rosen for the 'ifpga' bus, 'vmbus' maintainer seems already cc'ed.
> >
> > This variable ('bus_param_key') is used to construct 'bus_str', and 'bus_str'
> > seems used only for the '.dev_iterate' bus operation.
> >
> > Since 'ifpga' & 'vmbus' are not implementing the '.dev_iterate', so is
> > it really required to add them?
> 
> Good point Ferruh.
> 
> The only bus implementing dev_iterate are dpaa, fslmc, pci and vdev.
> So this patch makes sense.
> 
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>