From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E0B3A034D; Mon, 17 Aug 2020 07:27:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4846F1C11A; Mon, 17 Aug 2020 07:27:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BC0AD1C114 for ; Mon, 17 Aug 2020 07:26:58 +0200 (CEST) IronPort-SDR: Qq7YFxDKisjiARbmh84ygOI4fsEMR1twnL8qLKbOiY2S3yUQkS1mSMcJPhWz8wg1Z2lzVk9YaZ drnn2Dca3TsA== X-IronPort-AV: E=McAfee;i="6000,8403,9715"; a="142466644" X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="142466644" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2020 22:26:57 -0700 IronPort-SDR: r/CN+Ezia3FhrDObBdw+pgBAuXG5RuIOSvUATM3GPkZi4vNIBOJFoEIMlJqqfHB1MAeY2W1ROG Ny3obTD4V+RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,322,1592895600"; d="scan'208";a="400091389" Received: from unknown (HELO fmsmsx606.amr.corp.intel.com) ([10.18.84.216]) by fmsmga001.fm.intel.com with ESMTP; 16 Aug 2020 22:26:57 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 16 Aug 2020 22:26:56 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 16 Aug 2020 22:26:56 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Aug 2020 22:26:56 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 16 Aug 2020 22:26:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4f4wBZdHV8vSVs7yGTtHbIy4QDti3nYAFbCVi7ZgT5RBfgyNkOtvWKQHRhHMpaeynTHaJ37OI0NWlP/BBomSaYjAZz7+FEv7qaZwp/yK+JfrITI7pL+ajU8zrUVTpm8kww2Qo1sxKZUOijEmvUywG2OKPA7wic8CZQtKHDcbXB2MlrCRjRnkhq5v+E7IdEE+4p/ohoRtOrluwb68778pOAhMfvs4Q5DVrQ8FuImpcNYsM7sI9gr8/RU81uFjxMzxSxpOlaXmSc9WtaUGQ9bhvwLmuekvf1fQANvUZubb9wXJZ20ktAzFowUf+y6DB5qrm3PpvIVeZ5Zat+aP2CKPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6N9wDSLV6QY3P06AuQlFac2Tlm9zRjsU4BJeD0zKXvA=; b=JOWLnIFbSjW/3Pe7kGaMFSFdO/tLzKKVbUb8KC4cYuwCpmFlvhNxIKFomhT/qb7iRguUG27+10MrV20a+99D+6VHik6w2THxyeXjrLin5McCM/izAXA8FJw6ix/k0uT4lLW4u6L8uGBXRkNoJuumMGVp3QPrMZ17hhQmwXk/4k0qGhUrbpXEwRjQCqdaQw3DU4AH4F0ZyVpooIh1XINcoM4z4UokEbatSSXk1xlPCte/cL3P35Y9sfldYoWkLqCOI8x/DcQgf/dSm566s6jUnvLsMZtWCH1aOKd/eNbF4H3hBVLsBVqXdhGpvkV8v9i6TgRvN8FflHLhQk0kWeHcng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6N9wDSLV6QY3P06AuQlFac2Tlm9zRjsU4BJeD0zKXvA=; b=zjIV+PHPL6sIktRah3kB6YBVswwwz4xroHOakCvPsNtPmwdJK1FuTxFo6xBVeuL4uffKxyJrvkMhVMqVKbP3Fjij7c0n9CJO66fjlwlXknxTsaC3swCJcljGfwkhuZqwdB9B6x+Kw9vMO1uvC/ToKiQJIaJxRwbdHA2bh5CjZDY= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BYAPR11MB3719.namprd11.prod.outlook.com (2603:10b6:a03:fa::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Mon, 17 Aug 2020 05:26:54 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::515:a970:3fec:fb73]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::515:a970:3fec:fb73%6]) with mapi id 15.20.3283.028; Mon, 17 Aug 2020 05:26:54 +0000 From: "Xu, Rosen" To: "Richardson, Bruce" , Nipun Gupta , Hemant Agrawal CC: "dev@dpdk.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Zhang, Tianfei" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [PATCH v2 1/7] rawdev: add private data length parameter to info fn Thread-Index: AQHWcWTghObEpYSpOEq8p8QYoO4Koak7yyeA Date: Mon, 17 Aug 2020 05:26:54 +0000 Message-ID: References: <20200709152047.167730-1-bruce.richardson@intel.com> <20200813112806.164578-1-bruce.richardson@intel.com> <20200813112806.164578-2-bruce.richardson@intel.com> In-Reply-To: <20200813112806.164578-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWY0NjhkYzAtMGE4Ni00NjU2LTliZDQtMWM5OTk3NTE3ZTg1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibnIzN2tHTThXZElRM3dFcGxtSzZoZ3p4SXJSOGUxQ01tTlFwNVwvZFJGYkZnUGpGWnpYc0tuTXc1amNnYXJVS2kifQ== x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3d2345a3-76ec-4818-467d-08d8426e2732 x-ms-traffictypediagnostic: BYAPR11MB3719: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EoPNPBsMi3zD1D+BO+gIvxUNqDb0oWYBVy4BOO2tNiyXY97vLOKYldvLpJzGZfnUWqSP1okeklwrqzVKaSbhnj78AcLR0zX+EFrChdgPmGcNELbNK8d6NhLXbIZMSc7jwntFl871sbJVEMUJiAdRrSNybD9qM9uXmWHfDNlWqX0NRBX2rTRV7IMHL92LQi0PQdnR9+Q790k0GvfjO/a9FU94ZCfaPDo4z77jkDoCb0lNM6sEWMInY/7rSu7HvC0Tm919VbRH1XxJdIE7aJeZJ2neZb+Myvvm3lJegQh2Wr2ZHctp8lrgtuaIWPM0g3AXfNZMxgeyc6+Z1Hk1JbsZHA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(396003)(136003)(346002)(366004)(7696005)(53546011)(55016002)(6506007)(54906003)(478600001)(5660300002)(71200400001)(110136005)(8936002)(316002)(26005)(52536014)(107886003)(186003)(9686003)(76116006)(83380400001)(33656002)(2906002)(66946007)(4326008)(30864003)(8676002)(86362001)(64756008)(66446008)(66476007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 1d1iLNxV/903GHr3yn8xj2GFKX+4svzKWHapJflRJW5M4Sn2MpmtRBZLvbn4k87Q6/ePiYQHguacP2zQLoN9eC/vRZpZW7lHEBWmJ/t4/S1TullLLRnH4e6X6mMYcBpJ1cn7oC+yNw8iXR9HO4Ms8WaGFEn8sWy2tIJWeQ0jB8HbA5PPxe7Hs+2oJx+Xr/yTamvs7X5MamLhFm99o/eJQEVTsoZbsfxvKM4J3Xgy3HlZzTJssHbRbnSEStmSW3WC40XUGuNlgahtVcmSorgn3JRJ9TywVodF87v6bYVLzmTHnl13ijVzxcfDgyTRuVXJT8HaFtR5epJPB6xXwzJ516q1iZ4ttOQd+Ds7XMlzLgqGSyDrbIlAsNgimg/UPXVJ+c9BCSCqvS99Q0lN37Chu7qvNMklSdJWugmT8MpU4qEqHzbuZKiUUJXTa0420P/JMId58iyr02QoV+P5lLEH9Nq+lr93MD4N6vLGey4HbnT0uQ7sk8L0VFzuXLon0sb6Z+z3t6ohdTQzqqrOhml51Yvm3vHeUPmTokTlfYqbsya5U2uu9Y4KNYxVzNsP/3ukUx5qdFmYW55Ad9mPyE29UjJTUhjE4GTIkg8r5JYAAJnNIVrG2rQotC5ss36iWO6joJF63z+vrksIc7+PpOBOpA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d2345a3-76ec-4818-467d-08d8426e2732 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2020 05:26:54.3237 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ITaB7OGgGxoc3rJ+zBjjkhwA5WyGWIbjI3EChiZzTLJfPDLBsqaKnYue18JNuNk0bKeb+T+9VTa/UagUSyjeag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3719 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/7] rawdev: add private data length parameter to info fn X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, August 13, 2020 19:28 > To: Nipun Gupta ; Hemant Agrawal > > Cc: dev@dpdk.org; Richardson, Bruce ; Xu, > Rosen ; Mcnamara, John > ; Kovacevic, Marko > ; Zhang, Tianfei ; Li= , > Xiaoyun ; Wu, Jingjing > Subject: [PATCH v2 1/7] rawdev: add private data length parameter to info= fn >=20 > Currently with the rawdev API there is no way to check that the structure > passed in via the dev_private pointer in the dev_info structure is of the > correct type - it's just checked that it is non-NULL. Adding in the lengt= h of the > expected structure provides a measure of typechecking, and can also be us= ed > for ABI compatibility in future, since ABI changes involving structs almo= st > always involve a change in size. >=20 > Signed-off-by: Bruce Richardson > Reviewed-by: Rosen Xu > --- > app/test/test_rawdev.c | 2 +- > doc/guides/rawdevs/ioat.rst | 2 +- > doc/guides/sample_app_ug/ioat.rst | 2 +- > drivers/bus/ifpga/ifpga_bus.c | 2 +- > drivers/raw/ifpga/ifpga_rawdev.c | 5 +++-- > drivers/raw/ioat/ioat_rawdev.c | 5 +++-- > drivers/raw/ioat/ioat_rawdev_test.c | 4 ++-- > drivers/raw/ntb/ntb.c | 8 +++++++- > drivers/raw/skeleton/skeleton_rawdev.c | 5 +++-- > drivers/raw/skeleton/skeleton_rawdev_test.c | 19 ++++++++++++------- > examples/ioat/ioatfwd.c | 2 +- > examples/ntb/ntb_fwd.c | 2 +- > lib/librte_rawdev/rte_rawdev.c | 6 ++++-- > lib/librte_rawdev/rte_rawdev.h | 9 ++++++++- > lib/librte_rawdev/rte_rawdev_pmd.h | 5 ++++- > 15 files changed, 52 insertions(+), 26 deletions(-) >=20 > diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c index > 524a9d5f3b..d8d9595be1 100644 > --- a/app/test/test_rawdev.c > +++ b/app/test/test_rawdev.c > @@ -34,7 +34,7 @@ test_rawdev_selftest_ioat(void) >=20 > for (i =3D 0; i < count; i++) { > struct rte_rawdev_info info =3D { .dev_private =3D NULL }; > - if (rte_rawdev_info_get(i, &info) =3D=3D 0 && > + if (rte_rawdev_info_get(i, &info, 0) =3D=3D 0 && > strstr(info.driver_name, "ioat") !=3D NULL) > return rte_rawdev_selftest(i) =3D=3D 0 ? > TEST_SUCCESS : TEST_FAILED; > diff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst in= dex > d0eee5e237..dac52fabf1 100644 > --- a/doc/guides/rawdevs/ioat.rst > +++ b/doc/guides/rawdevs/ioat.rst > @@ -107,7 +107,7 @@ rawdev device for use by an application: >=20 > for (i =3D 0; i < count && !found; i++) { > struct rte_rawdev_info info =3D { .dev_private =3D NULL = }; > - found =3D (rte_rawdev_info_get(i, &info) =3D=3D 0 && > + found =3D (rte_rawdev_info_get(i, &info, 0) =3D=3D 0 && > strcmp(info.driver_name, > IOAT_PMD_RAWDEV_NAME_STR= ) =3D=3D 0); > } > diff --git a/doc/guides/sample_app_ug/ioat.rst > b/doc/guides/sample_app_ug/ioat.rst > index bab7654b8d..b5188220ba 100644 > --- a/doc/guides/sample_app_ug/ioat.rst > +++ b/doc/guides/sample_app_ug/ioat.rst > @@ -265,7 +265,7 @@ functions: > do { > if (rdev_id =3D=3D rte_rawdev_count()) > goto end; > - rte_rawdev_info_get(rdev_id++, &rdev_info); > + rte_rawdev_info_get(rdev_id++, &rdev_info, 0); > } while (strcmp(rdev_info.driver_name, > IOAT_PMD_RAWDEV_NAME_STR) !=3D 0); >=20 > diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.= c > index 6b16a20bb6..bb8b3dcfb9 100644 > --- a/drivers/bus/ifpga/ifpga_bus.c > +++ b/drivers/bus/ifpga/ifpga_bus.c > @@ -162,7 +162,7 @@ ifpga_scan_one(struct rte_rawdev *rawdev, > afu_dev->id.port =3D afu_pr_conf.afu_id.port; >=20 > if (rawdev->dev_ops && rawdev->dev_ops->dev_info_get) > - rawdev->dev_ops->dev_info_get(rawdev, afu_dev); > + rawdev->dev_ops->dev_info_get(rawdev, afu_dev, > sizeof(*afu_dev)); >=20 > if (rawdev->dev_ops && > rawdev->dev_ops->dev_start && > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index cc25c662bc..47cfa38778 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -605,7 +605,8 @@ ifpga_fill_afu_dev(struct opae_accelerator *acc, >=20 > static void > ifpga_rawdev_info_get(struct rte_rawdev *dev, > - rte_rawdev_obj_t dev_info) > + rte_rawdev_obj_t dev_info, > + size_t dev_info_size) > { > struct opae_adapter *adapter; > struct opae_accelerator *acc; > @@ -617,7 +618,7 @@ ifpga_rawdev_info_get(struct rte_rawdev *dev, >=20 > IFPGA_RAWDEV_PMD_FUNC_TRACE(); >=20 > - if (!dev_info) { > + if (!dev_info || dev_info_size !=3D sizeof(*afu_dev)) { > IFPGA_RAWDEV_PMD_ERR("Invalid request"); > return; > } > diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawde= v.c > index 87fd088aac..a5c0452d7e 100644 > --- a/drivers/raw/ioat/ioat_rawdev.c > +++ b/drivers/raw/ioat/ioat_rawdev.c > @@ -111,12 +111,13 @@ ioat_dev_stop(struct rte_rawdev *dev) } >=20 > static void > -ioat_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info) > +ioat_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info, > + size_t dev_info_size) > { > struct rte_ioat_rawdev_config *cfg =3D dev_info; > struct rte_ioat_rawdev *ioat =3D dev->dev_private; >=20 > - if (cfg !=3D NULL) > + if (cfg !=3D NULL && dev_info_size =3D=3D sizeof(*cfg)) > cfg->ring_size =3D ioat->ring_size; > } >=20 > diff --git a/drivers/raw/ioat/ioat_rawdev_test.c > b/drivers/raw/ioat/ioat_rawdev_test.c > index c37351af2d..2b40222eb4 100644 > --- a/drivers/raw/ioat/ioat_rawdev_test.c > +++ b/drivers/raw/ioat/ioat_rawdev_test.c > @@ -148,7 +148,7 @@ ioat_rawdev_test(uint16_t dev_id) > unsigned int nb_xstats; > unsigned int i; >=20 > - rte_rawdev_info_get(dev_id, &info); > + rte_rawdev_info_get(dev_id, &info, sizeof(p)); > if (p.ring_size !=3D expected_ring_size) { > printf("Error, initial ring size is not as expected (Actual: %d, > Expected: %d)\n", > (int)p.ring_size, expected_ring_size); @@ - > 160,7 +160,7 @@ ioat_rawdev_test(uint16_t dev_id) > printf("Error with rte_rawdev_configure()\n"); > return -1; > } > - rte_rawdev_info_get(dev_id, &info); > + rte_rawdev_info_get(dev_id, &info, sizeof(p)); > if (p.ring_size !=3D IOAT_TEST_RINGSIZE) { > printf("Error, ring size is not %d (%d)\n", > IOAT_TEST_RINGSIZE, (int)p.ring_size); diff -- > git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c index > e40412bb7e..c890c43a32 100644 > --- a/drivers/raw/ntb/ntb.c > +++ b/drivers/raw/ntb/ntb.c > @@ -801,11 +801,17 @@ ntb_dequeue_bufs(struct rte_rawdev *dev, } >=20 > static void > -ntb_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info) > +ntb_dev_info_get(struct rte_rawdev *dev, rte_rawdev_obj_t dev_info, > + size_t dev_info_size) > { > struct ntb_hw *hw =3D dev->dev_private; > struct ntb_dev_info *info =3D dev_info; >=20 > + if (dev_info_size !=3D sizeof(*info)) { > + NTB_LOG(ERR, "Invalid size parameter to %s", __func__); > + return; > + } > + > info->mw_cnt =3D hw->mw_cnt; > info->mw_size =3D hw->mw_size; >=20 > diff --git a/drivers/raw/skeleton/skeleton_rawdev.c > b/drivers/raw/skeleton/skeleton_rawdev.c > index 72ece887af..dc05f3ecf8 100644 > --- a/drivers/raw/skeleton/skeleton_rawdev.c > +++ b/drivers/raw/skeleton/skeleton_rawdev.c > @@ -42,14 +42,15 @@ static struct queue_buffers > queue_buf[SKELETON_MAX_QUEUES] =3D {}; static void clear_queue_bufs(int > queue_id); >=20 > static void skeleton_rawdev_info_get(struct rte_rawdev *dev, > - rte_rawdev_obj_t dev_info) > + rte_rawdev_obj_t dev_info, > + size_t dev_info_size) > { > struct skeleton_rawdev *skeldev; > struct skeleton_rawdev_conf *skeldev_conf; >=20 > SKELETON_PMD_FUNC_TRACE(); >=20 > - if (!dev_info) { > + if (!dev_info || dev_info_size !=3D sizeof(*skeldev_conf)) { > SKELETON_PMD_ERR("Invalid request"); > return; > } > diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c > b/drivers/raw/skeleton/skeleton_rawdev_test.c > index 9ecfdee818..9b8390dfb7 100644 > --- a/drivers/raw/skeleton/skeleton_rawdev_test.c > +++ b/drivers/raw/skeleton/skeleton_rawdev_test.c > @@ -106,12 +106,12 @@ test_rawdev_info_get(void) > struct rte_rawdev_info rdev_info =3D {0}; > struct skeleton_rawdev_conf skel_conf =3D {0}; >=20 > - ret =3D rte_rawdev_info_get(test_dev_id, NULL); > + ret =3D rte_rawdev_info_get(test_dev_id, NULL, 0); > RTE_TEST_ASSERT(ret =3D=3D -EINVAL, "Expected -EINVAL, %d", ret); >=20 > rdev_info.dev_private =3D &skel_conf; >=20 > - ret =3D rte_rawdev_info_get(test_dev_id, &rdev_info); > + ret =3D rte_rawdev_info_get(test_dev_id, &rdev_info, > sizeof(skel_conf)); > RTE_TEST_ASSERT_SUCCESS(ret, "Failed to get raw dev info"); >=20 > return TEST_SUCCESS; > @@ -142,7 +142,8 @@ test_rawdev_configure(void) >=20 > rdev_info.dev_private =3D &rdev_conf_get; > ret =3D rte_rawdev_info_get(test_dev_id, > - (rte_rawdev_obj_t)&rdev_info); > + (rte_rawdev_obj_t)&rdev_info, > + sizeof(rdev_conf_get)); > RTE_TEST_ASSERT_SUCCESS(ret, > "Failed to obtain rawdev configuration (%d)", > ret); > @@ -170,7 +171,8 @@ test_rawdev_queue_default_conf_get(void) > /* Get the current configuration */ > rdev_info.dev_private =3D &rdev_conf_get; > ret =3D rte_rawdev_info_get(test_dev_id, > - (rte_rawdev_obj_t)&rdev_info); > + (rte_rawdev_obj_t)&rdev_info, > + sizeof(rdev_conf_get)); > RTE_TEST_ASSERT_SUCCESS(ret, "Failed to obtain rawdev > configuration (%d)", > ret); >=20 > @@ -218,7 +220,8 @@ test_rawdev_queue_setup(void) > /* Get the current configuration */ > rdev_info.dev_private =3D &rdev_conf_get; > ret =3D rte_rawdev_info_get(test_dev_id, > - (rte_rawdev_obj_t)&rdev_info); > + (rte_rawdev_obj_t)&rdev_info, > + sizeof(rdev_conf_get)); > RTE_TEST_ASSERT_SUCCESS(ret, > "Failed to obtain rawdev configuration (%d)", > ret); > @@ -327,7 +330,8 @@ test_rawdev_start_stop(void) > dummy_firmware =3D NULL; >=20 > rte_rawdev_start(test_dev_id); > - ret =3D rte_rawdev_info_get(test_dev_id, > (rte_rawdev_obj_t)&rdev_info); > + ret =3D rte_rawdev_info_get(test_dev_id, > (rte_rawdev_obj_t)&rdev_info, > + sizeof(rdev_conf_get)); > RTE_TEST_ASSERT_SUCCESS(ret, > "Failed to obtain rawdev configuration (%d)", > ret); > @@ -336,7 +340,8 @@ test_rawdev_start_stop(void) > rdev_conf_get.device_state); >=20 > rte_rawdev_stop(test_dev_id); > - ret =3D rte_rawdev_info_get(test_dev_id, > (rte_rawdev_obj_t)&rdev_info); > + ret =3D rte_rawdev_info_get(test_dev_id, > (rte_rawdev_obj_t)&rdev_info, > + sizeof(rdev_conf_get)); > RTE_TEST_ASSERT_SUCCESS(ret, > "Failed to obtain rawdev configuration (%d)", > ret); > diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index > 75d8d5b9fe..76932d3dd2 100644 > --- a/examples/ioat/ioatfwd.c > +++ b/examples/ioat/ioatfwd.c > @@ -757,7 +757,7 @@ assign_rawdevs(void) > do { > if (rdev_id =3D=3D rte_rawdev_count()) > goto end; > - rte_rawdev_info_get(rdev_id++, &rdev_info); > + rte_rawdev_info_get(rdev_id++, &rdev_info, > 0); > } while (rdev_info.driver_name =3D=3D NULL || > strcmp(rdev_info.driver_name, >=20 > IOAT_PMD_RAWDEV_NAME_STR) !=3D 0); > diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index > eba8ebf9fa..11e224451c 100644 > --- a/examples/ntb/ntb_fwd.c > +++ b/examples/ntb/ntb_fwd.c > @@ -1389,7 +1389,7 @@ main(int argc, char **argv) > rte_rawdev_set_attr(dev_id, NTB_QUEUE_NUM_NAME, > num_queues); > printf("Set queue number as %u.\n", num_queues); > ntb_rawdev_info.dev_private =3D (rte_rawdev_obj_t)(&ntb_info); > - rte_rawdev_info_get(dev_id, &ntb_rawdev_info); > + rte_rawdev_info_get(dev_id, &ntb_rawdev_info, sizeof(ntb_info)); >=20 > nb_mbuf =3D nb_desc * num_queues * 2 * 2 + rte_lcore_count() * > MEMPOOL_CACHE_SIZE; > diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawde= v.c > index 8f84d0b228..a576890356 100644 > --- a/lib/librte_rawdev/rte_rawdev.c > +++ b/lib/librte_rawdev/rte_rawdev.c > @@ -78,7 +78,8 @@ rte_rawdev_socket_id(uint16_t dev_id) } >=20 > int > -rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info) > +rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info, > + size_t dev_private_size) > { > struct rte_rawdev *rawdev; >=20 > @@ -89,7 +90,8 @@ rte_rawdev_info_get(uint16_t dev_id, struct > rte_rawdev_info *dev_info) >=20 > if (dev_info->dev_private !=3D NULL) { > RTE_FUNC_PTR_OR_ERR_RET(*rawdev->dev_ops- > >dev_info_get, -ENOTSUP); > - (*rawdev->dev_ops->dev_info_get)(rawdev, dev_info- > >dev_private); > + (*rawdev->dev_ops->dev_info_get)(rawdev, dev_info- > >dev_private, > + dev_private_size); > } >=20 > dev_info->driver_name =3D rawdev->driver_name; diff --git > a/lib/librte_rawdev/rte_rawdev.h b/lib/librte_rawdev/rte_rawdev.h index > 32f6b8bb03..cf6acfd261 100644 > --- a/lib/librte_rawdev/rte_rawdev.h > +++ b/lib/librte_rawdev/rte_rawdev.h > @@ -82,13 +82,20 @@ struct rte_rawdev_info; > * will be returned. This can be used to safely query the type of a ra= wdev > * instance without needing to know the size of the private data to re= turn. > * > + * @param dev_private_size > + * The length of the memory space pointed to by dev_private in dev_inf= o. > + * This should be set to the size of the expected private structure to= be > + * returned, and may be checked by drivers to ensure the expected stru= ct > + * type is provided. > + * > * @return > * - 0: Success, driver updates the contextual information of the raw = device > * - <0: Error code returned by the driver info get function. > * > */ > int > -rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info); > +rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info, > + size_t dev_private_size); >=20 > /** > * Configure a raw device. > diff --git a/lib/librte_rawdev/rte_rawdev_pmd.h > b/lib/librte_rawdev/rte_rawdev_pmd.h > index 4395a2182d..0e72a92058 100644 > --- a/lib/librte_rawdev/rte_rawdev_pmd.h > +++ b/lib/librte_rawdev/rte_rawdev_pmd.h > @@ -138,12 +138,15 @@ rte_rawdev_pmd_is_valid_dev(uint8_t dev_id) > * Raw device pointer > * @param dev_info > * Raw device information structure > + * @param dev_private_size > + * The size of the structure pointed to by dev_info->dev_private > * > * @return > * Returns 0 on success > */ > typedef void (*rawdev_info_get_t)(struct rte_rawdev *dev, > - rte_rawdev_obj_t dev_info); > + rte_rawdev_obj_t dev_info, > + size_t dev_private_size); >=20 > /** > * Configure a device. > -- > 2.25.1 Acked-by: Rosen Xu