From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E03AA09FD; Sat, 19 Dec 2020 01:55:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA282CAF1; Sat, 19 Dec 2020 01:55:37 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B09BCCAE2 for ; Sat, 19 Dec 2020 01:55:34 +0100 (CET) IronPort-SDR: vDIRYwuiusYSMgo9JD4x9ciiTYXOIF9nIoVK9sS+GrO9gKywqm2oP9KCjp7uq9e9ROna97AbUo H3I2adO7kYnw== X-IronPort-AV: E=McAfee;i="6000,8403,9839"; a="260260014" X-IronPort-AV: E=Sophos;i="5.78,432,1599548400"; d="scan'208";a="260260014" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2020 16:55:32 -0800 IronPort-SDR: Ct6C6DXsXPdvFb88Hn0bQzUchvlVlSYWv3I0hUQyQRthZfINUI8SspV1nn8ACWtYMEpZFIlyVq xCEYKyM9Mx4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,432,1599548400"; d="scan'208";a="561657336" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 18 Dec 2020 16:55:31 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 18 Dec 2020 16:55:30 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 18 Dec 2020 16:55:30 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 18 Dec 2020 16:55:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZbwvk7HT/63/6IXYWqn4oizEUXz1B6r6J22s7y3QWMSg5rAufdlGBh21RIBSrIAXCYlZnBYW7KmYmx1jMXw/EhLDGDD7s7JtmddWw1IB4zpX8xinf9JT0bzeFWkIE4AcJbP0TnVgBxDNUehgiw3HhDORjyeOxp0pv/rDYLsmmValQXINnSmlUtLroCknh3Ko1YLUkEH3TnhfXeh3h8Sv+nPyXhjKnTUtwwAc1MbqvgG90Dtscdcmgm8Z5LtPPcbhPsYijBxIwvzikYR15OvwHGp57NnSDKSvsLkyISEd0+UWxjrUp6KnpS+T5l1gSCe2YiqrZBmFrv6tb8ymNybyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIGdMr7hNd1U51H3rgMVQk01FpbQAiMbFRHe9S/kSH0=; b=ah1+9qtwj/QPsbfFg5RJKftCLKkiKA1FFp0JBpUwhGG5tyW8pEOfIN4QacSCocunxl0jlE1cfDKcv4jzKatx+cPch72MVdzkbe6tnk8ilwqbgEBDrtkmK1v3+xiR3XttarNoVXkl6MOlbrTJjCHh+OBvrQr7LxzGGzoIaSS8mZMBUH6fbr1brS33s1rjSQUrQ19qnRf2Z8u0WrUIESZx0gayw7h25ozwu6EVGpjpHWD5E7PZnxu8HraDj9LuZqjStL+PmRoSq+VPvSAtJVVzrPgsPKtME9x3ZMd1fT9kbUAplY5xhw3ZT+s4froMZnmACbXxk1BldwUMUuHx2FoUYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIGdMr7hNd1U51H3rgMVQk01FpbQAiMbFRHe9S/kSH0=; b=mH6Ac6jiOWoS9RobIBTi8KxQKSkCUxaFUswUyf8olUbpsgQH8qCQ7Ed7rcGdwkrcCxdpJcPBnKHUin2WPLX9pxcF7yiFe2/2PsTjb4egJRaMIcBApA0lpkJEdMUAFE3z2W8L+Bq6vlFXm6L1Nac3uakWbZIFGrf0bg39GocBGC0= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BYAPR11MB2630.namprd11.prod.outlook.com (2603:10b6:a02:c2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.25; Sat, 19 Dec 2020 00:54:56 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::944f:d718:5ed7:fe75]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::944f:d718:5ed7:fe75%2]) with mapi id 15.20.3654.025; Sat, 19 Dec 2020 00:54:56 +0000 From: "Xu, Rosen" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , "asomalap@amd.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "Guo, Jia" , "Wang, Haiyue" , "g.singh@nxp.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "xavier.huwei@huawei.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , "sthotton@marvell.com" , "srinivasan@marvell.com" , "heinrich.kuhn@netronome.com" , "hkalra@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "kirankumark@marvell.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "andrew.rybchenko@oktetlabs.ru" , "mczekaj@marvell.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "ivan.boule@6wind.com" , "Ananyev, Konstantin" , "samuel.gauthier@6wind.com" , "david.marchand@6wind.com" , "shahafs@mellanox.com" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "olivier.matz@6wind.com" , "lihuisong@huawei.com" , "shreyansh.jain@nxp.com" , "wei.dai@intel.com" , "fengchunsong@huawei.com" , "chenhao164@huawei.com" , "tangchengchang@hisilicon.com" , "Zhang, Helin" , "yanglong.wu@intel.com" , "xiaolong.ye@intel.com" , "Xu, Ting" , "Li, Xiaoyun" , "Wei, Dan" , "Pei, Andy" , "vattunuru@marvell.com" , "skori@marvell.com" , "sony.chacko@qlogic.com" , "Richardson, Bruce" , "ivan.malov@oktetlabs.ru" , "rad@semihalf.com" , "slawomir.rosek@semihalf.com" , "kamil.rytarowski@caviumnetworks.com" , "Zhao1, Wei" , "Jiang, JunyuX" , "kumaras@chelsio.com" , "girish.nandibasappa@amd.com" , "rolf.neugebauer@netronome.com" , "alejandro.lucero@netronome.com" , "Yang, SteveX" Thread-Topic: [PATCH v2 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set Thread-Index: AQHW1FeQyL1PM+OsXk2JhfmZgaJqi6n9mmPg Date: Sat, 19 Dec 2020 00:54:56 +0000 Message-ID: References: <20201209031628.29572-1-stevex.yang@intel.com> <20201217092312.27033-1-stevex.yang@intel.com> <20201217092312.27033-11-stevex.yang@intel.com> In-Reply-To: <20201217092312.27033-11-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2QyYmUzZTYtNjgwNi00ZmQxLWFiOTAtZjkxODgzOWI2ODM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZEhsMldrOTkrZ0pjYjhWZFRydWdcL3V2bmNGd0M5dDl1aVRLN0s0RTEwdDVpVTBcL1RnZDJlNVkyRmlmempcL2grKyJ9 x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.216] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9fc708ed-86b9-47d6-082e-08d8a3b8b463 x-ms-traffictypediagnostic: BYAPR11MB2630: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j3f2ZiMpanqmPZ3JpDr22Nfa7dLZApIjZIVB4h4I1V/YV6Uaiq3Qi0o3tsWN+gIQFPKgrth0qpSvQ9Y9SJEXKGHc+7q34NfGGO41EGLIMTPqWn/Dwf0H4B1W6IakHd4eo4YA/3yMMhXxpElAom91M3UHGPt4cfPE6mfp2w7Q+7RDQAsyqAQthsxG7Fw/KhbGpDJ5MCPVZchySUpGfPdjBGNUDcp8vY7QwZw4hsPV/hEPwcKp5AsUwEc8bx9wRMRbynw4+5QQKyDCAbAx+hm7qlJvWl9lcQvZVOue1OdFmLJfrp1QefM9yF5KgrUwxalLjvkDnq9nwft4Bk7fxWpscoBtqhwLA5PhtWmHOeVmkJouFzhYWIR0QMqnsjTdWZSFPT9j7VkNS0t6cen4tkl2CQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(7696005)(64756008)(66476007)(52536014)(76116006)(33656002)(86362001)(66946007)(66556008)(5660300002)(7406005)(66446008)(2906002)(53546011)(186003)(9686003)(55016002)(478600001)(4326008)(54906003)(110136005)(7416002)(316002)(71200400001)(83380400001)(6506007)(26005)(107886003)(8936002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BkqBQ06GAAz0sFMvKMR5TtAhuidv7g8kq8O3oUkddCN2X6RAigBT51wDvyXu?= =?us-ascii?Q?KqGm4XA69Cw/Igj3LR/NQmxlwE6SjG7OpssMdqt2Rbg9tfirHLJQoaEE4+X/?= =?us-ascii?Q?HuigEvQXx4dEW/MSEzos97iSe1M1sUCkh90INHYUjHsykyaLPmXkXq74irSv?= =?us-ascii?Q?E8ZViFC4NtmtjDob13KMdY+sVWKyAaebskba/sRJH48vBqlhB+BI0ov0rG+b?= =?us-ascii?Q?P+madPSJzluGmjxr1R6ENigWSpLvEmkG2zFz4DQjbPnPs3BV1zQ2xG7eVF2/?= =?us-ascii?Q?zxxZ+PIRmD5zrsVMCgMLcNksWAsXpriHHDba5r9KPypFKHaJHJHZawPzCyrC?= =?us-ascii?Q?+5/MARt+lmYKAACDNgOglGsuy7gtB+ZRMEyyQ/Q65YjVU0pQh74WNBcx2l2O?= =?us-ascii?Q?N395awsbweUH1IZ2EHxVe+LsAVItJdf2/v/1ypt+uQD2LEJ0FhUwEh7S76fT?= =?us-ascii?Q?DFadCCuznQX3Lygi73KaA5J32AYiqq68ZITQVLA6XscEQE3JLwKZsukIVo1e?= =?us-ascii?Q?jU1PFtW5y0SIzm84xLYooBgjco/Gzmd4F9XrX1g6H6Tky8JhGJ7Qa+Gied2g?= =?us-ascii?Q?7zbUhbJcMOC3wzZ4nQcSRdkleMw7WGgRJeL/UCFQmv6f+Are4fou6AF5ccBw?= =?us-ascii?Q?vEn7D4o+d3lF9d9RazKtB0eC53tGmxj0FxBkRCKaziRopAol6aeSY9VvuDW6?= =?us-ascii?Q?gBesWJzWBO5c7UC4deJ2MgK/CY9DtP/DoV+YnSXMMkNhen20RM7AiCij7FKM?= =?us-ascii?Q?w50tAcxrk2wPJkDMfebQ3YMnEI5DyjvYtx8Yq3EinPtd4PxXm4jJ6X9ak/d6?= =?us-ascii?Q?UWvFoxKjIhmT/HvSsbzexa8WC/elv3N6mS7ON6K3OJ4ulATBTrB2IVg8uy60?= =?us-ascii?Q?Nu5ZqZbLHSgK3TZ1Ssv5TY1eauYQVEfPhts1LLmk4l5+IDO4XE3HfeAwpn6j?= =?us-ascii?Q?fMUL/dmS7CxHdv895gkHCTbNx2wJfpVg0TdSbhF9N5gssf6mma1BOO84Wk2W?= =?us-ascii?Q?0vIF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fc708ed-86b9-47d6-082e-08d8a3b8b463 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2020 00:54:56.5186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YrhyYB/umgjnChlX4xrzGtKrbXgZd8OfThPggBfVbttLkCg2hp2HJslhcijXyN0oYKDiU5W37PBP5yXOH2LSuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2630 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 10/22] net/ipn3ke: fix the jumbo frame flag condition for mtu set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Steve Yang > Sent: Thursday, December 17, 2020 17:23 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; asomalap@amd.com; > rahul.lakkireddy@chelsio.com; hemant.agrawal@nxp.com; > sachin.saxena@oss.nxp.com; Guo, Jia ; Wang, Haiyue > ; g.singh@nxp.com; xuanziyang2@huawei.com; > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; > xavier.huwei@huawei.com; humin29@huawei.com; > yisen.zhuang@huawei.com; oulijun@huawei.com; Wu, Jingjing > ; Yang, Qiming ; Zhang, Qi > Z ; Xu, Rosen ; > sthotton@marvell.com; srinivasan@marvell.com; > heinrich.kuhn@netronome.com; hkalra@marvell.com; jerinj@marvell.com; > ndabilpuram@marvell.com; kirankumark@marvell.com; > rmody@marvell.com; shshaikh@marvell.com; > andrew.rybchenko@oktetlabs.ru; mczekaj@marvell.com; > thomas@monjalon.net; Yigit, Ferruh ; > ivan.boule@6wind.com; Ananyev, Konstantin > ; samuel.gauthier@6wind.com; > david.marchand@6wind.com; shahafs@mellanox.com; > stephen@networkplumber.org; maxime.coquelin@redhat.com; > olivier.matz@6wind.com; lihuisong@huawei.com; shreyansh.jain@nxp.com; > wei.dai@intel.com; fengchunsong@huawei.com; chenhao164@huawei.com; > tangchengchang@hisilicon.com; Zhang, Helin ; > yanglong.wu@intel.com; xiaolong.ye@intel.com; Xu, Ting > ; Li, Xiaoyun ; Wei, Dan > ; Pei, Andy ; > vattunuru@marvell.com; skori@marvell.com; sony.chacko@qlogic.com; > Richardson, Bruce ; ivan.malov@oktetlabs.ru; > rad@semihalf.com; slawomir.rosek@semihalf.com; > kamil.rytarowski@caviumnetworks.com; Zhao1, Wei ; > Jiang, JunyuX ; kumaras@chelsio.com; > girish.nandibasappa@amd.com; rolf.neugebauer@netronome.com; > alejandro.lucero@netronome.com; Yang, SteveX > Subject: [PATCH v2 10/22] net/ipn3ke: fix the jumbo frame flag condition = for > mtu set >=20 > The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, > but the Ether overhead is larger than 18 when it supports dual VLAN tags. > That will cause the jumbo flag rx offload is wrong when MTU size is > 'RTE_ETHER_MTU'. >=20 > This fix will change the boundary condition with 'RTE_ETHER_MTU' and > overhead. >=20 > Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") >=20 > Signed-off-by: Steve Yang > --- > drivers/net/ipn3ke/ipn3ke_ethdev.h | 1 + > drivers/net/ipn3ke/ipn3ke_representor.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h > b/drivers/net/ipn3ke/ipn3ke_ethdev.h > index 9b0cf309c8..a6815a9cca 100644 > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h > @@ -640,6 +640,7 @@ ipn3ke_tm_ops_get(struct rte_eth_dev *ethdev, > */ > #define IPN3KE_ETH_OVERHEAD \ > (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + > IPN3KE_VLAN_TAG_SIZE * 2) > +#define IPN3KE_ETH_MAX_LEN (RTE_ETHER_MTU + > IPN3KE_ETH_OVERHEAD) >=20 > #define IPN3KE_MAC_FRAME_SIZE_MAX 9728 > #define IPN3KE_MAC_RX_FRAME_MAXLENGTH 0x00AE > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c > b/drivers/net/ipn3ke/ipn3ke_representor.c > index 8a53602576..9e15cce34f 100644 > --- a/drivers/net/ipn3ke/ipn3ke_representor.c > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c > @@ -2801,7 +2801,7 @@ ipn3ke_rpst_mtu_set(struct rte_eth_dev *ethdev, > uint16_t mtu) > return -EBUSY; > } >=20 > - if (frame_size > RTE_ETHER_MAX_LEN) > + if (frame_size > IPN3KE_ETH_MAX_LEN) > dev_data->dev_conf.rxmode.offloads |=3D > (uint64_t)(DEV_RX_OFFLOAD_JUMBO_FRAME); > else > -- > 2.17.1 Reviewed-by: Rosen Xu