From: "Xu, Rosen" <rosen.xu@intel.com>
To: "Hussin, Mohamad Noor Alim" <mohamad.noor.alim.hussin@intel.com>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Huang, Wei" <wei.huang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt
Date: Wed, 30 Jun 2021 10:02:46 +0000 [thread overview]
Message-ID: <BYAPR11MB29019C45173776CCEEDCE22A89019@BYAPR11MB2901.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210630092613.70647-1-mohamad.noor.alim.hussin@intel.com>
CC Tianfei, who is maintainer.
> -----Original Message-----
> From: Hussin, Mohamad Noor Alim <mohamad.noor.alim.hussin@intel.com>
> Sent: Wednesday, June 30, 2021 17:26
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Hussin, Mohamad Noor Alim
> <mohamad.noor.alim.hussin@intel.com>; Huang, Wei
> <wei.huang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] ifpga/base/meson: fix looking for librt
>
> Finding with "librt" keyword would give the output with full path of librt such
> as /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/librt.so
> instead of -lrt in libdpdk.pc pkg-config file.
>
> Assume find_library() will prepend "lib", thus remove "lib" from "librt"
> keyword. The output will shows as -lrt.
>
> This will cause an issue when compile DPDK app with static library as the
> path of librt has been hard-coded in the libdpdk.pc file.
>
> Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi-
> process")
> Cc: wei.huang@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Mohamad Noor Alim Hussin
> <mohamad.noor.alim.hussin@intel.com>
> ---
> drivers/raw/ifpga/base/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/raw/ifpga/base/meson.build
> b/drivers/raw/ifpga/base/meson.build
> index 8d27c6021..ce592a13a 100644
> --- a/drivers/raw/ifpga/base/meson.build
> +++ b/drivers/raw/ifpga/base/meson.build
> @@ -27,7 +27,7 @@ sources = [
>
> rtdep = dependency('librt', required: false) if not rtdep.found()
> - rtdep = cc.find_library('librt', required: false)
> + rtdep = cc.find_library('rt', required: false)
> endif
> if not rtdep.found()
> build = false
> --
> 2.17.1
next parent reply other threads:[~2021-06-30 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210630092613.70647-1-mohamad.noor.alim.hussin@intel.com>
2021-06-30 10:02 ` Xu, Rosen [this message]
2021-07-01 13:18 ` Zhang, Tianfei
2021-07-02 1:46 ` Hussin, Mohamad Noor Alim
2021-07-14 3:40 ` Zhang, Tianfei
2021-07-15 8:00 ` David Marchand
2021-07-15 8:11 ` Bruce Richardson
2021-07-22 8:16 ` mohamad.noor.alim.hussin
2021-08-30 9:29 ` Ferruh Yigit
2021-09-28 4:36 ` [dpdk-dev] [PATCH v3] " mohamad.noor.alim.hussin
2021-10-06 14:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB29019C45173776CCEEDCE22A89019@BYAPR11MB2901.namprd11.prod.outlook.com \
--to=rosen.xu@intel.com \
--cc=dev@dpdk.org \
--cc=mohamad.noor.alim.hussin@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).