From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33570A04DD; Thu, 19 Nov 2020 08:22:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1895B3B5; Thu, 19 Nov 2020 08:22:55 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E284B2AB for ; Thu, 19 Nov 2020 08:22:52 +0100 (CET) IronPort-SDR: Jb6Y4CjLfOvvERsarG36IYkHVH3mJRR/wMsP2mqQyrD1dhMXn+hh18UAlS64m48EthPFOq/rlK BAErtwpmIwoA== X-IronPort-AV: E=McAfee;i="6000,8403,9809"; a="158279778" X-IronPort-AV: E=Sophos;i="5.77,489,1596524400"; d="scan'208";a="158279778" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2020 23:22:50 -0800 IronPort-SDR: iRGeYN5maMwNsLePUe/ICMlehAi9wmgoNRNH+diBfl5eKaU5wE7/NQQ3JvwZYmWJ/gnRmsr9Xu IZ06jQYEasyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,489,1596524400"; d="scan'208";a="431138028" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 18 Nov 2020 23:22:48 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 18 Nov 2020 23:22:48 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 18 Nov 2020 23:22:47 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 18 Nov 2020 23:22:47 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.50) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 18 Nov 2020 23:22:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FxiaUIIPTZDR2VICImfPMbE5QFUuA//yZFCAJsIuuX9LhnH4R6/qsb03hwXKpgg531xkXHg+az+0Uz6108JenN1dsT2ByjuTiIurzKIGo22pFSFIVfJxFrEGlh5TxT0cI98JqX1EtJZLy+YBEJ0Rky/CTf+OTpbJXX08ZaB7Acyj6cRe0k068VMWqssHRoGiNSVhp6jsUeYvl9ucAhpajBEr8QIePTjv6IU9dB/lSCQXwjgyFs0uRaErGjK5EjbYe7sVfYBgBN9A4TMNtQXF8Gs4HIw8qkUwOQ4f9PezKev5lWD+2JzFzSVHN8BiW+AQTbzrCwJKkWwkntzRT79rjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9gj50SkRi1sUr+7LYN+Po3TB56xEJ4gCBnGgSgj3paI=; b=a/XHnV6XsQcFkvQL448akWcPr0FF30PdLOQ7NJek2Yo5yudbCOTljPFLz+O9XDrhnnS+9fiqm3WVX0qgTIZhZY0uFuDoIq9J2iqk7WCm2jyA9TpGYrukIzyNtgo77XcwHp+Qar00+FSPmyqgoVTp1dhdYgo28kTkOZ77+wPejrYJBqPOwQXYDdfavgaGk9wr2SnfRbyCgqDzpYbv+m45ITcDw6B+ybHBk4eP9kwyBKNSwLOylOogahlyo5MEY8iCJDHcrFktkyG6y+I76K2GSRTLS2YXC5bxYH7Mvhivp5C74klkkNmEQfBVKZ00qLS1uvoiK+gRzAUrl5znVWnD2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9gj50SkRi1sUr+7LYN+Po3TB56xEJ4gCBnGgSgj3paI=; b=M8NUHPQ9WM+HUnn0qEb3LmKeNfD/jCohTFsYfj9YWqVuqYdFS1TY3WEj92mxrcBxoniGZqaGRjlMk0IHU/nkOst3xQZuzeIjDVFnyfjULFWJg47wbUCPW8CBD0JdibDKKcyi7nXFIe3bNGctPpbq+Z4tkj3urSIRP+IIvwxYVD0= Received: from BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) by BY5PR11MB4258.namprd11.prod.outlook.com (2603:10b6:a03:1c2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.21; Thu, 19 Nov 2020 07:22:43 +0000 Received: from BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::944f:d718:5ed7:fe75]) by BYAPR11MB2901.namprd11.prod.outlook.com ([fe80::944f:d718:5ed7:fe75%2]) with mapi id 15.20.3589.020; Thu, 19 Nov 2020 07:22:43 +0000 From: "Xu, Rosen" To: "Yigit, Ferruh" , Jerin Jacob , "Dumitrescu, Cristian" , Hemant Agrawal , Sachin Saxena , Ray Kinsella , Neil Horman , "Wu, Jingjing" , "Xing, Beilei" , Nithin Dabilpuram , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Gagandeep Singh , Somalapuram Amaranath , Akhil Goyal , Jay Zhou , "McDaniel, Timothy" , "Ma, Liang J" , "Mccarthy, Peter" , "Shepard Siegel" , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , "Guo, Jia" , "Wang, Haiyue" , Marcin Wojtas , "Michal Krawczyk" , Guy Tzalik , "Evgeny Schemeilin" , Igor Chauskin , "Zhang, Qi Z" , "Wang, Xiao W" , "Yang, Qiming" , Alfredo Cardigliano , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Heinrich Kuhn , Harman Kalra , "Kiran Kumar K" , Andrew Rybchenko , "Singh, Jasvinder" , Jiawen Wu , Jian Wang , "Zhang, Tianfei" , "Ori Kam" , Guy Kaneti , "Burakov, Anatoly" , Maxime Coquelin , "Xia, Chenbo" CC: "dev@dpdk.org" Thread-Topic: [RFC] remove unused functions Thread-Index: AQHWviePKwtH4hvqG0OE/pge4xbC+qnPCkhg Date: Thu, 19 Nov 2020 07:22:43 +0000 Message-ID: References: <20201119035238.3653702-1-ferruh.yigit@intel.com> In-Reply-To: <20201119035238.3653702-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGYxMWQ5OGYtMGUyNS00MDViLWJkY2QtYjkxMGZjNWNjOTgyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibkNMVWlPOERLQlJ3aUVmZjhMNXRpNSt5RVk0YTVQN3VTY2l5QjBOaVY4d1dhdFZvZzJ6eEhSMWIxQ21Xd1RoWiJ9 x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dec81a32-c03b-4f08-d40a-08d88c5be836 x-ms-traffictypediagnostic: BY5PR11MB4258: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0e9U2He9OoOTanRmsI9ObxyCN+0BC4TDWSnXHzsWgZqea5TWGOwWgVE4nkpN60wasX5Xi6j30X6jfKfhyeFTCy4lDumSMYM0r2kqdTtH2zBUm4rB6S1IdKC1XHmodEXzoXR1UU34jsDJbvOJoI3Ux+5NMRdx3QveQxsBbuF/SMUhXlFaJzLOdwVAyCQTAnpGqwZ1uvWyVCnqDaWHEuqwUDxHB0Z7nPZ44tMvyDnrjQ2Di2j6za2OYWxhCAYkmmjZ7R46Xr71IWyJGrPr64/jHjaM81wJ7jxUo3dldhlaeVTxv6fJwDpeUYO67kQotkbCosjvN5yr0UVYydu5ok/hbJnBrtGmZNwqEx+fqVFgjhnScySsrxKulRhxcqjOmAZx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(136003)(376002)(346002)(8676002)(478600001)(8936002)(53546011)(7416002)(9686003)(52536014)(55016002)(7696005)(33656002)(4326008)(71200400001)(6506007)(6636002)(7406005)(186003)(83380400001)(5660300002)(110136005)(26005)(316002)(1191002)(2906002)(86362001)(66446008)(76116006)(66946007)(921005)(66476007)(64756008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: hEadDNa/vQGdbkFiFs9KZcDYUHjOShOkstg4Xy3DmRUdzVs7dYi0lSLgb/8K3+2V/omf1KzTG0Zb4ssH7BMBi/GdpO7sh4C1LJk+hv9NVqRbWgSXVBgVFZ4HVtsIcM6l7BU44VHKdJLaIR3MxJpHuqE2KjsKMvzRtR6FZUO20JmVDSIqjpwxwwap5Bg7UCCWn/nTQ9Rq7NjhzHWdKQwumpx2d6UNAzoFoAAHVCMUM+56zGpFf7OQud3E2CFWYTXCl3CSsO20fFjE14RonmpTqMf2HH+QfHpFPWDtFsAbPG7GPtEdq3ls5LqAoO6lCVzVNupeLf5tb0RiHi2V/XQ83wUWiPGLaXh1KQSNUndvZwtbKjh3ydUutMIwihFNQOgITiz/tK+ZH7TnkG9Qx0SY+qwZOF9bB5MeiqrO+i9F6RFPbrc13YPFZikeNgE8SC3qlBs/UXn3cRGn/oRNonB1M/CxVzCTvgOP/4M8Y5x5jFMKvl8W4NqG0qgTOGnkfmBS8LPmZ0Ov/xWEfS0cOWpaQrKRdqsFBkqinjsTzrCgj+7NNqEGkZszOYoxyb7bEt0lRFofDDVcU2FJg7S3nnm+erD8bejozycHyzuiFhcfrZ/S0sP9a66kI3jw1ijRc9pKH0pOEsk3ziTjw20xzH4CV8dPLKvhyxB3se7aJ6j93svxpyBUIvEvGLSGUgIvRXkAgUB6DlqkEgyq9bJ/Y+PTLcnmGWpFLPItGSBR967WelS8CiO/LqCoSwqxicp2cRJT6MdMF+646/HRwIxcQS1b0m7OJsI2l+461p07movZ5yJZBqjzu0Me7HUgrQsneEb2n3biRcmFpLWt7ondGuTFOhnvVrTuMcMTAgyMD7uw6YK3Y32ZzCxrLcN9UMyrZ8FiFLbgqPMYGjjf2UF4liJElw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dec81a32-c03b-4f08-d40a-08d88c5be836 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2020 07:22:43.6126 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3nsKD6jC27RwrjsDsI0Khwp0uv8YWLWQ9N1ulwgYUZQPFeydwo/9PN8cQVHwWURPNuTzgpRkNYjIIgX7Mlpl7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4258 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] remove unused functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, November 19, 2020 11:53 > To: Jerin Jacob ; Dumitrescu, Cristian > ; Hemant Agrawal > ; Sachin Saxena ; > Ray Kinsella ; Neil Horman ; Xu, > Rosen ; Wu, Jingjing ; Xing, > Beilei ; Nithin Dabilpuram > ; Ajit Khaparde > ; Raveendra Padasalagi > ; Vikas Gupta > ; Gagandeep Singh ; > Somalapuram Amaranath ; Akhil Goyal > ; Jay Zhou ; McDaniel, > Timothy ; Ma, Liang J ; > Mccarthy, Peter ; Shepard Siegel > ; Ed Czeck ; > John Miller ; Igor Russkikh > ; Pavel Belous ; > Rasesh Mody ; Shahed Shaikh > ; Somnath Kotur > ; Chas Williams ; Min Hu > (Connor) ; Rahul Lakkireddy > ; Guo, Jia ; Wang, > Haiyue ; Marcin Wojtas ; > Michal Krawczyk ; Guy Tzalik ; > Evgeny Schemeilin ; Igor Chauskin > ; Zhang, Qi Z ; Wang, Xiao W > ; Yang, Qiming ; Alfredo > Cardigliano ; Matan Azrad ; > Shahaf Shuler ; Viacheslav Ovsiienko > ; Zyta Szpak ; Liron Himi > ; Stephen Hemminger ; K. > Y. Srinivasan ; Haiyang Zhang > ; Long Li ; Heinrich Kuhn > ; Harman Kalra ; > Kiran Kumar K ; Andrew Rybchenko > ; Singh, Jasvinder > ; Jiawen Wu ; Jian > Wang ; Zhang, Tianfei > ; Ori Kam ; Guy Kaneti > ; Burakov, Anatoly ; > Maxime Coquelin ; Xia, Chenbo > > Cc: Yigit, Ferruh ; dev@dpdk.org > Subject: [RFC] remove unused functions >=20 > Removing unused functions, reported by cppcheck. >=20 > Easy way to remove clutter, since the code is already in the git repo, > they can be added back when needed. >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/bus/ifpga/ifpga_common.c | 23 - > drivers/bus/ifpga/ifpga_common.h | 3 - >=20 > diff --git a/drivers/bus/ifpga/ifpga_common.c > b/drivers/bus/ifpga/ifpga_common.c > index 78e2eaee4e..7281b169d0 100644 > --- a/drivers/bus/ifpga/ifpga_common.c > +++ b/drivers/bus/ifpga/ifpga_common.c > @@ -52,29 +52,6 @@ int rte_ifpga_get_integer32_arg(const char *key > __rte_unused, >=20 > return 0; > } > -int ifpga_get_integer64_arg(const char *key __rte_unused, > - const char *value, void *extra_args) > -{ > - if (!value || !extra_args) > - return -EINVAL; > - > - *(uint64_t *)extra_args =3D strtoull(value, NULL, 0); > - > - return 0; > -} > -int ifpga_get_unsigned_long(const char *str, int base) > -{ > - unsigned long num; > - char *end =3D NULL; > - > - errno =3D 0; > - > - num =3D strtoul(str, &end, base); > - if ((str[0] =3D=3D '\0') || (end =3D=3D NULL) || (*end !=3D '\0') || (e= rrno !=3D 0)) > - return -1; > - > - return num; > -} >=20 > int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0, > const struct rte_afu_id *afu_id1) > diff --git a/drivers/bus/ifpga/ifpga_common.h > b/drivers/bus/ifpga/ifpga_common.h > index f9254b9d5d..44381eb78d 100644 > --- a/drivers/bus/ifpga/ifpga_common.h > +++ b/drivers/bus/ifpga/ifpga_common.h > @@ -9,9 +9,6 @@ int rte_ifpga_get_string_arg(const char *key > __rte_unused, > const char *value, void *extra_args); > int rte_ifpga_get_integer32_arg(const char *key __rte_unused, > const char *value, void *extra_args); > -int ifpga_get_integer64_arg(const char *key __rte_unused, > - const char *value, void *extra_args); > -int ifpga_get_unsigned_long(const char *str, int base); > int ifpga_afu_id_cmp(const struct rte_afu_id *afu_id0, > const struct rte_afu_id *afu_id1); >=20 > 2.26.2 Reviewed-by: Rosen Xu