Re: [dpdk-dev] [PATCH v2] ethdev: add namespace

["Xu, Rosen" <rosen.xu@intel.com>]

Hi,

> -----Original Message-----
> From: Wisam Monther <wisamm@nvidia.com>
> Sent: Sunday, August 29, 2021 16:18
> To: Ajit Khaparde <ajit.khaparde@broadcom.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Tahhan, Maryam
> <maryam.tahhan@intel.com>; Pattan, Reshma <reshma.pattan@intel.com>;
> Jerin Jacob <jerinj@marvell.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; NBU-
> Contact-Thomas Monjalon <thomas@monjalon.net>; Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com>; Chas Williams <chas3@att.com>; Min Hu
> (Connor) <humin29@huawei.com>; Pavan Nikhilesh
> <pbhagavatula@marvell.com>; Shijith Thotton <sthotton@marvell.com>;
> Somnath Kotur <somnath.kotur@broadcom.com>; Daley, John
> <johndale@cisco.com>; Hyong Youb Kim <hyonkim@cisco.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>; Wiles, Keith
> <keith.wiles@intel.com>; Hu, Jiayu <jiayu.hu@intel.com>; Olivier Matz
> <olivier.matz@6wind.com>; Ori Kam <orika@nvidia.com>; Akhil Goyal
> <gakhil@marvell.com>; Doherty, Declan <declan.doherty@intel.com>; Ray
> Kinsella <mdr@ashroe.eu>; Nicolau, Radu <radu.nicolau@intel.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena
> <sachin.saxena@oss.nxp.com>; Nithin Dabilpuram
> <ndabilpuram@marvell.com>; Kiran Kumar K <kirankumark@marvell.com>;
> Sunil Kumar Kori <skori@marvell.com>; Satha Rao
> <skoteshwar@marvell.com>; John W. Linville <linville@tuxdriver.com>;
> Loftus, Ciara <ciara.loftus@intel.com>; Shepard Siegel
> <shepard.siegel@atomicrules.com>; Ed Czeck <ed.czeck@atomicrules.com>;
> John Miller <john.miller@atomicrules.com>; Igor Russkikh
> <irusskikh@marvell.com>; Steven Webster
> <steven.webster@windriver.com>; Matt Peters
> <matt.peters@windriver.com>; Somalapuram Amaranath
> <asomalap@amd.com>; Rasesh Mody <rmody@marvell.com>; Shahed
> Shaikh <shshaikh@marvell.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Ruifeng Wang <ruifeng.wang@arm.com>;
> Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>; Marcin Wojtas
> <mw@semihalf.com>; Michal Krawczyk <mk@semihalf.com>; Shai Brandes
> <shaibran@amazon.com>; Evgeny Schemeilin <evgenys@amazon.com>;
> Igor Chauskin <igorch@amazon.com>; Gagandeep Singh
> <g.singh@nxp.com>; Gaetan Rivet <grive@u256.net>; Ziyang Xuan
> <xuanziyang2@huawei.com>; Xiaoyun Wang
> <cloud.wangxiaoyun@huawei.com>; Guoyang Zhou
> <zhouguoyang@huawei.com>; Yisen Zhuang <yisen.zhuang@huawei.com>;
> Lijun Ou <oulijun@huawei.com>; Wu, Jingjing <jingjing.wu@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Andrew Boyer
> <aboyer@pensando.io>; Xu, Rosen <rosen.xu@intel.com>;
> Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Jakub Grajciar
> <jgrajcia@cisco.com>; Zyta Szpak <zr@semihalf.com>; Liron Himi
> <lironh@marvell.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> NBU-Contact-longli <longli@microsoft.com>; Martin Spinler
> <spinler@cesnet.cz>; Heinrich Kuhn <heinrich.kuhn@netronome.com>;
> Jiawen Wu <jiawenwu@trustnetic.com>; Tetsuya Mukawa
> <mtetsuyah@gmail.com>; Harman Kalra <hkalra@marvell.com>; Anoob
> Joseph <anoobj@marvell.com>; Nalla Pradeep <pnalla@marvell.com>;
> Radha Mohan Chintakuntla <radhac@marvell.com>; Veerasenareddy Burru
> <vburru@marvell.com>; Devendra Singh Rawat
> <dsinghrawat@marvell.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Maciej Czekaj <mczekaj@marvell.com>; Jian Wang
> <jianwang@trustnetic.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>;
> Yong Wang <yongwang@vmware.com>; Chautru, Nicolas
> <nicolas.chautru@intel.com>; Hunt, David <david.hunt@intel.com>; Van
> Haaren, Harry <harry.van.haaren@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Rybalchenko, Kirill
> <kirill.rybalchenko@intel.com>; Marohn, Byron <byron.marohn@intel.com>;
> Wang, Yipeng1 <yipeng1.wang@intel.com>; dpdk-dev <dev@dpdk.org>;
> Tyler Retzlaff <roretzla@linux.microsoft.com>
> Subject: RE: [PATCH v2] ethdev: add namespace
> 
> Hi,
> 
> > -----Original Message-----
> > From: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Sent: Saturday, August 28, 2021 5:26 PM
> > To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Cc: Ferruh Yigit <ferruh.yigit@intel.com>; Maryam Tahhan
> > <maryam.tahhan@intel.com>; Reshma Pattan
> <reshma.pattan@intel.com>;
> > Jerin Jacob <jerinj@marvell.com>; Wisam Monther
> <wisamm@nvidia.com>;
> > Cristian Dumitrescu <cristian.dumitrescu@intel.com>; Xiaoyun Li
> > <xiaoyun.li@intel.com>; NBU-Contact-Thomas Monjalon
> > <thomas@monjalon.net>; Jay Jayatheerthan
> > <jay.jayatheerthan@intel.com>; Chas Williams <chas3@att.com>; Min Hu
> > (Connor) <humin29@huawei.com>; Pavan Nikhilesh
> > <pbhagavatula@marvell.com>; Shijith Thotton <sthotton@marvell.com>;
> > Somnath Kotur <somnath.kotur@broadcom.com>; John Daley
> > <johndale@cisco.com>; Hyong Youb Kim <hyonkim@cisco.com>; Qi Zhang
> > <qi.z.zhang@intel.com>; Xiao Wang <xiao.w.wang@intel.com>; Beilei Xing
> > <beilei.xing@intel.com>; Haiyue Wang <haiyue.wang@intel.com>; Matan
> > Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Slava
> > Ovsiienko <viacheslavo@nvidia.com>; Keith Wiles
> > <keith.wiles@intel.com>; Jiayu Hu <jiayu.hu@intel.com>; Olivier Matz
> > <olivier.matz@6wind.com>; Ori Kam <orika@nvidia.com>; Akhil Goyal
> > <gakhil@marvell.com>; Declan Doherty <declan.doherty@intel.com>; Ray
> > Kinsella <mdr@ashroe.eu>; Radu Nicolau <radu.nicolau@intel.com>;
> > Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena
> > <sachin.saxena@oss.nxp.com>; Nithin Dabilpuram
> > <ndabilpuram@marvell.com>; Kiran Kumar K <kirankumark@marvell.com>;
> > Sunil Kumar Kori <skori@marvell.com>; Satha Rao
> > <skoteshwar@marvell.com>; John W. Linville <linville@tuxdriver.com>;
> > Ciara Loftus <ciara.loftus@intel.com>; Shepard Siegel
> > <shepard.siegel@atomicrules.com>; Ed Czeck
> <ed.czeck@atomicrules.com>;
> > John Miller <john.miller@atomicrules.com>; Igor Russkikh
> > <irusskikh@marvell.com>; Steven Webster
> > <steven.webster@windriver.com>; Matt Peters
> > <matt.peters@windriver.com>; Somalapuram Amaranath
> <asomalap@amd.com>;
> > Rasesh Mody <rmody@marvell.com>; Shahed Shaikh
> <shshaikh@marvell.com>;
> > Bruce Richardson <bruce.richardson@intel.com>; Konstantin Ananyev
> > <konstantin.ananyev@intel.com>; Ruifeng Wang
> <ruifeng.wang@arm.com>;
> > Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>; Marcin Wojtas
> > <mw@semihalf.com>; Michal Krawczyk <mk@semihalf.com>; Shai Brandes
> > <shaibran@amazon.com>; Evgeny Schemeilin <evgenys@amazon.com>;
> Igor
> > Chauskin <igorch@amazon.com>; Gagandeep Singh <g.singh@nxp.com>;
> > Gaetan Rivet <grive@u256.net>; Ziyang Xuan <xuanziyang2@huawei.com>;
> > Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>; Guoyang Zhou
> > <zhouguoyang@huawei.com>; Yisen Zhuang
> <yisen.zhuang@huawei.com>;
> > Lijun Ou <oulijun@huawei.com>; Jingjing Wu <jingjing.wu@intel.com>;
> > Qiming Yang <qiming.yang@intel.com>; Andrew Boyer
> > <aboyer@pensando.io>; Rosen Xu <rosen.xu@intel.com>;
> > Srisivasubramanian Srinivasan <srinivasan@marvell.com>; Jakub Grajciar
> > <jgrajcia@cisco.com>; Zyta Szpak <zr@semihalf.com>; Liron Himi
> > <lironh@marvell.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> > NBU-Contact-longli <longli@microsoft.com>; Martin Spinler
> > <spinler@cesnet.cz>; Heinrich Kuhn <heinrich.kuhn@netronome.com>;
> > Jiawen Wu <jiawenwu@trustnetic.com>; Tetsuya Mukawa
> > <mtetsuyah@gmail.com>; Harman Kalra <hkalra@marvell.com>; Anoob
> Joseph
> > <anoobj@marvell.com>; Nalla Pradeep <pnalla@marvell.com>; Radha
> Mohan
> > Chintakuntla <radhac@marvell.com>; Veerasenareddy Burru
> > <vburru@marvell.com>; Devendra Singh Rawat
> <dsinghrawat@marvell.com>;
> > Jasvinder Singh <jasvinder.singh@intel.com>; Maciej Czekaj
> > <mczekaj@marvell.com>; Jian Wang <jianwang@trustnetic.com>; Maxime
> > Coquelin <maxime.coquelin@redhat.com>; Chenbo Xia
> > <chenbo.xia@intel.com>; Yong Wang <yongwang@vmware.com>; Nicolas
> > Chautru <nicolas.chautru@intel.com>; David Hunt
> > <david.hunt@intel.com>; Harry van Haaren <harry.van.haaren@intel.com>;
> > Bernard Iremonger <bernard.iremonger@intel.com>; Anatoly Burakov
> > <anatoly.burakov@intel.com>; John McNamara
> <john.mcnamara@intel.com>;
> > Kirill Rybalchenko <kirill.rybalchenko@intel.com>; Byron Marohn
> > <byron.marohn@intel.com>; Yipeng Wang <yipeng1.wang@intel.com>;
> > dpdk-dev <dev@dpdk.org>; Tyler Retzlaff <roretzla@linux.microsoft.com>
> > Subject: Re: [PATCH v2] ethdev: add namespace
> >
> > On Fri, Aug 27, 2021 at 12:59 AM Andrew Rybchenko
> > <andrew.rybchenko@oktetlabs.ru> wrote:
> > >
> > > On 8/27/21 4:19 AM, Ferruh Yigit wrote:
> > > > Add 'RTE_ETH' namespace to all enums & macros in a backward
> > compatible
> > > > way. The macros for backward compatibility can be removed in next LTS.
> > > >
> > > > Internal components switched to new enum & macro names.
> > > >
> > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > > Acked-By: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > >
> > > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 
> Acked-by: Wisam Jaddo <wisamm@nvidia.com>

Acked-by: Rosen Xu <rosen.xu@intel.com>

> >
> > >
> > > I think that it should be pushed as early as possible in the release
> > > cycle.
> > >
> > > The changeset definitely deserves entry in release notes.