From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id D8723A00BE;
Tue, 28 Apr 2020 19:35:46 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5CAFC1D622;
Tue, 28 Apr 2020 19:35:45 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 3D2E51D61E
for <dev@dpdk.org>; Tue, 28 Apr 2020 19:35:43 +0200 (CEST)
IronPort-SDR: ah8wdug/0p8nKPH2m4nEbQrMuPGCRla7QJ78EeHQN3f2RozZl+aVWmu3DdceZ8uJAub+Aof2x6
u/0igdX/5itg==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
28 Apr 2020 10:35:42 -0700
IronPort-SDR: pF3oMuzlQjLi2JbJnBeHdcBW3+s34cih8YRF5D3wvgbu3fDdLusnYKklgGwikk+IVFvJusbbUb
CR6ys1jv0DMw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="275910907"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by orsmga002.jf.intel.com with ESMTP; 28 Apr 2020 10:35:41 -0700
Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Tue, 28 Apr 2020 10:35:41 -0700
Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by
FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Tue, 28 Apr 2020 10:35:41 -0700
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171)
by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id
14.3.439.0; Tue, 28 Apr 2020 10:35:41 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Ts7j2vU/KXn6tt8isSO7TeInK+8xjg3LJV/nSD9a9VA0sCCUMY4jZHKCNxYksS6/XX6nV3wb/gk2CMTRvrpPnk+EkyhA4ue/zb4FFUXMqrKZwzAymKlWHmFqssjYHE1Tmxv6VdFt3sfoifYIL8oUXmZuxBS4QdTWUIHcvIQoUrviEtftNNveijYWX2qYjO7vHSueHSw0Da3VmRat9uNXaVDOoh0SBI8MVoAbi/yR1mo7DKZBpzLwVwK4rD/hDeqJoDmqd/Hzl02+Znv8LQ3GnHElRsUMGzCEGjdOqChi9wQM4brQyMBQ+2Us7qSFO8CKuE7ynsmTNdib3BTzxPiGxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=HghVfnonN85wKMt52IhbuiNyMfrBf7Vx9mlTwNDOkpY=;
b=bfuYUDfEibCxFsDOG4egFCsL+iIPl4W9VQVazgJ3mjbfHX2R559+EYtOiGkMppXM3YYgxqImA2hKwYHA+YRiJ8yV+frl1ZLkLZEGAGWmOj6JfV/1xfyg0ADm72tmSGcBhcQ2MoL3zGwnQscvMY2xciw7fcJVgZ4PDmH8c6KZUnQDX5cNSqhpejnumI5yxx3ueCVnP0dL14kKRh+bc1f0dmZEKd9r+d5i5DAgLr5D4BHApSpILvYKDzB19ndvk6wDOdCoo6zhbNyy4B1C21Kv8cqjnxhLg78ydndJvAsnWTdD0VvQtui6zI+8KYMUcVukt2jPIb/o1I51NSh6r+lKNA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=HghVfnonN85wKMt52IhbuiNyMfrBf7Vx9mlTwNDOkpY=;
b=Fm4KxggEKUDMzKYlrd39IlO2cDdzaCCn+0DTcudvPGj8JyEjgIr0h/JqgUzguRtQHXYhLctcBhJTp3hUWCaX8xuMhwln4BivVnJK+cMORzFLoongjx9fgn+xWKGU+NwuomemI1g8bbN15vnNRyIxQ0Zzq6YzjXHGvUCvHckPipM=
Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24)
by BYAPR11MB3831.namprd11.prod.outlook.com (2603:10b6:a03:b0::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Tue, 28 Apr
2020 17:35:36 +0000
Received: from BYAPR11MB2935.namprd11.prod.outlook.com
([fe80::786e:a42b:df03:a829]) by BYAPR11MB2935.namprd11.prod.outlook.com
([fe80::786e:a42b:df03:a829%5]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020
17:35:36 +0000
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "Yigit, Ferruh" <ferruh.yigit@intel.com>, Nithin Dabilpuram
<nithind1988@gmail.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>, "kkanas@marvell.com"
<kkanas@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,
"Kinsella, Ray" <ray.kinsella@intel.com>, Neil Horman
<nhorman@tuxdriver.com>, Luca Boccassi <bluca@debian.org>, Kevin Traynor
<ktraynor@redhat.com>, David Marchand <david.marchand@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Thread-Topic: [PATCH v4 1/4] ethdev: add tm support for shaper config in pkt
mode
Thread-Index: AQHWGMqR3VqxJG8NS0ipNyOJfkoYrKiIFDWggAI0/4CAAmzroIAAdZkAgAAArFCAAYXLAIAAHxMA
Date: Tue, 28 Apr 2020 17:35:36 +0000
Message-ID: <BYAPR11MB2935235F14472A4F0A33A07FEBAC0@BYAPR11MB2935.namprd11.prod.outlook.com>
References: <20200330160019.29674-1-ndabilpuram@marvell.com>
<bd72bb76-62a2-46fb-244f-96527a439089@intel.com>
<BYAPR11MB293593F4668D04425F619BFEEBAF0@BYAPR11MB2935.namprd11.prod.outlook.com>
<7028049.mr9Zh2SJbS@thomas>
In-Reply-To: <7028049.mr9Zh2SJbS@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-version: 11.2.0.6
dlp-reaction: no-action
dlp-product: dlpe-windows
authentication-results: monjalon.net; dkim=none (message not signed)
header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com;
x-originating-ip: [192.198.151.176]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7bc53ac5-8861-438e-5237-08d7eb9a8fe0
x-ms-traffictypediagnostic: BYAPR11MB3831:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR11MB3831136386CD39A5B25658E1EBAC0@BYAPR11MB3831.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 0387D64A71
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: sfniDd0qjS1LgzlPDTnk5NYkT1So3MqgxKfSm70vdqSPAeeXDtfZXbON7xP6+BOASS8dDKbycKUaQo5VnRv3T692rJ5wkb5MOPkvvXy08Vnp97gO0XhlP+tAejBjRRgNzV2D80oOwrzvCz89MdXycsFmLiS7l+3SY9yOpslPP1G6nZV88dU6v9rc1ZyAp/ySitjR5LRYIRiOvBEf6nP+ZZKEEyugZdxUcCTxsbOgqCeb7w88sctLABzr8w6MgeYzXQjihW+GVhfnLZK8pGa8/Aot4QjJqzXBm0b1mak/Eu0+lpwPPe992u0y6AH9NLVV1vNr8kW2yMQlALbGyUIEF/NvOGM1o/OpfWwC4zOMDA46tVgmZmTPWM5tjs8SOcI5Gg6YtKep608YY+RHaGonvM2ZldnG1czltYl8DvMgTf5k1fMRFMNSR8nfIB5IHkOqFX+Y84KfSR4go3pD2RysOGPI5GzTVaxH+XOCYcS2/mSCz2eZ0FFKUayP4/tWzNKEupeo57+osUsEmiCBIRRvufjupGgp8BR95S7WVxtTMWXI6iSgE/xcdUpsRdqXrOMfLMtGD8QQVHplguWSI1x8Rw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(396003)(39860400002)(376002)(136003)(366004)(346002)(7696005)(76116006)(8936002)(66946007)(2906002)(5660300002)(6916009)(966005)(478600001)(8676002)(107886003)(55016002)(9686003)(33656002)(86362001)(7416002)(26005)(186003)(4326008)(71200400001)(53546011)(6506007)(52536014)(54906003)(66446008)(316002)(64756008)(66556008)(66476007)(10126625002);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: EucrkW7lR925nU0quM9fPi0SlYelk9rC0pgHgr1Q4o2HOmT3ncpeG84YmhlJW0ZKB1ZT0Kp8LqoNCfO3+J2ASq3fP09+04C8cKU92Mh6HKhuA6cM8cK4EK1nRwMVw73okc5NpHBNnoQa+PavNel6uMeITRYNmp7v15HUaHIxUTL1LghhVtDDcuTN1SFJ+ZxKmda9NIHtxuRvXrPLPupHFPfgmIyNfm7X8jlvzuejEaabhPHLvR2Y8udj9zLLODM7il3zwMuJuETWjnybvgX7BxAYbJFbs8UtpnkD+nvaK20aFwmub9To6yUoCtu8eDLapz5hqz2nE2zWMBiSw1tbvSLFIijRryDkpDAvR48gUjFQpWTN6+Uxx+ap3NFN3C9aEHUl0AZ4Hq2RkGkc7dOY3sLgVOQHEEQl/G+ZWmAm/EEska0TyZPJPOsZs6V6xEY8BKR00DbkvC5ziHNpyIVekV6XXdU7perUd2ns5YuJyIpZwm7wQ1YzLOajLmdUiQtJdwjZCZNyr3RBT/RRVNp84Z+or22hq80o1kwhCzR8bYiYBqHjm1N2dgE0Lk0RRLZ7yWHuP8d2zNPyTZtBehn7BzYUHLw9kP5OBmPhjrV0TT43pMg4izcU4js8tTOoLgZsP7HyIhMR8Xz9wIwOKYiRzg9+5zmc1Gjr2DUi91eELRtUg7rU3IwCtWK82ujm847UHChO4+7cYTFCGaP0v9xVd95XVqWPuKKH3u14X6yzWdNpt0vaV+erR44r7rxmLVi6c9xghL549U+tNK+nq/MVZKomWhyUa86ralKt7fXQFhUA2g8owYIszy+mOvKmvxAk
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bc53ac5-8861-438e-5237-08d7eb9a8fe0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 17:35:36.4270 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qVGDR9LSJdZGPDqFB91wef7nxBW4/mkB0ZWnjEDq5OzuIFbwvmlFWiOF3vWtAWkg/7WWjPlSLk97JO/kJr0iXjS6mF1jpVjKa9I5g8aarMI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3831
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add tm support for shaper
config in pkt mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, April 28, 2020 4:30 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Nithin Dabilpuram
> <nithind1988@gmail.com>; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Andrew Rybchenko <arybchenko@solarflare.com>; dev@dpdk.org;
> jerinj@marvell.com; kkanas@marvell.com; Nithin Dabilpuram
> <ndabilpuram@marvell.com>; Kinsella, Ray <ray.kinsella@intel.com>; Neil
> Horman <nhorman@tuxdriver.com>; Luca Boccassi <bluca@debian.org>;
> Kevin Traynor <ktraynor@redhat.com>; David Marchand
> <david.marchand@redhat.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Subject: Re: [PATCH v4 1/4] ethdev: add tm support for shaper config in p=
kt
> mode
>=20
> 27/04/2020 18:28, Dumitrescu, Cristian:
> > From: Yigit, Ferruh <ferruh.yigit@intel.com>
> > > On 4/27/2020 10:19 AM, Dumitrescu, Cristian wrote:
> > > > From: Yigit, Ferruh <ferruh.yigit@intel.com>
> > > >> Hi Nithin,
> > > >>
> > > >> It looks like patch is causing ABI break, I am getting following w=
arning
> [1],
> > > >> can you please check?
> > > >>
> > > >> [1]
> > > >> https://pastebin.com/XYNFg14u
> > > >
> > > >
> > > > Hi Ferruh,
> > > >
> > > > The RTE_TM API is marked as experimental, but it looks that this wa=
s
> not
> > > correctly marked when __rte_experimental ABI checker was introduced.
> > > >
> > > > It is marked as experimental at the top of the rte_tm.h, similarly =
to
> other
> > > APIs introduced around same time, but it was not correctly picked up =
by
> the
> > > ABI check procedure when later introduced, so __rte_experimental was
> not
> > > added to every function.
> > > >
> > >
> > > :(
> > >
> > > Is it time to mature them?
> > >
> > > As you said they are not marked as experimental both in header file
> > > (function
> > > declarations) and .map file.
> > >
> > > The problem is, they are not marked as experimental in DPDK_20.0 ABI
> > > (v19.11),
> > > so marking them as experimental now will break the ABI. Not sure what
> to
> > > do,
> > > cc'ed a few ABI related names for comment.
> > >
> > > For me, we need to proceed as the experimental tag removed and APIs
> > > become
> > > mature starting from v19.11, since this is what happened in practice,=
and
> > > remove
> > > a few existing being experimental references in the doxygen comments.
> > >
> > > Ray, Neil, David, Luca, Kevin, what do you think?
> >
> > Hi Ferruh,
> >
> > IMO your proposed approach is fixing the wrong problem and is
> > probably not the right way of doing things.
> >
> > This API is correctly marked as experimental in the header
> > file rte_tm.h and in the MAINTAINERS file,
>=20
> in rte_tm.h:
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice
>=20
> in MAINTAINERS:
> Traffic Management API - EXPERIMENTAL
> M: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> T: git://dpdk.org/next/dpdk-next-qos
> F: lib/librte_ethdev/rte_tm*
>=20
>=20
> > therefore it should remain experimental,
>=20
> in rte_ethdev_version.map:
> before 19.11: DPDK_17.08 {
> since 19.11: DPDK_20.0 {
>=20
> When adding rte_tm in 17.08:
> http://git.dpdk.org/dpdk/diff/lib/librte_ether/rte_ether_version.map?id=
=3D5
> d109deffa
>=20
> In 17.08, early July 2017, the first EXPERIMENTAL section was declared in=
EAL:
> http://git.dpdk.org/dpdk/diff/lib/librte_eal/linuxapp/eal/rte_eal_version=
.m
> ap?id=3Da3ee360f444
>=20
> When adding rte_mtr in 17.11, all functions are made experimental:
> http://git.dpdk.org/dpdk/diff/lib/librte_ether/rte_ethdev_version.map?id=
=3D
> 6613ffe1
>=20
> In 18.02, the tag __rte_experimental was introduced:
> http://git.dpdk.org/dpdk/commit/?id=3D7d540a3e735
> and functions are marked (including rte_mtr but not rte_tm):
> http://git.dpdk.org/dpdk/commit/?id=3D77b7b81e32e
>=20
>=20
Thanks, Thomas, for taking the time to put all the historic events in their=
proper sequence.
> > as more changes are expected from the people like Nithin and others
> > currently upstreaming drivers for it.
>=20
> They are doing changes in the API introduced 3 years ago.
>=20
>=20
> > For some reason, the __rte_experimental tags were not added to
> > this file when the ABI checker was introduced,
> > and this is the real problem that should be fixed.
>=20
> The mistake was done 2 years ago.
> As maintainer of rte_tm code, you are expected to notice the issue.
Apologies for not noticing this gap at the time. As Thomas shows above, the=
__rte_experimental tags were introduced several DPDK releases after the rt=
e_tm API.
> As maintainer of rte_mtr code, you were expected to review the change
> on the mtr functions being marked as experimental.
I did.
> I am sorry that it took 2 years to discover the gap.
>=20
> We can fix the ABI in the ABI-breakage window: in 20.11.
>=20