From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C07F2A0598; Tue, 21 Apr 2020 12:23:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E3171C1DA; Tue, 21 Apr 2020 12:23:16 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 51D631C297 for ; Tue, 21 Apr 2020 12:23:14 +0200 (CEST) IronPort-SDR: 9ypWemX1ZglX4JkamtrO5AJL3iC0iM7XjgldY/BvOImusOz5eF2z4ii20r2tNrdK+KWgJqG/4n QrYfibfoEWIQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 03:23:13 -0700 IronPort-SDR: f6pYV5VQagC7l5twrRHs5gU1QtsEQtg5lWcrS+PzFLooDQa/9gBCgmPfYY+Ed5IQOhCPUbmMaX GsHofC1V0MZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,410,1580803200"; d="scan'208";a="291558577" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga008.jf.intel.com with ESMTP; 21 Apr 2020 03:23:13 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 03:23:13 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX162.amr.corp.intel.com (10.22.240.85) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 03:23:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 03:23:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZMGN3qxdPpS8HKOHK0afgni67RM3F8vAfjRt6oiB1DuMPPfFpqk+IcZF9cNjnuexL75Vxg7XHjN4yk2DqaiVZmeWSPax+WY8uN1e0CI2qA6vFiw43DM8iWe7U+2QalWm6ny1cjM3w072hiNKsUZlnXGjhz82iubxWqyFoouohXS8zfT7RHRn+JsHV9YAyj8y/D/btKnU4mErJnA7cjXFknIA0EKxe3ebvBv+h5y8qSnwWGqh6AvB4daYGBOJrw6swYn702t03NcG1rDxZ4MBUGf8/RqzQcKZ9LOOX4+HRxE2vi+4MUtJaP92wMWajG8ySkXLptUxgyTCegeJmu5KSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yfo6CarLJnxHnpS0bhuzNOdrVGg+Bh1J8KQqQ5r6qmw=; b=Gcz2w6PpSJq1c40r11IRFM0AGYSJrwQOlXZvGZ1kD1TTJ6EW5b90RXe1a+J8iJut01G1R+TLTOBqjRlCMHkq1LaKfaz2aqkUR2WsbvGnvGJgRitNJJJSnrIK0bpODG/+PRYnEjiLi40UJH9UCpOwWNqfMylRpWYvxe/nidHS3ohQ+m4kwUGq0jL6EocBF7pMRyh2s/KI8SWhEhdQQMnyqrQbzVP1peceB0aFM4m2nmQHyLXxg+WyfwVgYsAKYOnIfCVZTfIHviQhSLoHxLPIZV6op30U951H4vA9pvyadbXQdsvKwuJW+DV/kpMrjnO9TdHbbBAEK41jdV69Si+nvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yfo6CarLJnxHnpS0bhuzNOdrVGg+Bh1J8KQqQ5r6qmw=; b=OvuR2yV5B5aVus0miSircXrKQbrv3DDVva7SVlUMmlIZRpfk6zVkHcZ3V+Ddw7aeuooSOlEzT0Jr+iZC3dhorf005Xpp6RQfKB2T0HyJG/Ha5uPIZKtqpq8gKeZZMkvDr7SjuZtu0w6HT5TjOleyDWwHSIMxoUb0qVE0eCZBIhU= Received: from BYAPR11MB2935.namprd11.prod.outlook.com (2603:10b6:a03:82::24) by BYAPR11MB3672.namprd11.prod.outlook.com (2603:10b6:a03:fa::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 10:23:11 +0000 Received: from BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::786e:a42b:df03:a829]) by BYAPR11MB2935.namprd11.prod.outlook.com ([fe80::786e:a42b:df03:a829%5]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 10:23:11 +0000 From: "Dumitrescu, Cristian" To: Nithin Dabilpuram CC: Nithin Dabilpuram , Thomas Monjalon , "Yigit, Ferruh" , "Andrew Rybchenko" , "dev@dpdk.org" , "jerinj@marvell.com" , "kkanas@marvell.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode Thread-Index: AQHWD/albJRPkm4dGUCJmUYHj84ik6iDVLWQgAASG4CAAAFdgA== Date: Tue, 21 Apr 2020 10:23:11 +0000 Message-ID: References: <20200330160019.29674-1-ndabilpuram@marvell.com> <20200411114430.18506-1-nithind1988@gmail.com> <20200421095813.GA2740@outlook.office365.com> In-Reply-To: <20200421095813.GA2740@outlook.office365.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=cristian.dumitrescu@intel.com; x-originating-ip: [192.198.151.167] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 83108458-8a8f-4b67-3bb1-08d7e5ddfe59 x-ms-traffictypediagnostic: BYAPR11MB3672: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2935.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(396003)(136003)(39860400002)(346002)(366004)(376002)(54906003)(9686003)(55016002)(478600001)(7696005)(26005)(8676002)(81156014)(8936002)(6506007)(66946007)(71200400001)(6916009)(66476007)(76116006)(66556008)(5660300002)(2906002)(4326008)(316002)(33656002)(186003)(52536014)(66446008)(64756008)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N/0Ej9E/U5vIOYHUvvYuXzCBwoSZWbhlIS4b5pNrkqAK4RbOcayZ/wQkbaag0Bc7vypXZ9y/kYgHmEvMs24YS9UJlEtLHdw+yp82gfbc39u8ZlBTapUmifIpSHdaz83f/vJ//Vt0OV0ppiGaTF+X8Mtbt9hew+OFA66skYHS/rJbQM42QtZhpPbaFNZF6hLhpGKDc10+qlYMJ+HJqiZ7MOu33+R8kNuy5sgZm+oWQ8pcelZUhPKTfPLByJvCOlHAIkcZVBTRUxM2kz6X0NtTyHrme7FJkfJuFXLjadxm5WQ8BNMElcWE6Zqow50AXwIRele8ee6IWV7mAQvPnjdjKQZgHeHDN9a8hVAftQBZgMaXlmzq3+ruCX25npqPGmgorxqQJkIHCrKtIoYvpjEby7tALxedxWtrqAiG8WB6TCiweWU1wNBRXw0m1WHEuhTW x-ms-exchange-antispam-messagedata: d/Ux+ec8vocI+14JwkFwW2lx+KWbv8xPazRv2rT55IDF13usas1+IyDti0WuAANqGSIZPBLNAesEkfdWXEf9hQQxFwElWCtXXFjQYJzKNMbvsdQYctOBGlOfLvWPPq6psfZHVsb8++mEXOst8GQnew== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 83108458-8a8f-4b67-3bb1-08d7e5ddfe59 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 10:23:11.2690 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v3BKYNb/B86OdG7lr2SizCP2qS46q8St/04NWoy0gURixlIpFaDrAPBIzY0wI8GQ2xnrK72z/+GNxNQtoscbRlo0D7sOqyxPM5BtiaWlzdg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3672 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nithin, ... > > You are missing the shaper_shared_(packet, byte)_mode supported for > non-leaf and leaf nodes in struct rte_tm_level_capabilities. > > > > The description of this nodes should be aligned with the description of= e.g. > shaper_shared_n_max field: basically, we want to say that, when true, the > flag signifies there is at least on non-leaf/leaf node on this level that= can be > part of a shared shaper that works in packet/byte mode. Makes sense? >=20 > I intentionally didn't add shaper_shared_(packet, byte)_mode in node and > level > capabilities and added it in only global cap assuming existing semantics = are > enforcing that. >=20 > Currently, except for 'shaper_shared_n_max', all the other existing share= d > shaper capabilities like > shaper_shared_dual_rate_n_max, shaper_shared_rate_min, etc are only > provided in global cap. >=20 > I felt the semantics are as such because, shared shaper doesn't really be= long > to any node > or level and any node from any level can attach to a particular shared sh= aper. > Isn't it so > ? That's exactly why we need to formulate node/level capability from node's p= erspective, and not from the shared shaper's perspective, as a shared shape= r is by definition related to a set of nodes, not just one node. The fact that a given node can be part of a shared shaper that works in pac= ket or byte mode, etc is a node capability in itself, right? So the node's = capability called "shaper_shared_(packet, byte)_mode" being supported by th= e node means that this specific node can be part of a shared shaper that ha= s those properties. To me, this is a valuable thing to capture in node/leve= l capabilities. We already have other node level capabilities for shared shaper, and we app= ly the same rationale there. What do you think? Regards, Cristian