From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E233A00C5; Thu, 30 Apr 2020 11:14:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85F6A1D9FC; Thu, 30 Apr 2020 11:14:35 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0E1B01D9E8 for ; Thu, 30 Apr 2020 11:14:32 +0200 (CEST) IronPort-SDR: 8cXwnQ4KYTKDPWgbPg4mJS+0xeWBTFo91XXU7tPEmqw4rJLq5hppzqVIyCLo1NFPDIDNlSW5hV HxCRmq8YZwhQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 02:14:32 -0700 IronPort-SDR: F/rrarq13nvzyGgePV4AilhNuhhIsTPS9/HJRSTbz2WPocdJXD6BwdaYiIRNEreme6K7fKNR3i lK0d1tovSr2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="337239476" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga001.jf.intel.com with ESMTP; 30 Apr 2020 02:14:31 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 02:14:31 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX116.amr.corp.intel.com (10.22.240.14) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 02:14:31 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Apr 2020 02:14:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbkiD+GTcI3pxvc0fseGani3ooMsclqdVzy8W6WZKU3itCyb0vE3jU/Pbdn96fqIjEYQaKhbjXok/Dtg5u/mFiXImJu6+3k7qxJAWerTiOKK3xfzwEmkJzaDq7txNYIZVQNI2VbO4bMfvK2fquSulTMX3Ss4QwcYMqFmZVYgwwRTaN9nzfBg82+VdnW3fWZRCqCdYUHKpHRjrIFY0NCVN2ClQ1LM0/L6J8fzSozS1mzSRV6K5sSo4WBjrVqdVrQqFghm3xFNlplHjCttJB0/FUUnMU013Yu6QVXDmy7+gqmlYKjYYgIMY2ZDQ9UcWDWF6Q4O5NBoDTIitdGtuh4+Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oMFGVfMgRxr0Iy1kNP119I/J775y9ctemFw2XPaMU60=; b=aTh4ZZco/waSourPb45aa85w7gBa53eQG8gKigtjoHCqneUFFh75t29y6gKLREBeY9ADsn4HE417/ooBS/Km3L6fby93l5csM04GDDSTOAR7zX8iZRbPDmsX0vwdGM8RFnnaWaamOK5vcKkapWo7hD1DTtG5H5lHETTbKMLncBsNzGiiu962OxVHfUE81wufNJLmge2wJVQrhh2x1ALTiJeen4XTCJnjlljCR5gzQdOFdXiIGazfsl9lNvR3WzuUHdVMAUnmnErCcLVjXmUkNGvQkoyVNuWFzZu3NOnhCrji/t7yq4S8+9pMilRscx2t+JXj8Kcw6bgpM7uimpF0kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oMFGVfMgRxr0Iy1kNP119I/J775y9ctemFw2XPaMU60=; b=UNYZGPI7WGClMrCPpj0jwNyURq0S4yhnCWR881OUq+0DATG1TwUlRRLtyW8QuXEd5FTEmkfx9ctGaYs3GLdh0ZCyAhRvHKwWa3xngKvtBvJ2WnNQxpuWJGlQKi/DkaEwfZ4cPLtxxD55Z/1nEMrdXZLQP3p5A7g39WAH2Jb+P/0= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3560.namprd11.prod.outlook.com (2603:10b6:a03:f8::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Thu, 30 Apr 2020 09:14:29 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49%5]) with mapi id 15.20.2937.023; Thu, 30 Apr 2020 09:14:29 +0000 From: "Van Haaren, Harry" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "thomas@monjalon.net" , "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , Ruifeng Wang CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM Thread-Index: AQHWHlDp8y6ob4x/AEKvbFUdhD0MAKiRYZ2g Date: Thu, 30 Apr 2020 09:14:29 +0000 Message-ID: References: <20200429180515.5704-1-pbhagavatula@marvell.com> In-Reply-To: <20200429180515.5704-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.167] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0162769f-9c3f-4d13-ad11-08d7ece6e333 x-ms-traffictypediagnostic: BYAPR11MB3560: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0389EDA07F x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vvxSFbDAPjjXoJ35NkKDeXqL0hBgHtwEIB8aaRpMRlZwBBJDIrKe7AqFNBMv+l8ptDbcullGGrZTGvNGSIe/zgDEavsq+Vnu0fwHaggmycZz8Cl8zQn1vujydl9ZBtEOkkW9QB2OcfnOEux2w08cVH5WiheaCbI3n0EDRENlgLwa3dwe8S6+Olg8oMtMqAqV8fzEvgPDx30zEfvHiAZ9je128ACS3FRIp/6T8++qePnai1vu0y/u0BmKaw7ej+yjOcx8s9DcfyjAmjDVtJuzr1tRUvRGJllktgFuiqRKNZ7rJ0hQjEeTuI/d2Ax3CTL6M9Mv4+pmZsEDR2l3wqKdaEMow/BQoaE/C5qOBMz3iu3JczLr6WB0pMF5/bLO/GohAgO7rcnCISSjJoCsawdHp1DtNGWiadSEOrtE/Qqo82eQ3C1gVmGaFBlTcm36V1MTC5ZtWjoKOzdpHiVJcpuig4xgOKffqx0ofJWWYNyDilU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(366004)(39860400002)(376002)(136003)(396003)(8676002)(316002)(478600001)(110136005)(2906002)(8936002)(86362001)(5660300002)(7696005)(71200400001)(6506007)(26005)(76116006)(186003)(53546011)(55016002)(52536014)(9686003)(66446008)(64756008)(33656002)(4326008)(66946007)(66476007)(66556008)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: jrGXF+nvRapskTPz3yCJh6Gu1g/6DmjsV9mioJcI608IAO/uiOIvb5J68Rpm34SW9PZw/e6ymXDIzR8rCEIYLWRVOv8HvzMmFU99xHC/xWyH5eZyTq5xUX16kqFhe8w4TBaBCLFNflmKtMuyThTW+1hWCX0URxVuP8V+Gf0VT6xhmlJmvGZrdODUSp46wWrFgtILeeIEtuuqahXFgXf0MepDtpi42dIIBm4simDZ54msMPU0D5qwA2qCz2brDAKpb8pw9MBxQVC7jWNfoyUWfqxVZQIJsLl4sXqFPAWFAS2LnSeXnLpCTo4F1TS3nRG9mxVjm3I5Ah1iG+BUx12spAgf65YJF8fipy+Fb41/HcdgaqpImEgfECxMv5gZljxIiifJsvSXu1sd9G0Sj8S9Ka/LMc/wv136ytq8iZHgG4mwUiR7g4B+Tr4SrTDToHf7/IFEJf/SVQPWFJS5+zHoqyGQk1+W66NjJoQfBtAWsSfrYqHicyTgAgZ7uAxbI9iE/KaGmb0XR9/SygYkcbpwUpvjvJ6KYpUmleeUpA2V05kL2CAqcF6cww/FzKX+CufRCvrxUm6zi9qeUG3uLDgzf7Q1G83McMY0ONT65Pj/jz7b5WeEswPByWDGaHqxbX3HvkSE/NnOn8TDj/ZjtQo0rCZu8HVANkK0c1r+aQlkJ3T1WROJqSeDQ+8/uUTqOP5nIrHcNnCdVey5HE+zd0COW4UKUSOP9P1p6eOgifVNNY9FWoEDXQyB3RCU/35pD6cvZ9ejgOP4sxfC2+vKC68AsEuOmOTOeM8qtxFZf+LWkdHRmNPFUeVn09Hwl7t7CPpD Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0162769f-9c3f-4d13-ad11-08d7ece6e333 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 09:14:29.3333 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gPZWU5619v5pafubMvc24CFbD+sRQiiBN71KNHaWsFeVPMX6HD4twD0K5S4XtDpmJKk4moYFwHxw5Xvifmz9GiMMdSaw2izI405awcXVJ30= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3560 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of pbhagavatula@marvell.com > Sent: Wednesday, April 29, 2020 7:05 PM > To: jerinj@marvell.com; thomas@monjalon.net; Wang, Yipeng1 > ; Gobriel, Sameh ; > Richardson, Bruce ; Ruifeng Wang > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [RFC] hash: unify crc32 API header for x86 and ARM >=20 > From: Pavan Nikhilesh >=20 > Merge crc32 hash calculation public API headers for x86 and ARM, > split implementations of x86 and ARM into their respective private > headers. > This reduces the ifdef code clutter while keeping current ABI intact. >=20 > Although we install `rte_crc_arm64.h` it is not used in any of the lib or > drivers layers. All the libs and drivers use `rte_hash_crc.h` which falls > back to SW crc32 calculation for ARM platform. > diff --git a/lib/librte_hash/meson.build b/lib/librte_hash/meson.build > index 6ab46ae9d..90a180bc8 100644 > --- a/lib/librte_hash/meson.build > +++ b/lib/librte_hash/meson.build > @@ -1,8 +1,7 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation >=20 > -headers =3D files('rte_crc_arm64.h', > - 'rte_fbk_hash.h', > +headers =3D files('rte_fbk_hash.h', > 'rte_hash_crc.h', > 'rte_hash.h', > 'rte_jhash.h', Am I right in that previously an application could #include and hence if we no longer install that file, this will cause a compilation failure on that app= lication? Applications shouldn't include arch specific headers... but we shouldn't knowingly remove publicly= accessible includes either. Perhaps consider just installing a dummy header file if the code cleanup in= the rest of the patch is desired?