From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A707A0562; Fri, 3 Apr 2020 13:58:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13B751C0B8; Fri, 3 Apr 2020 13:58:02 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 71F621C08C; Fri, 3 Apr 2020 13:57:59 +0200 (CEST) IronPort-SDR: SssxL2VqNKOv1SVIsoA56btdyuPce75JvtcKZVMQPTbUYY76MYVyWwDlfjp5l6+GSHFCC9n2wN 71QLpnrxDhaA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 04:57:58 -0700 IronPort-SDR: qPbzlbQlRrBoGru7UGUFpLyY38kQSb4/Gx29+kpntHyS+PDu+1OkQg8xaez0Ri03YMyIBZTRB4 3++NttSMmcCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,339,1580803200"; d="scan'208";a="268339121" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 03 Apr 2020 04:57:57 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Apr 2020 04:57:56 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Apr 2020 04:57:56 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 3 Apr 2020 04:57:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QeAaQYwugySiq1pUeFrIfgXvzyNXKUnFPkmyQRg4+01esW4CheYyshrVSP5+XcLpULjDHXEcA0M51vKxG/CyJclk171WrtUXDIo5C/UatCnXM+xMIQcFhUrs67IniqLaT6y1vt/Otea0xQ+pmx+SoQjFGmx6RMUvA1VJpw3mAxgl/7ReaeabWGECHgcAU1sgS/9Dl4Hd8lnGqZNY6n7tHEtBIoQR9PbHWjFVyD9NlI9x7zA1q6l7+cwSLaVu0RpBRdJIa+wa3L6HFYwZ+D+akNf/n47eGJytsucoYFdZZLbtbyv6o+5crVSDsYoFALIf/nVZiDbqnu4pivPNh4blWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cPv8gIyQXRaH7Big1YpBuaXkpnH10ktJP+2ZR5DyI4M=; b=Sq/1XeJes05JeZiqBHhZnFmvuMzH2n10qGLqIrXbqinNA2SulsLErgpra7CScVLgli/lRcoIZfKHJnZHxonQwp7J5mITPs6X5wy3EwLyYgIm/7qmzQ2i8F9YOVUyKCFvF9TW81GLgZ7eEsaX0LcoMpWRJRcWUxLo3Lx7Ck6Hr1SjisqffU6yHUm2yV2oxUzm68hMkQpPUbXgzMxN+j4GMx+hTGZ/eTf7rXWIhNxyQqv8wRwGqOexCxXwb4VNXYfcfOE9HxmeKIPLDjGDkd8vMgN9ktJpGEnwix1VoeMetlF2GjI07HCqsg9C1eHx7VBGQUWEgvStKdGkPG5NtoVK0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cPv8gIyQXRaH7Big1YpBuaXkpnH10ktJP+2ZR5DyI4M=; b=S933Jwddy6qTjr5CFTZ8p2Wn3ZvLoU8kOCVsRxOmi0StEYYkwq4HyaZl095UeXju90LA+hhmkG9itWFgAtcZTBBjwLk5xLZ4ZjHB8zORNCbRLHe7swcbsUpC4FPr4Zlquv60BwWtSj8wQRkwd5o0sQ6dCbIGFFZu36dRc8ea9Qk= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Fri, 3 Apr 2020 11:57:54 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49%5]) with mapi id 15.20.2878.014; Fri, 3 Apr 2020 11:57:54 +0000 From: "Van Haaren, Harry" To: Phil Yang , "thomas@monjalon.net" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Honnappa.Nagarahalli@arm.com" , "gavin.hu@arm.com" , "ruifeng.wang@arm.com" , "joyce.kong@arm.com" , "nd@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH v3 07/12] service: remove rte prefix from static functions Thread-Index: AQHV+/oc6HY4R6pDkkesLzySnA/auqhnRqdQ Date: Fri, 3 Apr 2020 11:57:54 +0000 Message-ID: References: <1583999071-22872-1-git-send-email-phil.yang@arm.com> <1584407863-774-1-git-send-email-phil.yang@arm.com> <1584407863-774-8-git-send-email-phil.yang@arm.com> In-Reply-To: <1584407863-774-8-git-send-email-phil.yang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=harry.van.haaren@intel.com; x-originating-ip: [192.198.151.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4b063a9-4b73-4bb6-7ece-08d7d7c63e7f x-ms-traffictypediagnostic: BYAPR11MB3541: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0362BF9FDB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(396003)(136003)(376002)(346002)(366004)(39860400002)(76116006)(53546011)(8676002)(478600001)(9686003)(7696005)(66476007)(81156014)(81166006)(55016002)(5660300002)(64756008)(4326008)(66556008)(186003)(52536014)(66446008)(2906002)(66946007)(26005)(8936002)(33656002)(86362001)(110136005)(54906003)(6506007)(71200400001)(7416002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0ah7I9/2dnznum+Eqg7YJqf/eDAio1eEWeQbHH3W0IeOzJvfxFCmacuivYVLCpCJMtBAPyVmOQoSp9DpS/8oulvCLvdSbWUEYpi2qbxLdP6aLqVrfCeeZBqqOtZhHns4v7YDOT5rQ5KM4CbJHhLGgtvv1lQvIxssEcYNGzSt7M76bpjg2HhztDzRySeEO9KQ8rZbUIF+eTIJlomsEQo5g7gswoYgQHCdPO/0rX969MeiPG5k4SoKzJEPk7Zx13RNnoUjtpmRsdUUi5nlYbqQGSk6p8GbsSP7hI4qAhls0VmNhoXRPoG9QtAEudWYAATECpKz11xDKepvzALjkeAJXLxx5Ktsw+zvNmj+x8z1+njxbTzC2/U3MN0JOlJ57y4rVyZURm0LAMmRLPdpumDnbZKddbVgc/MgtaW3yrQzc/jzphqznicBnjcDcC39NPrM x-ms-exchange-antispam-messagedata: 6YLEV8GyWnDTEAt9mhTSToZ5YZl1jc6nGfFJwBkogFqkjxj3qmRjOOj3u/pYe+nBUvwkQFg0wEnu99/xzVzvIKziZQrquD0RY0KTa6+mFfPzYBV7t67k0eScaTGqb3ASqXF398rzk+sL+fLd27d3IQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d4b063a9-4b73-4bb6-7ece-08d7d7c63e7f X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2020 11:57:54.7284 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QNT16cXtZ2b3Y/wKw/J6exCo6vZsSVw2Bkj7KrICNiRsZ0ujX/qFumtVrtS7d1z6JFfUFWYYvI96wuDqBohtyGhIkn41RrJop52cE95qjlk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3541 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: thomas@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > stephen@networkplumber.org; maxime.coquelin@redhat.com; dev@dpdk.org > Cc: david.marchand@redhat.com; jerinj@marvell.com; hemant.agrawal@nxp.com= ; > Honnappa.Nagarahalli@arm.com; gavin.hu@arm.com; ruifeng.wang@arm.com; > joyce.kong@arm.com; nd@arm.com; stable@dpdk.org > Subject: [PATCH v3 07/12] service: remove rte prefix from static function= s >=20 > Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses") > Fixes: 21698354c832 ("service: introduce service cores concept") > Cc: stable@dpdk.org >=20 > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli This patchset needs a rebase since the EAL file movement got merged, however I'll review here so we can include some Acks etc and make progress. Is this really a "Fix"? The internal function names were not exported in the .map file, so are not part of public ABI. This is an internal naming improvement (thanks for doing cleanup), but I don't think the Fixes: tags make sense? Also I'm not sure if we want to port this patch back to stable? Changing (i= nternal) function names seems like unnecessary churn, and hence risk to a s= table release, without any benefit? ---