DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore
@ 2020-10-16  9:08 Kevin Laatz
  2020-10-16  9:18 ` Van Haaren, Harry
  2020-10-16 11:50 ` David Marchand
  0 siblings, 2 replies; 5+ messages in thread
From: Kevin Laatz @ 2020-10-16  9:08 UTC (permalink / raw)
  To: dev
  Cc: harry.van.haaren, david.marchand, l.wojciechow,
	Honnappa.Nagarahalli, phil.yang, aconole, Kevin Laatz

There is a potential race condition in 'service_attr_get' which will cause
test failures since the service core thread is still running while the
values are being retrieved/reset.

This patch fixes the race condition by waiting for the service core thread
to stop before continuing with the unit test checks.

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
 app/test/test_service_cores.c | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c
index 5d92bea8af..44b6fc3624 100644
--- a/app/test/test_service_cores.c
+++ b/app/test/test_service_cores.c
@@ -119,6 +119,17 @@ unregister_all(void)
 	return TEST_SUCCESS;
 }
 
+/* Wait until service lcore not active, or for 100x SERVICE_DELAY */
+static void
+wait_slcore_inactive(uint32_t slcore_id)
+{
+	int i;
+
+	for (i = 0; rte_service_lcore_may_be_active(slcore_id) == 1 &&
+			i < 100; i++)
+		rte_delay_ms(SERVICE_DELAY);
+}
+
 /* register a single dummy service */
 static int
 dummy_register(void)
@@ -305,6 +316,8 @@ service_attr_get(void)
 
 	rte_service_lcore_stop(slcore_id);
 
+	wait_slcore_inactive(slcore_id);
+
 	TEST_ASSERT_EQUAL(0, rte_service_attr_get(id, attr_calls, &attr_value),
 			"Valid attr_get() call didn't return success");
 	TEST_ASSERT_EQUAL(1, (attr_value > 0),
@@ -394,11 +407,7 @@ service_lcore_attr_get(void)
 	TEST_ASSERT_EQUAL(0, rte_service_lcore_stop(slcore_id),
 			"Failed to stop service lcore");
 
-	/* Wait until service lcore not active, or for 100x SERVICE_DELAY */
-	int i;
-	for (i = 0; rte_service_lcore_may_be_active(slcore_id) == 1 &&
-			i < 100; i++)
-		rte_delay_ms(SERVICE_DELAY);
+	wait_slcore_inactive(slcore_id);
 
 	TEST_ASSERT_EQUAL(0, rte_service_lcore_may_be_active(slcore_id),
 			  "Service lcore not stopped after waiting.");
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore
  2020-10-16  9:08 [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore Kevin Laatz
@ 2020-10-16  9:18 ` Van Haaren, Harry
  2020-10-16 11:54   ` David Marchand
  2020-10-16 11:50 ` David Marchand
  1 sibling, 1 reply; 5+ messages in thread
From: Van Haaren, Harry @ 2020-10-16  9:18 UTC (permalink / raw)
  To: Laatz, Kevin, dev
  Cc: david.marchand, l.wojciechow, Honnappa.Nagarahalli, phil.yang, aconole

> -----Original Message-----
> From: Laatz, Kevin <kevin.laatz@intel.com>
> Sent: Friday, October 16, 2020 10:08 AM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>;
> david.marchand@redhat.com; l.wojciechow@partner.samsung.com;
> Honnappa.Nagarahalli@arm.com; phil.yang@arm.com; aconole@redhat.com;
> Laatz, Kevin <kevin.laatz@intel.com>
> Subject: [PATCH] test/service: fix race condition on stopping lcore
> 
> There is a potential race condition in 'service_attr_get' which will cause
> test failures since the service core thread is still running while the
> values are being retrieved/reset.
> 
> This patch fixes the race condition by waiting for the service core thread
> to stop before continuing with the unit test checks.
> 
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>

Thanks Kevin for handling; can't reproduce race-cond here, but by code review
this is the correct fix, thanks also for refactoring the wait into its own function.

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore
  2020-10-16  9:08 [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore Kevin Laatz
  2020-10-16  9:18 ` Van Haaren, Harry
@ 2020-10-16 11:50 ` David Marchand
  2020-10-16 11:51   ` Van Haaren, Harry
  1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2020-10-16 11:50 UTC (permalink / raw)
  To: Kevin Laatz, Van Haaren Harry
  Cc: dev, Lukasz Wojciechowski, Honnappa Nagarahalli, Phil Yang, Aaron Conole

On Fri, Oct 16, 2020 at 11:13 AM Kevin Laatz <kevin.laatz@intel.com> wrote:
>
> There is a potential race condition in 'service_attr_get' which will cause
> test failures since the service core thread is still running while the
> values are being retrieved/reset.
>
> This patch fixes the race condition by waiting for the service core thread
> to stop before continuing with the unit test checks.

We won't backport it, since we need a new API, but I would flag it for info as:
Fixes: 4d55194d76a4 ("service: add attribute get function")

Ok for you?


--
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore
  2020-10-16 11:50 ` David Marchand
@ 2020-10-16 11:51   ` Van Haaren, Harry
  0 siblings, 0 replies; 5+ messages in thread
From: Van Haaren, Harry @ 2020-10-16 11:51 UTC (permalink / raw)
  To: David Marchand, Laatz, Kevin
  Cc: dev, Lukasz Wojciechowski, Honnappa Nagarahalli, Phil Yang, Aaron Conole

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, October 16, 2020 12:50 PM
> To: Laatz, Kevin <kevin.laatz@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev <dev@dpdk.org>; Lukasz Wojciechowski
> <l.wojciechow@partner.samsung.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Phil Yang <phil.yang@arm.com>; Aaron
> Conole <aconole@redhat.com>
> Subject: Re: [PATCH] test/service: fix race condition on stopping lcore
> 
> On Fri, Oct 16, 2020 at 11:13 AM Kevin Laatz <kevin.laatz@intel.com> wrote:
> >
> > There is a potential race condition in 'service_attr_get' which will cause
> > test failures since the service core thread is still running while the
> > values are being retrieved/reset.
> >
> > This patch fixes the race condition by waiting for the service core thread
> > to stop before continuing with the unit test checks.
> 
> We won't backport it, since we need a new API, but I would flag it for info as:
> Fixes: 4d55194d76a4 ("service: add attribute get function")
> 
> Ok for you?

Yes - thanks.

> David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore
  2020-10-16  9:18 ` Van Haaren, Harry
@ 2020-10-16 11:54   ` David Marchand
  0 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2020-10-16 11:54 UTC (permalink / raw)
  To: Van Haaren, Harry, Laatz, Kevin
  Cc: dev, l.wojciechow, Honnappa.Nagarahalli, phil.yang, aconole

On Fri, Oct 16, 2020 at 11:18 AM Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
> > Subject: [PATCH] test/service: fix race condition on stopping lcore
> >
> > There is a potential race condition in 'service_attr_get' which will cause
> > test failures since the service core thread is still running while the
> > values are being retrieved/reset.
> >
> > This patch fixes the race condition by waiting for the service core thread
> > to stop before continuing with the unit test checks.

Fixes: 4d55194d76a4 ("service: add attribute get function")

> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Thanks Kevin, Harry, applied.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-16  9:08 [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore Kevin Laatz
2020-10-16  9:18 ` Van Haaren, Harry
2020-10-16 11:54   ` David Marchand
2020-10-16 11:50 ` David Marchand
2020-10-16 11:51   ` Van Haaren, Harry

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox