From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDBCBA0597; Wed, 8 Apr 2020 12:36:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 905021C1A4; Wed, 8 Apr 2020 12:36:44 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4A5061C139; Wed, 8 Apr 2020 12:36:42 +0200 (CEST) IronPort-SDR: iaF7F/kzmFEsIYiWYnb4QPbP6eBsCJnEEPqB7vYVt0zXmVxoGhTgVU+mkCy9CrQl2w9L/FJL1R zctUO/hRI5Iw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2020 03:36:41 -0700 IronPort-SDR: M3BvwZ9BtY03u2O7s1GF3Ft6hv60leLqnBNO3ZLUCSqgkDZ+HG30Jgjrv56BbVU20+1vZET8sc ogCnr7BQzWdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,357,1580803200"; d="scan'208";a="240259859" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga007.jf.intel.com with ESMTP; 08 Apr 2020 03:36:40 -0700 Received: from orsmsx124.amr.corp.intel.com (10.22.240.120) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Apr 2020 03:36:41 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX124.amr.corp.intel.com (10.22.240.120) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Apr 2020 03:36:40 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Apr 2020 03:36:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XPROXYWaF45DgnvzLKqi0akH67xLSKAt8pZlW9lRJj88iKf7DRz+qEqFB8TS826QXPoGtYqJ3gwM5tya9fUj0oX6rHy0+ehXlOpbtQJB7Twnf30dI74pQ8OUhuZ4mGMITCmAosyVtJIhQzRc2igcGBxjnsMyqQvVtsJXCO3y09PvWZU0MiCRk/dEDGqMHJCbtzH/1mMqyNrU2wwPZsG035Zd/MjVtgZUJj97+FQmdAGZc4fKW+Eo3VlxlZ7Av7HZ/7+e1Sjpqiq8yHtXkc6+mwe0uBhIx6cb0E64W1J2i6pAZq/snt84iQvxwJUs6ED03mKce1FALaiF0lHZPtglpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQkvs+hQjH+OJ4fqt4CeNgAC/5ZErfRztFo+oEyfYlI=; b=HyPyN2NPeE4y/4q0iHMJGsYsH+J82FUE1nQpRXbUERiEU1f/zERprWihGHMQUhHna4oB5V8R4X1K55W7lbzRE5XrXDBiD4hlJTs8HLrf4u29lVFfxlUDIoc8DL2B43b65J9eHv9g8ZT7V4FJh2RK08aQQ0P8yOnf20J7M0TnDOwNwDF9HBXlO2+ZdCqMOQD16n3WVIRSV5DyCmV6pUrlbZK4bKWBAPkmSas2WNibYN548PTEEh0XaUWTM1rRmJoQ7hhmjA99Re57fskrF56ArR2RucuFmdEMTleIcmoHEvUlb8Yjqk6Wj4J43ODOel5qhG3WTfKJ9P/iE1M1GWUzMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQkvs+hQjH+OJ4fqt4CeNgAC/5ZErfRztFo+oEyfYlI=; b=jnlSQ9ribqEQc/0kSJ7LZ8wID2LIh259PJ/JKYC+sR4Cp4sxxm7rg/g8xdxN/6cziuxt0K6FsfY08JYkhqUZQDnYWZ1NLvga81sIOgzygDzGWJkRpu3DUg4VTEzJ0CHIBBCUCuOE2sRWD5bisVzh/ZV93g4fd+YjMe+tsDqxBE4= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3031.namprd11.prod.outlook.com (2603:10b6:a03:8d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Wed, 8 Apr 2020 10:36:38 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49%5]) with mapi id 15.20.2878.021; Wed, 8 Apr 2020 10:36:38 +0000 From: "Van Haaren, Harry" To: Phil Yang , "thomas@monjalon.net" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Honnappa Nagarahalli , Gavin Hu , Ruifeng Wang , Joyce Kong , nd , "stable@dpdk.org" , nd Thread-Topic: [PATCH v3 07/12] service: remove rte prefix from static functions Thread-Index: AQHV+/oc6HY4R6pDkkesLzySnA/auqhnRqdQgAfedICAAAWCYA== Date: Wed, 8 Apr 2020 10:36:38 +0000 Message-ID: References: <1583999071-22872-1-git-send-email-phil.yang@arm.com> <1584407863-774-1-git-send-email-phil.yang@arm.com> <1584407863-774-8-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=harry.van.haaren@intel.com; x-originating-ip: [192.198.151.165] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2ecc25e-3e3a-4475-9692-08d7dba8b7f7 x-ms-traffictypediagnostic: BYAPR11MB3031: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0367A50BB1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(376002)(136003)(396003)(346002)(366004)(39860400002)(5660300002)(66556008)(71200400001)(66446008)(33656002)(26005)(186003)(64756008)(66946007)(76116006)(81166007)(53546011)(52536014)(54906003)(7696005)(81156014)(8936002)(110136005)(66476007)(316002)(6506007)(8676002)(4326008)(2906002)(55016002)(9686003)(7416002)(478600001)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cdh3Bcsob/LDNqtlJTVB9Wr724eH3kQ9Gdjqryi/OyougeoP1nKoG8A5DhsnEaf9j5xcEEqxDGMhYmhcx4Gljc1ih4GQMO02/SULowgFFg6lab9aLQr94/TO+OdcoU8j3cBgJpkubXPt9ZWEEJTTSD2qpj9I8LeCG5uBRCsJqUt7LqEJ7BwSjT81yjsMCPN3cU1CIv4uV2kmdwDMiCdlJkU3AlWcDCvk/6WC5tZPNAbGXxtKeTuvvxB6C1neTb8dKFVTQjBmk/uuUi8CtvQZwa4kom+aP097y9GObG9WLzBgI17mPs7YYNEcMTBjwpNK5M3IiH+PlpKs1QsFPaIfEPWyUPz+BpA3wZWrnT/CDp6NZn80vEudT7RrVAGIWtzZlBebZFnNbq/01Lt/nlLWng90Dm5yUtIsE0BX9CClgnrPpCnjqpQPEjxWbC6V5yLB x-ms-exchange-antispam-messagedata: tKJ5Ql6CM9DrKggAxz9E+2XmjJR2pnMPyZb72Ro6X5t72cfRCsc53FAv77t4/Q8pWpc2UtPbqdZ1m+BOCVnUF9DTZkqbf1D4XgMdbYQhScPVOGIH+5C+hI4U1yhmIp1v/wRJKBl81Cqtzukq78UJNQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b2ecc25e-3e3a-4475-9692-08d7dba8b7f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2020 10:36:38.2290 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: afVvT3nrnOXtx6DRmQDKauWMHSJyERDtZfL0IqoRNZpFO33E8UJjjSOxhEhGhjN+B/msIL1VyC8CmJ8AFh6t/00YlcZiFlRRDYZTlmBnKGk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3031 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Phil Yang > Sent: Wednesday, April 8, 2020 11:15 AM > To: Van Haaren, Harry ; thomas@monjalon.net; > Ananyev, Konstantin ; > stephen@networkplumber.org; maxime.coquelin@redhat.com; dev@dpdk.org > Cc: david.marchand@redhat.com; jerinj@marvell.com; hemant.agrawal@nxp.com= ; > Honnappa Nagarahalli ; Gavin Hu > ; Ruifeng Wang ; Joyce Kong > ; nd ; stable@dpdk.org; nd > Subject: RE: [PATCH v3 07/12] service: remove rte prefix from static func= tions > > Is this really a "Fix"? The internal function names were not exported > > in the .map file, so are not part of public ABI. This is an internal > > naming improvement (thanks for doing cleanup), but I don't think the > > Fixes: tags make sense? > > > > Also I'm not sure if we want to port this patch back to stable? Changin= g > > (internal) function names seems like unnecessary churn, and hence risk = to a > > stable release, without any benefit? > OK. > I will remove these tags in the next version and split the service core > patches from the original series into a series by itself. Cool - good idea to split. Perhaps we should focus on getting bugfixes in for the existing code, befor= e doing cleanup? It would make backports easier if churn is minimal. Suggesting patches order (first to last) 1. bugfixes/things to backport 2. cleanups 3. C11 atomic optimizations > Thanks, > Phil Thanks, and I'll get to reading/reviewing your and Honnappa's feedback late= r today. -H=20