From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3FD1A04B5; Tue, 27 Oct 2020 11:57:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 497852BDB; Tue, 27 Oct 2020 11:57:29 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 659DE2BAA for ; Tue, 27 Oct 2020 11:57:27 +0100 (CET) IronPort-SDR: MZefSctxzb5liG2KLxahIKsX2mEBtwTiWolHxd2HR41nT97EPNtaCI2rcfnCdRkeunA8wHtKxI EDnTOrujPEXA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="147914503" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="147914503" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 03:57:25 -0700 IronPort-SDR: TGXPTdjK/GAuzcstPTmU7hP4UnOMiiIuTxSHOjOOZpmJC1A4HshOLeglxtzTl9HrbQ1jtMkfCQ b7wbeq0gO2bQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="334354934" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 27 Oct 2020 03:57:25 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 03:57:24 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 03:57:24 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 03:57:24 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.58) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 03:57:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBcYDLH+Z+b/OyLgzFi1azAPIUvXPvqk6a/pPx0p+/RTb4hW2wbE6JVtSobX9QWlRvQKWauymrwt/1bkxDRLtLbvnGAw1Z/OLKjLaFaOqft4B9aHPtmIlFFkLjAKg3n9CD/0M8VeAGFhChNY2AlyeMkgaTTsfrKXx2Kk4nWa7E4fvjl+WX3Z2142GuFni7flfks0O7SedDH899ntUA2QgrBJEylqVfZ/EtkVx3mqTYEIVgr88pmgRlc5ieFKuarTP8gcEWPAe86/cGba0k7IvgPDn6vrzU7ETeM7KkB9f5uYOnftWNKW077CA46HFf1RA6Hgx1f6p/lTrlxXYXkVjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3gCsoAxxYho/qGqzrj/w+DTommV+KHzMlm6bMe4u10=; b=CI6EcHYLypzPfBGSEvJqcFLbncNcs0w2wKUbeZNmQNKSiD84NR1DIYYjHKZ/ph0EZs9CvzhDAFp6QeLOWmn86OAnfLLBz0Y1JR1a55fT/Gz9S0UiinnUCXNS/4sxORkLX6Vx5P/bllXsGwdw9caJXEefQw2lY0uxiuP18El9noJbUxmmvFp/R6t7JFtH8W9Olk75GRgKUSqP7idhJIFEsythm+j7PzO7U1e+jqe7YnwfYHDRGlllKpXpdEcPzqxVinjuD1IGSj9iodTtGXUhtZV5JYorGei7bXgo3QjcYBrqByheiMKOMVBQXnoORl6Ydi+z3vsyOfmp+u6O2hrAFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3gCsoAxxYho/qGqzrj/w+DTommV+KHzMlm6bMe4u10=; b=BCAQn/umHpwFFAFEWtxcEZTKmU7G5NKDUgMAe7bvpVsW6a5/yE5DdBToU0vebS8wQmoO+2Try2nIsajUNZ20XI4j4tLFe3oNnOraR5c0UbK/K7meTTQTNxudtk11sO8tG5w2eVlXdMs1EuyfhnHLROLnz8kCTdyUkDBJWvovVrM= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by SJ0PR11MB4783.namprd11.prod.outlook.com (2603:10b6:a03:2af::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Tue, 27 Oct 2020 10:57:23 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::59e7:5ab9:4e99:27b9]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::59e7:5ab9:4e99:27b9%5]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 10:57:23 +0000 From: "Van Haaren, Harry" To: David Marchand , "dev@dpdk.org" Thread-Topic: [PATCH] service: separate dump and reset code Thread-Index: AQHWqEqImZpbzPEwpUagxHknUNr1PqmrTwsw Date: Tue, 27 Oct 2020 10:57:22 +0000 Message-ID: References: <20201022080810.22153-1-david.marchand@redhat.com> In-Reply-To: <20201022080810.22153-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f09ad33-86cf-4215-6385-08d87a67155f x-ms-traffictypediagnostic: SJ0PR11MB4783: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rdYpsJKeUCpMDQDk7cGniYRMOsdKTondhgO994n5gaEL/XlrYl/1/MD0RLdzgHh9yQDbPlWntme+9l75T72RKVm9izyQ9YAvc+QLDTpUB+r+vjK6pGiqr9KSO6g9Iz9wq0d+nbqzT6Mr8oovPMoMqA8wgJrtAyUyb8eGOOJugu13ykojtrAtqFlWH0l7x0cJLyO5oFidxJ44SnMs55eynxOB5cVosRG/6zBffV5OFJNoHT/dtrxXxdE0D6cATQhooU+PcPzC8z+okO5FtnccCIHD2jZAyeio6pTlTBsXkytPYg+h9hgXX7VO00N5ZYu3LcgUGrcEN2cTYIOuVSWZhQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(66446008)(83380400001)(64756008)(478600001)(52536014)(26005)(71200400001)(76116006)(55016002)(66476007)(110136005)(66946007)(8936002)(4744005)(5660300002)(53546011)(186003)(6506007)(316002)(66556008)(86362001)(7696005)(8676002)(9686003)(2906002)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: qonffTd5G0/vsUfftfjSPwh2uA8TOlypiyNZ5olCdkQq3uLhKxqxIR/bmHheKMj/KQCr7SzsFlauwY2WZ3V8746fvnLypD6ftZOYELdLHdgd/1jKKud7L8fsCWdBeHxXDScgPK6s5OMUC82d7VxB2m7o3MTta2YDcRXhclI2Fb3lkkwMvSNn2IWz5lxUHTyY0UbOXCXlU5jP1do+KDdAV+TwK9XWv4WlBU68sCe3nmtAvPKt5BZTca/DNF17sT6pgkI9bB/p4V5tNleGLDVuSlt4BKK7MFe3z+OP03mJiypNfcBkndoa/CX2YJKXGMKni+a7FBv47LroF41vbFxTBSqCaBJbERnOyO+3QjmuPhPkbzl49ZH1tpmny3o470F8O4J3jgl/Ntt2pho5LKzU9plGIiLujMQpen23rsZw0axwQw8XK2wPz0nyhiQtYx4egp6wHFT7pVp4A+y37pj1M7IuVeG8M2C92KSNes6gGe83xFIFco7YTMBq97WABkpZnYsjBbCA+qvtd7EaKK/03ML6NJK/Lin+ss4a2RUgNmKJgpElUW96hgKMDXrO9XU6B44nQsUV34kh7Th8MUPmtQXLQQEy64160YmJ2EKYJI+IJ6N0tXyimsMdmsIvUioJ0m9e7+orO9FESrNM5bpzjg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f09ad33-86cf-4215-6385-08d87a67155f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 10:57:23.0139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xmKXu1HaW2wEY2Kdnm4luOK7M0cNRncohACg9v94Y1ZWUTTBePkABHcPWse2vI4CEELQZTu5klgg6l2ar3v9QBPNrpiLoEIST5gKy9l80vo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4783 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] service: separate dump and reset code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand > Sent: Thursday, October 22, 2020 9:08 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry > Subject: [PATCH] service: separate dump and reset code >=20 > No functional change intended. >=20 > service_dump_calls_per_lcore() was always called with a 0 reset flag. > service_dump_one() was called with either a 0 reset flag or a NULL > FILE pointer. >=20 > We can split the code for readability sake. >=20 > Note: there is no path to resetting calls_per_service[], this is left as > is. >=20 > Signed-off-by: David Marchand Simplifies logic - thanks: Acked-by: Harry van Haaren