From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97465A04B8; Tue, 5 May 2020 16:49:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2191F1D616; Tue, 5 May 2020 16:48:52 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0984F1D608 for ; Tue, 5 May 2020 16:48:49 +0200 (CEST) IronPort-SDR: mwUM/DpUiaBh4Kvbs7W4n5+9aSOxFQZSqw2TQgBYT7PZ58+v5AmVkWBtAGSxGAcUwIhr2JYKsT wHTVKO4vKyMQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 07:48:49 -0700 IronPort-SDR: b62DFKYBCxlB+UftO0BL3TpxxLM3AjDLrMrGyk8Q/HLQqawX/hDuwwOr0ngbvK4qoAvTVF0NCR 2DU13YcAEeZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,355,1583222400"; d="scan'208";a="294993075" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 05 May 2020 07:48:49 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 07:48:48 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 07:48:48 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 07:48:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HJsV242oIxt1+1oSgKFQMkRMH5LGupOe82bFP+NjN5SQLSFNlMpb1bBvsSSdjUKK3UnF+1Wvp6N4tzHuuGVX95Hp54XLN5egsbBUBr5SbD7+O89XAERt+7Tzw+ucswm6++yrcNAu6fFdeI/JeOd43P/sWDy6S8vgoKhj3mR2puTmTYC2LCPaI0DsbaPC4KamC+hu5/U/TAv/onrQVE6F2phU9gQzeFPPKgbk3Q0LT5rYx3NoMVVYGm410gkEPvIMazsDgDAhthemN/voZ0b0z0Y+nrcOXisRqGxaKESFzn180j8kelYADN0vZrD5ez2kTyzNpI1pCHdp05bJ10JFqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HuJm5v6qPSN4I6WEb2zOSPZACORiSY9B8ziOci6ppDA=; b=AzRC3K6oaSx/4x0STAKhlNUjJk4QNTq/7LRXPtg+DOAUs7kTjt/FhFkLs8/LysPVOQ0JZTUW9FDtDWu/kt16wjlkwCN2f500BuMcXPajHsCE1ByEOGVnPJnMxvauOzi58IV7dL4x72Qo9Z/P3kSrtQnQcuw0LPe3fEAp/sIpcp7BXD+Zbh9GXtpSwRte2TYtB8JPX/IhmCvDl6lFerP6OTcjawKjC089/gefgL+omSDhCdxm+UPfDvju26b3gs7YeRehIOzILjZVX53CXZ7HSEmZ1P0JsnJNzIz8Q8ntkL/liQe9Ap5tRVBSrf3vlDXYOX90sVSpgOhBw3TJ3tXegQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HuJm5v6qPSN4I6WEb2zOSPZACORiSY9B8ziOci6ppDA=; b=JguUfyvezy+5TAxgSWcO6Yvw+XFFu/RTJ5Ilpo0cf2pdgRSRB7SbXDgXNtbWhIFOzNlvXsw/JF1NSFDbcZ2IWHqUhgfShE4U6uIV76Sz3CWQ2rwEmbqT+1I/ZPL9man5veOGjid33I8jVJjyVU3dnJSFAPPYY3REw0smbjI6Yic= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3432.namprd11.prod.outlook.com (2603:10b6:a03:8a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Tue, 5 May 2020 14:48:36 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::5917:9757:49b0:3c49%5]) with mapi id 15.20.2979.025; Tue, 5 May 2020 14:48:36 +0000 From: "Van Haaren, Harry" To: Honnappa Nagarahalli , "dev@dpdk.org" , "phil.yang@arm.com" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "Ananyev, Konstantin" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Eads, Gage" , "Richardson, Bruce" , "nd@arm.com" Thread-Topic: [PATCH v3 4/6] service: remove redundant code Thread-Index: AQHWIBUmYFveUjsN5kieAoZ+doooS6iZky2A Date: Tue, 5 May 2020 14:48:35 +0000 Message-ID: References: <1587659482-27133-1-git-send-email-phil.yang@arm.com> <20200502000245.11071-1-honnappa.nagarahalli@arm.com> <20200502000245.11071-5-honnappa.nagarahalli@arm.com> In-Reply-To: <20200502000245.11071-5-honnappa.nagarahalli@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d5b30676-d480-40d6-4532-08d7f10363f6 x-ms-traffictypediagnostic: BYAPR11MB3432: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1388; x-forefront-prvs: 0394259C80 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TYlMgxBXvhRpibqDogXfb3EblxTKVrxgKUgFwWuKLWa7UKytfxll/JDZWhXMIqgRVrgmNI5gBERjsvNcGebNMDZ2rIwkiBwyPbzQnct+qqFj8m5okKUPGcV/28e+S3bkWr+Lh6j1nQP/nZAatHHhX8qWBfDPeeSA/NpDZs8tCuzjLIFg2qEOSppsReAbG84LUw1UGusXGRmoSuufO8wXmkpexBgrt9+I+Uc0INJtC+BPwMlm9jbVkdot1oeZoiVnWeMRRUX+fVqXgtBJnarJIiyEV/EsQ9qwfNSH+tXdKV1JuIELad2SUy/bd6A5v6+Y9C16jc7GD6f5A2HR3GpxsarPm65F6Z2xNN+VoULrLUnFUTyI0elj+O4I1gLHbf8hQJqTI4WRXaUpzD9rBIJsyQI8gXA/Hga+WBgtmg4ppF0x9UMMQdteEEJXqD0C9bhyrk174/wXCQAl6yvTrnRbNcYYm6kxEExYwsI4/VT+n1D7Yhb0ccD6TDJ2kiTZJPCsw/m/8EzGIdYol1/Rxl7pmw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(39860400002)(366004)(376002)(136003)(346002)(33430700001)(186003)(26005)(7696005)(55016002)(9686003)(53546011)(6506007)(86362001)(4326008)(33656002)(478600001)(8676002)(2906002)(76116006)(8936002)(4744005)(33440700001)(71200400001)(66476007)(64756008)(66556008)(52536014)(66946007)(66446008)(5660300002)(54906003)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: TjTZ9z9IddQAzhFmJNnoN4P3mMk3MTtFNyHaEol0bBvbBeDOJGbpH0XZATtQ37+S8tXIDeixnTDdV42yTwZaN5AJ3DMsgk49fT+GU/DLBeDKpIZJ7SLGPoKbHT47PEN8pcbydT/WBpLggYDy9jYsIG4jn3uW+8gTXfRn6SkrH8n1jWvioqwNI9Jm0cVEjF10vOF1T/RViXSN7ARSMtIDrMv+qfOmHwkHNJXrEG+1+9UhERGufv7NqHLA6z6Pc8tkKFw7SRYiiCyfFS4Pq7jVEw4JExl8ooO3sp05Ucz6B0djEZ7oGYbLLtRlj72CyfOQbECRHrddIR01gqaLDENWydj7+KKRJaQExeStCDAHxK7PFMNicpng50x5OTSw3eqw4F+joO2qXfxCpB9ARQn56CPbyfwGOF75iyvMERubJwKmlXG3EsQJxhsH5gldNMst8U5d9o13LpUndqKv3YsYs2mRoUurkyRWw08YpHhZD46BdPydl82jAwAOIvSNjtLYOof7IdB52gF7DAjTvPtL32v/SdhXtJWirIcrgvslf7D8WKhKvqzqJTuFP4GAi92ykL0al3665PHlyq/8WV/fXt15qoMFWHMSiGaVy55J2F1o8ZMQTdu99nUe9/t0vNg1xJrTYm3hdXI/WfoBhQvp8+O2w4zfOslNAt7hZklyEVtYdYUA2IwPvGlEDHExw5YgbnFpNDxAe/yfAWHQr0BZyYMfjnUcsbfbY5l+BPdwUkA6gRB6Td6kMlg/BzNMPjuzy0enSiNjIBSK/i7OSGeD05rP6DdJ/EuA/lEZF/6bNFv4KcBNBFwQWmhZpn2jowPI Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d5b30676-d480-40d6-4532-08d7f10363f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2020 14:48:35.9574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OHPzFGxh+pT4hrnNsrofsvQbvb7dHFnJUuu9QnIMuPVIK3F5Uvu+SwyYyNY8Hcmjs/kLqonR1eR3lz7prqVZPU3hz9Sx6WXSj32Ab0wlivM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3432 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 4/6] service: remove redundant code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Saturday, May 2, 2020 1:03 AM > To: dev@dpdk.org; phil.yang@arm.com; Van Haaren, Harry > > Cc: thomas@monjalon.net; david.marchand@redhat.com; Ananyev, Konstantin > ; jerinj@marvell.com; > hemant.agrawal@nxp.com; Eads, Gage ; Richardson, > Bruce ; honnappa.nagarahalli@arm.com; > nd@arm.com > Subject: [PATCH v3 4/6] service: remove redundant code >=20 > From: Phil Yang >=20 > The service id validation is duplicated, remove the redundant code > in the calling functions. >=20 > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli Acked-by: Harry van Haaren