From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB7A8A0522; Thu, 2 Jul 2020 19:56:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0ECAA1D99A; Thu, 2 Jul 2020 19:56:44 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id F0AE91D995 for ; Thu, 2 Jul 2020 19:56:41 +0200 (CEST) IronPort-SDR: cgjoZmD7WLFcwyK/w0G3zZGsIoXo/VqOx6jIjfEHifWyAQ6TI//jduSV2oeIgFBfSJ+MBptAGy Ow2ZBf2C6qkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9670"; a="127065361" X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="127065361" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 10:56:40 -0700 IronPort-SDR: rXA5sbkS2RE4TOp7U1a0hj+qmFwr+weWV1XxWytS3+tQdda6FU4gMsek/IZw+oADdIRkn3qxqL QMu9bkxKYsqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,305,1589266800"; d="scan'208";a="278194544" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 02 Jul 2020 10:56:40 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jul 2020 10:56:39 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.57) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jul 2020 10:56:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X6pS/pZFHW4dvgUnyui+NdR6RpbdXkN9x5D7C7i0UduntdhHViAsYgkKtUZ0K0GpTeWh6wrgPILNnBjXLcJm62oAPdiMVsLgHnQWsdLZcppWXTUAT/q++GLvO0niEB5ldPgBkrFTDVCWl3mbn5vUpYW1bmmHpwG1ntvI6kepM8M7LBz9etSBdKYOo5JET45Ruw7nfXbwmPfkFXDNsPHL2hEV4OKLw0VkeRBfm16i47wGtvkFJ5OLHvNHBcZHuT5cRoMSgRofn3rorER+oM1IzIwR/9n8r7XekBg4KEp6KLlPb/qJfkUM+xxfTwlkWGWk6dSNHfmMFeT8W37vcBF7Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIk05IbX/aEk30N2bF2wZhmlqsjr1QdvpERIp95ezIg=; b=Gq/T4mybxS+NefGpeJFyt5Be4F85r/yPbVQm1j3xULhJW2yp9gWLJGHTuUeeTYRDJnZLfrRLhuUmc7v62E68NQIRtZ78TqrjMCmMZS9PkS+gGRu+WpN9ohJsQRtGyp7W8kFuOMb09KqO5K4j4E9Q775jQYld2VPKA4bGPQ+sDeRKrM72v1eIMPUrQ9Z2xQ1tY6KhCpaAbC+bltfsXyU0HkBi8Jfy1Wxg4k+RgU2///rX9jpSdUUu38GxURfaETt69wcRfH5OjMr6znUyNYcEDBVurN5aj19aBdyNn5nziFUBsIeZ1grBjttb/GSrlcssxyHKP1rdH5AiLb/adyCZhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIk05IbX/aEk30N2bF2wZhmlqsjr1QdvpERIp95ezIg=; b=JQGqMR7wSBaIoAyI/btbq51nIuxSVSPlsprvgWUUKG3S4WgGIbxf588Yak8J/HARoLfQM+8/XdkQfbX4XHS2yRD7aKOuf7/DjtOAL86QtuFJopRAX4s4mnMztk0hKHmsXxvwHhshrU8/KvoTz+eMw3e+UJQckisRDxeuwMmXo/s= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BY5PR11MB4465.namprd11.prod.outlook.com (2603:10b6:a03:1c0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.27; Thu, 2 Jul 2020 17:56:36 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::9c6b:5ce:b551:8678]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::9c6b:5ce:b551:8678%4]) with mapi id 15.20.3153.020; Thu, 2 Jul 2020 17:56:36 +0000 From: "Van Haaren, Harry" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "thomas@monjalon.net" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v2] build: check functionality rather than binutils version Thread-Index: AdZQmh5ikh63WMkkQNS02Abyj5Zh/A== Date: Thu, 2 Jul 2020 17:56:36 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.164] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28355372-2370-44b0-dccd-08d81eb143db x-ms-traffictypediagnostic: BY5PR11MB4465: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0452022BE1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LcAj8gKZbBgeZvkiCza1X12QUb78fyMilV0xd5fGRt/1ofo3ja9DlPSLDZG6SFvaYZRL/g8/vtlW7mf7FQx8VMmwQomvf9xE5hW4Tln1IRmW9wTdAIiUvvCkqfoYo02PQ9KKsC7BKi3y2xpI3rPzsUBquz7SZxP+mlBbMPsk2mTV3abvmNiKDGwHy7Rv3+tRfhiEDzA3Yf/IQpGmPN3ww4Fea+OZ6S8IBPyF/wG2SjBTRZEGZS2LfHMZgKKLo0aOg1Mc8uZg/39dX/V1R0bGrmFCHfEN0+F9G7VTve0n7GnuzBa7FtB7D0pTmwWkT1CHuNOVpR1X7ndlmAI1xX8oTgn9arOheT3V8Pwv6QM4kFkmdyfMk5U/+QNIhKc9r4Qa5B8GECzkdnY6xtMYqSSgCw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(966005)(52536014)(86362001)(8676002)(76116006)(33656002)(107886003)(478600001)(66946007)(66476007)(66556008)(64756008)(66446008)(6506007)(53546011)(55016002)(5660300002)(9686003)(71200400001)(4326008)(186003)(26005)(83380400001)(316002)(54906003)(8936002)(7696005)(2906002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: DeqImo7GaT2goSDKmkcaR89aHr4VSVvD3xRE237FOJEUY+V7xua/Jv7B8PhuY2v61z7PNmOGl4lGtyR+vKHK2C2Iiu4Uw9RZIvo4UgN1Aor7cZ4XPR4Huqe5VOFkn923nESmdML8V3wNBMP2zR6aI+OcIejdQY/C0akW1BChgMosqRSJeKHVF8O3GFzFkGgpv7FUYNVLposXtP61jXdMoCeqx5l8FEY3kJ5+47M/SukluXztFbHbBYROz/gS/6zAdhAuPZhl+GKTVo9Hgcd2xZy2uVGe/ZtSux8xnA2mYKY6rR7/DtW/c7NODu/KKM4aCuRoI8vmyycci64eiQp+pgvp2RsS1Wy66pnMkYunk6ZDyslf9g8aJTA5BUZM+Rl25oqFXwmXvLk11bu9AGQoQ1bfjdUv0jC4lMloFUj8gTHKRZZLiiydnax5VBfngZuyH5obyAboQ7pCLtLxuGmZG+n9JsvWre+fs5opgupOBY90hVore2qwR3a8xPiRS+au Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28355372-2370-44b0-dccd-08d81eb143db X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2020 17:56:36.7805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZGLWgGZhV3FXufZEaJxADDTyzSXZdo5BGSk4nbbyAH9iYRxIB7MMikzsR9s6a+He3NuqSBHrJ1ZOF+BEs6tqs626W+0pcHFqyTI3tadryao= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4465 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] build: check functionality rather than binutils version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Van Haaren, Harry > Sent: Thursday, June 18, 2020 1:05 PM > To: 'Bruce Richardson' ; dev@dpdk.org > Cc: Yigit, Ferruh ; thomas@monjalon.net; Richards= on, > Bruce > Subject: RE: [dpdk-dev] [PATCH v2] build: check functionality rather than= binutils > version >=20 > > -----Original Message----- > > From: dev On Behalf Of Bruce Richardson > > Sent: Thursday, June 18, 2020 12:57 PM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; thomas@monjalon.net; Richar= dson, > > Bruce > > Subject: [dpdk-dev] [PATCH v2] build: check functionality rather than b= inutils > > version > > > > Rather than checking the binutils version number, which can lead to > > unnecessary disabling of AVX512 if fixes have been backported to distro > > versions, we can instead check the output of "as" from binutils to see = if > > it is correct. > > > > The check in the script uses the minimal assembly reproduction code pos= ted > > to the public bug tracker for gcc/binutils for those issues [1]. If the > > binutils bug is present, the instruction parameters - specifically the > > displacement parameter - will be different in the disassembled output > > compared to the input. Therefore the check involves assembling a single > > instruction and disassembling it again, checking that the two match. > > > > [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D90028 > > > > Signed-off-by: Bruce Richardson >=20 > Tested on binutils 2.30 without backported fixes, can confirm that __AVX5= 12F__ > define is > not present at meson configure time. Re-tested with Ubuntu LTS version 18.04 with the proposed binutils backport= fix: https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1883880 With this fix, AVX512 gets enabled as it should after running the check: Fetching value of define "__AVX512F__": 1 As before, still, and now even more so: Tested-by: Harry van Haaren