From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BBD2A00BE; Tue, 7 Jul 2020 15:15:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B76951DDA5; Tue, 7 Jul 2020 15:14:58 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C0FE11DC89; Tue, 7 Jul 2020 15:14:56 +0200 (CEST) IronPort-SDR: zf6eENlYEMn542c50kb9OXnvwWXv16WAyN7ItSr4L0njphbPA15BJtYfIDyAv1cYkvew3aFY/i vlV+oZgwRirQ== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="146663138" X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="146663138" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 06:14:55 -0700 IronPort-SDR: W5u+5fECoBdo9bZ8zp0zuc3usuNCs9ZJU4Ev+gmy/mK3VkpmlK302l/wBg7DauRYzuOtAcNtoG DvotQ1fNjhsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="283441999" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 07 Jul 2020 06:14:55 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 7 Jul 2020 06:14:55 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 7 Jul 2020 06:14:55 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jul 2020 06:14:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejeTLXjUntG/mBwjWDpxqGrDs8FnEA/EqzDO0ykKtyjsVsZmBZxg5/1H5d9+Nefty3U5sI9TaTtr/xqnIrn8wdWhmnsV8vbSOhMfG40G9wqF5WTWQU69xjoKew9BqmQq07blLbMiDaAr6Zu3Ik4113CHcxvgnvcH/+8AYd2jYZTZ9SXu9t9ktuqwPwOl3RiJze5h1GdpzS/rLM873crXembIPgkaxEPS3p8EDDXHW+XA9acewcZ+q0NPUOucebtNxe1nmMJSzCpPyIFQhaF8oJSY3ptwqfNdkD09vVhsJZwNURqMf51gb/405lRHJu1tyhxY8bVtQwBdmKeshkdbyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEaaD+lici30/tYFoKZDctJfTKmScgykfj0QkXlCwA4=; b=V7+5UgaxH4/Ednn+Zi6t40H7NVEhtcIJzM1nz5RVIktOJQXXvhQGKPNvT7Es6ChAUBiX1IvBDkiu6rkeuoooBTBA1lGPdjnC608aMEkJWASVD2k5+jMPsqzwu1i6fjSQRQiVG/cR5flbXUEGrJ6E2PjeZw5DgT3awzpDS7FHP19PxhmLjS8+i5ueaYiswGhrHyKW2QIupi1MpxCqXlXLivt+nt4JLo1mxl9Pe0w3PCeVOP3kQpsJmnzX7JgUg7J5zOv2MqQxst1qcRwTapBhZai5AQiuHc3oNjJTUYpUQCvbz1XwCYeN75cWYLtDsE820v52d/mAoiYhov4ckUcT5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEaaD+lici30/tYFoKZDctJfTKmScgykfj0QkXlCwA4=; b=RwDJyNc/MRKvUs+EOf/trZBY33UeIjJdYajsXxzE8EH5H8T1vaasYJISFWnLbpgQpJB1Xt9PFbUc8tokGQlISbHIJRCZgB7YmnMi6qu1ZrQrAPJZyWsgrwvLu9cT+46GT7l/7xtemiqnh7ro5ym1X6cTtALlXy0JJnXCuE/d0yM= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3144.namprd11.prod.outlook.com (2603:10b6:a03:8f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Tue, 7 Jul 2020 13:14:46 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::9c6b:5ce:b551:8678]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::9c6b:5ce:b551:8678%4]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 13:14:46 +0000 From: "Van Haaren, Harry" To: Andrew Rybchenko , "dev@dpdk.org" CC: Igor Romanov , "stable@dpdk.org" Thread-Topic: [PATCH v3 1/2] service: fix wrong lcore indices Thread-Index: AQHWVEvRWwnnNFSPKUK17f3xst6Blaj8Ffag Date: Tue, 7 Jul 2020 13:14:46 +0000 Message-ID: References: <1593873347-13686-1-git-send-email-arybchenko@solarflare.com> <1594118726-8421-1-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1594118726-8421-1-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: solarflare.com; dkim=none (message not signed) header.d=none;solarflare.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6c14e1e8-1a53-444d-c769-08d82277b874 x-ms-traffictypediagnostic: BYAPR11MB3144: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hfdcUi0VTJe6gHyRupEI3/OzetPkMUZSFi6ozGNvGCEoPCKmZlYZt7lviwdkvJSrcRLRnjARdzVHIpy1/iAIz5MY5d6zPZO/2TzOvspw/kTRwFNAvlbs2sWRTarRbQK1arbcxlXitmsz3hHNGKZKf+d9G2uB1Rww9YhU47zj5PQa8Ae6dSmefQDCb5M8N1GWx8MqidhfUoBBbnYsMw1pt5AfRboOqsQU5bszvVZXnFPZ9LTlLH0JYHkhRQ/qMnPUPc4YfkKgx6xRiSpeVZR8WmLxosgv1291rEe8pZa+FQl5IlToQtYak+6ihJsjnv8j x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(186003)(66556008)(66476007)(52536014)(66446008)(64756008)(26005)(66946007)(8676002)(8936002)(76116006)(4326008)(6506007)(53546011)(4744005)(86362001)(71200400001)(54906003)(83380400001)(316002)(9686003)(33656002)(478600001)(5660300002)(110136005)(7696005)(55016002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Hc9gkdlHIIvSkT7NiiVfNY5dJbPAETyJ+o8br+upeFi6Ch+f62Goo3sPTaI5KA8BMLqrjSgZ7zbEvWgv/urQDNrlrLHGLXveosIQ3jL1S90hi1uV1armkBsu5k+94aduVK6Dmq4d9BPIUms403E9pZokoX01V2anLZHdaR4c6uXcQWYaqG4uj/lWqmJmAekYE7t7z5jEjF843i4jHeBrZqGpk+PXOR7HnDjjjzuVpGljL2ZSasDSa7HqBxmmTlfG7zLkXUip4IQUl6Zw+jI8oHyo4hE5BnWxoxdamGBhO3nPhtLo4LPgdYJqeKDgfa4OuVC1twCOrfPnA2LoSwHJy+A78JfbimSt8w97WGrF17YntGEOe6oAEqk6KHPP89Tu6ukeuTlbuRoe5N03UyeTi/Jps04Z+aVsj9Pxp1zsJSd7iHlgWuoB2sBZQRxjatDps8gno3lyZKkWUAE28DISGgksbGl3IeMVPGWJTa1v/rACFF39GqwUccrTOcU11Jd3 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c14e1e8-1a53-444d-c769-08d82277b874 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 13:14:46.2102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L184gPD7lwZzzdllNOQBsZq3ioOYLa8eYOxXPN07HQ/H+KQ5ustORvMKAf6EDTc9h9NfI//e4PQeJRnRrC1l0CXPqfoPcvLwX1uTnlrW/KM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3144 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/2] service: fix wrong lcore indices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko > Sent: Tuesday, July 7, 2020 11:45 AM > To: dev@dpdk.org > Cc: Igor Romanov ; stable@dpdk.org; Van Haaren= , > Harry > Subject: [PATCH v3 1/2] service: fix wrong lcore indices >=20 > From: Igor Romanov >=20 > The service core list is populated, but not used. Incorrect > lcore states are examined for a service. >=20 > Use the populated list to iterate over service cores. >=20 > Fixes: e30d d318 47d2 ("service: add mechanism for quiescing") > Cc: stable@dpdk.org I believe the original adding of quiescing did not have this exact bug (ids= [] was used)? It seems to have been introduced when reworking to avoid false sharing, so = fixes is: Fixes: e484ccddbe1b ("services: avoid false sharing on core state") > Signed-off-by: Igor Romanov > Signed-off-by: Andrew Rybchenko Code change itself:=20 Acked-by: Harry van Haaren