From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D19941D34; Wed, 22 Feb 2023 02:54:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC40C40697; Wed, 22 Feb 2023 02:54:30 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 5CB2E40693 for ; Wed, 22 Feb 2023 02:54:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677030869; x=1708566869; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ENxqw3gYzGwb/Nosg4o1uz2KE6n0j+ohzLGVYQ0+y1c=; b=MhBY4DA0E780K/moi8cxTuIrYKQNXb3efZR3o7l/xWi0np8QKauLLXW5 RXXgzbny2yLyioBC5Uzwl4uNfRtcZEl6RjhvnqWd5FO2mAN7VDUP/pmnB yV45F+2znOWnOz4HV+9RHqsNiOVtsCWYfXA2zQDkwGt642+V2soScjbQD +f+J1uynFWT+etSE/bNnJ3qTO8aXqjzBBqT8vxANzt347DPucI1krNdlJ /zv3yjI6JG/bfSh8vT6TMH2UlBmpsmu5kbqjbUqZI+l0AqXiPbGPJQB/Q wnRWHxIRTTT33rg2g/A1TFPb7TDKTmibQ4eS6uoZy2vGmce8RoAqguMtN g==; X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="397497851" X-IronPort-AV: E=Sophos;i="5.97,317,1669104000"; d="scan'208";a="397497851" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 17:54:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="795722390" X-IronPort-AV: E=Sophos;i="5.97,317,1669104000"; d="scan'208";a="795722390" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 21 Feb 2023 17:54:27 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 21 Feb 2023 17:54:27 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 21 Feb 2023 17:54:27 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 21 Feb 2023 17:54:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=goxcURsFJnadqXbn5ua3aUXlh6x6cvZzt3vkMFHr7/8UhThxesNDrslWHLavKkL45PJMkvyMR3uLkWHDCQp3Zz0IHt1NTx/g7rW1Qc+20c72SYz8pzexZT6aX2wLZCIQrHOdYJcWbOOkjOxcqgHJj1KafbPsUW42JbgJrMCQkKDIR6uD7b/qPwS2jMcUL6G2UV1p8AHwAcsLOsAkeatzb+rLBghWbKxJbqRZNgBSyXtqXEVt0YpImu0MTEx6yHE7GFMgC/Z7O8qIZTI/FcDlNaReRSVOX/lf7e5MOp3PbWPRSiNVBwnUSMHhNnL8tDoXr8U6cdjngnhIxeDchZFkGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ENxqw3gYzGwb/Nosg4o1uz2KE6n0j+ohzLGVYQ0+y1c=; b=jQa9tPm/MOQHvLAozqyZwNvexTDb/lUz+luf0mtXKbPGcDc7JhTc+y5e17gpnXU0Ft3pxLz1hK8CijnvT4w9rBcoxcpUYRVvg1KPKEyuKXzhf70EgpcXH9DEBWkrCYijH3XZaBZIKuOMs7AEb3Eo121/NDqAR6hzffesCJDvBo1WuAg+T+iH8MyptL/NjinT1Ntpvcvs4ofrmMi0TsoQUSOzJbkRcwMasHeFeHJ8gZcki3xV/908ZKJgvnsNtSUQ12J1Knp1JX/S3Qu0KI3HyO/5BoxRYnH0ObqXUYahfFRtPSO8X8jNugy08rcSm1hWY3y9RNxG+OwJT2jgYS4nrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3158.namprd11.prod.outlook.com (2603:10b6:a03:1c::29) by BL1PR11MB5528.namprd11.prod.outlook.com (2603:10b6:208:314::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Wed, 22 Feb 2023 01:54:24 +0000 Received: from BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::83a5:d291:ab75:23fc]) by BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::83a5:d291:ab75:23fc%5]) with mapi id 15.20.6111.021; Wed, 22 Feb 2023 01:54:24 +0000 From: "Sevincer, Abdullah" To: Stephen Hemminger CC: "dev@dpdk.org" , "jerinj@marvell.com" Subject: RE: [PATCH v3] app/procinfo: display eventdev xstats for PMD data Thread-Topic: [PATCH v3] app/procinfo: display eventdev xstats for PMD data Thread-Index: AQHZOn+AbSZEmyGHgk+iQG5PBgS0gq7Cn4SAgAkeQ7CAB54FkIAACk+AgAbld8A= Date: Wed, 22 Feb 2023 01:54:23 +0000 Message-ID: References: <20220409153056.1010236-1-timothy.mcdaniel@intel.com> <20230206230505.3029148-1-abdullah.sevincer@intel.com> <20230206162227.2a8234c3@hermes.local> <20230217083323.45074019@hermes.local> In-Reply-To: <20230217083323.45074019@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3158:EE_|BL1PR11MB5528:EE_ x-ms-office365-filtering-correlation-id: 0692b366-bb6f-430f-6e66-08db1477b8e8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CWPjYljuITJKC0ETYYy5C/YE11X8fY/xI7STxSlpB5nW0BCo5/ThY4y4yYhe+KmEhQk2d+SDIsQhFj0Tdk1aHpD1sR5/pBAc0CE+PgFlbw5WxxFscTnmDtpxYHHDmr3s+I/HyHysFX3K5XvkTp+mphFGjhWXtyw3kYIUJqzQQFToPYv1zMVfLC3J33LGjsU4ik8uo2ZbfEdxY/RHkoBE5jAj5EXTAv/e8kLIDUZkDkSsjKfffulgwvRkTz0FN3lUbSvFI7Zbol1QQv8oAoEZNPEBWDTBMy5ZU249o8/w2XW0YZSQuKWj2jdbwqC5wF3ZTucVCFTokkqlfnVXDK4Gs08exE7X4E5kKXQiaNMeXlSA4GuDH/62hnTD2LF3P6FMJNQAs+tNP5E6y0xkTcjruxesoNBbjPhSF0OMHEB8ogLO8xpPkaRr434/L4hU1xLSEVWi8k35MXu5L0BtV+wvwPv3agrt8IJse9goy4+IJnqSLv4qp393VYOznr07GAbflag7SnM6SZngorNuCVYl7QGO2jVdHprnsD9u1cDl6W7wdSeyRJdvOnaMos15RUziv9uAPAWB5cObqj+5+oghMtHWSw/ZgBakGoJA4jxV7drLUstYaga2hKvRmUTBSthdhls1KTSrKXBu2O7+15vS3/XPny6SeFVj5KgGpfgx3epwFQB9jY3s/qoMnjs/D7aMf2ZhV3xv8zyEpiatNDZqsn16x4+xuMNeMcnjYw4qnL4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3158.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(346002)(396003)(39860400002)(376002)(366004)(451199018)(478600001)(71200400001)(7696005)(82960400001)(122000001)(86362001)(38100700002)(33656002)(2906002)(38070700005)(316002)(54906003)(41300700001)(5660300002)(9686003)(8936002)(52536014)(66476007)(64756008)(4326008)(76116006)(55016003)(66946007)(66446008)(6916009)(66556008)(8676002)(26005)(186003)(6506007)(53546011)(83380400001)(181643002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FTtLol1tLZdGUaVko9XJ2hDHO0cpJyqhX0heSuZguNWRxrNfcNR41DutMYxb?= =?us-ascii?Q?9BjtU5UzR8aMHkpWS1PuihJa/0R0QNViyQ20DdFVWCWy1S6+jPUrvuAt9Lr1?= =?us-ascii?Q?uf3W6FtInSfJLEO/RcNjwjBYXcFG8LjloZYA5RzKdM5GdRlpujpMgdtJ2n6j?= =?us-ascii?Q?xoZaQl7DUWQIrKLAS98H36gx5cUZjbShY/GSKt79nKycE3G0VGIJyqOlupoc?= =?us-ascii?Q?5W3F8SfVp/9dGObM4WJL5+ghgknFB+H9wGa/lb8/AK+YkCk9mYJ8IfuGH5Yn?= =?us-ascii?Q?Vf+rVEk6FJoRxcuAX1qjdLwAZCR3bA+ZHFLvToL8mWLUAccw+jc/5X6sTYY3?= =?us-ascii?Q?wz9oiSrZBChIB5uCGhcwO4ZIsj9NMUCH2CuW16BXxEcqO9DXJX2s49xD8eqO?= =?us-ascii?Q?NB7Mjey9ZESYhqNBLmIOwPEUFlrL/49Z2uoXs585WWUxNzEdmmKXsEdjzvMh?= =?us-ascii?Q?Wi5SwbYhCodm7t7Vikh/61NZTCYNJ2UfXJtd3lqRl889PQe45x9KZegYuSE7?= =?us-ascii?Q?i6tKBySAq+pUcZgSntVewjEQv18r8mIbYOZ2D4IHAjML8zPxJEtNIDGP2rSg?= =?us-ascii?Q?lsSW06FUzrIPN+6Qbu1/E6COlSqxmBSssQouXMnvCcOVOLVlTc9XlYgIEAAI?= =?us-ascii?Q?KBIxK/rU7lfYbzeYufxweAYmx2mQG/s9FB5DMApULiNZr/F1LUD5YY4H0BhH?= =?us-ascii?Q?Nnrgk2nsBJ3l4cy8mhe0PD8slToQeP/St4wnMu2J3OCfSBj0Aag9u85W3nKi?= =?us-ascii?Q?/QuJDw8GveKP38rZopbSp1wO91pgTI1g7s1xCot9/ulBD7LnN9CS3/cva1Jo?= =?us-ascii?Q?/PNnZAn8vqZqnDe43cr0oZrbdA7Jm6KmY5jGQR3h286OKNtDh0gvMVTbQlTL?= =?us-ascii?Q?XVzqzyCMU+bvXuGCrGMIVdsuUPwcv6NgGvxMTlTqvBzYBUizsntKXJSudB5r?= =?us-ascii?Q?NJekwoUPvHoUYH8K54SjFMV+P1Gj68nQhQCf+a1Lyghk3eB4ZZjCUXXyFQNQ?= =?us-ascii?Q?AB3ok+uSlWN2oLW/DVGw0yuBDzu4H8PRCdbKAmkrkstVnLhREZ4KoDXfxms8?= =?us-ascii?Q?EDhNIa1MycvAM305us22mCjqPB+zg9KSqA3esGottLVwb7fFnF344XxLTE72?= =?us-ascii?Q?tjZ1IF3Kl/QWT3kihJ0IVKN6peNNvJZY7P1C9i5yMFr9zSirdOxXM+//k7a3?= =?us-ascii?Q?+dP14Fn8wvLAlA+26rwTmkQOaNFhoLc4iSJOiKduuNrtIqLcjrrsCxQPZhq3?= =?us-ascii?Q?Atw/szf2Q7BIGvi/ZE7ncwqG2XwvqS0mnxvwZ9YlZNv/sAznNRO0kYRyWl+9?= =?us-ascii?Q?bDAAhdrAhbHhVvPdU5HzHB2j06mF24aDcK7OoE+Fe90uYw3xJGASwM++gr0E?= =?us-ascii?Q?noPz9yGIeHHgFEFSNAs1k+VrA9i2wWNL/oPj7/MvwoxzgFguFy7o1aWoRc+W?= =?us-ascii?Q?445ndcLX3eNvvCh9ufOFS0AtZMUQdn5dYhe1awxulX/tcwf4rZguAepEQMOD?= =?us-ascii?Q?w6CwuQiWhwwKOZcTgSGQr59GMoLhNNmTdI3xhI2R4J6vEzFtYGwEApZU9t/M?= =?us-ascii?Q?rwyF9eMhDoaMl7z3r63i1ouCn8XXp3FpWcw5xf2ulvmFPa4Cvuizyw3X/78W?= =?us-ascii?Q?BQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0692b366-bb6f-430f-6e66-08db1477b8e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2023 01:54:23.8492 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0GoehPElyM9oIr8uBmv6K/Ms6dU79Q54tOW19eCMnvUBch078qQzsrddeGp03vd7Yl1UQ7oFbXHsgyRhvRcmEeOuP0f55A5udZCEgzRF1bM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5528 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Got it. Looking at forums and made some reading, like you said it does not = matter much. I will keep consistency with other call methods so keep malloc. I will push another patch removing extra line. Thanks. -----Original Message----- From: Stephen Hemminger =20 Sent: Friday, February 17, 2023 8:33 AM To: Sevincer, Abdullah Cc: dev@dpdk.org; jerinj@marvell.com Subject: Re: [PATCH v3] app/procinfo: display eventdev xstats for PMD data On Fri, 17 Feb 2023 15:58:52 +0000 "Sevincer, Abdullah" wrote: > From: Sevincer, Abdullah > Sent: Sunday, February 12, 2023 11:44 AM > To: Stephen Hemminger > Cc: dev@dpdk.org; jerinj@marvell.com > Subject: RE: [PATCH v3] app/procinfo: display eventdev xstats for PMD=20 > data >=20 > Thanks Stephen, > I will remove extra line there. >=20 > Instead malloc using of calloc is required or just suggestion?=20 > I can see allocation is done in same way with malloc in lib\eventdev\rte_= eventdev.c (reference to eventdev_build_telemetry_data function). > I will keep malloc as it is if there is no opposition. It doesn't matter much if you use malloc vs calloc. But there are some static analysis tools that might look at calloc as way t= o determine number of elememts for later array checks. Also, the kernel checkpatch warns when kmalloc is used but kcalloc or kmall= oc_array could be used instead. That is Linux kernel specific but same idea= applies.