From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19F93A04F3; Fri, 3 Jan 2020 11:49:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F39851C43B; Fri, 3 Jan 2020 11:49:10 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 867A31BF85 for ; Thu, 2 Jan 2020 10:58:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 01:58:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,386,1571727600"; d="scan'208";a="419691463" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 02 Jan 2020 01:58:18 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 01:58:18 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 01:58:18 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 2 Jan 2020 01:58:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JJkA9CSBMgrZvNfYttf+WpXu38O/J9cePGfwIZIwT5A1/RnqnJN8TesNOXw/BcBzogkqwck0a77iKbVEFAJQwCZRQQqO3/iL0cdanWAZFvfgRMxqpEiep7UrnsvnW7oXJCcgbIxXJKm7/KJPuUacNlH6co4P9JHmP77LYd/eYOC6C7K05w5VgIjn0BzQIojGLvb2+YX/zVABPrf8DJSae2IX907bFpZFg5RQCjXEOsKAgah63j90kQcvPvjFrmAbv3JdYOaAoTKTA93thu/+WtWyvij8MOydm8YODIlcmaGfmPaW6ho4nMMh+sv6iL0i5mAC4I56Z4gh9UbqhDdwXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ot3vd9qt7cO+0XK4BDGCLa8mnnP0GTcNP6zqXhbyjFs=; b=H1/JOMkUuCS/QgPvjmhJYXaOr7lJ/R8A0KN33mejHOPVktBq9j0aCNxKLpRac+DffwPwlzCjl5lg5OjaOYgkTfdQbYgpUoD87/H2bZ1XOhq67gOBjd+KNq8Ne+V5utxY004XuID3rEwQRToSaLhSsn9BFzeXKabhxnfQmB2KaV9hTk3m7J5YjNUWRYAJf1UhyvXpmPXZtbk+fJe+IVEpsFGg8gJ8vXoNP6RUKloW/ml/SXviZVIWGjBMojc3UfW3WTBfe+LZsS8cSDcXxwjGBw8qc1Hp/ote2nBRViIASEKq0Jz/mZ4kYs/7jY5cXT1gEiEYrkCCW7Ob4sklfhWRoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ot3vd9qt7cO+0XK4BDGCLa8mnnP0GTcNP6zqXhbyjFs=; b=gwIyfjQOFCpSBElEwCPsPXEssGye8ct08aQH6oop36or7KpcseqdTLIRsaP0kpozUao0lHWC1ytVefsmketj9IiDFGlRY+Mn194ysngQkhKhM1XhEGz6eT+Z7p/R8L4R9SYPy4YfyeSlcKfbOiSsO2AlksGBH37G8e8Kpp+X+aI= Received: from BYAPR11MB3286.namprd11.prod.outlook.com (20.177.127.218) by BYAPR11MB3318.namprd11.prod.outlook.com (20.177.184.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.12; Thu, 2 Jan 2020 09:58:15 +0000 Received: from BYAPR11MB3286.namprd11.prod.outlook.com ([fe80::1af:4c99:d83e:331a]) by BYAPR11MB3286.namprd11.prod.outlook.com ([fe80::1af:4c99:d83e:331a%7]) with mapi id 15.20.2581.007; Thu, 2 Jan 2020 09:58:15 +0000 From: "Loktionov, Aleksandr" To: "Xing, Beilei" , "Ye, Xiaolong" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH v3 36/36] net/i40e/base: add new link speed constants Thread-Index: AQHVs7uUxTNilCLqUEWox1Xtq1FTuqfNiAuAgAm2S2A= Date: Thu, 2 Jan 2020 09:58:15 +0000 Message-ID: References: <20191202074935.97629-1-xiaolong.ye@intel.com> <20191216024336.174318-1-xiaolong.ye@intel.com> <20191216024336.174318-37-xiaolong.ye@intel.com> <94479800C636CB44BD422CB454846E013CEB3654@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CEB3654@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action authentication-results: spf=none (sender IP is ) smtp.mailfrom=aleksandr.loktionov@intel.com; x-originating-ip: [134.191.221.123] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f6b4e3a-78d9-445c-33b7-08d78f6a4970 x-ms-traffictypediagnostic: BYAPR11MB3318: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-forefront-prvs: 0270ED2845 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(366004)(396003)(376002)(346002)(136003)(199004)(189003)(13464003)(9686003)(5660300002)(8676002)(64756008)(71200400001)(53546011)(7696005)(478600001)(52536014)(6636002)(8936002)(26005)(81166006)(55016002)(81156014)(110136005)(316002)(33656002)(54906003)(66476007)(76116006)(186003)(6506007)(66556008)(4326008)(2906002)(66946007)(66446008)(86362001)(107886003); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR11MB3318; H:BYAPR11MB3286.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XETBrxr+5iAenK9ncdvyC+lVc0gXUAQr0V6hpyDwi1vmal/q8Tj9t7MUAXmQJI3N7XUg6fnDjbAJg2HupRh3ffqEC9ttu0C2w4/cNTOihq8Y1EqZnNKj6aAewQ/hyDOt2BDEuHUAs2mxvuUtQz23uAtF9qeQlSsiZSSwQMlC5UZuNZyDs9fF2S5x8l5rohfgDemyzDkVX5gGjyXP+HqE++Tn9KEnySvYNVbwm1Rz+1OUB5W4nOc2rIttFspJ4V8SSeJpR18LnB5YXZOO2s2XxdlbqpCFyWQKvHj99WRPNwIQmuUg69K9wVJA/B25kbfQNU7NaxO9YbHQTNEuI4MFHDwfk/DZVv1tCbVBmimxn3nhJqu46HC3y3r5byieYTOJ/E6PkcVHBDD9GPtS8YCKaNWFrVjy6w7E6CI1OtYWtHYZqaurE7p0p6YLni5KxR1GNw/i3Vyzp/ZKsdiQVhZ/8eQgLInY5BytTX3loOLjwMuuRmV5cRqvNwfoHtaFiQGi Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2f6b4e3a-78d9-445c-33b7-08d78f6a4970 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2020 09:58:15.1753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8nlA4/LVCoOMGVNRKrZ5KwAvlaKFYdVinQn1MRWFyewk5OzWdug7j5A8KzPQpvaKq7rxlb13m9JVGx25JjJ7c2GZvH8+h/DbmnGGwIbkwHQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3318 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 03 Jan 2020 11:49:00 +0100 Subject: Re: [dpdk-dev] [PATCH v3 36/36] net/i40e/base: add new link speed constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Good day dear ALL It's a new feature /*new speed display*/ but from other point of view it's = a fix /*because it was found after new feature release*/ -----Original Message----- From: Xing, Beilei = Sent: Friday, December 27, 2019 6:38 AM To: Ye, Xiaolong ; Zhang, Qi Z Cc: dev@dpdk.org; Stillwell Jr, Paul M ; Lok= tionov, Aleksandr Subject: RE: [PATCH v3 36/36] net/i40e/base: add new link speed constants > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, December 16, 2019 10:44 AM > To: Xing, Beilei ; Zhang, Qi Z = > > Cc: dev@dpdk.org; Stillwell Jr, Paul M = > ; Ye, Xiaolong ; = > Loktionov, Aleksandr > Subject: [PATCH v3 36/36] net/i40e/base: add new link speed constants > = > This patch fixes 'NIC Link is Up, Unknown bps' message in dmesg for = > 2.5Gb/5Gb speeds. This problem is fixed by adding constants for = > VIRTCHNL_LINK_SPEED_2_5GB and VIRTCHNL_LINK_SPEED_5GB. > = It's a fix patch, fix line is needed? The same comment is also for patch 27= /36, 25/36, 21/36, 14/36. > Signed-off-by: Aleksandr Loktionov > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/base/i40e_prototype.h | 4 ++++ > drivers/net/i40e/base/virtchnl.h | 4 ++++ > 2 files changed, 8 insertions(+) > = > diff --git a/drivers/net/i40e/base/i40e_prototype.h > b/drivers/net/i40e/base/i40e_prototype.h > index 0f06e3262..d8ab3ea0a 100644 > --- a/drivers/net/i40e/base/i40e_prototype.h > +++ b/drivers/net/i40e/base/i40e_prototype.h > @@ -505,6 +505,10 @@ i40e_virtchnl_link_speed(enum i40e_aq_link_speed > link_speed) > return VIRTCHNL_LINK_SPEED_100MB; > case I40E_LINK_SPEED_1GB: > return VIRTCHNL_LINK_SPEED_1GB; > + case I40E_LINK_SPEED_2_5GB: > + return VIRTCHNL_LINK_SPEED_2_5GB; > + case I40E_LINK_SPEED_5GB: > + return VIRTCHNL_LINK_SPEED_5GB; > case I40E_LINK_SPEED_10GB: > return VIRTCHNL_LINK_SPEED_10GB; > case I40E_LINK_SPEED_40GB: > diff --git a/drivers/net/i40e/base/virtchnl.h = > b/drivers/net/i40e/base/virtchnl.h > index c613d4761..92515bf34 100644 > --- a/drivers/net/i40e/base/virtchnl.h > +++ b/drivers/net/i40e/base/virtchnl.h > @@ -53,12 +53,14 @@ enum virtchnl_status_code { #define = > VIRTCHNL_ERR_PARAM VIRTCHNL_STATUS_ERR_PARAM #define = > VIRTCHNL_STATUS_NOT_SUPPORTED VIRTCHNL_STATUS_ERR_NOT_SUPPORTED > = > +#define VIRTCHNL_LINK_SPEED_2_5GB_SHIFT 0x0 > #define VIRTCHNL_LINK_SPEED_100MB_SHIFT 0x1 > #define VIRTCHNL_LINK_SPEED_1000MB_SHIFT 0x2 > #define VIRTCHNL_LINK_SPEED_10GB_SHIFT 0x3 > #define VIRTCHNL_LINK_SPEED_40GB_SHIFT 0x4 > #define VIRTCHNL_LINK_SPEED_20GB_SHIFT 0x5 > #define VIRTCHNL_LINK_SPEED_25GB_SHIFT 0x6 > +#define VIRTCHNL_LINK_SPEED_5GB_SHIFT 0x7 > = > enum virtchnl_link_speed { > VIRTCHNL_LINK_SPEED_UNKNOWN =3D 0, > @@ -68,6 +70,8 @@ enum virtchnl_link_speed { > VIRTCHNL_LINK_SPEED_40GB =3D > BIT(VIRTCHNL_LINK_SPEED_40GB_SHIFT), > VIRTCHNL_LINK_SPEED_20GB =3D > BIT(VIRTCHNL_LINK_SPEED_20GB_SHIFT), > VIRTCHNL_LINK_SPEED_25GB =3D > BIT(VIRTCHNL_LINK_SPEED_25GB_SHIFT), > + VIRTCHNL_LINK_SPEED_2_5GB =3D > BIT(VIRTCHNL_LINK_SPEED_2_5GB_SHIFT), > + VIRTCHNL_LINK_SPEED_5GB =3D > BIT(VIRTCHNL_LINK_SPEED_5GB_SHIFT), > }; > = > /* for hsplit_0 field of Rx HMC context */ > -- > 2.17.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.