From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3227AA04B7; Wed, 16 Sep 2020 15:39:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D2A61C2A1; Wed, 16 Sep 2020 15:39:41 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DF8FD1C29F for ; Wed, 16 Sep 2020 15:39:38 +0200 (CEST) IronPort-SDR: NQ0wTMff9sMAH90jsMLfvAR8kMtVxwnWvdzZ9QCj9PQW2K3jCkRnwJRqWqwTIJHrvij9qY9GlP RNmA/DN8JxJA== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="147146805" X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="147146805" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 06:39:37 -0700 IronPort-SDR: sLvcZw8uYZ9Pn7Q5iHU3tnXZK+YWE7Ylz2r5mveVX7JKHqiERem6yCsRb6lN+6ptVIoI9cNGoW nDas4wbFFcoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="483316792" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga005.jf.intel.com with ESMTP; 16 Sep 2020 06:39:37 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 06:39:37 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Sep 2020 06:39:37 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Sep 2020 06:39:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kTDnq+rdqctHVbLvogfSZhJMQkNsS/E2oZehW6CEHsOJEv3in1LhJMXbNYfAyZVnIeCu8cb4r75V1SKQgKOy3h6rujeLStLr4DPSWTLan726qSvFZxj1bKQ4qcrZIZNOtKqlG85YZJVkAdVxZhf7+PNxwL4XOWMQr0hzSj8RqXTTu9XblkO4zzAZC4cIoLBx6RWAceGp5QJ87sgWNJtH0cQIF1G8D5kTKylKe2hMMTWfLseof4tfudJMm0KiZgkR+a15txEzldggpvJHMYkqA3omD+B8MJJdUIxjP8pxv9k0LJ4lVGoKmFDgKpOKmHneX4ggmuaF97IaCehnsSnSuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0q4worhEWgTp54jsNkNn8wQrIgjnmevXGfHLLhA+LE=; b=dSUMfIcuzDUKrnu2OFWgCiuUQRHKcwtr5UwmuneEx7SDoxSty2aSHfjkMpC8k73QBZM3R73KgwwqR0C8JBIEhkV+dAGeujo5NzFu6Zz1/oh3H9nQw0sOh+xGVdlbbwPCZWpC5EHDfl4Kf4Jqh+1FG7LptypCLq7dZhodOc4LyOXFL0yij6PDKPFonT9w85ocEid74/6o33C4a/tRS8IquAMC07wrgpvMlSEbvTo6EuppytuHKxWGehvJoIqncdO4Bn9hj6PhRNno2m+tlz52j1ZVtOH97gSNeyv4APrwjLxCuouWOw+cshEvBOizW4DMOSam3ASDX/yac+pWuq7GKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a0q4worhEWgTp54jsNkNn8wQrIgjnmevXGfHLLhA+LE=; b=ZJTh4qXWkFGf2qfA99IcmPUbQu3E8m192bX8aWt/BRdVb6BGLo0OaNogJBbTWSSAR2qTxblxRO5UqQTPo9CK30E2awX1I+snwimDZ23l9EpTksroq/YcmDSC4APpv71lJJc6k7h0/ReE/zdp4qRqk+/zS+GOG83LYMkPmzDdl3Q= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BY5PR11MB4152.namprd11.prod.outlook.com (2603:10b6:a03:191::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.18; Wed, 16 Sep 2020 13:39:32 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b%6]) with mapi id 15.20.3391.011; Wed, 16 Sep 2020 13:39:32 +0000 From: "Ananyev, Konstantin" To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: "Doherty, Declan" , "jerinj@marvell.com" , "akhil.goyal@nxp.com" , "Vangati, Narender" , "Gujjar, Abhinandan S" Thread-Topic: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions Thread-Index: AQHWhsTbY+pAzzKww0euN2orABmUValrRWzA Date: Wed, 16 Sep 2020 13:39:32 +0000 Message-ID: References: <1599549024-195051-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1599549024-195051-1-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa7dfa47-d363-4fed-a0ce-08d85a45f1b6 x-ms-traffictypediagnostic: BY5PR11MB4152: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bl88DmsgDQ8Hc1Rtbpu9qEagUi2emSxtxG1dPHj77q4iedOyQPmAS1mbeE/A3J2eO2PIoNtQMgdRadbxJvsmIoO77cOhQ3Ll9qyLgCFICWr3BX7zgKOyzS5q0XZL+Sem532g/0R7jlF/EAt1yefPxikOhhDR4bHCmAMrIjblE3C0Ng/L05JEcyHTQV5TZIvu0/xHFC19JZphS4e3FC2Kc9XtG/ZR510WybeDCgnKgZ24MjDx8r4xwBORQo2XKT8/vMK/mvM7V32AnZEc6O1wCsMWA2YLO2djMhyJt1f/x7Ikm4Od2fgRUxFBbYyt0PC6Aaap2Jkr1mfaVwIq8l4yUQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(39860400002)(136003)(346002)(376002)(478600001)(76116006)(107886003)(83380400001)(5660300002)(54906003)(6506007)(52536014)(55016002)(9686003)(110136005)(186003)(33656002)(86362001)(71200400001)(8936002)(30864003)(26005)(7696005)(8676002)(4326008)(66556008)(2906002)(64756008)(66446008)(66476007)(66946007)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 6I/JmPZHPyv7XMTNM979TPCp8UXJNQNv2mdS4a8YOGGMqoK2yE0/1Yuhow2K6HZ315Yc2Ln8bq1cKg6Cf0vV4w+E+C9eQYuGBJWpqSCw49dSE0R+BxXHrwuC4o5JIq4iBXcbyH0td7ayU0xqkt93blVPmjCxqI0hZ3IzG5HIWnjmAbkhNb80kaU/aUojVMaqsogopR1orCbABC8Q4kQBskpEowRTbb2m+bNtQHeH9Hpbo7tnWbPatneIibKS5ydM91Rxo5KvTwFS7xN6abpOuCtCbKnik++FXeVJg8Ks2I2ppQsVTVF9J1o6IKVs0gYNTxDRPG+SFbXzo4XzhdmSaiMTqN7DbWMM0PjheFFv8/I2hLnosLzdBFisYtVH5z7h37IVyNtA3ut7UWZA2nTJb4l+UO+v81NgoTRF4j0mRrthNbJPffbMItJpu+uCjKbRimFn4FVYCzY4M8KGfmZ/ztKeCIQhnTMxLXmE1vXFGGXzytcRThDY+Q4ht7wKwY1Y8wBwISt8+ASD01VBPUm1tatZy15wuptCXm9kVjOrPBJc4znq+RPxwEa19rSgsz00T7ltAiD5AHlV3DOBP6MW1QiF5lgSlmqMsFmp4mwsgADhjFfVQ4sxvrjjvzQ16iSbCBDePcZpRbCXKgzL9Jog0w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa7dfa47-d363-4fed-a0ce-08d85a45f1b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2020 13:39:32.5697 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KF5W4hx5p29/NqYTpQI8Qu/2pH9jmny2nfWtdHSAkMNWYjw/+JVJldPrTHeUUuruWbeWGdV1Tjlpte+ISxrwxG6xivAPvFLfAEWtfihFrno= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4152 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Guijjar, >=20 > In an eventdev world, multiple workers (with ordered queue) will be > working on IPsec ESP processing. The ESP header's sequence number is > unique and has to be sequentially incremented in an orderly manner. > This rises a need for incrementing sequence number in crypto stage > especially in event crypto adapter. By adding a user callback to > cryptodev at enqueue burst, the user callback will get executed > in the context of event crypto adapter. This helps the application > to increment the ESP sequence number atomically and orderly manner. >=20 > This patch adds APIs to add/remove callback functions. The callback > function will be called for each burst of crypto ops received on a > given crypto device queue pair. >=20 > v1->v2: > Moved callback related members to the end of cryptodev struct > Added support for RCU >=20 > Signed-off-by: Abhinandan Gujjar > --- > config/common_base | 1 + > lib/librte_cryptodev/Makefile | 2 +- > lib/librte_cryptodev/rte_cryptodev.c | 157 +++++++++++++++++++= ++++++ > lib/librte_cryptodev/rte_cryptodev.h | 154 +++++++++++++++++++= ++++- > lib/librte_cryptodev/rte_cryptodev_version.map | 6 + > 5 files changed, 318 insertions(+), 2 deletions(-) >=20 > diff --git a/config/common_base b/config/common_base > index fbf0ee7..f5ebde4 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -599,6 +599,7 @@ CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC=3Dy > # > CONFIG_RTE_LIBRTE_CRYPTODEV=3Dy > CONFIG_RTE_CRYPTO_MAX_DEVS=3D64 > +CONFIG_RTE_CRYPTODEV_CALLBACKS=3Dy >=20 > # > # Compile PMD for ARMv8 Crypto device > diff --git a/lib/librte_cryptodev/Makefile b/lib/librte_cryptodev/Makefil= e > index 73e77a2..514d552 100644 > --- a/lib/librte_cryptodev/Makefile > +++ b/lib/librte_cryptodev/Makefile > @@ -10,7 +10,7 @@ LIB =3D librte_cryptodev.a > CFLAGS +=3D -O3 > CFLAGS +=3D $(WERROR_FLAGS) > LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_ring -lrte_mbuf > -LDLIBS +=3D -lrte_kvargs > +LDLIBS +=3D -lrte_kvargs -lrte_rcu >=20 > # library source files > SRCS-y +=3D rte_cryptodev.c rte_cryptodev_pmd.c cryptodev_trace_points.c > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/= rte_cryptodev.c > index 1dd795b..2fb3e35 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include >=20 > #include "rte_crypto.h" > #include "rte_cryptodev.h" > @@ -499,6 +500,10 @@ struct rte_cryptodev_sym_session_pool_private_data { > return 0; > } >=20 > +#ifdef RTE_CRYPTODEV_CALLBACKS > +/* spinlock for crypto device enq callbacks */ > +static rte_spinlock_t rte_cryptodev_enq_cb_lock =3D RTE_SPINLOCK_INITIAL= IZER; > +#endif >=20 > const char * > rte_cryptodev_get_feature_name(uint64_t flag) > @@ -1449,6 +1454,158 @@ struct rte_cryptodev * > rte_spinlock_unlock(&rte_cryptodev_cb_lock); > } >=20 > +#ifdef RTE_CRYPTODEV_CALLBACKS > +int > +rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct rte_rcu_qsbr *qsbr) > +{ > + > + struct rte_cryptodev *dev; > + > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > + return -EINVAL; > + } > + > + dev =3D &rte_crypto_devices[dev_id]; > + dev->qsbr =3D qsbr; > + return 0; > +} So if I understand your patch correctly you propose a new working model for crypto-devs: 1. Control-plane has to allocate/setup rcu_qsbr and do rte_cryptodev_rcu_qs= br_add(). 2. Data-plane has somehow to obtain pointer to that rcu_qsbr and wrap crypt= odev_enqueue() with rcu_qsbr_quiescent() or rcu_qsbr_online()/rcu_qsbr_offline(). That seems quite a big change and I don't think it is acceptable for most u= sers. >From my perspective adding/installing call-backs to the dev has to be opaqu= e to the data-plane code. Also note that different callbacks can be installed by different entities (= libs) and might have no idea about each other.=20 That's why I thought it would be better to make all this RCU stuff internal= inside cryptodev: hide all this rcu_qsbr allocation/setup inside cryptodev init/queue set= up invoke rcu_qsbr_online()/rcu_qsbr_offline() inside cryptodev_enqueue(). > + > +struct rte_cryptodev_enq_callback * > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + rte_cryptodev_enq_cb_fn cb_fn, > + void *cb_arg) > +{ > + struct rte_cryptodev *dev; > + struct rte_cryptodev_enq_callback *cb, *tail; > + > + if (!cb_fn) > + return NULL; > + > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > + return NULL; > + } > + > + dev =3D &rte_crypto_devices[dev_id]; > + if (qp_id >=3D dev->data->nb_queue_pairs) { > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > + return NULL; > + } > + > + cb =3D rte_zmalloc(NULL, sizeof(*cb), 0); > + if (cb =3D=3D NULL) { > + CDEV_LOG_ERR("Failed to allocate memory for callback on " > + "dev=3D%d, queue_pair_id=3D%d", dev_id, qp_id); > + rte_errno =3D ENOMEM; > + return NULL; > + } > + > + cb->fn =3D cb_fn; > + cb->arg =3D cb_arg; > + > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > + if (dev->enq_cbs =3D=3D NULL) { > + dev->enq_cbs =3D rte_zmalloc(NULL, sizeof(cb) * > + dev->data->nb_queue_pairs, 0); > + if (dev->enq_cbs =3D=3D NULL) { > + CDEV_LOG_ERR("Failed to allocate memory for callbacks"); > + rte_errno =3D ENOMEM; > + rte_free(cb); > + return NULL; > + } > + } > + > + /* Add the callbacks in fifo order. */ > + tail =3D dev->enq_cbs[qp_id]; > + if (tail) { > + while (tail->next) > + tail =3D tail->next; > + tail->next =3D cb; > + } else > + dev->enq_cbs[qp_id] =3D cb; > + > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > + > + return cb; > +} > + > +int > +rte_cryptodev_remove_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + struct rte_cryptodev_enq_callback *cb) > +{ > + struct rte_cryptodev *dev; > + struct rte_cryptodev_enq_callback **prev_cb, *curr_cb; > + uint16_t qp; > + int free_mem; > + int ret; > + > + free_mem =3D 1; > + > + if (!cb) { > + CDEV_LOG_ERR("cb is NULL"); > + return -EINVAL; > + } > + > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > + return -EINVAL; > + } > + > + dev =3D &rte_crypto_devices[dev_id]; > + if (qp_id >=3D dev->data->nb_queue_pairs) { > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > + return -EINVAL; > + } > + > + if (!dev->qsbr) { > + CDEV_LOG_ERR("Rcu qsbr is NULL"); > + return -EINVAL; > + } > + > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > + if (dev->enq_cbs =3D=3D NULL) { > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > + return -EINVAL; > + } > + > + prev_cb =3D &dev->enq_cbs[qp_id]; > + for (; *prev_cb !=3D NULL; prev_cb =3D &curr_cb->next) { > + curr_cb =3D *prev_cb; > + if (curr_cb =3D=3D cb) { > + /* Remove the user cb from the callback list. */ > + *prev_cb =3D curr_cb->next; > + ret =3D 0; > + break; > + } > + } > + > + if (!ret) { > + /* Call sync with invalid thread id as this is part of > + * control plane API */ > + rte_rcu_qsbr_synchronize(dev->qsbr, > + RTE_QSBR_THRID_INVALID); > + rte_free(cb); > + } > + > + for (qp =3D 0; qp < dev->data->nb_queue_pairs; qp++) > + if (dev->enq_cbs[qp] !=3D NULL) { Some reference count (number of callbacks) seems like a better approach her= e. > + free_mem =3D 0; > + break; > + } > + > + if (free_mem) { > + rte_free(dev->enq_cbs); > + dev->enq_cbs =3D NULL; > + } > + > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > + > + return ret; > +} > +#endif >=20 > int > rte_cryptodev_sym_session_init(uint8_t dev_id, > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/= rte_cryptodev.h > index 7b3ebc2..2c7a47b 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -530,6 +530,32 @@ struct rte_cryptodev_qp_conf { > }; >=20 > /** > + * Function type used for pre processing crypto ops when enqueue burst i= s > + * called. > + * > + * The callback function is called on enqueue burst immediately > + * before the crypto ops are put onto the hardware queue for processing. > + * > + * @param dev_id The identifier of the device. > + * @param qp_id The index of the queue pair in which ops are > + * to be enqueued for processing. The value > + * must be in the range [0, nb_queue_pairs - 1] > + * previously supplied to > + * *rte_cryptodev_configure*. > + * @param ops The address of an array of *nb_ops* pointers > + * to *rte_crypto_op* structures which contain > + * the crypto operations to be processed. > + * @param nb_ops The number of operations to process. > + * @param user_param The arbitrary user parameter passed in by the > + * application when the callback was originally > + * registered. > + * @return The number of ops to be enqueued to the > + * crypto device. > + */ > +typedef uint16_t (*rte_cryptodev_enq_cb_fn)(uint16_t dev_id, uint16_t qp= _id, > + struct rte_crypto_op **ops, uint16_t nb_ops, void *user_param); > + > +/** > * Typedef for application callback function to be registered by applica= tion > * software for notification of device events > * > @@ -853,7 +879,6 @@ struct rte_cryptodev_config { > enum rte_cryptodev_event_type event, > rte_cryptodev_cb_fn cb_fn, void *cb_arg); >=20 > - > typedef uint16_t (*dequeue_pkt_burst_t)(void *qp, > struct rte_crypto_op **ops, uint16_t nb_ops); > /**< Dequeue processed packets from queue pair of a device. */ > @@ -870,6 +895,17 @@ typedef uint16_t (*enqueue_pkt_burst_t)(void *qp, > /** Structure to keep track of registered callbacks */ > TAILQ_HEAD(rte_cryptodev_cb_list, rte_cryptodev_callback); >=20 > +/** > + * @internal > + * Structure used to hold information about the callbacks to be called f= or a > + * queue pair on enqueue. > + */ > +struct rte_cryptodev_enq_callback { > + struct rte_cryptodev_enq_callback *next; > + rte_cryptodev_enq_cb_fn fn; > + void *arg; > +}; > + > /** The data structure associated with each crypto device. */ > struct rte_cryptodev { > dequeue_pkt_burst_t dequeue_burst; > @@ -898,6 +934,14 @@ struct rte_cryptodev { > __extension__ > uint8_t attached : 1; > /**< Flag indicating the device is attached */ > + > +#ifdef RTE_CRYPTODEV_CALLBACKS > + struct rte_cryptodev_enq_callback **enq_cbs; > + /**< User application callback for pre enqueue processing */ > + > + struct rte_rcu_qsbr *qsbr; > + /** < RCU QSBR variable for rte_cryptodev_enq_callback */ Probably better to have both these fields per queue. Space for them can be allocated at dev_configure() or so.=20 BTW, wouldn't it make sense to have ability to add callback for dequeue too= ? > +#endif > } __rte_cache_aligned; >=20 > void * > @@ -1019,6 +1063,18 @@ struct rte_cryptodev_data { > struct rte_crypto_op **ops, uint16_t nb_ops) > { > struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; > +#ifdef RTE_CRYPTODEV_CALLBACKS > + if (unlikely(dev->enq_cbs !=3D NULL && dev->enq_cbs[qp_id] !=3D NULL)) = { > + struct rte_cryptodev_enq_callback *cb =3D > + dev->enq_cbs[qp_id]; > + > + do { > + nb_ops =3D cb->fn(dev_id, qp_id, ops, nb_ops, > + cb->arg); > + cb =3D cb->next; > + } while (cb !=3D NULL); > + } > +#endif >=20 > rte_cryptodev_trace_enqueue_burst(dev_id, qp_id, (void **)ops, nb_ops); > return (*dev->enqueue_burst)( > @@ -1351,6 +1407,102 @@ struct rte_cryptodev_asym_session * > struct rte_cryptodev_sym_session *sess, union rte_crypto_sym_ofs ofs, > struct rte_crypto_sym_vec *vec); >=20 > +#ifdef RTE_CRYPTODEV_CALLBACKS > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Add a user callback for a given crypto device and queue pair which wi= ll be > + * called on crypto ops enqueue. > + * > + * This API configures a function to be called for each burst of crypto = ops > + * received on a given crypto device queue pair. The return value is a p= ointer > + * that can be used later to remove the callback using > + * rte_cryptodev_remove_enq_callback(). > + * > + * Multiple functions are called in the order that they are added. > + * > + * @param dev_id The identifier of the device. > + * @param qp_id The index of the queue pair in which ops are > + * to be enqueued for processing. The value > + * must be in the range [0, nb_queue_pairs - 1] > + * previously supplied to > + * *rte_cryptodev_configure*. > + * @param cb_fn The callback function > + * @param cb_arg A generic pointer parameter which will be passed > + * to each invocation of the callback function on > + * this crypto device and queue pair. > + * > + * @return > + * NULL on error. > + * On success, a pointer value which can later be used to remove the c= allback. > + */ > + > +__rte_experimental > +struct rte_cryptodev_enq_callback * > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + rte_cryptodev_enq_cb_fn cb_fn, > + void *cb_arg); > + > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Remove a user callback function for given crypto device and queue pai= r. > + * > + * This function is used to removed callbacks that were added to a crypt= o > + * device queue pair using rte_cryptodev_add_enq_callback(). > + * > + * Note: The callback expects a RCU QSBR to be configured to synchronize > + * to free the memory. Application is expected to configure RCU QSBR aft= er > + * adding an enqueue callback. > + * > + * > + * @param dev_id The identifier of the device. > + * @param qp_id The index of the queue pair in which ops are > + * to be enqueued for processing. The value > + * must be in the range [0, nb_queue_pairs - 1] > + * previously supplied to > + * *rte_cryptodev_configure*. > + * @param cb Pointer to user supplied callback created via > + * rte_cryptodev_add_enq_callback(). > + * > + * @return > + * - 0: Success. Callback was removed. > + * - -EINVAL: The dev_id or the qp_id is out of range, or the callbac= k > + * is NULL or not found for the crypto device queue pair. > + */ > + > +__rte_experimental > +int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + struct rte_cryptodev_enq_callback *cb); > + > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Associate RCU QSBR variable with a cryptodev. > + * > + * This function is used to add RCU QSBR to a crypto device. > + * The purpose of RCU is to help multiple threads to synchronize > + * with each other before initiating adding/removing callback > + * while dataplane threads are running enqueue callbacks. > + * > + * @param dev_id The identifier of the device. > + * @param qsr RCU QSBR configuration > + * @return > + * On success - 0 > + * On error - EINVAL. > + */ > + > +__rte_experimental > +int rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct rte_rcu_qsbr *qsbr= ); > +#endif > + > #ifdef __cplusplus > } > #endif > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_= cryptodev/rte_cryptodev_version.map > index 02f6dcf..46de3ca 100644 > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > @@ -64,6 +64,7 @@ DPDK_20.0 { > rte_cryptodev_sym_capability_get; > }; >=20 > + > EXPERIMENTAL { > global: >=20 > @@ -105,4 +106,9 @@ EXPERIMENTAL { >=20 > # added in 20.08 > rte_cryptodev_get_qp_status; > + > + # added in 20.11 > + rte_cryptodev_add_enq_callback; > + rte_cryptodev_remove_enq_callback; > + rte_cryptodev_rcu_qsbr_add; > }; > -- > 1.9.1