From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "levendsayar@gmail.com" <levendsayar@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition
Date: Tue, 7 Jul 2020 12:42:06 +0000 [thread overview]
Message-ID: <BYAPR11MB330123DB9DB5F74EAC5A269E9A660@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200707122643.29222-1-levendsayar@gmail.com>
> From: Levend Sayar <levendsayar@gmail.com>
Could you provide some explanation:
What do you think is wrong with current version and why,
and what your fix does.
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
> lib/librte_acl/rte_acl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_acl/rte_acl.h b/lib/librte_acl/rte_acl.h
> index aa22e70c6..d34fdbc0e 100644
> --- a/lib/librte_acl/rte_acl.h
> +++ b/lib/librte_acl/rte_acl.h
> @@ -116,7 +116,7 @@ struct rte_acl_rule_data {
> RTE_ACL_RULE_DEF(rte_acl_rule,);
>
> #define RTE_ACL_RULE_SZ(fld_num) \
> - (sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) * (fld_num))
> + (sizeof(struct rte_acl_rule_data) + sizeof(struct rte_acl_field) * (fld_num))
>
>
> /** Max number of characters in name.*/
> --
> 2.27.0
next prev parent reply other threads:[~2020-07-07 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 12:26 levendsayar
2020-07-07 12:42 ` Ananyev, Konstantin [this message]
2020-07-07 15:25 ` Levend Sayar
2020-07-07 16:44 ` Ananyev, Konstantin
2020-07-07 16:59 ` Levend Sayar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB330123DB9DB5F74EAC5A269E9A660@BYAPR11MB3301.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=levendsayar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).