From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3483A00BE; Tue, 7 Jul 2020 14:42:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 967A61DC80; Tue, 7 Jul 2020 14:42:13 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 70FEA1DC43 for ; Tue, 7 Jul 2020 14:42:11 +0200 (CEST) IronPort-SDR: XpTK4mCkSK+G5DEEjoRPUYfnwtDxpXPqTzJYad6oRlyu3TwukGljsayYtR/qssptTAn//w482v xbBYLicMgq0w== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="149090146" X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="149090146" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 05:42:10 -0700 IronPort-SDR: ic8U3HgSoj7mSyiC1LLwFthqCoF0Uytt6NZOxBaioz7y1fD3+dhqqxxRAhBR0xhlh47ktg0E+D KZg2SaFmzbhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,323,1589266800"; d="scan'208";a="297373287" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2020 05:42:10 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jul 2020 05:42:09 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jul 2020 05:42:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WBnuSK4jzNNwlAaGhLLZuuUqUo21Rahc6Eoi6sy3F60MWUmd7d1ChwguSqViYctCiJWJCmyBzJfFjA3rWl6nsrtxVs8G9e/cDVqkaQvWGTmy+m72UsrlBrn9qB3IOb1uWnIoUJHFXkVgwOQR0Zme8djeqdct+IpmBhEsGvSB/GpZHxhDXjNLtkA5/Vk3+kjax53SLNvpcnHIxXTCBknIuQcLDNiayYGMUp1aTj1lBcEw53YI8RsFI1bt9wJDKbWFCK71djegkH9EidV65ieZHyotyqFHDooqWItTceq6WXSicyrfG8TF/wZAVWFOOL0SnP6XvXSd2X+sr4ixqgFyCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9t7pEFPmRc9g8tKwXAVWRHtuvudhHufCOhdg8WW106o=; b=g6E5YCFfZ0j9+E1PpVzM0xl+qOgYReHq8ymZrYpc1nwJFhaVwz8RDt5rZlx6AJtwbyLKIJM0gQHxf41ortKkmJwi8z1DGOMRBYSfuW+YTvws6XFcAh0U8UWamiHBG7J3aP903dYzPi2ZtoiM9bcCKPMC1LXWZ2efzW1CMG7smWd9grRVJwuapldA9NPoaiJQYwJH6s6E+WL0LzlB15p7hbXhPPf55ky80+erwy1xk/THHjD4RLViw0C46XomZJfZckKoZAbeojKCKmWQfw3EXto37N3THTsa2smMHwI917xIt/BUnNgpIIffSKidtnXfiJmT/6Q9xpADTKtbakPoGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9t7pEFPmRc9g8tKwXAVWRHtuvudhHufCOhdg8WW106o=; b=yt2CynimULbAW0AzDtH9TbyXPPKLNNe0adMI9KvTpsK8Q7o3Rar95f2PxpXnyuqN+bhiXK4ThvmZaEk9sqPtIh6VVxMQudc5v2ijCfiqy4aF3Ar5S+W5mqmOkWr9oFXnHB9yYp7rFtzhJjl/g2BNjvenA5D15MT76y6u87V4h70= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2918.namprd11.prod.outlook.com (2603:10b6:a03:92::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Tue, 7 Jul 2020 12:42:06 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 12:42:06 +0000 From: "Ananyev, Konstantin" To: "levendsayar@gmail.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition Thread-Index: AQHWVFnvWPdVkjeB3Ei3ZGEA1LGJnqj8DwXA Date: Tue, 7 Jul 2020 12:42:06 +0000 Message-ID: References: <20200707122643.29222-1-levendsayar@gmail.com> In-Reply-To: <20200707122643.29222-1-levendsayar@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e422b2b0-03b2-4497-7bb5-08d82273286f x-ms-traffictypediagnostic: BYAPR11MB2918: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:357; x-forefront-prvs: 0457F11EAF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IjS5uaKVNWs0DF0E/1M+esefOlG6MJxKi/kbGmW74Ssmzhgd4wgMxDeklBWd6ZcOZmJmICQwrRXXtm0+wxPAqWq9D3/0Cpdqo/N3V3kXwJNt95pj30+8jQ4lCNyW9Fj297yExWreqzQvkOqddhK/hNWqAZ1gh/YIco8NQ35/SpC4F8pGLdg6gVF2Lf0LrXXo9O7FOfwKlLDpPDzeUmHpuUhr5C2+KuQJLxEK0SChxgu/YSHH/rXNzbhrCOnGSvvXcV8ApVvhBkVmtppRERRT4S4iXp5tnIMPqMBNHmB/5Nx44bDeQ0NCdNdbJE2WbF6wYnMwXVtDXTO//Sg6oM8EIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(86362001)(4744005)(76116006)(8936002)(7696005)(4326008)(66946007)(52536014)(26005)(6506007)(66556008)(66476007)(64756008)(66446008)(5660300002)(186003)(2906002)(316002)(71200400001)(33656002)(6916009)(55016002)(8676002)(9686003)(478600001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: VNi+JtgpJA6l1oqJPZXbXWd1xm7C1M5mkRu8bDiCYD9z438bfU51oCDbU47aZTV+j16/LfFIyxFi6juqSJELVv1LwtzD9G5ppT0LRNnvMFD1iTLlJwlovxb/J4pHZyyyBLyCQEa8aQzLHWbyWVHAm52RY24msWh/uLy9czsDcbhI1g2UiGrfosChAgjD+pxpF2rbnNrNsCu96ko78RsEiJEvc/lnxsaRh+tAyK4KtQRlugotjFiH1yta1T/oLZPHcSxDN6xPBZwEL2/wrAf8TD+LMe/aA1uYBBFoXSRsGG0PPdGsBFqyBVeS+N38qls5/RjtfbTn9SoiHUIh8wHoV4W6/LymkcNdDzdFlAgJPmsJcS9v2zoBDVV+oy31Kbjt+8vJC6p7FcS8VV9IyYbosyAtZObn8hD2wWD1Ki7gibe0Y9sep7oWzFyT4b+UnIazaduFJF5FyOoTtmJuFY1JKFAx+jhp/BKaGhs7H4czeH5gaTNw3MmZttxietKbgRcb x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e422b2b0-03b2-4497-7bb5-08d82273286f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 12:42:06.4685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E23CVAQO4C/eAzFGb+6CP71HH2wgqQJQ/Jxo39FZqz50W5dkM4wnXxEZCM1z/kth+7W7KvyEJAaNPdZ/An8c26biA2JV1ZrpogBycUfOg2c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2918 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Levend Sayar Could you provide some explanation: What do you think is wrong with current version and why, and what your fix does.=20 >=20 > Signed-off-by: Levend Sayar > --- > lib/librte_acl/rte_acl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_acl/rte_acl.h b/lib/librte_acl/rte_acl.h > index aa22e70c6..d34fdbc0e 100644 > --- a/lib/librte_acl/rte_acl.h > +++ b/lib/librte_acl/rte_acl.h > @@ -116,7 +116,7 @@ struct rte_acl_rule_data { > RTE_ACL_RULE_DEF(rte_acl_rule,); >=20 > #define RTE_ACL_RULE_SZ(fld_num) \ > - (sizeof(struct rte_acl_rule) + sizeof(struct rte_acl_field) * (fld_num)= ) > + (sizeof(struct rte_acl_rule_data) + sizeof(struct rte_acl_field) * (fld= _num)) >=20 >=20 > /** Max number of characters in name.*/ > -- > 2.27.0