From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/3] examples/l3fwd-acl: add source and destination MAC update
Date: Thu, 15 Oct 2020 13:06:40 +0000 [thread overview]
Message-ID: <BYAPR11MB33012D39A84CCE0DB61DD3EC9A020@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yB61ab30P_YPSbs5CcyCcXAScSRCGux_mX_-xkzUK9Ow@mail.gmail.com>
> On Tue, Oct 6, 2020 at 7:17 PM Konstantin Ananyev
> <konstantin.ananyev@intel.com> wrote:
> >
> > Introduces two changes into l3fwd-acl behaviour to make
> > it behave in the same way as l3fwd:
> > - Add a command-line parameter to allow the user to specify the
> > destination mac address for each ethernet port used.
> > - While forwarding the packet update source and destination mac
> > addresses.
>
> This new parameter is optional, but I see no default for l2
> destination in the patch.
> How does it work when you won't set this option?
Ah yes, forgot to init l2 dst array with some default values.
Will fix and re-spin then.
>
>
> Bonus question, what keeps us from merging this example with l3fwd?
Nothing, except the effort required.
next prev parent reply other threads:[~2020-10-15 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:39 [dpdk-dev] [PATCH 0/2] Few enhancements for l3fwd-acl Konstantin Ananyev
2020-09-07 16:39 ` [dpdk-dev] [PATCH 1/2] examples/l3fwd-acl: add source and destination MAC update Konstantin Ananyev
2020-09-07 16:39 ` [dpdk-dev] [PATCH 2/2] examples/l3fwd-acl: allow explicitly select classify method Konstantin Ananyev
2020-09-15 17:04 ` [dpdk-dev] [PATCH v2 0/3] Few enhancements for l3fwd-acl Konstantin Ananyev
2020-09-15 17:04 ` [dpdk-dev] [PATCH v2 1/3] examples/l3fwd-acl: add source and destination MAC update Konstantin Ananyev
2020-09-15 17:04 ` [dpdk-dev] [PATCH v2 2/3] examples/l3fwd-acl: allow explicitly select classify method Konstantin Ananyev
2020-09-15 17:04 ` [dpdk-dev] [PATCH v2 3/3] examples/l3fwd-acl: add support for AVX512 Konstantin Ananyev
2020-10-06 17:16 ` [dpdk-dev] [PATCH v3 0/3] Few enhancements for l3fwd-acl Konstantin Ananyev
2020-10-06 17:16 ` [dpdk-dev] [PATCH v3 1/3] examples/l3fwd-acl: add source and destination MAC update Konstantin Ananyev
2020-10-15 11:58 ` David Marchand
2020-10-15 13:06 ` Ananyev, Konstantin [this message]
2020-10-16 12:19 ` David Marchand
2020-10-16 13:14 ` Ananyev, Konstantin
2020-10-06 17:16 ` [dpdk-dev] [PATCH v3 2/3] examples/l3fwd-acl: allow explicitly select classify method Konstantin Ananyev
2020-10-06 17:16 ` [dpdk-dev] [PATCH v3 3/3] examples/l3fwd-acl: add support for AVX512 Konstantin Ananyev
2020-10-15 12:11 ` David Marchand
2020-10-15 12:42 ` Ananyev, Konstantin
2020-10-16 13:12 ` [dpdk-dev] [PATCH v4 0/2] Few enhancements for l3fwd-acl Konstantin Ananyev
2020-10-16 13:12 ` [dpdk-dev] [PATCH v4 1/2] examples/l3fwd-acl: add source and destination MAC update Konstantin Ananyev
2020-10-16 13:12 ` [dpdk-dev] [PATCH v4 2/2] examples/l3fwd-acl: allow explicitly select classify method Konstantin Ananyev
2020-10-19 7:03 ` [dpdk-dev] [PATCH v4 0/2] Few enhancements for l3fwd-acl David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB33012D39A84CCE0DB61DD3EC9A020@BYAPR11MB3301.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).