From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AA46A00C5; Fri, 8 May 2020 10:09:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 838EF1DB73; Fri, 8 May 2020 10:09:02 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 1027E1DB72 for ; Fri, 8 May 2020 10:09:00 +0200 (CEST) IronPort-SDR: abwNisVGJSpu4XVvxlkMTa4L+lLbQtK7gTrBMOhu9UlvTwuWB+o+hcGYmPR7MxEs3aJDmffgeX vejsnAddpNwA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 01:09:00 -0700 IronPort-SDR: H9TD0GeSakxSYYHrOrux1YAgeSlhV7E5Wn7N7oWc4p8XGZalZtrVQmhiqDHOeejvzM3g3TdVEF XKHZGPlNgD1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="285299391" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 08 May 2020 01:09:00 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 01:08:59 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 01:08:59 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 01:08:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APz1pVYgFZiLUFWSpet/j5wzfMgYrPTMNQWJ8Hfqfaou3eiAxx1z+nTJT1c2Ck0CCRbJDlq2aUae1JP7sz/egbvuu5GkEY88tk0BNtr4RFDSBTIE5rDLFemCK6uH9XyZ619+Sg64mQwFM7b42fgubHliHNoCzp1W6pKhPjiuCXp2nO+GVGSL5oRMq+1QkRglx1AWBtJ9nvW5E4JBqph6cnJ7rS4Fkv01WYgvTUcr8KoCtoDypN4fKYi07JyqlLwutgdR7KnG/+7ygTpMJoAy+mF3nGo1zftLaVlxi05aB7wB6nhO8xOiTA2WH91dHR+f/ESCqYzvFkUMi5lVydl35Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mmINzNe0Reyp9utYJwozy0aROAnSNET9el/H4NF+JfQ=; b=Qs6lI5+PKNupXwkYgXaR1wWltyjWLturTsFteQ5VUh3l2RGDbsJIJobzj4r/eiidCog+A0hhzHKXdrvLQo79I+U1Re56DpwBe6weUwo2pqaJS2KPFQr7EpYF5PkfBy+pFSUK4dz1n//+aflWGAAz78oGN3sSw2CljPUOdJ9Ru4TSE6CMKuLha7dydvrG/fBi/c3vI192g0g6uBg/+XsPLyPRRAWBp2zCo8UqCZkoOIrQMEb31ZaUOJBNfF7EM00pQZfBSYJsR+ssdXVQtrmHOyQftGNcS2lA2Wz+TTeet3sHBq3nqYmXPodC5/g8kBkFkS6BRGbQc7D6wscbDAIigw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mmINzNe0Reyp9utYJwozy0aROAnSNET9el/H4NF+JfQ=; b=Y87ijVH19SJhK26PwhMs5Ojb0cEXAZ2st8a/WbajpTsflbnIYp5ZAO7arq0AQlX2MnUy78vain0KFumqwSdfpVYGQWhyxBTOLPIS6i3o5UIN0V3IlJ39qaA/TntZNdFOeMbTIvlbS8tCkyWnNO7/BVyqENsAnV8kIMnpoOaZJ7k= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3030.namprd11.prod.outlook.com (2603:10b6:a03:87::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Fri, 8 May 2020 08:08:58 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2958.035; Fri, 8 May 2020 08:08:57 +0000 From: "Ananyev, Konstantin" To: Anoob Joseph , Akhil Goyal , "Nicolau, Radu" CC: Narayana Prasad , "dev@dpdk.org" Thread-Topic: [PATCH v3] examples/ipsec-secgw: add per core packet stats Thread-Index: AQHWI6SkbuuME/sCGUWlN/0x2cLQmKid16cQ Date: Fri, 8 May 2020 08:08:57 +0000 Message-ID: References: <1587647245-10524-1-git-send-email-anoobj@marvell.com> <1588769253-10405-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1588769253-10405-1-git-send-email-anoobj@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9147fe6-0bb9-45ca-38a6-08d7f3270f22 x-ms-traffictypediagnostic: BYAPR11MB3030: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 039735BC4E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xWKb1sNZEmvgqL4WrvWx+lBwA05Vb18gvZvxxXm2pb9WHbqw9mZsraCQ9++C97+NjI48HYY+KZoEEeP8hlejv4+S9RrRfSoypfABPuMuIl2SPna4NXJDje3hmCqZw7FKCk8zURidQ4QSG7UyHQoe50pK+qZVT11VMA0u+gvNzacpok+BLqMGgdb6aPymRgbVC5cvXG1fi39JxzRhgn02qWPTl05GwcVYy/jYo9kobV4QJHEXgXs2csIU96a9psYA1vopYM6Gsat911PYUa4LYF24Uneerz51Y7xeL8YBAUrl7MMcdLdlVEIs8hNisWb87Bo4bTshayGrtRq92FBxT14GFxwzUTsgM8L3HYqcyh2w11lEW7xRvNpnDATFwBIEXUlNjQMeiSYF5n0RQxxhQJBJtgtVUPs/2c9kuaw3OpDlSO+k/VL2nwx4iZLDRn0Sp9F4bizocXQ6uON49mDIpZnLifVLjnLmPshV/ClhigMNadT51mJVYMsy+6U92CzeL880s+fcUGwgxh4+UmTACw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(136003)(396003)(376002)(346002)(366004)(33430700001)(71200400001)(66446008)(186003)(64756008)(66476007)(6636002)(478600001)(8936002)(4326008)(66556008)(110136005)(33656002)(55016002)(54906003)(83300400001)(9686003)(83310400001)(83320400001)(83290400001)(83280400001)(8676002)(26005)(33440700001)(86362001)(2906002)(52536014)(316002)(7696005)(76116006)(5660300002)(30864003)(6506007)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: dSFS08hHYy1BOaTBziJDgqNPJC6CeGd/cwDyTarfmXEnhk1YGCwq0d6Ww3SplBsSfx7Ae5m0RpDN7yKPGNzVZvPMYw4n1RcgGjlthH1SddweN0R9afptXeBqmW+otcEbs9n8mPdMSwnRrtK8595KXQCLWvRW6HQxzkXuXNas9gmz0FUGzf/d4cPRhcX2QmIowf7SisxJRnp2+pPA5MQ0xoCVV2x+JMnbMaEM7korPiMw5RQJtAYMDal+Sm/C419WHy62LmgYIZcBCm41QGNUEbXVgKGlZ4BuMbTKdoR6Qv0oCiwm06uzj9/595ERf1Ya/uxiJkUS3ITqcortIFY578OYU3634HZ3efHdiCwrREGroIb1V5f1zv40iJShnI3haWm9a60Ew7z4XSNldwtfNlVk0dOclx4vPNuQHkcdJDUn/vyJXH1EjSKe+wlLUYxPIxib/G+SwIuFPofoVWzd97uHvQrcQmFdqwffn0AtfRMlMUacev4P6CjeANdKQ1ff Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f9147fe6-0bb9-45ca-38a6-08d7f3270f22 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 08:08:57.7610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7AZA4kCKTJJbH9X9XXoNOVO1upNUn7qftIupEqxx5DeIa37iQBAWUESuxV2oraVlDKX4P1o2lxeVsLWHBnP3WcAbdavfuSLqi6ot9fzV17A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3030 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > +#if (STATS_INTERVAL > 0) > + > +/* Print out statistics on packet distribution */ > +static void > +print_stats(void) > +{ > + uint64_t total_packets_dropped, total_packets_tx, total_packets_rx; > + unsigned int coreid; > + float burst_percent; > + > + total_packets_dropped =3D 0; > + total_packets_tx =3D 0; > + total_packets_rx =3D 0; > + > + const char clr[] =3D { 27, '[', '2', 'J', '\0' }; > + > + /* Clear screen and move to top left */ > + printf("%s", clr); > + > + printf("\nCore statistics =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D"); > + > + for (coreid =3D 0; coreid < RTE_MAX_LCORE; coreid++) { > + /* skip disabled cores */ > + if (rte_lcore_is_enabled(coreid) =3D=3D 0) > + continue; > + burst_percent =3D (float)(core_statistics[coreid].burst_rx * 100)/ > + core_statistics[coreid].rx; > + printf("\nStatistics for core %u ------------------------------" > + "\nPackets received: %20"PRIu64 > + "\nPackets sent: %24"PRIu64 > + "\nPackets dropped: %21"PRIu64 > + "\nBurst percent: %23.2f", > + coreid, > + core_statistics[coreid].rx, > + core_statistics[coreid].tx, > + core_statistics[coreid].dropped, > + burst_percent); As one more comment: Can we also collect number of calls and display average pkt/call (for both rx and tx)? > + > + total_packets_dropped +=3D core_statistics[coreid].dropped; > + total_packets_tx +=3D core_statistics[coreid].tx; > + total_packets_rx +=3D core_statistics[coreid].rx; > + } > + printf("\nAggregate statistics =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D" > + "\nTotal packets received: %14"PRIu64 > + "\nTotal packets sent: %18"PRIu64 > + "\nTotal packets dropped: %15"PRIu64, > + total_packets_rx, > + total_packets_tx, > + total_packets_dropped); > + printf("\n=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D\n"); > +} > +#endif /* STATS_INTERVAL */ > + > static inline void > prepare_one_packet(struct rte_mbuf *pkt, struct ipsec_traffic *t) > { > @@ -333,7 +386,7 @@ prepare_one_packet(struct rte_mbuf *pkt, struct ipsec= _traffic *t) >=20 > /* drop packet when IPv6 header exceeds first segment length */ > if (unlikely(l3len > pkt->data_len)) { > - rte_pktmbuf_free(pkt); > + free_pkt(pkt); > return; > } >=20 > @@ -350,7 +403,7 @@ prepare_one_packet(struct rte_mbuf *pkt, struct ipsec= _traffic *t) > /* Unknown/Unsupported type, drop the packet */ > RTE_LOG(ERR, IPSEC, "Unsupported packet type 0x%x\n", > rte_be_to_cpu_16(eth->ether_type)); > - rte_pktmbuf_free(pkt); > + free_pkt(pkt); > return; > } >=20 > @@ -477,9 +530,12 @@ send_burst(struct lcore_conf *qconf, uint16_t n, uin= t16_t port) > prepare_tx_burst(m_table, n, port, qconf); >=20 > ret =3D rte_eth_tx_burst(port, queueid, m_table, n); > + > + core_stats_update_tx(ret); > + > if (unlikely(ret < n)) { > do { > - rte_pktmbuf_free(m_table[ret]); > + free_pkt(m_table[ret]); > } while (++ret < n); > } >=20 > @@ -525,7 +581,7 @@ send_fragment_packet(struct lcore_conf *qconf, struct= rte_mbuf *m, > "error code: %d\n", > __func__, m->pkt_len, rte_errno); >=20 > - rte_pktmbuf_free(m); > + free_pkt(m); > return len; > } >=20 > @@ -550,7 +606,7 @@ send_single_packet(struct rte_mbuf *m, uint16_t port,= uint8_t proto) > } else if (frag_tbl_sz > 0) > len =3D send_fragment_packet(qconf, m, port, proto); > else > - rte_pktmbuf_free(m); > + free_pkt(m); >=20 > /* enough pkts to be sent */ > if (unlikely(len =3D=3D MAX_PKT_BURST)) { > @@ -584,19 +640,19 @@ inbound_sp_sa(struct sp_ctx *sp, struct sa_ctx *sa,= struct traffic_type *ip, > continue; > } > if (res =3D=3D DISCARD) { > - rte_pktmbuf_free(m); > + free_pkt(m); > continue; > } >=20 > /* Only check SPI match for processed IPSec packets */ > if (i < lim && ((m->ol_flags & PKT_RX_SEC_OFFLOAD) =3D=3D 0)) { > - rte_pktmbuf_free(m); > + free_pkt(m); > continue; > } >=20 > sa_idx =3D res - 1; > if (!inbound_sa_check(sa, m, sa_idx)) { > - rte_pktmbuf_free(m); > + free_pkt(m); > continue; > } > ip->pkts[j++] =3D m; > @@ -631,7 +687,7 @@ split46_traffic(struct ipsec_traffic *trf, struct rte= _mbuf *mb[], uint32_t num) > offsetof(struct ip6_hdr, ip6_nxt)); > n6++; > } else > - rte_pktmbuf_free(m); > + free_pkt(m); > } >=20 > trf->ip4.num =3D n4; > @@ -683,7 +739,7 @@ outbound_sp(struct sp_ctx *sp, struct traffic_type *i= p, > m =3D ip->pkts[i]; > sa_idx =3D ip->res[i] - 1; > if (ip->res[i] =3D=3D DISCARD) > - rte_pktmbuf_free(m); > + free_pkt(m); > else if (ip->res[i] =3D=3D BYPASS) > ip->pkts[j++] =3D m; > else { > @@ -702,8 +758,7 @@ process_pkts_outbound(struct ipsec_ctx *ipsec_ctx, > uint16_t idx, nb_pkts_out, i; >=20 > /* Drop any IPsec traffic from protected ports */ > - for (i =3D 0; i < traffic->ipsec.num; i++) > - rte_pktmbuf_free(traffic->ipsec.pkts[i]); > + free_pkts(traffic->ipsec.pkts, traffic->ipsec.num); >=20 > traffic->ipsec.num =3D 0; >=20 > @@ -743,14 +798,12 @@ process_pkts_inbound_nosp(struct ipsec_ctx *ipsec_c= tx, > uint32_t nb_pkts_in, i, idx; >=20 > /* Drop any IPv4 traffic from unprotected ports */ > - for (i =3D 0; i < traffic->ip4.num; i++) > - rte_pktmbuf_free(traffic->ip4.pkts[i]); > + free_pkts(traffic->ip4.pkts, traffic->ip4.num); >=20 > traffic->ip4.num =3D 0; >=20 > /* Drop any IPv6 traffic from unprotected ports */ > - for (i =3D 0; i < traffic->ip6.num; i++) > - rte_pktmbuf_free(traffic->ip6.pkts[i]); > + free_pkts(traffic->ip6.pkts, traffic->ip6.num); >=20 > traffic->ip6.num =3D 0; >=20 > @@ -786,8 +839,7 @@ process_pkts_outbound_nosp(struct ipsec_ctx *ipsec_ct= x, > struct ip *ip; >=20 > /* Drop any IPsec traffic from protected ports */ > - for (i =3D 0; i < traffic->ipsec.num; i++) > - rte_pktmbuf_free(traffic->ipsec.pkts[i]); > + free_pkts(traffic->ipsec.pkts, traffic->ipsec.num); >=20 > n =3D 0; >=20 > @@ -901,7 +953,7 @@ route4_pkts(struct rt_ctx *rt_ctx, struct rte_mbuf *p= kts[], uint8_t nb_pkts) > } >=20 > if ((pkt_hop & RTE_LPM_LOOKUP_SUCCESS) =3D=3D 0) { > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; > } > send_single_packet(pkts[i], pkt_hop & 0xff, IPPROTO_IP); > @@ -953,7 +1005,7 @@ route6_pkts(struct rt_ctx *rt_ctx, struct rte_mbuf *= pkts[], uint8_t nb_pkts) > } >=20 > if (pkt_hop =3D=3D -1) { > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; > } > send_single_packet(pkts[i], pkt_hop & 0xff, IPPROTO_IPV6); > @@ -1099,6 +1151,10 @@ ipsec_poll_mode_worker(void) > const uint64_t drain_tsc =3D (rte_get_tsc_hz() + US_PER_S - 1) > / US_PER_S * BURST_TX_DRAIN_US; > struct lcore_rx_queue *rxql; > +#if (STATS_INTERVAL > 0) > + const uint64_t timer_period =3D STATS_INTERVAL * rte_get_timer_hz(); > + uint64_t timer_tsc =3D 0; > +#endif /* STATS_INTERVAL */ >=20 > prev_tsc =3D 0; > lcore_id =3D rte_lcore_id(); > @@ -1159,6 +1215,19 @@ ipsec_poll_mode_worker(void) > drain_tx_buffers(qconf); > drain_crypto_buffers(qconf); > prev_tsc =3D cur_tsc; > +#if (STATS_INTERVAL > 0) > + if (lcore_id =3D=3D rte_get_master_lcore()) { > + /* advance the timer */ > + timer_tsc +=3D diff_tsc; > + > + /* if timer has reached its timeout */ > + if (unlikely(timer_tsc >=3D timer_period)) { > + print_stats(); > + /* reset the timer */ > + timer_tsc =3D 0; > + } > + } > +#endif /* STATS_INTERVAL */ > } >=20 > for (i =3D 0; i < qconf->nb_rx_queue; ++i) { > @@ -1169,8 +1238,10 @@ ipsec_poll_mode_worker(void) > nb_rx =3D rte_eth_rx_burst(portid, queueid, > pkts, MAX_PKT_BURST); >=20 > - if (nb_rx > 0) > + if (nb_rx > 0) { > + core_stats_update_rx(nb_rx); > process_pkts(qconf, pkts, nb_rx, portid); > + } >=20 > /* dequeue and process completed crypto-ops */ > if (is_unprotected_port(portid)) > diff --git a/examples/ipsec-secgw/ipsec-secgw.h b/examples/ipsec-secgw/ip= sec-secgw.h > index 4b53cb5..5b3561f 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.h > +++ b/examples/ipsec-secgw/ipsec-secgw.h > @@ -6,6 +6,8 @@ >=20 > #include >=20 > +#define STATS_INTERVAL 0 > + > #define NB_SOCKETS 4 >=20 > #define MAX_PKT_BURST 32 > @@ -69,6 +71,17 @@ struct ethaddr_info { > uint64_t src, dst; > }; >=20 > +#if (STATS_INTERVAL > 0) > +struct ipsec_core_statistics { > + uint64_t tx; > + uint64_t rx; > + uint64_t dropped; > + uint64_t burst_rx; > +} __rte_cache_aligned; > + > +struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; > +#endif /* STATS_INTERVAL */ > + > extern struct ethaddr_info ethaddr_tbl[RTE_MAX_ETHPORTS]; >=20 > /* Port mask to identify the unprotected ports */ > @@ -85,4 +98,59 @@ is_unprotected_port(uint16_t port_id) > return unprotected_port_mask & (1 << port_id); > } >=20 > +static inline void > +core_stats_update_rx(int n) > +{ > +#if (STATS_INTERVAL > 0) > + int lcore_id =3D rte_lcore_id(); > + core_statistics[lcore_id].rx +=3D n; > + if (n =3D=3D MAX_PKT_BURST) > + core_statistics[lcore_id].burst_rx +=3D n; > +#else > + RTE_SET_USED(n); > +#endif /* STATS_INTERVAL */ > +} > + > +static inline void > +core_stats_update_tx(int n) > +{ > +#if (STATS_INTERVAL > 0) > + int lcore_id =3D rte_lcore_id(); > + core_statistics[lcore_id].tx +=3D n; > +#else > + RTE_SET_USED(n); > +#endif /* STATS_INTERVAL */ > +} > + > +static inline void > +core_stats_update_drop(int n) > +{ > +#if (STATS_INTERVAL > 0) > + int lcore_id =3D rte_lcore_id(); > + core_statistics[lcore_id].dropped +=3D n; > +#else > + RTE_SET_USED(n); > +#endif /* STATS_INTERVAL */ > +} > + > +/* helper routine to free bulk of packets */ > +static inline void > +free_pkts(struct rte_mbuf *mb[], uint32_t n) > +{ > + uint32_t i; > + > + for (i =3D 0; i !=3D n; i++) > + rte_pktmbuf_free(mb[i]); > + > + core_stats_update_drop(n); > +} > + > +/* helper routine to free single packet */ > +static inline void > +free_pkt(struct rte_mbuf *mb) > +{ > + rte_pktmbuf_free(mb); > + core_stats_update_drop(1); > +} > + > #endif /* _IPSEC_SECGW_H_ */ > diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c > index bf88d80..351f1f1 100644 > --- a/examples/ipsec-secgw/ipsec.c > +++ b/examples/ipsec-secgw/ipsec.c > @@ -500,7 +500,7 @@ enqueue_cop_burst(struct cdev_qp *cqp) > cqp->id, cqp->qp, ret, len); > /* drop packets that we fail to enqueue */ > for (i =3D ret; i < len; i++) > - rte_pktmbuf_free(cqp->buf[i]->sym->m_src); > + free_pkt(cqp->buf[i]->sym->m_src); > } > cqp->in_flight +=3D ret; > cqp->len =3D 0; > @@ -528,7 +528,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct ipsec= _ctx *ipsec_ctx, >=20 > for (i =3D 0; i < nb_pkts; i++) { > if (unlikely(sas[i] =3D=3D NULL)) { > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; > } >=20 > @@ -549,7 +549,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct ipsec= _ctx *ipsec_ctx, >=20 > if ((unlikely(ips->security.ses =3D=3D NULL)) && > create_lookaside_session(ipsec_ctx, sa, ips)) { > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; > } >=20 > @@ -563,7 +563,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct ipsec= _ctx *ipsec_ctx, > case RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO: > RTE_LOG(ERR, IPSEC, "CPU crypto is not supported by the" > " legacy mode."); > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; >=20 > case RTE_SECURITY_ACTION_TYPE_NONE: > @@ -575,7 +575,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct ipsec= _ctx *ipsec_ctx, >=20 > if ((unlikely(ips->crypto.ses =3D=3D NULL)) && > create_lookaside_session(ipsec_ctx, sa, ips)) { > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; > } >=20 > @@ -584,7 +584,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct ipsec= _ctx *ipsec_ctx, >=20 > ret =3D xform_func(pkts[i], sa, &priv->cop); > if (unlikely(ret)) { > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; > } > break; > @@ -608,7 +608,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct ipsec= _ctx *ipsec_ctx, >=20 > ret =3D xform_func(pkts[i], sa, &priv->cop); > if (unlikely(ret)) { > - rte_pktmbuf_free(pkts[i]); > + free_pkt(pkts[i]); > continue; > } >=20 > @@ -643,7 +643,7 @@ ipsec_inline_dequeue(ipsec_xform_fn xform_func, struc= t ipsec_ctx *ipsec_ctx, > sa =3D priv->sa; > ret =3D xform_func(pkt, sa, &priv->cop); > if (unlikely(ret)) { > - rte_pktmbuf_free(pkt); > + free_pkt(pkt); > continue; > } > pkts[nb_pkts++] =3D pkt; > @@ -690,13 +690,13 @@ ipsec_dequeue(ipsec_xform_fn xform_func, struct ips= ec_ctx *ipsec_ctx, > RTE_SECURITY_ACTION_TYPE_NONE) { > ret =3D xform_func(pkt, sa, cops[j]); > if (unlikely(ret)) { > - rte_pktmbuf_free(pkt); > + free_pkt(pkt); > continue; > } > } else if (ipsec_get_action_type(sa) =3D=3D > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > if (cops[j]->status) { > - rte_pktmbuf_free(pkt); > + free_pkt(pkt); > continue; > } > } > diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/= ipsec_process.c > index bb2f2b8..4748299 100644 > --- a/examples/ipsec-secgw/ipsec_process.c > +++ b/examples/ipsec-secgw/ipsec_process.c > @@ -12,22 +12,13 @@ > #include >=20 > #include "ipsec.h" > +#include "ipsec-secgw.h" >=20 > #define SATP_OUT_IPV4(t) \ > ((((t) & RTE_IPSEC_SATP_MODE_MASK) =3D=3D RTE_IPSEC_SATP_MODE_TRANS && = \ > (((t) & RTE_IPSEC_SATP_IPV_MASK) =3D=3D RTE_IPSEC_SATP_IPV4)) || \ > ((t) & RTE_IPSEC_SATP_MODE_MASK) =3D=3D RTE_IPSEC_SATP_MODE_TUNLV4) >=20 > -/* helper routine to free bulk of packets */ > -static inline void > -free_pkts(struct rte_mbuf *mb[], uint32_t n) > -{ > - uint32_t i; > - > - for (i =3D 0; i !=3D n; i++) > - rte_pktmbuf_free(mb[i]); > -} > - > /* helper routine to free bulk of crypto-ops and related packets */ > static inline void > free_cops(struct rte_crypto_op *cop[], uint32_t n) > -- > 2.7.4