From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 982AFA0598; Tue, 21 Apr 2020 12:21:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC0C11D61E; Tue, 21 Apr 2020 12:21:51 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C68781D61A for ; Tue, 21 Apr 2020 12:21:50 +0200 (CEST) IronPort-SDR: MH+ASiAvtMczSFk25njku/uYHbETTmeHbUua3YxlLDIoiavD2NIuS9BHgWMlpfMeoIzgCB6mY3 4F7Gq61i3Wzw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 03:21:49 -0700 IronPort-SDR: +FjMtXaJPMadfaR/NMTFpJY6IPjpD3WIoMIWNIpWfe942GeeqxOsIV8KZrxLkcCpu3pJbA/EJe /tPmBYSyhzFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,410,1580803200"; d="scan'208";a="402145719" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 21 Apr 2020 03:21:49 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 03:21:48 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 03:21:48 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 03:21:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QNus8xNEpzi5GNBaiNqgpnXtrZffVsOlHBx6y31OXShLJKp+/phCC4MPv3XW7BgDeh7N7T2G7AduUpH8iEcY8ip5oohfDWsJ1B7CqyMeiyLxWMQiH5USR3IOLMprkc7VfStmn4N8OFAAmMziuxqO9vhHM027gwsTS2QmeozQtV26vwvCW2l0jKFZN9uj64bcZxpktK/H7Fenl4BHCtDzLezhkl/giJYyDCYSfaylql4/xQ0J/HTU/LXtIvG2PooZefFzhl62sKzERkNs/U6QL0BX0EFndN56gmGn9UigdsirzJfxvA79jRKMXtiaqZskEMyGAgU/1nM4C8x07a7QcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iYviWlQwyi6YgO2V84XTLkca7GCDmtbE1FltQnJclac=; b=FeRaWqW+nZpqaqNvzUIM6lY7mmIISMyNQ9lzRlpgGTLVgPp4ABusdMEMS1j6LFGvEP/IfF+ciMC3W88wvPpsx6PdTfe77vkahocoKI3bXm7q0nKgjfjmlsMn6Y5ySNvvO0dpZwekUD1ldbzo29e5husA1dKpBIVOhk09YTIlUboCK0YomdI076F840TAm3R8pNrM0Jde4FEeZ/aq7Sv0OnH4V7l2FzhP8OCmiLiAemo94dx7ooU38GYnNH77YKt3oDQqtluQ01t6md9wC9fS+8gfJh6hWHBNxJsie0H254hBOLZT01a8NaBqes0rgyGsXs5JDixzU9JpTwLdisET8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iYviWlQwyi6YgO2V84XTLkca7GCDmtbE1FltQnJclac=; b=nbjQ1BxdQ//t+70OzxEIwA2Z5vThm635cKQ+Ao2OrEVWcdt4Ot3hG986WiOOCIzaAZsj312ws2IGrjsr1UDqjntPPDkzeRk2pTKcYfyfeD31qs6OCmyQS9Hhpa3QV+ZWZb3WpneO3wF13XAN1N0TvVhBu7lDziOYNWNBWOwpKvQ= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3704.namprd11.prod.outlook.com (2603:10b6:a03:f9::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 10:21:46 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2937.012; Tue, 21 Apr 2020 10:21:46 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , "akhil.goyal@nxp.com" , "Dharmappa, Savinay" CC: "dev@dpdk.org" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance Thread-Index: AQHV84Ylsw/O/CpaU0iRJqvqsLWuBqiDImMAgAABvgCAAIFEcA== Date: Tue, 21 Apr 2020 10:21:45 +0000 Message-ID: References: <20200305071523.30952-1-savinay.dharmappa@intel.com> <20200306070825.19424-1-savinay.dharmappa@intel.com> <4223016.LvFx2qVVIh@thomas> <2018185.irdbgypaU6@thomas> In-Reply-To: <2018185.irdbgypaU6@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 492484a8-2f8b-4ff2-c898-08d7e5ddcb81 x-ms-traffictypediagnostic: BYAPR11MB3704: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(366004)(136003)(39860400002)(396003)(346002)(376002)(54906003)(8676002)(186003)(33656002)(81156014)(316002)(6506007)(478600001)(8936002)(71200400001)(52536014)(2906002)(4326008)(66476007)(86362001)(26005)(7696005)(110136005)(66946007)(55016002)(66556008)(64756008)(66446008)(6636002)(5660300002)(76116006)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vv2Sgjn/bIeDwds8ucNu1INn6pJUAXjIza7uR8/va1CVYjtzNt8bvCRYGfY8OA6jFv5YyvHe4ewT87m/m5pvm2CRI1MJCunIgvQLjtLd4aqAfWScZFDyrUk+/3h0DUPawOG9HK9bEuzO1Gd6KJeb8blM+ab0fuOMEHvKJifZltOmCvJS9ZFc2NCjPrRzyW/859oz39jQkiyPcFMJ1b1U6hnoAygl0Q+27MJtM02obeMEFnd1pLFuq27nQDLDIK64vwTO0kbUl8cFxMvnQ73t6JtKlTGJ0eN64ZmuK8q2M1g7aERTCI1Wp9eXCiUd25GssMdbzuohlNduILlg89rFIxAq0b6CGgdjprtgo6aM6CdrQS6r+uUPVr3bIWKyTjEswbEoLzbSYWdwxWeGd9+W328a4YXF3wBke4f+tO1x2vYa31ajFHaLGd3OXT0sw9Sr x-ms-exchange-antispam-messagedata: gSsGJ5Vlsv0uQDWpy/earYT+gCJ/KYNkch62bXG5gEBrt1aqkqZHy37oMpfk1urWBv+9hXg2fig/E7X4V8zX4MvX6muOdS0APPSla5yZN9PoqRdWrcz/6ZzaRnuiE0oH2OJqSUmy6+MCCdrJB7vC2A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 492484a8-2f8b-4ff2-c898-08d7e5ddcb81 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 10:21:45.9229 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iKYBORkA4seAXl1WdJRRWLwYY0c+WYGgu3qrcKZ4avKezt/BF0/nbChYCiSCkWHUFkeMFF2uGSUTy1Q7bO5zkfNyL376Ll6q3IzH5HMxgns= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3704 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 21/04/2020 04:29, Thomas Monjalon: > > 06/03/2020 08:08, Savinay Dharmappa: > > > test app to measures the performance of libipsec > > > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. > > > > Please make sentences in commit logs. > > > > > Signed-off-by: Savinay Dharmappa > > > Acked-by: Konstantin Ananyev > > > --- > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -1259,6 +1259,8 @@ F: lib/librte_ipsec/ > > > M: Bernard Iremonger > > > F: app/test/test_ipsec.c > > > F: doc/guides/prog_guide/ipsec_lib.rst > > > +M: Savinay Dharmappa > > > +F: app/test/test_ipsec_perf.c > > > M: Vladimir Medvedkin > > > F: app/test/test_ipsec_sad.c > > > F: app/test-sad/ > > > > Repeating what I said on v3: > > Having one different maintainer per test file is quite ridiculous. > > The maintainers of a lib are expected to maintain the related tests. >=20 >=20 > In addition, reading the first lines of the file, I see two mistakes: >=20 > > --- /dev/null > > +++ b/app/test/test_ipsec_perf.c > > @@ -0,0 +1,619 @@ > > +/* SPDX-License-Identifier: BSD-3-Clause > > + * Copyright(c) 2010-2014 Intel Corporation >=20 > The Copyright year should be 2020 I guess. >=20 > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include >=20 > rte_malloc.h is already included 3 lines above. >=20 >=20 > I have a bad feeling about this patch, > I think it should be dropped from 20.05-rc1. If you feel patch is not good enough - sure feel free to drop it, we'll try to fix the issues and resubmit it for rc2. About having separate MAINTAINER for the test - honestly I don't understand why it is a problem for you. Obviously we would like to spread the load - what's wrong with it? Konstantin=20