From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C33D2A00BE; Tue, 28 Apr 2020 13:04:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF9E11D596; Tue, 28 Apr 2020 13:04:42 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4B1FF1D579 for ; Tue, 28 Apr 2020 13:04:40 +0200 (CEST) IronPort-SDR: OzlBn6GqB9wLJVw9NTyehGrEm5ZW32kKBAq0AJc2Jt0V1mPsgiVea5bca+bg8DrXbO0xPrxPPd 1/Mz5wqsLVBg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 04:04:39 -0700 IronPort-SDR: kKh3eay7zmJTsSWGmBkpKbLlR/dl8Jje2wou6QtBjq5bSC9z75ZvvrkBFWAwa9Uk6iC1rld+gc 3bmXqdp3dqBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="246470500" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 28 Apr 2020 04:04:37 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 04:04:37 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 28 Apr 2020 04:04:36 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 28 Apr 2020 04:04:36 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 04:04:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UkZ+oSVdE74S6eNwgQuOgnVaOnEbUOsLudnvoXewGaq78hiAy+Nf/inskGdJqUZEeARkitwSYneRzOaSM0z1dLZ2Bo5fDF49PPQqjaX21ehSNLMvKe+DqpAoJ3gN7SEXVp2897ZNoXDWNeQn28J0917El+0i/Zog7mLIhWL7a9LKfAMVk6yrJWGpAkGtZ4TzksX2QS0C1laIMyHTwzALZOWeZzRr+S4zMia9lhMfqcu4iWWRzh9NmPCb9aBVkEKK1I6xJ4rK0uG7hUc/NTYnaJbpQLyCL7ieoyoVzHEHfOEVgGVSeGJRtkQIeghvPskyBg/5tpPyUfUMGuosm4auXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQo1FKud+QfZgax5/3VEVN5jiYwtEf4k6NY/hL9+C5A=; b=gCPNmU/J9PFJf59BULNfa8A9YhluDmC/BOmMpWOtr3tKWOiphLb4R5TWGXX5zfBye1Os11LmSyfZ8L+bUPhAENmV392lVuxAw9rz0LIpn5gZJVmBPAho2XBvldY1lT5lXEZDPoj+qgTX2j0JG1hB7veQt1P8ZxqAAHfnOACUsvB7sCoOj8RFDVAH7afGI6i2q2fo6l+sjtseA8vtEoF3yN3JP/v7xNdKlSakIiRiiqvYLkRu9ZNV4bLJv4MC62/vATLduHC/Pc6CUs0TRVEUdSNTa3dk9QWEDF34Cw7bq6zkZtHCOFDty7nzpnGEB5gM6qrfJGqPRdXFcEtewglBNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YQo1FKud+QfZgax5/3VEVN5jiYwtEf4k6NY/hL9+C5A=; b=o4oHtp9Pub0/ssZ/mO5IT66Ph5nCG+xnYuW4eT2s4QlpGvSZ6ZsreROXLLy6Jw6ifRY/bzl0k2bK/8VkXlgHNiRXg/gvRN5ECQzWQNRO6dskBU+OgoB4XiYAz28/IZT7ur40bHTdOAWDJVhVrXSuHItY9+iO4XYhxSTFeq3a7VU= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3510.namprd11.prod.outlook.com (2603:10b6:a03:8b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Tue, 28 Apr 2020 11:04:30 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2937.023; Tue, 28 Apr 2020 11:04:30 +0000 From: "Ananyev, Konstantin" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 0/4] Enforce checking on flag values in API's Thread-Index: AQHWHOobhKLJbUgKjEWRo+ZHeq+fF6iOX6yQ Date: Tue, 28 Apr 2020 11:04:30 +0000 Message-ID: References: <20200212230810.2837-1-stephen@networkplumber.org> <20200427231625.10135-1-stephen@networkplumber.org> In-Reply-To: <20200427231625.10135-1-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7e09305-7203-4658-a6f3-08d7eb63ed09 x-ms-traffictypediagnostic: BYAPR11MB3510: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0387D64A71 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(376002)(366004)(39860400002)(396003)(136003)(8676002)(33656002)(81156014)(8936002)(6506007)(66556008)(7696005)(52536014)(186003)(26005)(66446008)(2906002)(478600001)(316002)(9686003)(86362001)(110136005)(55016002)(66946007)(64756008)(66476007)(76116006)(5660300002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gneNzFo9PTdGTM5ERclDvX3YC5l+zkrRdLZuGAadHvzrlFgJI5A+4Cxh6r3pM7uJPDpYnxPPLq58NfGItKWM0ENCHJ23tT8Yka2Vturs3Mq8Qx/P18hn4O07TQW9Z5KJpE3h5JbNYUkN1igfHJd31jy9s5UPqgIYXf/mrBrN76kdRFavPcAO+r/boqaxYy3Wn3nKQ/EpGDbQqOJq+pq/WsNpa2IsUjvAKh8feGTT00wL3D3yil9vznXYzs5yjZ2lw9IRRqSz4vEYp/p/EHxlnSUCSY+Sk1JMX3OFdca16+8M1i1cX3wCLsfwMcuTYIp4bLxJ5C17ukuLj4PDgt7q0OOrB2Tf7kiEWkJxcYiNHxR5ochItWDDZ/WOlm4yZ25cQoPMZZCSJGPjOsvBP6vW1bwZiNP/dEws1pv4ystiCE97ij478AaP4GEJi5L+GjxP x-ms-exchange-antispam-messagedata: 1vTzMj8wRxYKt7+5ii/67j7zH+qD3dyyPOFqiWcgZIRMLUcChHH+2YvrWTfyrvWxSnfjv5SINmkm37AC9gibJ/MbYwGWHEGbqjgsV1U8hWYtc5/XEjN0yVgminZ+G5gDMiYqQm6yY1DxpvbauHn9NEEyEPL1XqQmzaH6VYHokmrCU5kebTTAvprMz8G9wkOmgMnBRcuCn7Vlw79gUI0zpXFIplwcoeaahjMjeofwR4SKtYjtQkq1FW2Ac2NyR+e2js9ld9xKLDX0/vGtTAP3W7AFRt3egbq5Pj8sZeNq/ZoLjz2Wehp1nJzvUWBdaApZdNWy22SwiLPM14xBfKqj9KXK+UNXJ+UeByL9tH+8w9K4//kh7kyA0f79jyz+6JM/K7b9MjvvwQqFMgcz/4Z+rV+lHuqFhgTeGJwxsHO49ZEZarB4OBgd4voMMf1JzyTPv28dwHdZcf8pfBUCXxM+u6IObuB2w7g/TBqX/7gwY0QlzD0YBhIeDaB/hQXdji1OuOjDO1UpXvvi+xyWu2T0Espe0YlR0Si26CLnZVMK/gUCxROGzzpNHpzsBM+8NZFUGgzi0/s02VyeKmC678AJd0Hceil1TOfm9RlDEceQlQLyKcqgbahQyk57GgcCXApHUmN+a0rhuBPeVi9dkG4myASt3lI/OQLPKczuRkMeFlyShHAj2RnAeiqu7SsXUPaE4h2QRz1bmSWC0UadFU5gIbpdj1EgrsMEvLSAtjf3I/uZBaaM1RTnFn69BMPOsSRzMddoJAvRkSrYnDjuaDvG2G9K/P8PZWPGq2KD4Q362NHbk0Wc/+ODN4+aAL6WgzD8 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f7e09305-7203-4658-a6f3-08d7eb63ed09 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2020 11:04:30.5837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5MPFrQrNwaENp9UgYbEcxr/F+BpVzQhuY9cRIQ6NfCnQe9eMdaVJSIy+CT3JP0nDr5CHE4J+XMtHB56SDpzwVa2iIf38Ycgi565tRhMcRPE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3510 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 0/4] Enforce checking on flag values in API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > The DPDK API's are lax about checking for undefined flag values. > This makes it impossible to add new bits to existing API's > without causing ABI breakage. This means we end up doing unnecessary > symbol versioning just to work around applications that might > pass in naughty bits. >=20 > This is the DPDK analog of the Linux kernel openat() problem. > Openat api was added but since kernel did not check flags it > ended up that another syscall openat2() was necessary before > the flags could be used. >=20 > v3 - define mask based on existing defines for ring and hash >=20 > Stephen Hemminger (4): > ring: future proof flag settings > hash: check flags on creation > stack: check flags on creation > cfgfile: check flags value >=20 > lib/librte_cfgfile/rte_cfgfile.c | 4 ++++ > lib/librte_hash/rte_cuckoo_hash.c | 14 ++++++++++++++ > lib/librte_ring/rte_ring.c | 12 ++++++++++++ > lib/librte_stack/rte_stack.c | 5 +++++ > 4 files changed, 35 insertions(+) >=20 > -- Series Acked-by: Konstantin Ananyev > 2.20.1