From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1EA5A04C7; Wed, 16 Sep 2020 12:06:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E7501C224; Wed, 16 Sep 2020 12:06:46 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C3BBD1C221 for ; Wed, 16 Sep 2020 12:06:44 +0200 (CEST) IronPort-SDR: T4ZfJ2e0hvpz5XY4A9fhaPx0KLUN3TIdw7AKhtePTrzzDEKmZqA+bV17OXbkAnGXcKxA1fvonZ sUe/Q/2nlWzg== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="147188638" X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="147188638" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 03:06:43 -0700 IronPort-SDR: Xd6uAFcG9WWHw29xu0mIYSgC/9uG0lAvltL0M+EyUyqPqnIWckkDZt0nPEVZxd26WPSDEe4b9r vRTTBQ+YOdLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="483245093" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 16 Sep 2020 03:06:43 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 03:06:43 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Sep 2020 03:06:43 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Sep 2020 03:06:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSrYML5M4vQ+jU8taD3seGuyyTkFWWa4wZ+ENXUFzTnF1JuVK7+M629JDQERLJuJYHJfR45dlI85F8TbIbcUEIVC1jsbDFszaRjSx1tinyqp3f3SaSjCdD8QFxfpK1/RFp+4iI4JWo2DwwwFZfHTq6v3eZKU/0pTNAHxLyeEbPs6bPBUJYltGC3nUn65DMnBGAG8LQGOI7nArocXI443CnrI20re0CJNcvrOydyy7fcMe2bAuqBv+KL9Gcq4o844m/SXK3TGTQ2iqLEMksh7rVapIJmFgUfe6A5r7PkkWMBvn2Pl2IjQDnzNsqfk4n1R3RMzZrLvBD6tyZmGuSDtyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C/qIuN6OfqPXBotFgoCXdXx3jdEI5lu1d8o1UAZZ4I8=; b=VmQaIcd5Zv3X1sRNmNce8x/JqwsTORb7JovfgUw0xI6wrZPxEryny+adiINjCBAzNbKWK+1QmnzGPE4vWOrTe9pXeYokfXnitaDKJpJiAair2hagUsl1fTfb35Wgx5ud+XYTeIbs9pslOCI3hwop2U4r4EykIeNk0HNYA9kF5isrw3oLN2Xpsq4f/xMqoKpkjAXKZ7SBgUEGohLBjsuyoDYmPLn/JPyP6dgjU4ihIbKRtWTI8RmF7Nsni0sPvmGinVhDro5IHJSORFczTfg/MbTrS80xl/skP+Of44KkAOvrEQTfB7N/K0UODlg/GVnzVPJlzFHEGMQwL+xSyCwg1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C/qIuN6OfqPXBotFgoCXdXx3jdEI5lu1d8o1UAZZ4I8=; b=sKStdrC3xakzSMPneFukMYsuWCme0zfFYsTC3NUQERj3kx6Z6JXnmCKC87/KNswjulDHRhwkBO4Y8aSup2cWj/eBP8eBC6whhXPJ5oU+SiaWilJFfK1j7HFOu64W3RS44tEVkirh85VRxBwpXt6teksjciHLcdgmPfVhoOwfPgg= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BY5PR11MB4151.namprd11.prod.outlook.com (2603:10b6:a03:18f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.17; Wed, 16 Sep 2020 10:06:40 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b%6]) with mapi id 15.20.3391.011; Wed, 16 Sep 2020 10:06:40 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , "Medvedkin, Vladimir" CC: "dev@dpdk.org" , "jerinj@marvell.com" , "ruifeng.wang@arm.com" Thread-Topic: [dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify Thread-Index: AQHWi4B1pdWrsRGndUaTN0+uBiNjLKlq+7cAgAAHAACAAAN8AIAABHMA Date: Wed, 16 Sep 2020 10:06:40 +0000 Message-ID: References: <20200807162829.11690-1-konstantin.ananyev@intel.com> <20200915165025.543-1-konstantin.ananyev@intel.com> <20200915165025.543-8-konstantin.ananyev@intel.com> <20200916091128.GA1849@bricha3-MOBL.ger.corp.intel.com> <66917b48-ce20-176a-b90e-dfebdf481d15@intel.com> <20200916094900.GB1849@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200916094900.GB1849@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5714b9c3-110a-4f6c-1f3d-08d85a2834de x-ms-traffictypediagnostic: BY5PR11MB4151: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l+Jb2mBCl8JEsDxUhjDy44+VNQg+tGchPr4pG2dWFJ1QNxGBmJecv5Av03j216quc+rk2roISScj70121LgWkcIlsmiHtVm4Pvh7QO7Yh7ttfmALnzDwigYpdBhqIDlfg7LjLpCJ/8dDkz3NAgB08DeMrl2RegH3Ijtjg3M6gbmnWphWV8aKSBPepjzapRotgF4zLfyMHTrCKzxzUGcmETzemITgSOwT0Z2XI+G7buIX6B+m6YIjKKCW1AZWzSSY+KwFvXHCObOqp7YIAh5pbi0ZHCqi4+aDZXfeASrGRS7QFx5odE2G3wh3PUYw0Yaq4Z/1dUpVRCzOHOMtWjOtgw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(346002)(376002)(396003)(7696005)(2906002)(4326008)(71200400001)(26005)(66946007)(66556008)(66446008)(64756008)(76116006)(66476007)(53546011)(6506007)(316002)(186003)(6636002)(110136005)(52536014)(9686003)(33656002)(5660300002)(54906003)(8936002)(8676002)(86362001)(478600001)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 5uaj6P5NrEbdsL+1sBMRIFe0yh3SIAfKzNz5mNwJ7iWDM4kfiEK069wMAiagqLkvwBdShHdZTxhdPrbkcAQPrwl6bitLx86GuLgkU8Whp3iHgGZnncF+/VzFwPbk8Btf1Qcl6K3zXCCUXXaMH6QuSYz19hP4PluLptcdVPcJjWCJow9gtnRFtLawUAGxWu8YjDSfI+OZQn3Fysqxzr5hmvarRIPAHJxMboEObmt7Hi1Gdi+OrAnA/oEcylBlVKAx10ROa29nqPgkdiMpcL3y21+Gi6bf61HB6ejGx/kjHIXYNippr6czCGEamLNlmVWkn3gvgBkfhwKl6Qv6bYx47jtmYiR1ZvxbUD4CRffpzjXzniyYtLD6LjIB5u3T68Di2WY7F+LGwYTBv9AlDe1tFmbFz1crK4e7EMEXr43grkup/DJB2QafA2xMPUDMINgutbSFznkAAYWtUvxIt7y2WTCNGnl1lgFHbFZkqQPYMPghBzIlByRkmyoLSy+XmRJ2XvrHBV6FF29whAwjoBx779Y/unSI6+YHJ0NU3qzF4fYnvQIulcVD6nxe2y9PDsS9HWpPw7UGEF/8S78HhlGCWzqVvP1UKXViKhxMdvlImGQH22Y7+4ZbGcKa4ujP7ueLmFRCudxBeovN6s3ngDHfRg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5714b9c3-110a-4f6c-1f3d-08d85a2834de X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2020 10:06:40.3579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +EFFMZxclPZFunM33Ak0IlUANhNNs1LljvslfzKiFOMZp1kOuSa83OVv8jLh3J8MgvYadjFcWudpikLmLWxeS1DPT2YO10KTgmWfeS7J9nY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4151 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =20 > On Wed, Sep 16, 2020 at 10:36:32AM +0100, Medvedkin, Vladimir wrote: > > Hi Bruce, > > > > On 16/09/2020 10:11, Bruce Richardson wrote: > > > On Tue, Sep 15, 2020 at 05:50:20PM +0100, Konstantin Ananyev wrote: > > > > Add necessary changes to support new AVX512 specific ACL classify > > > > algorithm: > > > > - changes in meson.build to check that build tools > > > > (compiler, assembler, etc.) do properly support AVX512. > > > > - run-time checks to make sure target platform does support AVX51= 2. > > > > - dummy rte_acl_classify_avx512() for targets where AVX512 > > > > implementation couldn't be properly supported. > > > > > > > > Signed-off-by: Konstantin Ananyev > > > > --- > > > > > > This all looks correct, though I wonder do you really need to check a= ll > > > those AVX512 flags in each case? Since "F" is always present in any A= VX512 > > > implementation perhaps it can be checked, though if the other three a= lways > > > need to be checked I can understand if you want to keep it there for > > > completeness. [Are all the other 3 used in your code?] Yep, ACL uses all of them. Thanks Konstantin > > > > > > > As for me it is good to check all the flags supported by compiler. Some= old > > (but still supported by dpdk) gcc can't compile the code in some > > circumstances. For example: > > > > gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.12) <-- prett= y old > > but still supported, right? > > > > gcc -march=3Dnative -dM -E - < /dev/null | grep "AVX512" > > #define __AVX512F__ 1 > > #define __AVX512BW__ 1 > > #define __AVX512CD__ 1 > > #define __AVX512DQ__ 1 > > > > Does not support __AVX512VL__ > > > Interesting, seems like checking them all to be sure is the right approac= h > so. > My ack stands so, and ignore the comment.