From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAC95A0350; Wed, 24 Jun 2020 12:45:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B75D31D72E; Wed, 24 Jun 2020 12:45:42 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E7D2D1D675 for ; Wed, 24 Jun 2020 12:45:41 +0200 (CEST) IronPort-SDR: R4TNyj7/wD5qcPi2BfK/0ZQIuxBljMg2jk4xGMEQ7KjR9lzbgxwVjrAjcygw22ckPUzmT3Nw6D c3xn3ANOymQQ== X-IronPort-AV: E=McAfee;i="6000,8403,9661"; a="205914459" X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="205914459" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2020 03:45:41 -0700 IronPort-SDR: TfY216DbH+TQqysxtI0soZFVim/UqK1zGfYDGhqwoAzCyrOmRZj3fSRs85nfUScNZL2u8JBUnj HQRGn0J9k7Mw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,275,1589266800"; d="scan'208";a="293503791" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga002.jf.intel.com with ESMTP; 24 Jun 2020 03:45:41 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 03:45:40 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 24 Jun 2020 03:45:40 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 24 Jun 2020 03:45:40 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jun 2020 03:45:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kF2W/DOcI/T2aYOwL8hOFn2bvSs7rWq5k/71mHWQwJNw7wgT87m6CLFDmQ6k/ioZwgppQ3gfzV+AxXlEZkmxLAs82DHOAcUlw1dft49KGOVbZt7f5PP8OFXYZ1eag4iR1xk6ulcIOuckZiT3UxrsYQwY8i2MqBoMMp6ZZSnQobQsmi7OmiqpJOAfl/NO422qAqAd3ZRVMVnziH8N7k4eFCUqogZTRz+XtD3DX6HSSJpip5gyhH3vYv7hkX+CflGEVXevwsAgzMWFeYvbiBoVb7y++fY6tRFjLO5X+uRq4nyH9HGZS60R9WVs/HifVWubqHraYxwh//czmS4TM9JE1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6GvfxrZLfLGGNnu07ZRd6bsgjUi2wUcGeGDULNWzay8=; b=Y1cHngZVdcdBTFxzUaI5gYjCbfNGqub96LEvO4wWkoeIsPEX/k1dVoSjAvrCMRpxRjtJz6oca+F2hvxKqXUndVamSrOkvD2hnn83hWe+PKuYmF++kjXu69qifK+CPzaHvEbYUkXarpsGrYfhoUKADAgacTDZ+40dtarXpYnWxc9MUqc+jQVfztE/7OB3dXXjPdNyfgRxQZUAP8soSHN4vfNkpnrBFtQ8ccPM0UUzHLn5QzoVtvUhTGNdKefNTQM3F9VlrOtkRYsBN9rrdEdMNRJekAMaE+573OCsOa5TtBNawaSajCy9ihrdK/GzmmXBz1Y3oF26j4BZkhqoOGvYhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6GvfxrZLfLGGNnu07ZRd6bsgjUi2wUcGeGDULNWzay8=; b=Yo/zjokANQcYR2+U5RcPv2FyHbna/we779AeMrJNmyEuq/Krl2URRhkzLCJoyvJN2LcSvwB+529/4Irz1oChRerVYmh2vYpgbCacTafhdRLBMoeEF4YT316KaYN414I+wwQmMM+0ALpcKH2RnEhPih5vGYDyN78A7LZShXF8J4w= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3607.namprd11.prod.outlook.com (2603:10b6:a03:b2::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Wed, 24 Jun 2020 10:45:38 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3109.027; Wed, 24 Jun 2020 10:45:38 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , David Marchand , "Richardson, Bruce" CC: "dev@dpdk.org" , "jerinjacobk@gmail.com" , "mdr@ashroe.eu" , "ktraynor@redhat.com" , "Stokes, Ian" , "i.maximets@ovn.org" , "Mcnamara, John" , "Kovacevic, Marko" , "Burakov, Anatoly" , Olivier Matz , Andrew Rybchenko , Neil Horman Thread-Topic: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores Thread-Index: AQHWSJjc02miHDhvs0aJZlTx+B7uGKjkxSPggAEPRACAAFFvIIABW1WAgAAI/gCAAANyAIAACOdQ Date: Wed, 24 Jun 2020 10:45:38 +0000 Message-ID: References: <20200610144506.30505-1-david.marchand@redhat.com> <20200624095606.GA929@bricha3-MOBL.ger.corp.intel.com> <2150079.oGfeyVPo5L@thomas> In-Reply-To: <2150079.oGfeyVPo5L@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.184] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f889b98a-8c07-4e7a-a6a1-08d8182bbbad x-ms-traffictypediagnostic: BYAPR11MB3607: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0444EB1997 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dXy6T/xYhKFH0IjEkUOXUdY6+XUEQIHpY7cOeKWkBirx8VXUNiz5a4ds+Oj5/bJtOjkcacBAzM6pjaWQzs+H/R/UmRyI01FcH5CesK2VM8mq+Mv1xrmD4ejD2tHfHXdAxUx0Myl6AwGWaskoyQViSQg/AmqhppQWh3jiNilo/CrF3PpajkfbY+cRTzH6yiFvjeS9RndfSGDA0u/Bpw7yc9L3x6NvPecInl/EQc5TPG4/DjvjMan/MjEtV/dMtdHLhMw3dCT+sjtnJZIHfFc06KthmeFIgVmwtc6L6dzdlSF3y9Flil0yaXESN3whccf4TEn39JfP7PPplBHbOcg1Hw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(346002)(396003)(136003)(376002)(64756008)(66476007)(6636002)(26005)(8936002)(52536014)(53546011)(83380400001)(33656002)(7696005)(6506007)(5660300002)(2906002)(86362001)(478600001)(71200400001)(66446008)(66556008)(186003)(7416002)(76116006)(54906003)(110136005)(316002)(9686003)(4326008)(55016002)(66946007)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: fgfuNa/MVHJ25pptPvEfLZbxeyko1f7BFWW0doXhX/ZtHsWDLVbJBMugqQAKGwDuoOFCLs9WuN4yCyFHkapHP2umHoRr0hRTsIYxIBeqNhjzq29IY47EvZA8zGXYW6uUsFFxrQK1mmeKhVb/ZCPMKcCCO0wf3KdTPDZHEjhH/ZUSgV9cvzSphbagAXd1Muv+n4VektJcQG5kfTeNtdSKVpDK+9sPwpCeWe8/5TevzDDqKHEe0MKgwkLbXuDH+cxSKsSXLiCj9YyL9BvHwA86OMzf7isO3O9j2+Uvk4+wHWfGx1aHBGdhUhfRC//KZs3ZrnSECU2T+ahSahnddvm8CdqMNHM5Eg0qXPwhAGBqFxbGLSCZ6FeHg6hL5rerGPF0+UC/lBhuSLpyZxr8QCKVtlfy9a5Vh1WMez76lHXdVNaAzBtTmmwg2BFjHb0PYvWB5riTglXMp9YYH2Irv0EaZetM0PxYDXT9kZebHKxHTzJPpOJhJk/kZtunt+Ut8jyM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f889b98a-8c07-4e7a-a6a1-08d8182bbbad X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2020 10:45:38.1207 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u/jLy20U96lKj8WQAtjUivJvHe8/xdLc8scAH3A6u69ZRs5GohiDoBx0D1AKvhdB8XRSSSEEA9vNAfG7HyOxlh8vwQBXTmFibsYPrNQHCDA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3607 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 24/06/2020 11:56, Bruce Richardson: > > On Wed, Jun 24, 2020 at 11:23:55AM +0200, David Marchand wrote: > > > On Tue, Jun 23, 2020 at 3:16 PM Ananyev, Konstantin > > > wrote: > > > > > Even before this series, MP has no protection on lcore placing be= tween > > > > > primary and secondary processes. > > > > > > > > Agree, it is not a new problem, it has been there for a while. > > > > Though making lcore assignment dynamic will make it more noticeable= and harder to avoid. > > > > With static only lcore distribution it is much easier to control th= ings. > > > > > > > > > Personally, I have no use for DPDK MP and marking MP as not suppo= rting > > > > > this new feature is tempting for a first phase. > > > > > If this is a strong requirement, I can look at it in a second pha= se. > > > > > What do you think? > > > > > > > > In theory it is possible to mark this new API as not supported for = MP. > > > > At least for now. Though I think it is sort of temporal solution. > > > > AFAIK, MP is used by customers, so sooner or later someone will hit= that problem. > > > > > > I understand this argument. > > > But then we don't see those customers giving feedback. > > > > > > > > > > Let say, we do have pdump app/library in our mainline. > > > > As I can see - it will be affected when users will start using this= new dynamic lcore API > > > > inside their apps. > > > > > > Supporting lcore allocation in MP requires exchanges between > > > primary/secondary processes like what we have for memory allocations. > > > It will be quite a beast to get to work fine, while not even knowing > > > if people actually want to use both. > > > > > > For v4, I added a check to exclude MP and the new API. > > > I am still willing to help if people do care about using both feature= s together. > > > > I wonder how much we could simplify DPDK generally if we had to enable = a > > specific runtime flag to enable multi-process support and it was off by > > default. This would break proc_info I think, but maybe we could provide > > telemetry callbacks to provide the same data, but beyond that it would = just > > allow us to know whether a DPDK app is actually using MP, or just runni= ng > > as a single process. >=20 > Same thought here. > I like the idea of a "mode flag" when multi-process is in use. > Should it be an user explicit flag or an automatic one? It is probably possible, but that would mean will need to start splitting core parts of DPDK code into two paths: standalone/MP, right? =20 Wonder how much effort it would require in terms of code rework, testing, maintenance, etc. At first glance seems quite substantial.