From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C10EAA0516; Tue, 9 Jun 2020 13:25:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1518F293C; Tue, 9 Jun 2020 13:25:19 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B9C572862; Tue, 9 Jun 2020 13:25:17 +0200 (CEST) IronPort-SDR: n9Z/RxubqeyWSq7SrVTIMtP0ZHBQkwHNIDVQp0bqJKIEPAGi3yxXAsGS2QBfSTHss7srwlwmfH cmsAznzGGYhg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 04:25:16 -0700 IronPort-SDR: 8PwOzhu7R+Re2GdIh2iZe5/tKBB1AHwCn3T2PD/Q4bsLcQF0TbcWct8Pp+wTu2wQFwIR+C7xx5 pyn81BKZfTkw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,491,1583222400"; d="scan'208";a="418375749" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 09 Jun 2020 04:25:16 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 04:25:16 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 9 Jun 2020 04:25:14 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 9 Jun 2020 04:25:14 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 04:25:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LGxpar5QXy+kcZoGmlih87qD+IDXtEdUiHsg3R29cmp4mdFgBBgd8SxoLzzzJfljd6HcS2aCklbfiiOyRIcr86F0jjd8GsYEZkbhCVwn4DAyT0v8K4TJXDX2E77MWH7GRHWgqilhSs86YBL4qjKmZCrdodTYKlLDxPsMOs35VpWDWOpazYweVBe2Ghw2fie7ZhBRBBNRllPFP2WufG60hnZeG5tR7zsLrHv6Ub3gPpSmi9xaBXI3+NlDZkwqKc8HyWfz7/iHmmZJUHUumpg1nbqIHop7C8j/pVgcMUjOthXhfXasokUGF3U5MdaWO77VIUlUvIYamDntT+wCqQgFKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wnUipZQLKplWIvDXcDPGqNumT9wNC2UZ0fpvzpwSp1I=; b=TIgTRjc/Cj+hjVqGGNrDreVmZQM8cNuV0iiPJAT+r181bRCDXnQtG6so+ln0DKC9r8e03Bn1q8SY5nNZVvetgLqoBQGX7NduQsT1otMfs+QMdCTHl6OezKJYnttxBGv6ejQ9V5RYAFFZMg74eZ8e0kf8dZlj7VRpqh+mM7bqc9BWk3tQK/PgeJKAzSbJ/AM8E7eNCmxz6+pRxQBwVHKAP1qbMA56dCBD2vzXOZhypVB7gfimJSYWGxBS48ynQa6tWDUrqrUq29J1o6wX9AqkkJqK+/EjjNP+vk/9xCEGU9bnfR5xKn/jU0Utxz1xCl95kS8jb61z6/igwMq6/PqUgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wnUipZQLKplWIvDXcDPGqNumT9wNC2UZ0fpvzpwSp1I=; b=vCtdZHOm+jL0vFn5VRqCGCMgcXbY1PEAiiL4Ae5Y2sAU2OutXcmH9W1L98+ypoSG3QOlKwtoy8FkxtFQzBbIKF51xjD3BwZQEXJakj5Zx/wMsFv9OpqgoH/vqerJUKgTsTczbrYxeCvYe6P2T+k/cxJ5bMxVgf99ulRPzp3OHCk= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3093.namprd11.prod.outlook.com (2603:10b6:a03:88::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.23; Tue, 9 Jun 2020 11:25:13 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 11:25:13 +0000 From: "Ananyev, Konstantin" To: Feifei Wang , Honnappa Nagarahalli , Ola Liljedahl , "Joyce Kong" , Gavin Hu , Ruifeng Wang CC: "dev@dpdk.org" , "nd@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH] test/ring_perf: fix error statistics in bulk enq/dequeue Thread-Index: AQHWPVnuwzbVP5nHJE+QlTSNuppscqjQIT1g Date: Tue, 9 Jun 2020 11:25:13 +0000 Message-ID: References: <20200608055846.46971-1-feifei.wang2@arm.com> In-Reply-To: <20200608055846.46971-1-feifei.wang2@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.166] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5ea5da8-fd22-4aef-3448-08d80c67c6fe x-ms-traffictypediagnostic: BYAPR11MB3093: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 042957ACD7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZaQU17/kAuNlgBZF5r/x6vgJhAUY4Vm/jWIL38PYM5Kn8885iNdvoMYTYM4ZKmIQwzMFx8+f5ZF+qzyiaIJ39d8eCnVryKTSxvDvrtWfPXtBhS+tsj0cfztrSzJUK49RIpUGqrdLAn0S6IQuKbgl8ltHnnTOlvwOueE5dYNvJ65UorNmYVZxBxc4A5RfOP/VOv8o33KNs1lWW5zJYJDGZ4Uy3P5vlNgXCflm/vsMhgSxfBEkIvRIBWRQa29vXnVSQQkFxo93yhIVFiO75UEuE9t+EfokucLqkp4oFGOTj1FptmsFcjBdVcEj7Q0Oq1w/DwgOvpxVkuwKHpbdk9J9vQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(39860400002)(376002)(396003)(346002)(366004)(186003)(86362001)(8936002)(9686003)(2906002)(316002)(26005)(55016002)(83380400001)(478600001)(6506007)(8676002)(66556008)(66446008)(71200400001)(54906003)(76116006)(33656002)(5660300002)(66476007)(4326008)(52536014)(66946007)(7696005)(64756008)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: y+Slvet+YGaxmG/43GBxH9/BHzr4j0LK4BMiiwdBto36ef6K4Yzvly5Hd9F0KJJ4Duo+GjJeNQgxU1r4pSm8lWOf/tJ3c0U1h/qJpr41TpbR/k+Wsh6lrJmdMWX+sQMCVlFuUpm8kOA/3LaAE5ushxIe36nGo2ASdoZFBiLryPCiF751Jms8hxcCDxbpofaiQ/imA20Lr1iEx2lZ88LtgN5+M6D1cAAFPHxvRx40V/42oL0bK5XsYk7UP6vER0WQk43vYDVtDMX2daG4S9Xg+A7cN/lJz1zfOvphM2HzH8riVUZNqUr+6gomb/b+3OqoLPkLqGoof/2Yjjt4egB7dR4EHqCL/Lp5rSIQcT3WdfJlDmJXBc7H5FK5yNB2AzNrZWdhDbgZA2OKsfWur06AQk7hyAeT7u/e86mqjfyIuAspQsh4slyiLpAQm5EBc5nr6ZTa4GUtkFzsY9/6ZbqP9NM3iUFpfTscL5u42npcsxVEXHPQt83RTgRpVhlTtjQ5 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b5ea5da8-fd22-4aef-3448-08d80c67c6fe X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 11:25:13.0749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h3h/K+sHbwiHH9fpmOrdQdqZBKahBBGQtXU+E4RPsNeui+fF8TxDmABJePHoQTkl+YRLDch+lEPHiQagf7Fqfk61lIK14G6GTV0JHVq790Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3093 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/ring_perf: fix error statistics in bulk enq/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > In size 32 bulk ring enq/dequeue performance test, the "Total count" > statistics is incorrect. For example, running the test on lcore 25 and > lcore 26, the output is as follows: >=20 > The test command: > $sudo ./arm64-armv8a-linuxapp-gcc/app/test -l 25-26 > RTE>>ring_perf_autotest >=20 > Bulk enq/dequeue count on size 32 > Core [25] count =3D 288268 > Core [26] count =3D 288281 > Total count (size: 32): 1066323 >=20 > Fixed it by reset the counter at the beginning of each loop. The > revised output is as follows: >=20 > Bulk enq/dequeue count on size 32 > Core [25] count =3D 285643 > Core [26] count =3D 285688 > Total count (size: 32): 571331 >=20 > Fixes: 759cf9b5632c ("test/ring: enhance mp/mc coverage") > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Reviewed-by: Phil Yang > --- > app/test/test_ring_perf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c > index ee21faf71..ac9bf5608 100644 > --- a/app/test/test_ring_perf.c > +++ b/app/test/test_ring_perf.c > @@ -380,7 +380,7 @@ load_loop_fn_16B(void *p) > static int > run_on_all_cores(struct rte_ring *r, const int esize) > { > - uint64_t total =3D 0; > + uint64_t total; > struct thread_params param; > lcore_function_t *lcore_f; > unsigned int i, c; > @@ -392,6 +392,7 @@ run_on_all_cores(struct rte_ring *r, const int esize) >=20 > memset(¶m, 0, sizeof(struct thread_params)); > for (i =3D 0; i < RTE_DIM(bulk_sizes); i++) { > + total =3D 0; > printf("\nBulk enq/dequeue count on size %u\n", bulk_sizes[i]); > param.size =3D bulk_sizes[i]; > param.r =3D r; > -- Acked-by: Konstantin Ananyev > 2.17.1