From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD931A0597; Tue, 21 Apr 2020 14:05:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F05371C037; Tue, 21 Apr 2020 14:05:17 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 488461C036 for ; Tue, 21 Apr 2020 14:05:16 +0200 (CEST) IronPort-SDR: HWAQBPcKitYHCALD4maSKHfL1uKXuo9LvA/XWCceNhpj/ZGvckw16BXw7gVpHHdtYOdX8e6FCl z5Aps/wpV1fw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 05:05:15 -0700 IronPort-SDR: /cbyC93yXFAn7beQGNaUsqAaXqEIMdYMUMsGx+fDZD26K4tgLOhDoJL/KBYuXf9pCrqRaJE7c8 bbLNH+Pi6MtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,410,1580803200"; d="scan'208";a="429509105" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 21 Apr 2020 05:05:12 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 05:05:12 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 05:05:11 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.54) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 05:04:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUHMGuUrtC9y7fJbgysOYKDFHFa9wHzDNctVw0XuyJBE4EZjLO3v1RSbyo9+FeY1ftC6BTBmV9e+8SDm1Q81k/aCTlfbPCZOYRMb7dIZ/ysE9KzAVsUI1mygOnbPuS/twkut/UOXnzR0qgiphuH37twizEnboRm7WmPSPYq/5o8WZZdXGfPARVm5LP2X++rBGC+aUgfVKl+ztHRSayTn/yiTui+rp4DFjDrU/t9kUWVtdii2dsSQdPzASuUzrhHCHbqbfL7zFAouSWdOkhUyB/2Bdm+GQ+ZLMIGyDB3FCyvET+mCZnlpa4h12DLAEEjyNocPu6L+WuVwRaJRRfc2mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8x2/j2vnUznRB+SvycHR8DUzZxMyI/HXewvtMufUa/0=; b=Eih6w9NaZ8026COzV47wAOSmesqgrohUVJSq4RZqYUWpST4XEY5qcpAli/FdVIGmytoC9A7dbcqa/deMzS5fViyUUQCElZLvYXJowUdrC6AT/2OYJPeHGzKlL82/HOjl4eOlMo6C967Tnev8rjCebQ6s9WY1g31jAOWJrqGFmWRatiF4Cmo+T3sAc5zWkSqiqCL9sQ+QfxrYVWgIw0pBx2Gd/x5FTiSY1jL+Z/w1Yphvrj91S9XAcRmWMfetGGh2wpxtw/AkxFWY6VHNMXTUWx8zhvi3eH9XkrgIWkA06WO3ZwqZhJNZUhUOA2X8gNdfUiBF6MJTRz7l19PhEN1h/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8x2/j2vnUznRB+SvycHR8DUzZxMyI/HXewvtMufUa/0=; b=dMOTOyDyQvYhe0Sz5rOym6B+Eo2nMReoj4Dn0EmFQ7tfO23wlFIZIg5B4OxFFhZTATEorawMXjVWOrROw8lowHLbAon031HFns1Ut6EVhXTuQ9mWrnc2lFIFbW7Y0tNEwEnqjskQMWeTCd6wQ/MrMetUH8GZmw820VB7pm9IacE= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3830.namprd11.prod.outlook.com (2603:10b6:a03:fc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 12:04:52 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2937.012; Tue, 21 Apr 2020 12:04:51 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon CC: "akhil.goyal@nxp.com" , "Dharmappa, Savinay" , "dev@dpdk.org" , "david.marchand@redhat.com" , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance Thread-Index: AQHV84Ylsw/O/CpaU0iRJqvqsLWuBqiDImMAgAABvgCAAIFEcIAAAr6AgAAJ9ICAAAzHAIAAApHQ Date: Tue, 21 Apr 2020 12:04:51 +0000 Message-ID: References: <20200305071523.30952-1-savinay.dharmappa@intel.com> <42905568.fMDQidcC6G@thomas> <1827889.yKVeVyVuyW@thomas> In-Reply-To: <1827889.yKVeVyVuyW@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 129e1827-83c2-4abf-15c1-08d7e5ec3296 x-ms-traffictypediagnostic: BYAPR11MB3830: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(376002)(366004)(346002)(39860400002)(396003)(136003)(64756008)(5660300002)(8936002)(81156014)(8676002)(66476007)(66946007)(76116006)(55016002)(6916009)(66446008)(7696005)(66556008)(52536014)(9686003)(54906003)(6506007)(316002)(2906002)(26005)(186003)(107886003)(86362001)(4326008)(33656002)(71200400001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g7zakHMznfmjangfwOtH09N3IvAMf7ts8T+g6/WyFybbaELMaOt6PhAy855p1Rzs77nwn4VN4NipsJafbypUTLc+LNeoV8DsL4UG+yNAyIILrcfB4WcnY22rXBb829Z8bvyrefbFfbBKUYxlQIzDWYNIkkvpVGc9/5dMVDJklxFOUs9ZNUrxZrTNQEQCo5LQ2wvW4vhaDL/652dciDhcGpp6+F8zeSvfthWFQcHjwHAiJaaPj8kywtmh+bW7wn3Zv97cDKgZFuhCRqUU/lMzu8yIH0kaAeYFdVCEfB1aUD9Ovufpfr+ecKkz08OA7zto1nid+5cDw5glRPnM/sRWI1FSs/xmxYR48A6i0VLwzYrcEuSHi9w2mZR/MsSo+xob6knzvgtDBPJR96PHXcEdFisS23xYVhmmqBgcW2PuXf+/NecC6DlXCY0Kr5rpiACw x-ms-exchange-antispam-messagedata: eZo1Wsbuy4R9KhUF3nVh8w2zxVp4GR+55CSIe7pGyvlZ4gjqD/RwcnB5X9RN/Y7HopTS2BJMWTPFRT6NlF9Cp/8+/aRZhe/sMTW3PQ+WvYnkTQK0P3rFLovtQcchHpYRw/h45SNszRlUlg4yHs/ltg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 129e1827-83c2-4abf-15c1-08d7e5ec3296 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 12:04:51.8564 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ISrJ0i1o52ZONDkbn6K9HVXj42bwlalC3TF68VSpr9ZQwvalUdoUbVVI0nYpbv/FmrTuIL+mb/qXckfuCqbLkUNlqWA08ApXkTfLNsgteXI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3830 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 21/04/2020 13:07, Ananyev, Konstantin: > > > 21/04/2020 12:21, Ananyev, Konstantin: > > > > > 21/04/2020 04:29, Thomas Monjalon: > > > > > > > --- a/MAINTAINERS > > > > > > > +++ b/MAINTAINERS > > > > > > > @@ -1259,6 +1259,8 @@ F: lib/librte_ipsec/ > > > > > > > M: Bernard Iremonger > > > > > > > F: app/test/test_ipsec.c > > > > > > > F: doc/guides/prog_guide/ipsec_lib.rst > > > > > > > +M: Savinay Dharmappa > > > > > > > +F: app/test/test_ipsec_perf.c > > > > > > > M: Vladimir Medvedkin > > > > > > > F: app/test/test_ipsec_sad.c > > > > > > > F: app/test-sad/ > > > > > > > > > > > > Repeating what I said on v3: > > > > > > Having one different maintainer per test file is quite ridiculo= us. > > > > > > The maintainers of a lib are expected to maintain the related t= ests. > > > [...] > > > > About having separate MAINTAINER for the test - > > > > honestly I don't understand why it is a problem for you. > > > > Obviously we would like to spread the load - what's wrong with it? > > > > > > This is a problem of ownership. > > > Maintaining a library means you take care of every aspect, including = tests. > > > That's why I would like to see you as a global maintainer of IPsec. > > > > > > It doesn't prevent you to delegate workload, of course. > > > But at the end it is more convenient to know there is a limited numbe= r > > > of persons responsible for the global quality of a component, > > > a person which is accountable and answering questions on the topic, > > > no matter which exact file we are talking about. > > > > Just talked with Bernard, he kindly agreed to be a maintainer for all i= psec UT: > > app/test/test_ipsec* > > Hope that will fulfil your concern? >=20 > My concern was to have the library maintainer maintaining also the relate= d tests. > I don't understand why you don't want to take this responsibility, > but I cannot force you. > Having only one maintainer for IPsec tests is better than the current sit= uation. Ok, are you going to drop v4, so we can submit v5 with the fixes? Or should we submit a patch with fixes on top of v4? Konstantin =20