From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF5CBA0540; Mon, 13 Jul 2020 14:58:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE1CF1D708; Mon, 13 Jul 2020 14:58:07 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5D8711D69D for ; Mon, 13 Jul 2020 14:58:06 +0200 (CEST) IronPort-SDR: JdzrzVBBl0QurmU8t6R14BxyN881vknIFNA3eFnVLB/X0on+h8bfzYq8hiSfElcBld8FEtOlI0 D472IFGjmXnA== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="166712503" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="166712503" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 05:58:05 -0700 IronPort-SDR: jPZx4un+GfabIXL0sRdINK87wvaTJtVKJzlCG/sVvOJUfX7fXRHIvW6eeTfLYDMF+Zt0OPhyQ/ iVUxOCZous5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459282959" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga005.jf.intel.com with ESMTP; 13 Jul 2020 05:58:05 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 05:58:04 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX155.amr.corp.intel.com (10.22.240.21) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 05:58:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jul 2020 05:58:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YbtYGPHcxkLUnEBKXi0tuBaU4IC3MRGnpNk7m8ZhaZPOOqk55uqx6QtXt2CgmR/aFs+iqkKks3HSCa0H32tqEtF8VYZpeYShjqgWdIHJDwOq1oIIgD4T7VyUQq/luJbRywDqX0ZmoL6NMnnQp1aZaZ+ovXtHMyimKWf2RW2NA7R0tPQ6tftrL6DiDcKV5HuHwRXA7cf704EhXr6f19PZ8Skjl/lf57Qb/1J1Aonr6IM1cYj0qORKSY9CnixITGZiDWNHd4FWFJ//Oc4IcaRQL8GhF+aqNjUWYZEYKGNUFPGbEWVM1NZGGn90luiSxZX6JFgs/yguOMd6q13aqE9Owg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAYzwNC3YU5dPC12ZeoRWRqukgz5UI5Jaw0KU6CLxsQ=; b=ZWFQT3rHHPz/ZspmvM8yOz2U3hBQTOn1v0/x91slq6+bTK9jjjVsGiNJ8J1zNwlksuxtEBgE0eviSwq/T5FI8m/kQOtRoxuiQbleRy40fYd2OqIR69v705vNHSRYv5QbRlMBvE714Br2xSMwYU3k04/X4IndibfmjP2VMRyzm0MdQ2x1SL1ypTRu83u5zuQd+6LXhYZMONRgq2Eqhcm23OyjpkLyQKNQDNaoIJ8qBQv70ASqbG7i/7o7uZ7H4h69/dnvSNSNqVSM8a2hjn1q7AJJj38ix6o0W/kZT3el42g1zeOqrCciSUUVoJ8tjVZcUncmIsFJSV8CqMwK8WjDCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAYzwNC3YU5dPC12ZeoRWRqukgz5UI5Jaw0KU6CLxsQ=; b=dG8YO8VOwVF19jSsg6Knar9lOCj0nvFNRBbJdUveYt8UXeHEDbgz8CHQHNZlTe2FqXRyrBkFbpEtDrLGJrZrGO4hFMMwkqH0M/B5R4a5v3bGCW0R+BsgrUbNvY0xJujfpkn02LZJ7ya/L8SoTECEpSVybKC37/2JccND/FEyx8g= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2598.namprd11.prod.outlook.com (2603:10b6:a02:cb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Mon, 13 Jul 2020 12:58:02 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 12:58:02 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon CC: "dev@dpdk.org" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "jielong.zjl@antfin.com" , "Eads, Gage" , "david.marchand@redhat.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v3] mempool/ring: add support for new ring sync modes Thread-Index: AQHWVtY1EBxf3/b4hESX7uB3hkTR3akBaaiAgAQSZpA= Date: Mon, 13 Jul 2020 12:58:02 +0000 Message-ID: References: <20200629161024.29059-1-konstantin.ananyev@intel.com> <20200710162119.27653-1-konstantin.ananyev@intel.com> <40884900.fRxCVIVvzE@thomas> In-Reply-To: <40884900.fRxCVIVvzE@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDA4YTBhYTktNjY0OS00MjQzLTg4ZjctYzlkODZjZDIxZWY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibis5aGtsVHJpY3kzSU5vdUtcL1FFdXJjXC9rZGdJR09pMEZ1TDhOYVlET1d0TDlLbHpFdHg5VGMrc2M1ckRjYUtHIn0= dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.38.224] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1cd01b7-f9d1-4855-f24e-08d8272c60a9 x-ms-traffictypediagnostic: BYAPR11MB2598: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5uraWyGqIH4Ds4bmKJh6A0lehon0OWgCj4wZjNUg2odM+v1AK4VGp+GPqnXoKGeqxL1pr5Z84qB2n5SRCJKJDyy8XaApz+x01dDLBlSE5raNaGFhRKM9bkiOFrakq+EPPNS8qNUs1Us6FR2K5rpQ6dkHSMFGQGkCdY08uoYAr+vxBt/dJ9I42gLdSSKx0rNT5IDffEOoedjUWn4dr5FQVg4XJ30LhZOl4bDh6MPH2NHilA/Chynse2VbKgylwyrpXjlH3+tYB5cpBe/pZ4U+zr30FGwApGIbgvwBLJjWh2KLg75kAVTbhS4EfDgKEvmqg/7yC2Wajdua8zbKuo9Fye2/huhHKJsUc76vGNAybHSBguglkSScXO+ivgTa3QRaNRTQ46ao6+tJAVE/rj6Elg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(5660300002)(83380400001)(52536014)(66556008)(64756008)(66476007)(66446008)(66946007)(6916009)(76116006)(2906002)(4326008)(71200400001)(86362001)(316002)(54906003)(8676002)(966005)(186003)(8936002)(7696005)(6506007)(26005)(55016002)(9686003)(478600001)(33656002)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: rDaV+OzRwiBRL3T65re4Vhik12JFL8s/L/RzTNouid2pl991JWiRcEBXbMi5orUAFXkAHOWlthwkXVEo9mPrb1agn/lGfJJ0OfDQWwpN1y39ZP94CnMIn+UToxiAPRCNCGz7rGklruXZtjLxq9DcSihFecWwuXw2jFmuQfTKvKWkgOQgMKVJDFR2rhvFXWWEP2bOTfjzp3XTJyQMpGNGgOlw7tOVIF+F3RumAjxrUeWrG8i7RLI2Anz4dj/lbJD+zrZuw8wQjR+Guwlmv3qpnmfsEYuxOw3m4xKBukWXMfKNB56tDNKiP4HknxZUNqhTC6NSW/yLTKZPio6EbMQ0zUFhZvREpAScfPlg8sEjXz2NF0oYH4d/5/AK2v+BzWxeT8OM1/Ix0bvojVNVchJmjvlcA/XVlSwXKTbP4rtC+9xyGMMToY+dZInb4DHDdV0uonprmY4db8odbaSyMFPHJ4zVKfPuTJCOmD5R6uWD6TQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1cd01b7-f9d1-4855-f24e-08d8272c60a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2020 12:58:02.4980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RApnMDT7LHutzX+dH4q+J5RwFf79CUs+sGEhVVKBixDzCxWaIFdbR7nBjBff98A0eeTp+oCOWFbrcEeGpSxM9gTu1fSJ3smAd4NCrRxz+b4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2598 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] mempool/ring: add support for new ring sync modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 10/07/2020 18:21, Konstantin Ananyev: > > Two new sync modes were introduced into rte_ring: > > relaxed tail sync (RTS) and head/tail sync (HTS). > > This change provides user with ability to select these > > modes for ring based mempool via mempool ops API. >=20 > No, the user cannot use these modes because there is no doc, > except in release notes. AFAIK, there is no section for rte_ring and others SW based=20 mempool drivers: https://doc.dpdk.org/guides/mempool/index.html Are you asking me to add such section as part of this patch? =20 >=20 > Sorry I don't understand why I have to do such obvious comment > after so many years. > And more importantly, why nobody else asked for doc? >=20 > I think I will add "UNMAINTAINED" for doc in MAINTAINERS file. > If nobody is interested in doc maintenance, we could "git rm doc/". >=20 > Sorry in advance for hijacking this thread. >=20 > [...] > > --- a/doc/guides/rel_notes/release_20_08.rst > > +++ b/doc/guides/rel_notes/release_20_08.rst > > @@ -171,6 +171,12 @@ New Features > > See the :doc:`../sample_app_ug/l2_forward_real_virtual` for more > > details of this parameter usage. > > > > +* **Added support for new sync modes into mempool ring driver.** > > + > > + Added ability to select new ring synchronisation modes: > > + ``relaxed tail sync (ring_mt_rts)`` and ``head/tail sync (ring_mt_ht= s)`` > > + via mempool ops API. >=20 > Please check the comment on top of new features about the ordering. > Mempool features should be mentioned earlier in the list. >=20 >=20