From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57627A00C5; Thu, 7 May 2020 13:12:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A83CE1DB33; Thu, 7 May 2020 13:12:53 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 364F01DB21 for ; Thu, 7 May 2020 13:12:51 +0200 (CEST) IronPort-SDR: gzk55jFzc4Kt5ogaOLlrvqsNQvvLc/ncUxgKUuto4QBZ4qFlm/rhpGwMHUUQEZj3sM6hfVC5wb 96eN4oLslCww== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 04:12:49 -0700 IronPort-SDR: Os3ye3KD2qnZCEJ9ptTx19vJHDC/QGQh0ia/BnFk9eMW7EvgAgOrk/Air52bNOZ8dGcccSxfdW PbieUk1fsJig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,363,1583222400"; d="scan'208";a="263905052" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 07 May 2020 04:12:49 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 04:12:47 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 04:12:47 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 04:12:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gAXeK/Bozd3+k7vD8X+lYai2ZM3EACCy/yJ0mLqzZYJfRYdb/n53Dm3b3KIcmRIQrs/uNfo+Gf3KSzRwSVxjZfB3lUV74HKxJySMKC9IvTQ2D7i1cZgH6gaygZSEmOCTQfPqkhu31lUnkUwlLRq7Xmu3UG96Y7L5sSvp/dIHhLUBQJlNKgf8JOqU2BQONVLFUmrfGROvUQ0b7jkM0KhqZ9WQWGaas9utRtIT6A8lcJkeN58WGl6YU39UzSsWQ2K8aefwOe1ngGl8hbkSRl8QF/5HYegsgDNoJcpQeL/W6Vh13dqL7OWRN63qH1yB58tpJDVk40Z5p8ot85nCXmggUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10D/iSeBsa1kBo64oOAKcP1A3KA5LTgGKZwKze41T/A=; b=Oo33HyJUURliji/kvxu+dRL0UfdaNCTEE36CeUh7XiyJvGj9K+jO3I1FwHdMm1AAUzvHnxpORYEt665R9AzjDmmUPUGVR4DJ20AWVtdctuE4gspFmyEFhXI+Unc/cmY8FQcbM0HehfcOumWiqem/fy3UzJvTd29TRnMmP8I1vA8lvULZnZ2S7Ze0Hq9ce+M7W45cWhnazyPSxYR5eLCZDzfdx/E9Fhg+4FQ1ZGYg5/WNDiahFTB0LAwd2xknEK3e8eqlJ3XzfTP2YggJvRqe0mkA7JvJglS5RFULfHVXkHrtIQWVzyCH+F3LdhWewNoL+MdmiEr2p0kjS1JMn8MXEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=10D/iSeBsa1kBo64oOAKcP1A3KA5LTgGKZwKze41T/A=; b=bGuiB5bemwHEljjQHy2mlaWLl5egjVIVwUSC7KKcqpCIHGaZbsuQvvsEDcgzsoJwBhnxkLiXmnPQDHq52cPtUpOF2bvzzvnSFGSzxGWfyxyGr1HLtEj3XO3lot5mytMkD4cftsDMqaggyD9UThWGLjvj3ovdKkaaVf4rWFy+ABw= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3160.namprd11.prod.outlook.com (2603:10b6:a03:1b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Thu, 7 May 2020 11:12:45 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2958.030; Thu, 7 May 2020 11:12:45 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , "dev@dpdk.org" CC: Ruifeng Wang , "Feifei Wang (Arm Technology China)" , nd , nd Thread-Topic: rte_ring work Thread-Index: AdYj2/yEUDvXLCvbSjmLQfkOx8WHHgAfYkpw Date: Thu, 7 May 2020 11:12:45 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a02b4cb-c1cb-4638-5b7d-08d7f27791a8 x-ms-traffictypediagnostic: BYAPR11MB3160: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F2io2f8GJ1ALBh2MuHLLace/ptDjfdbt7rZAG0JZZqKiVF/vOc8m/8Pizqrf+aAcpntHqijE6xoQZJPZc6Gg8FdGEOgssxrwmqotJa8RwlRzV2RKDCWsOlgmuGemJt4mwCbPNbj2ADVW0373rS7x2F4ijNkajsByzsOzFwLazY41CVXNC64FRcZ29Zux0pqJ+uOfJ3YOVfnuSCf0ozbZeBAcEF2+Cv+LdPxQ45rQmfcLr+fgbdFgcrjv+cWloaGRwUvRY05ouYp2bwFQe6hMjizwBiEx9/CluQBGotsPAQ3okEsPsE0fFU6bWKiqyyqUC1r4HjLTUU/jdA52ToBV0IpnRVlK8JkiNSMDsiKuMRByohO3TzWow28nzztXZR8q2ONecSwOB+tY67WuJhfq17R/kFwfu/itFyfaZYqgXPxqfZGWA/EZMrbOx8XA0bH1tpGyxYcj3Pi6UVgfGY66DSF1UCE1L5z3CdD/pmmBRDDRNJ7dBxDOJ0j5tRROr6ED9k/QxCUxChjihXPJlDZ0NGy9xDiYDBP4FpPzlTkbldwGlK/ISFf15Y3nrfZhRIQN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(346002)(136003)(396003)(366004)(376002)(33430700001)(7116003)(33656002)(2906002)(186003)(66556008)(6506007)(66476007)(54906003)(9686003)(66446008)(76116006)(26005)(66946007)(64756008)(110136005)(55016002)(7696005)(86362001)(71200400001)(5660300002)(4326008)(8676002)(8936002)(33440700001)(316002)(83280400001)(83320400001)(83290400001)(478600001)(52536014)(83310400001)(83300400001)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: P1Y1uK9burcNXTafb2PnFNywojHBC0G21lRGzkd++HBp/XwMGnVLZRL949kr11fFqenQrA8yi4BBnZeGoPighfuHMQ+0Js+aKUjLKMzc0+1t4pYI2qDJY6qccjm5k/ZdycUyQBaXT39LIAtsDcjwNFX/24nNPpdNfzxB400HA+k4TToHAk262KBz8wIDuWy+Gc96yIqa+eYNc4S3ay1/5N1PoYOSlNWLQy4L7hFTOr4+dUvpWrWwB+5wF5nZisitFVwsh9v/RmaT68KgBnNW62oSB3rtEYiWRrKWrqu+Tp7il4BQ4DEaTzfd98FhPs/sQXqWJv8Jy+U7txSU7IGDjtJxpqi+2CxFlxhCTU3gedASKf4bQFa4vcJIWsvr7Qme0AFqYxTZXiwhkrhlUPBIWPxxP0Z85ZbSwF2+Lu73H/6iDBbKk+eLYMFKkUW23OY3JdIu6MzPzfUGO3PCX/VbrM7Ks8rsqYhA/USdvQmlJiLFt6F2Fayq8okoI2jfS8JT5YZVv2EZpLVrVv70xIlvAMMu1N/wi4J1S6dtCX4SCNNrLDQaBanBuxi3zCstMeEjgO3L8fG4mv9c26Nuf8UMJe+zMF4ORCg68q9fDwxqfYD6SPrTR8p6q5mKX5EFjwQNHAy6xzTl2K4qcr3w/R6kerUs+SPAJMEaQ7wq/UH531dTy4dmO4TAv+SaMIvkaB8ytUkyHS5PE3mD25ggaAtZMajuUDSFsGQiJ/vDaVfCbZurFBd6+G51P4fA2+KvnfA+0pDY2r/tJzzm7w4nOK8QuF5sKHNrrfarTGqtZaM1li1yaHWoRdHoUy4cgsxlFQQT x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2a02b4cb-c1cb-4638-5b7d-08d7f27791a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 11:12:45.3345 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sjnAIV3YBBYvnSztLppoLW1ETEjLWUgDOddcWqvATcdOaHWoX6P6/Ec9iSDzFq/ZrIm54DS06IOCZp0uDRn4reMSw75i35zsCfbejw0g43E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3160 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] rte_ring work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Honnappa, >=20 > Hi Konstantin, > Just to make sure we are coordinating the work on rte_ring, I plan to ge= t the following things done for 20.08. Please let me know if > you have any comments. Thanks for sharing your plans. In general, looks reasonable to me. Few comments/questions below. >From my side - I have just few rte_ring related plans for 20.08: 1) Try to integrate hts/rts ring mode into mempool_ring (new flags for memp= ool_create or so). 2) Use peek API into crypto/scheduler PMD.=20 3) Plus few ideas how to improve ring performance in particular usage scena= rios.=20 Don't know yet would it boil to something real or not (might be new sync mo= de or so). =20 > 1) Remove experimental tag on rte_ring_xxx_elem APIs - they have been aro= und for 2 releases now. > 2) Make the legacy APIs use elem APIs > 3) Check the possibility to remove rte_ring_generic.h implementation. Thi= s can be done if the legacy API performance between the generic > and C11 implementations is not much. > 4) Peek APIs for RTS Due to nature of RTS I don't think it is possible to implement peek API for= it. But might be I am missing something here. BTW, do you guys plan to continue with WFE API adoption in rte_ring?=20 > Some cleanup activity (assuming above things are successful) >=20 > 1) Remove the detailed comments on top of the internal functions - it is = hard to maintain, the parameters are already self-explanatory > 3) Files need some re-org > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, rte_ring_peek.h - will ha= ve legacy format APIs written as wrappers around xxx_elem > APIs > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h, rte_ring_p= eek_elem.h - will have xxx_elem APIs > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h, ring_peek_= elem_pvt.h > - these will contain the internal functions including the c11 functions= to manipulate the head/tail pointers. > The files with xxx_c11_mem.h will disappear. Make sure private functi= ons have __rte prefix Basically you'd plan to: a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h b) get rid of rte_ring_generic.h Correct?