From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 219CBA00C2; Thu, 23 Apr 2020 02:11:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCA451D167; Thu, 23 Apr 2020 02:11:29 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D94741C2F9 for ; Thu, 23 Apr 2020 02:11:27 +0200 (CEST) IronPort-SDR: Agd3NOLlkH3h93iVa1CO6Rhf8vkYL950cxMKVaHCOszJAR1gEIppWS/QEoEtN9E4oGnebZPnza MYK4JYm3TJRg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 17:11:26 -0700 IronPort-SDR: oo0XEuDufRkuA6id4Fvm9HGOSeUr0tRb7P7J7xQpBC8KPfeDZ+VvFhE2cbuYvvfGxsiQiDE5Ub hhmUuaf3e0MQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,305,1583222400"; d="scan'208";a="430119870" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga005.jf.intel.com with ESMTP; 22 Apr 2020 17:11:26 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 17:11:26 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX163.amr.corp.intel.com (10.22.240.88) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 17:11:26 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 17:11:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dw7A3Rx1qNoQbT0r1Rdw7LzfJr/TMRW9dD0BBwCd+ODIMEwTmb1vw5uTjcco53+A/BfWaiFPmCErMKOLUkf5SuuBuljsJQmKSUbDZonsc0rZrGe0QaHVUkhD0X4kyrDgxq0Xyp5D2QReYcIqoTGVsjWY+smS2y0OhS4qAosVjV1joa2W0RiCASyWzZs/zHgmAyyMa8/rBXu/TVe+5KNrmXLI3YBFPToV3ztAdIAo8jz1tT+ocVU19AxhAZOdFT9fHkB6oWMPA+WZ/5U6/NvZ22yT5+xDhlNcmPhGpyqpw6K6aB3nlhbj6ZBLp7sBeB4yFoh1YcsZ1i4SYdasOqQ3Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1kMaEvfXqK2WNh/7tPbmZyGjvYRyAhR11vBqTRADY7Y=; b=Uh5pAfjlNI8iFCRu0DGcwsoBEPpVisaNX55JJxd7CGvkRNAHIpmMAvCHI3BuLpc1Cvc8wsdsTU0uN/cpifIg0OlCzSgZVTpeMqR/DV6ErSkiYl/2eImmjrw+sigWBLFguHTan2S2LmIpUyBKZ+8MLVVbXxAOsiTZGrwF3kiwJwS713OU0LEgj+Z18QW5SoxyLW7kCO+MYQPjqopLY4CW9GIy59e5MEAD3I3/vO2UDnTC2UmFdT2gC2DRh5yowwspihlewLA8FHcrWuie9TnXoyrsLWyIUGYDQJjqR7bkDsrVrb6XYUcgAknYRbavSF6DFX03Ye7QsuJzP4riRIgvKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1kMaEvfXqK2WNh/7tPbmZyGjvYRyAhR11vBqTRADY7Y=; b=ClUbYQhghs+nUKxPZJUH5IoXm0EXJ5xuGmFGFtyz19KlhGbJ7I9ntolJMcRfDFk9K7yqEyuHrv3n0bFHR7B836l3iqhSOb5Jx2Vdgm/nykLBulKoqxBbcWDS4t3RPvDE3UCVUX1HQzntAvkKq+n+vmZxAUoyaoDgqHbbkD/RFCI= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3656.namprd11.prod.outlook.com (2603:10b6:a03:f8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Thu, 23 Apr 2020 00:11:24 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2937.012; Thu, 23 Apr 2020 00:11:24 +0000 From: "Ananyev, Konstantin" To: "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Doherty, Declan" Thread-Topic: [PATCH] security: fix crash at accessing non-implemented ops Thread-Index: AQHWGQEm/kkoVgGeo02OiaefHqVr66iF0/QA Date: Thu, 23 Apr 2020 00:11:24 +0000 Message-ID: References: <20200422235158.24497-1-konstantin.ananyev@intel.com> In-Reply-To: <20200422235158.24497-1-konstantin.ananyev@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.180] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c3c6aa13-2ced-4d12-85ef-08d7e71adc6b x-ms-traffictypediagnostic: BYAPR11MB3656: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 03827AF76E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(396003)(376002)(346002)(136003)(366004)(39860400002)(15650500001)(66946007)(6916009)(81156014)(186003)(26005)(9686003)(55016002)(71200400001)(4326008)(76116006)(66446008)(53546011)(6506007)(52536014)(33656002)(2906002)(66556008)(86362001)(316002)(8936002)(54906003)(8676002)(478600001)(5660300002)(64756008)(66476007)(7696005)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U/f5fRWbH0hc+w2kODvkxGU+U/HFDiT8oprRYgkbFzYsw+iTPa4OGWTrPsAEOk7vHjPKvrShOe8mBp9pq8/i4NpJu2tDf0zQG74sATPBn4HTRQcpgcdmIsfwy44oTeK+kbz7FzGfHlh3m5vkDOrxuo5EgyiRrcz6D4FeewGJxhdUdgFkQoCv0K/xv2gakhNRyDpH35y6I0+U9vMVklr+jt+4x2gfSYyS3TfLu3CU9xtpy60qNViLSUB8FWgVRLZF3UjZHkUydWpSm8q+mVh5/oOD/2IqO2pFt/8eNInV/ZWLbSeJLExCF2HD8OrTWXxeJFfgOzmxE6t3RbWXEaw9FL23EeeVugziaLFm6QEMlAKbbdoWkIpld4dV8dd1Vb84DkR+HJEZI2UiLxyAzXrOa/Be5iixmSr4RWjpJqYCIoU+k985od7O8YtsQ/hKd9G/ x-ms-exchange-antispam-messagedata: nBE6QH1Qpp/pvpHbJW99+pcvYiEGEndT+6T6CdA1vLkQlpdUOWUTJLy+SWc71NvmdnFZ8tQgzO7imqH8+GUtAbTRFe3JG9nQZLshT1eZAlswERCwvGWYi+7CfiSkUB7QgN69N1P9uAP04IZVmKXeJQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c3c6aa13-2ced-4d12-85ef-08d7e71adc6b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 00:11:24.8465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kXH5j6HFAXkLDD4xt/cq2QQBwQiXgpMqS607PNzi7rE5fY5PPrs+kI8UXfIriZugSu6uozu6tTb6UcEOSkp7VFDcYoakSAmbEfQQw+vZNj4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3656 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] security: fix crash at accessing non-implemented ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Actually looking at app/test/test_security.c I also see a few '#ifdef RTE_DEBUG's. Let say: +static int +test_get_userdata_inv_context(void) +{ +#ifdef RTE_DEBUG + uint64_t md =3D 0xDEADBEEF; + + void *ret =3D rte_security_get_userdata(NULL, md); + TEST_ASSERT_MOCK_FUNCTION_CALL_RET(rte_security_get_userdata, + ret, NULL, "%p"); + TEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 0); + + return TEST_SUCCESS; +#else + return TEST_SKIPPED; +#endif +} What is the point? Why not always run the test unconditionally? > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, April 23, 2020 12:52 AM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Doherty, Declan ; Anan= yev, Konstantin > Subject: [PATCH] security: fix crash at accessing non-implemented ops >=20 > Valid checks for optional function pointers inside dev-ops > were disabled by undefined macro. >=20 > Fixes: b6ee98547847 ("security: fix verification of parameters") >=20 > Signed-off-by: Konstantin Ananyev > --- > lib/librte_security/rte_security.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte= _security.c > index d475b0977..b65430ce2 100644 > --- a/lib/librte_security/rte_security.c > +++ b/lib/librte_security/rte_security.c > @@ -107,11 +107,9 @@ rte_security_set_pkt_metadata(struct rte_security_ct= x *instance, > struct rte_security_session *sess, > struct rte_mbuf *m, void *params) > { > -#ifdef RTE_DEBUG > RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, set_pkt_metadata, -EINVAL, > -ENOTSUP); > RTE_PTR_OR_ERR_RET(sess, -EINVAL); > -#endif > return instance->ops->set_pkt_metadata(instance->device, > sess, m, params); > } > @@ -121,9 +119,7 @@ rte_security_get_userdata(struct rte_security_ctx *in= stance, uint64_t md) > { > void *userdata =3D NULL; >=20 > -#ifdef RTE_DEBUG > RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, get_userdata, NULL, NULL); > -#endif > if (instance->ops->get_userdata(instance->device, md, &userdata)) > return NULL; >=20 > -- > 2.17.1