From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F123A04B5; Tue, 27 Oct 2020 18:43:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F5D92BF4; Tue, 27 Oct 2020 18:43:11 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id DA2652BEA for ; Tue, 27 Oct 2020 18:43:08 +0100 (CET) IronPort-SDR: k2cncHiNygMec+oVqJjr2NLM7CTa8LMsiwFCDrFKWfHHiQ9a1eYLLAqHGw3b5CBMIxagtzNKaw nbn4nUvxR6+A== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="147415799" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="147415799" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 10:43:07 -0700 IronPort-SDR: A7714dQBTuGA1iSpfobQ4FMmTqI7oWfGQZUTBZaOHrYaEMH6ZmXxXx4PfQfk2QkRptwh8+ANKK Pn0HCjy+X+Bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="355628423" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2020 10:43:06 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 10:43:06 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 10:43:05 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 10:43:05 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 10:43:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dlns/N0XdzwpkxWOVffJ80+9eFMROwmzYAlMIzBbKJVD5ngVGV/yqbIkNw2QBDqTMIqrlxbPHvtn+8bYKSNPUf3X8AFpjyt6UpDXaddQ2aBoL6xOdD3l04MmrnpnIUDFnHK9duP/grfmOeBPPDyg67DQkXRl4u1ptEqBZHL49CIOzSSSuKLA0yzG8fOIbsLcIm66xu27+kqXgnpCDrhoPcwi/tbOUYEAks/47qwK/sCmDCGz7SGVEdtkIVB/+An/cUNWc2LTqkyTdUS1HJ8t5pkBOB6vfpXYTmyw7itZU1/0UgqjdL1ANbmwV57W5r7GVIUTIPuNi2ogYhdlskGndg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3jtm9ui7aARx4g5+A6dGzInZh6/AsmIyViPnrDzN4c=; b=VqFMm2EfutKfeU20YcFOoT2N1i6JZakX3nGTaE+WqxtDjpET1w+2LZl0D15SF4X/8oGHCzigSyLVZs6kTXrndK9dJMbC3Xv/WgzCEi/amjLaTsn68EH/E+jMX/wxKm45v1Gbi/rppHbuBuqBEKFqpvlpAL0lrMOI0vZQW5csV2/odqZ1yZvLH45im8m7ScYB+4VP9Rh6GP3UPiOED6tJUe9c/HErp3pODPKZlbxt2HMCydZlHbGnltKVAZAMhxTHSK8gP9lDE1NlYW8lpuIEHpNqX0i6lr4S2xawcs8/9Hyviiv8nlOtEUzvgxNYlJq+K5tOfsVOPmbjfBVjqCeAhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p3jtm9ui7aARx4g5+A6dGzInZh6/AsmIyViPnrDzN4c=; b=jpSX7LJ/wO7Mzi8+C5F+j3G8VU97s0bX4v2G+B2e71wcf6x+X9c8Laayr84Bh774UK3hJFmwO078tqZO7kO4ZUYfgBHOjSStc5vbOLVIzvOEsLbC0q7SWY7GUYSXmYCaZ8tA9tUIL8tloZbaITveYwlWL+7IOmIOlsLHsbKTtHo= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by SJ0PR11MB5071.namprd11.prod.outlook.com (2603:10b6:a03:2d7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 27 Oct 2020 17:43:02 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3499.018; Tue, 27 Oct 2020 17:43:02 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , "Ma, Liang J" CC: "dev@dpdk.org" , "Burakov, Anatoly" , "viktorin@rehivetech.com" , "Zhang, Qi Z" , "ruifeng.wang@arm.com" , "Xing, Beilei" , "Guo, Jia" , "Yang, Qiming" , "Wang, Haiyue" , "Richardson, Bruce" , "Hunt, David" , "jerinjacobk@gmail.com" , "nhorman@tuxdriver.com" , "McDaniel, Timothy" , "Eads, Gage" , "drc@linux.vnet.ibm.com" , Andrew Rybchenko , "Yigit, Ferruh" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "viacheslavo@nvidia.com" , "matan@nvidia.com" , "ajit.khaparde@broadcom.com" , "rahul.lakkireddy@chelsio.com" , "johndale@cisco.com" , "xavier.huwei@huawei.com" , "shahafs@nvidia.com" , "sthemmin@microsoft.com" , "g.singh@nxp.com" , "rmody@marvell.com" , "maxime.coquelin@redhat.com" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v9 04/10] ethdev: add simple power management API Thread-Index: AQHWqZE3z65AkE+Fe0eVJps/s0I8camnOIaAgAQZLQCAAE1zAIAAHTNw Date: Tue, 27 Oct 2020 17:43:01 +0000 Message-ID: References: <1603494392-7181-5-git-send-email-liang.j.ma@intel.com> <2168123.9p5K5TOhLB@thomas> <20201027111504.GB15973@sivswdev09.ir.intel.com> <3195982.LjJ4KgG7bb@thomas> In-Reply-To: <3195982.LjJ4KgG7bb@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da8f229c-d11d-4bf5-2831-08d87a9fc08e x-ms-traffictypediagnostic: SJ0PR11MB5071: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jcWBROgVStLsfYDLjU99/Gg7vkv1VveDfNL91TQMIMvkihebMq6sIlO04i1rvApYxpKDZQ2TktPeaGEvNCmiuWj9gUxrfFNZhtd+E8DHZmJx/0CZUqwpecBHSs4eoVH7YQnwBEtLd3qvXb1XNeokxmwo4SXI9UxwqTk02YV0MyKvsr9g0weTw1TkRq+/dyGgEO7I3n+9EjH2m2REk5YacRbJmMbR+ZJiInRF9kD6Yoa9zv42h8E2JARgddvmMvsGAqa/qgEZ/nYESC8x+StVggxi2aCvb3laCF4R+HmGT1h2tseV+FKD2dezRFTWX9tawZ9zraEvCXyilJYNEiBQVA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(9686003)(76116006)(71200400001)(7416002)(66476007)(83380400001)(26005)(7696005)(8676002)(2906002)(6506007)(33656002)(8936002)(4326008)(66556008)(186003)(110136005)(54906003)(64756008)(478600001)(52536014)(6636002)(66446008)(316002)(55016002)(66946007)(86362001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: rryvZeMI+sqfUwXwLiraYNuw2eNRBzxhIF6osx7THZDI+xFmsA1+WLRDLXXE80hSJSqMyxmW6917YxHHn3dgS2aW0G0Z7R4Z9YTm9lhUYcldJYLj70l8MN1O4TJbNP6rXYZvFuj43dW3kVFtDgazFjaexiqJQzjnSqdnKNOnUlhwGnpLIroMUalECZC5i+xDltLkGSB/teq2rqMMnhg7kcGckl9qMrndpLOTxAjySV5CSDe8FVbLiC9/UJSxeq4S5x3Rlw1ZcLEb/qucX6Vy2RgPP02Itnr/rY5VkSWV9w4jcYkvkf/gjwXRkveCY9rMPTiEZ/hBAF6l1afvD2GPaexV486Y8HzVPOY/ke2Azdg/JLek0GGeMMiT1x/c6rVd7PkYXWjN0C86VnsiFqUCaU9LTMlRHFcbXkzeP1gSZAH6Kf7tDmGte0L2QK7Rcgm9ydCm4dMTbJx7VBFBznUB+uEJIHG5+MEIBc8AZhR8H7bqaf5ZX52jjXFqeVteUivuFprUgW7oTH3/2iDNulFAPnG13wcxjM056Ol0Ohz3eDpDzMJln7tQ1IrfE4HiNrMRAVNFKP5jmTgdRrXtJsrKkHfDQ6XHeUdjQHLc9lWQKtEtR8Il6DiQ7N1n6ZFaeedF2F4FpQJB5aMrBud7jS93Bw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da8f229c-d11d-4bf5-2831-08d87a9fc08e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 17:43:01.9377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OY4svD2yORj6kMGGopdlokNFAFVBTWpFcFJftcaSGG6c71WyX2ZKQPDmZl7Fwm4lnc2b0vOAE37N+JhuXnyqjfudLWB0lp4WmIenB3YGcws= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5071 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v9 04/10] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 27/10/2020 12:15, Liang, Ma: > > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > > +/** > > > > + * Retrieve the wake up address for the receive queue. > > > > > > I guess how this function should be used, > > > but a bit more explanations would not hurt here. > > agree > > > > + * > > > > + * @param port_id > > > > + * The port identifier of the Ethernet device. > > > > + * @param queue_id > > > > + * The Rx queue on the Ethernet device for which information wil= l be > > > > + * retrieved. > > > > + * @param wake_addr > > > > + * The pointer to the address which will be monitored. > > > > > > This function does not make the address monitored, right? > > This function only get the target wakeup address. that does not monitor= this address. > > > > > > > + * @param expected > > > > + * The pointer to value to be expected when descriptor is set. > > > > > > Not sure we should restrict it to a "descriptor". > > actully that is not limited to a descriptor, any writeback content sh= ould work. > > > > > > Expecting a value or some bits looks too much restrictive. > > > I understand it probably fits well for Intel NICs, > > > but in the general case, we can imagine that any change > > > in a byte array could be a wake up signal. > > > > this parameter doesn not limited user how to use it. > > In fact, current design can support any bits change within 64 bits cont= ent. >=20 > How the driver can specify that any value change should be monitored? > I understand that it is only a value/mask pair, > it does not give room for "any value". As I can read the code, value=3D0, mask=3D0 will provide you with 'any valu= e'. Though it would mean that rte_power_monitor() will *always* go into sleep, so not sure what will be there any practical usage for such case.=20 Konstantin