From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD834A04BC; Thu, 8 Oct 2020 13:39:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FDFD1BDDC; Thu, 8 Oct 2020 13:39:43 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 523EB1BDD9 for ; Thu, 8 Oct 2020 13:39:41 +0200 (CEST) IronPort-SDR: e4r4834c89CK4/TrSJeE4f0s8lyYdTIsPIiOAtK8vwSYw4Zljhi0b6PEOUL6enxOcYtIQ2CN4Z olU5PNAHraCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="250015145" X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="250015145" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 04:39:39 -0700 IronPort-SDR: LxC4q1iji2I2C9dHcI87op+yZ5vAlLgt2ujare/SHYcsqrR68uaAf588VnDHu4pZ4F+liPrV7A KnOKtTyU5uVw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="312186001" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 08 Oct 2020 04:39:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 8 Oct 2020 04:39:38 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 8 Oct 2020 04:39:38 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 8 Oct 2020 04:39:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LeUWnqyQk3GzddxAUnaqHA9uAas2rw3ZLbSuNd9zFy4S4jk24T9JaQi/NShwnjXT+eWd8QUkfwIk5coGaiMm4g76xE7qjI5keacogq6qeO5VvSeDiUEVBxCVSC7xI7hJ8PyBkrxYSRIdZ8KPKW3nw4eQasMX3sYsIAIvTlC6fnwzJdT7jVsQg2UmTRQ+7uaxhAJBaLYfOIngl5x3F/KpTuRLvK5pKkicsAoF8XNWmmR7TgQnmjont+CznLxKFK4F8rH2AtAU2CuSnTx+iT1lAo2KnbasfN/pOv5kXsgcAaatNlmvz1jCLa6BJoTChlGFBsB8K1Ca3znx4CsKfqFxTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NLAymzx3iFc9NxJPGp7RVO1GobQH86KfYAlil5RET6o=; b=dKNLhwv84VJuJ5L40RBB/wAalKLtzJPzA7ImY/EEU8U+6EStO9krtWclSSiDGdzUXz0P4LTklSPSIpAdqxr0SQejX7IVqnQ2S/kVviubB95SCnzyulHMfdW2niZ3JYEEmmMxJdFQ30f17iZ5ZxAMG4EAjaLHFvnpfCK+32jedEtdUlnj4TxPGnhhda7vDU0KXrBREIGDI/Eq76yc2l6wAFlfeq4VRwviP+wOItXuTku7UFBBolYx/bIz2Kw8HcrYdG4lSar/JlmO1WNdekhJcylRq4QTwZUu60ukAHuUg1oFx1K9wg6w5ikEcrz2i0Vuh1soHdg6p0L33D0BfW6X9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NLAymzx3iFc9NxJPGp7RVO1GobQH86KfYAlil5RET6o=; b=oo12msaIfxasupYFdqfb0IKTFCu6n3q18BGvyamAVLoB2xmjL73KYy3V1PXfKEnVGrr/rwVWARcAtHOf2Q1jLh8tYSDtK/BBnX3xOejkdNTrDtyhTvBiFhF7etjWvMmi885wqK1/Iq4cJaYI3kPnh54EUJ8W0gU8tbFUVh3xwkg= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3766.namprd11.prod.outlook.com (2603:10b6:a03:b5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Thu, 8 Oct 2020 11:39:34 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3455.023; Thu, 8 Oct 2020 11:39:34 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , "Ma, Liang J" CC: "dev@dpdk.org" , "Hunt, David" , "stephen@networkplumber.org" , "Burakov, Anatoly" , "Ma, Liang J" , "Yigit, Ferruh" , "arybchenko@solarflare.com" , "honnappa.nagarahalli@arm.com" , "ruifeng.wang@arm.com" , "jerinj@marvell.com" , "David Christensen" Thread-Topic: [dpdk-dev] [PATCH v4 03/10] ethdev: add simple power management API Thread-Index: AQHWmMYP1YIY4HfankenulenmkAl0qmNbX+AgAAtVjA= Date: Thu, 8 Oct 2020 11:39:33 +0000 Message-ID: References: <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> <1601647919-25312-1-git-send-email-liang.j.ma@intel.com> <1601647919-25312-3-git-send-email-liang.j.ma@intel.com> <21651717.U2su3LxMx8@thomas> In-Reply-To: <21651717.U2su3LxMx8@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89a2e92c-cf82-453a-a284-08d86b7ed423 x-ms-traffictypediagnostic: BYAPR11MB3766: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FfWRPxhRmFXJN6ISDkP4+e5beqxNg2B5P8qX+l9AFm1WWTgkJYBoPDArt2moz30I6nlKEtxH8vGluz32MsVH8H7+n8GLlYOJ0bkz71gRqpdzVhY7CgjYqTjfE7j5rr4+Tol/JCMV594gIEF1ltikNpCI45aBJLmrw+K9aOCCvZBv133Yuenp80HLIa+Yz32hqs6tWWx2v0MDHnVYcrA2xpvPpO9kgieeSyldHvz2V0vuzyZaFNtmL2fdGR3BlJlos5fHV1tGzjys6fCeciUjuuB6Zx19HDW+ZneNEzkVUXgq+R/QEVbN/7qIbInJmHnM9poObsrlfS6FcVNQ+K+Row== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(8676002)(55016002)(33656002)(5660300002)(52536014)(26005)(478600001)(83380400001)(6506007)(7696005)(71200400001)(186003)(4326008)(316002)(54906003)(8936002)(76116006)(66476007)(66556008)(64756008)(66446008)(66946007)(9686003)(6636002)(110136005)(86362001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: j7OsocmBJVqeydErSnkFVL13/U79bbTmza8D4VeM0DGPYoFzKfbmzIPL4gyAIQ+DMNt97Z7ew9RIQ7d4mzqu124gloaZHdWxoCLYGhYzuVjfhZ7zZbwJ3ObZEDgdqWCekBDVm2HmYSzp8zAcrhSJXyU8LIA7UC7OzZq2YIXMp7YOTzU01DI8bq/yBt5DZaPjbmQOYQL2HqW9u+m0Rfpuf5dDfdKwlwcvR9u0JxLLwFmrMIeHlP1+hHeBWHM0eJvHc5NzEqjYllq+wDzQJH3/wal6MlgjTJOXlmEH8DYq9sYzggH9c3axRWOWlrIASIP/fiaFE4CdHL8lFR3dLypFN+9YwbPwtjFYdF5an2oUcHoVYJCsjfoUnu7/22NPCT/UH+IktMcQRXiNVmP9WyNJsZ7I4zirYsarYzCwfK18iArCgzruLIUuWeoPHC/ROFLnuQhUPdrWc6RtWMfH1DYTSd2nTaRsp+D9HG58rpfkmzKXmzHsGiJElcfWa8pY3IB1MucedYl0DjXurpynEcbr7VphmEwYEAoIY19rmTJZuxYt8jZ4UdhXpWjGEgfACXWztmrSt1MbQUhWdBjuxQp6F5OcgmfKwtt5lYb92m9otdaW87JPgTH01jnbd8Vc3NHaML+Fl9Jo7M6/3kD1Mn1MUw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89a2e92c-cf82-453a-a284-08d86b7ed423 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 11:39:33.9393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qcACz1NGV+Hxd94T07o5PMRKuIGaMFiY/LaCPy3GG6HemM7xKgMdi6rUm3ak2PTwiswiLLyBqdpLIQxChCGVnogA6+6TGI/IRIfNCuWM/ZM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3766 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 03/10] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > +/** > > + * Retrieve the wake up address from specific queue > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param queue_id > > + * The Tx queue on the Ethernet device for which information > > + * will be retrieved. > > + * @param wake_addr > > + * The pointer point to the address which is used for monitoring. > > + * @param expected > > + * The pointer point to value to be expected when descriptor is set. > > + * @param mask > > + * The pointer point to comparison bitmask for the expected value. > > + * > > + * @return > > + * - 0: Success. > > + * -EINVAL: Failed to get wake address. > > + */ > > +__rte_experimental > > +int rte_eth_get_wake_addr(uint16_t port_id, uint16_t queue_id, > > + volatile void **wake_addr, > > + uint64_t *expected, uint64_t *mask); >=20 > It looks to be a very low-level API. > Can't we do something more "ready-to-use" at ethdev level? I think that series provides both: There is a low-level API at ethdev/eal to retrieve information to wait for and actual function to put core to sleep. Plus there is a high-level API at rte_power lib: rte_power_pmd_mgmt_queue_enable()/rte_power_pmd_mgmt_queue_disable() that uses these low-level ones and puts some high-level logic around it. >From my perspective it is a good design choice, as it keeps all power-related burden inside rte_power library and provides user a lot of flexibility in terms of API usage. Konstantin=20 >=20 > Cc'in the relevant maintainers... > Note: sorry this comment come late but ethdev maintainers were not Cc. > Reminder: having no feedback is not a good sign, you should request comme= nts. >=20