From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Anoob Joseph <anoobj@marvell.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>
Cc: Narayana Prasad Raju Athreya <pathreya@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats
Date: Wed, 13 May 2020 12:42:49 +0000 [thread overview]
Message-ID: <BYAPR11MB3301B14C6CC649FFBBB0F9C39ABF0@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR18MB2877EF900C77F2B0583E4859DFBE0@MN2PR18MB2877.namprd18.prod.outlook.com>
> > > @@ -1099,6 +1151,10 @@ ipsec_poll_mode_worker(void)
> > > const uint64_t drain_tsc = (rte_get_tsc_hz() + US_PER_S - 1)
> > > / US_PER_S * BURST_TX_DRAIN_US;
> > > struct lcore_rx_queue *rxql;
> > > +#if (STATS_INTERVAL > 0)
> > > + const uint64_t timer_period = STATS_INTERVAL * rte_get_timer_hz();
> > > + uint64_t timer_tsc = 0;
> > > +#endif /* STATS_INTERVAL */
> > >
> > > prev_tsc = 0;
> > > lcore_id = rte_lcore_id();
> > > @@ -1159,6 +1215,19 @@ ipsec_poll_mode_worker(void)
> > > drain_tx_buffers(qconf);
> > > drain_crypto_buffers(qconf);
> > > prev_tsc = cur_tsc;
> > > +#if (STATS_INTERVAL > 0)
> > > + if (lcore_id == rte_get_master_lcore()) {
> > > + /* advance the timer */
> > > + timer_tsc += diff_tsc;
> > > +
> > > + /* if timer has reached its timeout */
> > > + if (unlikely(timer_tsc >= timer_period)) {
> > > + print_stats();
> > > + /* reset the timer */
> > > + timer_tsc = 0;
> > > + }
> > > + }
> > > +#endif /* STATS_INTERVAL */
> >
> > I still don't understand why to do it in data-path thread.
> > As I said in previous comments, in DPDK there is a control thread that can be
> > used for such house-keeping tasks.
> > Why not to use it (via rte_alarm or so) and keep data-path threads less affected.
>
> [Anoob] From Marvell's estimates, this stats collection and reporting will be expensive and so cannot be enabled by default. This is required
> for analyzing the traffic distribution in cases where the performance isn't scaling as expected.
Understood.
> And this patch achieves the desired feature.
Ok, but why not to do it in control (house-keeping) thread?
That would achieve desired goal and keep data-path unaffected.
> If Intel would like to improve the approach, that can be taken up as a separate patch.
This is not a vendor specific part.
You making changes in common data-path code that is used by all ipsec-secgw users.
I think it is everyone benefit (and responsibility) to keep common data-path
code clean, tidy and fast.
If we can avoid polluting it with extra code, I don't see a reason not to do it.
>
> >
> > > }
> > >
> > > for (i = 0; i < qconf->nb_rx_queue; ++i) { @@ -1169,8 +1238,10
> > @@
> > > ipsec_poll_mode_worker(void)
> > > nb_rx = rte_eth_rx_burst(portid, queueid,
> > > pkts, MAX_PKT_BURST);
> > >
> > > - if (nb_rx > 0)
> > > + if (nb_rx > 0) {
> > > + core_stats_update_rx(nb_rx);
> > > process_pkts(qconf, pkts, nb_rx, portid);
> > > + }
> > >
> > > /* dequeue and process completed crypto-ops */
> > > if (is_unprotected_port(portid))
> > > diff --git a/examples/ipsec-secgw/ipsec-secgw.h
> > > b/examples/ipsec-secgw/ipsec-secgw.h
> > > index 4b53cb5..5b3561f 100644
> > > --- a/examples/ipsec-secgw/ipsec-secgw.h
> > > +++ b/examples/ipsec-secgw/ipsec-secgw.h
> > > @@ -6,6 +6,8 @@
> > >
> > > #include <stdbool.h>
> > >
> > > +#define STATS_INTERVAL 0
> >
> > Shouldn't it be:
> > #ifndef STATS_INTERVAL
> > #define STATS_INTERVAL 0
> > #endif
> > ?
>
> [Anoob] Will update in v4.
>
> >
> > To allow user specify statis interval via EXTRA_CFLAGS='-DSTATS_INTERVAL=10'
> > or so.
> >
> > > +
> > > #define NB_SOCKETS 4
> > >
> > > #define MAX_PKT_BURST 32
> > > @@ -69,6 +71,17 @@ struct ethaddr_info {
> > > uint64_t src, dst;
> > > };
> > >
> > > +#if (STATS_INTERVAL > 0)
> > > +struct ipsec_core_statistics {
> > > + uint64_t tx;
> > > + uint64_t rx;
> > > + uint64_t dropped;
> > > + uint64_t burst_rx;
> > > +} __rte_cache_aligned;
> > > +
> > > +struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; #endif
> > > +/* STATS_INTERVAL */
> > > +
> > > extern struct ethaddr_info ethaddr_tbl[RTE_MAX_ETHPORTS];
> > >
> > > /* Port mask to identify the unprotected ports */ @@ -85,4 +98,59 @@
> > > is_unprotected_port(uint16_t port_id)
> > > return unprotected_port_mask & (1 << port_id); }
> > >
> > > +static inline void
> > > +core_stats_update_rx(int n)
> > > +{
> > > +#if (STATS_INTERVAL > 0)
> > > + int lcore_id = rte_lcore_id();
> > > + core_statistics[lcore_id].rx += n;
> > > + if (n == MAX_PKT_BURST)
> > > + core_statistics[lcore_id].burst_rx += n; #else
> > > + RTE_SET_USED(n);
> > > +#endif /* STATS_INTERVAL */
> > > +}
> > > +
> > > +static inline void
> > > +core_stats_update_tx(int n)
> > > +{
> > > +#if (STATS_INTERVAL > 0)
> > > + int lcore_id = rte_lcore_id();
> > > + core_statistics[lcore_id].tx += n;
> > > +#else
> > > + RTE_SET_USED(n);
> > > +#endif /* STATS_INTERVAL */
> > > +}
> > > +
> > > +static inline void
> > > +core_stats_update_drop(int n)
> > > +{
> > > +#if (STATS_INTERVAL > 0)
> > > + int lcore_id = rte_lcore_id();
> > > + core_statistics[lcore_id].dropped += n; #else
> > > + RTE_SET_USED(n);
> > > +#endif /* STATS_INTERVAL */
> > > +}
> > > +
> > > +/* helper routine to free bulk of packets */ static inline void
> > > +free_pkts(struct rte_mbuf *mb[], uint32_t n) {
> > > + uint32_t i;
> > > +
> > > + for (i = 0; i != n; i++)
> > > + rte_pktmbuf_free(mb[i]);
> > > +
> > > + core_stats_update_drop(n);
> > > +}
> > > +
> > > +/* helper routine to free single packet */ static inline void
> > > +free_pkt(struct rte_mbuf *mb) {
> > > + rte_pktmbuf_free(mb);
> > > + core_stats_update_drop(1);
> >
> > Probably just:
> > free_pkts(&mb, 1);
> > ?
>
> [Anoob] Will update in v4.
>
> >
> > > +}
> > > +
> > > #endif /* _IPSEC_SECGW_H_ */
next prev parent reply other threads:[~2020-05-13 12:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 4:50 [dpdk-dev] [PATCH] " Anoob Joseph
2020-04-23 13:07 ` [dpdk-dev] [PATCH v2] " Anoob Joseph
2020-04-24 11:14 ` Ananyev, Konstantin
2020-05-02 18:43 ` Anoob Joseph
2020-05-05 10:45 ` Ananyev, Konstantin
2020-05-06 12:47 ` [dpdk-dev] [PATCH v3] " Anoob Joseph
2020-05-07 16:12 ` Ananyev, Konstantin
2020-05-12 12:14 ` Anoob Joseph
2020-05-13 12:42 ` Ananyev, Konstantin [this message]
2020-05-14 4:11 ` Anoob Joseph
2020-05-08 8:08 ` Ananyev, Konstantin
2020-05-12 12:16 ` Anoob Joseph
2020-05-13 12:12 ` Ananyev, Konstantin
2020-05-13 17:45 ` [dpdk-dev] [PATCH v4] " Anoob Joseph
2020-05-14 13:47 ` Ananyev, Konstantin
2020-05-17 14:39 ` Akhil Goyal
2020-05-18 3:42 ` Anoob Joseph
2020-05-18 7:06 ` Akhil Goyal
2020-07-01 19:21 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3301B14C6CC649FFBBB0F9C39ABF0@BYAPR11MB3301.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=pathreya@marvell.com \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).