From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CCB3FA04B6;
	Mon, 12 Oct 2020 17:28:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2CE641D8EF;
	Mon, 12 Oct 2020 17:28:39 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id D84D11C01
 for <dev@dpdk.org>; Mon, 12 Oct 2020 17:28:36 +0200 (CEST)
IronPort-SDR: FG82IPuFOsCzcTjXdg1TSrnFSuQM6L/W7dIBoNN6Ms9XZi4WTieEJ33GXA4rT0SmCZ5cji2MBq
 lpPsC201Ukhw==
X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="162290271"
X-IronPort-AV: E=Sophos;i="5.77,367,1596524400"; d="scan'208";a="162290271"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 12 Oct 2020 08:28:33 -0700
IronPort-SDR: GcjbXCcVGnL1v/r2iJgedbS1EkeR8r6996C1Akusz+/6a2C80ofxsKOjz33MlLf5w3i0UvoS08
 /h+vVEtrvfkw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,367,1596524400"; d="scan'208";a="329787377"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
 by orsmga002.jf.intel.com with ESMTP; 12 Oct 2020 08:28:33 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
 fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Mon, 12 Oct 2020 08:28:33 -0700
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
 fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Mon, 12 Oct 2020 08:28:32 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
 via Frontend Transport; Mon, 12 Oct 2020 08:28:31 -0700
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by
 edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.1713.5; Mon, 12 Oct 2020 08:28:27 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=ZIPjeQUkGOGFgFwLyYHDaledJZcmn53tLWp3LXX/N6bUOtvcMwEfO3SWbrnSHzrF5uBbvlIB/hg9NHqBiuhZt44O1t9098hDkYqlQSByETc49uep9wnC+VEeNWx7FQTdYOLzKg/HD8mtxeuFSP66FmkiCUUl5flnZ7cDIFBovMcVGwcspn4dgTChjQFiRpjI8EpMzfHm7H/MRJFbtNCIjmBuZ5srSfe6/UMcYOtMFHSZniSHxX6hPTaTCPdwGXdqEtAHFCTNpeZjE4OM3+XOFHSs7gFNFCM8iPL9kG+mk1XUhrQ1Nv+0dEfGzfqAV4Tvw766rJG9QzdY2O0Z0B8CXA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yomb7Am1LcWDoJmxsQxhVFKcwhYO1P67zHqDPrI4QQc=;
 b=WpcLh2LOM0hzB/fgfyUjgoUDW5OgTg1kkFOBBitbojliiwfzx1NBpdsaVzAnojx4p8OrCObSFQVU7sbxuRSMAu6vINl2jvQsR/2S5VhvswMS+UIdyn+G5ONGHVjVdi3++bWB0MCBRnZlCa9GUUdl+/LFFayBpqooXP1DCZrQUOC4kI1/iryhIhGZ+wRYGg/sv4ks19NDCltLu5b3J/rQ8NlZcUy6qDUvw57UdlgcZyHP0i+jDdW/ShDl/3lbHPV9NYb9/PQa5HXsLa7P9/hzCbKyggU06MsTIcbBuoiEI2DjCSk7VTzOP+2gcsRoFIzhaA599qK6CMaOilvLqkvdDg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Yomb7Am1LcWDoJmxsQxhVFKcwhYO1P67zHqDPrI4QQc=;
 b=OgqHve2Z2lSYhr+2OBM2W+nyW4iIzyuLBMnQx1WlmY0JOZKhFOynUCGuTzC98hp0c4ammI6whEu+QrQeLThVaNFNxHPYS+FN4JsJQSd5yH+bYorO6gXtjmb9oxoyy9qqpXtVBjj9zEI6vVgUXF60U9kOZy8YgPgiqPCiYDt0nvY=
Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26)
 by BY5PR11MB4242.namprd11.prod.outlook.com (2603:10b6:a03:1c1::28)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.28; Mon, 12 Oct
 2020 15:28:21 +0000
Received: from BYAPR11MB3301.namprd11.prod.outlook.com
 ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com
 ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3455.029; Mon, 12 Oct 2020
 15:28:21 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko
 <Andrew.Rybchenko@oktetlabs.ru>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Slava Ovsiienko <viacheslavo@nvidia.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>, Shahaf Shuler <shahafs@nvidia.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "jerinjacobk@gmail.com"
 <jerinjacobk@gmail.com>, "maxime.coquelin@redhat.com"
 <maxime.coquelin@redhat.com>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>, Asaf Penso <asafp@nvidia.com>
Thread-Topic: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split
Thread-Index: AdZ0vX26iflBD6P5QjC0iZ6rubHz2wYVc4aAAq8mKXACKQeeAAAB7r+QAAuoYQAAAGdmgA==
Date: Mon, 12 Oct 2020 15:28:20 +0000
Message-ID: <BYAPR11MB3301B8E47E7ED80403FE80219A070@BYAPR11MB3301.namprd11.prod.outlook.com>
References: <MWHPR12MB136076E652230CEBD6EE6562DF5F0@MWHPR12MB1360.namprd12.prod.outlook.com>
 <4d4be3cd-e418-00cf-ce6d-51f6c3e5c078@oktetlabs.ru>
 <MWHPR12MB13602B0C1E0EF3C134130064DF070@MWHPR12MB1360.namprd12.prod.outlook.com>
 <8304375.31BPq7MtOA@thomas>
In-Reply-To: <8304375.31BPq7MtOA@thomas>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
authentication-results: monjalon.net; dkim=none (message not signed)
 header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com;
x-originating-ip: [46.7.39.127]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: bee39f1a-c5b3-49e2-f577-08d86ec373d3
x-ms-traffictypediagnostic: BY5PR11MB4242:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BY5PR11MB4242CA3CD631550626A6AA8E9A070@BY5PR11MB4242.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: YurenLhBTcR9zyEeenw/GAwnTWqti6i9o+yHmZDFCYJcpjT/WEGbkCZWoFbB4tkeZcKzXIjKA3WMRiInLE/J5rkthABD7b/QdXvqAb8MjWWMUTcHhb/HwXAFRvCGMRB6W4vRhyzx6qRrdE4thQ5PtzPDb/egN9DcnaQ7JAi8Uq1jN75aN/A5Q3E5pCY3dWQIitsAPftuCjdLDelu/5cP21M8HAJn3Gbx8lSa3PGJzquQ03kV75wsk01yg5tmQHz0AGyQnBKZg+IbdJX5AL8uBtupRPMFsRktX3zTGu7/Thy85bwWqZRue5QaEanYD1YnUszEg1OSAjE9pDBOiMt7qw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(376002)(39860400002)(346002)(396003)(366004)(136003)(478600001)(76116006)(33656002)(2906002)(52536014)(86362001)(6506007)(55016002)(316002)(7696005)(4326008)(8936002)(66446008)(8676002)(54906003)(66946007)(186003)(5660300002)(7416002)(9686003)(71200400001)(83380400001)(110136005)(66556008)(26005)(66476007)(64756008);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata: t6Zs95H/VegjXbfeF7sn0sEa3xt3rcn7HmC7eTyNYWq/wMYJdXUeeR5qVJb2zqJc+f1/0fhExgdaqJLQJdvBlaUoniELXpc7M67TGsIQanMzUSjn6K0/TPiIyfQ6gYU6W+LC5ODX3ggoDJ+8hr1uaJU8SbHGWthR75yrgBUTfEwY5GrI7TZnd2MKAKIQ4Y4OJUheMSjV7HlqGD63MY4aYRppDgvD8hBSMtatqL/79txW+cdN0UnfBlRxPo3axiEoMoqn8TzRi3a0GGkUrRa+YXbC9dj84L10We4rgjBmkF6JpAKp3slvNqod931tH5z6xouL6Xf/9afPZWAeSfNhiPRNjL08DVNOgEy9E7ePOM7Sgji92h/AtVIAfTGv7E8jrfPVRMeAT2cbXH7B5VmVJsKDGh0415nBZkuEeebtB6SbIqpC8joFdoSauBoCXsNQpkJMpQYE3ObHEtAemFkC+ANuL9acIFg7UWbV4fyAMTiQ9d3LxO4AJ0Rj2wKmCAFK7QZ5Ka0oaLaEBYknZN3UQuBHGKt7aPcP9ZNEPjepHlDFkm/DRVoPP5jhcWrU0McFIcmwpNz8g28hm8/zGhcsmcsrZbEbO+dw+yCOo/pYU8rPC1Oy9NQ2uWih5SXDsf3/CbfKHfoRP81XXD6WfXetmQ==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bee39f1a-c5b3-49e2-f577-08d86ec373d3
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2020 15:28:21.0655 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6IFXpAfL1Sgnbdpk/PJlAdlJGUNSfdPzmy4noZT9uF7nVu5944myGYDssfduVSLkVDdeEoaW6ux29Knm7doDUbdWHFZ5ZaFJ3fyerVXLg0g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4242
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [RFC] ethdev: introduce Rx buffer split
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



>=20
> 12/10/2020 11:56, Slava Ovsiienko:
> > Hi, Andrew
> >
> > Thank you for the comments.
> >
> > We have two approaches how to specify multiple segments to split Rx pac=
kets:
> > 1. update queue configuration structure
> > 2. introduce new rx_queue_setup_ex() routine with extra parameters.
> >
> > For [1] my only actual dislike is that we would have multiple places to=
 specify
> > the pool - in rx_queue_setup() and in the config structure. So, we shou=
ld
> > implement some checking (if we have offload flag set we should check
> > whether mp parameter is NULL and segment descriptions array pointer/siz=
e
> > is provided, if no offload flag set - we must check the description arr=
ay is empty).
> >
> > > @Thomas, @Ferruh: I'd like to hear what other ethdev maintainers thin=
k
> > > about it.
> >
> > Yes, it would be very nice to hear extra opinions. Do we think the prov=
iding
> > of extra API function is worse than extending existing structure, intro=
ducing
> > some conditional ambiguity and complicating the parameter compliance
> > check?
>=20
> Let's try listing pros and cons of each approach, so we can conclude.
>=20
> 1/ update queue config struct
>=20
> 	1.1 pro: keep same queue setup function
> 	1.2 con: two mempool pointers (struct or function)
> 	1.3 con: variable size of segment description array
>=20
> 2/ new queue setup function
>=20
> 	2.1 con: two functions for queue setup
> 	2.2 pro: mempool pointer is not redundant
> 	2.3 pro: segment description array size defined by the caller
>=20
> What else I'm missing?
>=20

My 2 cents: can we make new (_ex) function to work for both
original config (1 mp for all sizes, no split) and for new config
(multiple mp, split allowed)?
Then in future (21.11?) we can either get rid of original one,
or even make it a wrapper around all one?
Konstantin