From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B676DA04C3; Mon, 28 Sep 2020 14:00:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5A4DB1D93E; Mon, 28 Sep 2020 14:00:17 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E72F11D16B; Mon, 28 Sep 2020 14:00:14 +0200 (CEST) IronPort-SDR: 2jDeMuC+9WIAkTiX8AtJSRN6YEoYheA6WP52J3Q0uGOCnQVPbYYzzvn1D3OCJ3Ae27RoiPgD3D BSBxTAWMcccQ== X-IronPort-AV: E=McAfee;i="6000,8403,9757"; a="180136999" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="180136999" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 05:00:09 -0700 IronPort-SDR: hLgQKfxsvEaMn3J5dcBx1plaMFGBt4HuJMqFtrn/WvbPUzOJ1y/QH2CAkS/IGD0/1iAxtxYBfl nrmp9e02EMsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="513422058" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2020 05:00:08 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 05:00:08 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 05:00:07 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Sep 2020 05:00:06 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 28 Sep 2020 05:00:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rhkgm6Y6JMh4JhYWglJjSDVLeJzP2MfFFj2BFdKyt4hv48/MxqcGfdc68yQ3bEhP+mHnxhvVFBnCpnyLqKvk/5zjF/os3TrwXdTCvxdYyg/jR2ndppAFcfGfm6Y1k7BTTeqt/kFE1MDk4o3uKviQbJzEV1dZLvml6IKjB0bkjmhyB5tm4QP97uJNUZnzfrDS7dvUjWM49EoWPRgCvPYYNKUu25jXh3gHYaFPTAkK87qx95ucnqnO2EHyomn3vRE94Qw6rAAFRILHcp8jw0pqlQ7NE9zyp7mjZuO7ibqS3GpD+SebOz7qQXnbIFIXQriY/eORZPoNp+GGaLOOBMqLxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVVUuLeLirbWnZznuy/bJuAwt0vRqH5HLUt6W/R6xvY=; b=bsv4jcS3xufWpa42rsxefFTsLIYlD9H6z7SX08fzy8Ll1gaGFqlEjWkd4R7LPR/yCYd/SccuBt5yo77qznrJHU0PRmOGJZVK9oOLI9x5LodKscXjvDWVi6iHbajhLuq9TVDa/FR9fyr2s+skB72a9B0hO+GAmuvb810LQmGtT0gf9JxDatlULSBekQQc33CRfi4Wyo3J26ulOeHboorDls38mDKxrHhghNJrDKHRkLNp00GbHIzzRvHHsUMM1VB6skPwQNGI3c6AYnula/FchQ/cwuIO7w7Na7VxqGY8hx4+p7ZxQRsWsXgKd1Myow+36dVw5OolkROhvot1nuU28A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mVVUuLeLirbWnZznuy/bJuAwt0vRqH5HLUt6W/R6xvY=; b=ib2o39tY7pNXYjoVhGnimMOwEMmVI7getT+FoTC5BnZ7BgXAlkw/g0wVwinQUVdoVocPX3iwNDFkUF8gSsKr21cLltwvm0qBA1PMuWGhzjq0vk2p14FAwIVK0DvpuKUJ73m+7X/RZJhMCxPa4Ht8sj1XKU0rJ6hfi5ssfez/R2g= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3671.namprd11.prod.outlook.com (2603:10b6:a03:b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Mon, 28 Sep 2020 12:00:02 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3412.026; Mon, 28 Sep 2020 12:00:01 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , "Yigit, Ferruh" CC: "Min Hu (Connor)" , "techboard@dpdk.org" , "stephen@networkplumber.org" , "Richardson, Bruce" , "jerinj@marvell.com" , "Ray Kinsella" , "dev@dpdk.org" Thread-Topic: [dpdk-techboard] [PATCH V5 1/2] dpdk: resolve compiling errors for per-queue stats Thread-Index: AQHWlXXgspY5UJfgnU2idOEY6ZFnnql9xTaAgAAsC2A= Date: Mon, 28 Sep 2020 12:00:01 +0000 Message-ID: References: <1598845317-55956-1-git-send-email-humin29@huawei.com> <1601176596-29900-2-git-send-email-humin29@huawei.com> <32785804.XpyAPG8jY8@thomas> In-Reply-To: <32785804.XpyAPG8jY8@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e809a78e-a53b-4b2e-5b13-08d863a607cf x-ms-traffictypediagnostic: BYAPR11MB3671: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TdnZy7dhhPgiSl5ffRn/mkzDJ2q1xHt1d1VeM9gd6VijRzyckXOP++13WpITMZG4Mim0uqko5qdP5zHCJ66lkTUWS8qOI1DtwjCsyH8UXStPJJeJhvid6kfA0gKGZ+ONFYOBaXHp0muQUrRR0ZjDeIRTfeRNokgRd/eoDiJMlu9M04q8mLOlIXCG27URVMhkI/IEhDt5Ka2PseNoo5CtS7xZ+zOZoyPsyTjVB1TqpEgPoEiH7wIo70fcIPmfLsK30aauQBS+gs/pA/b5OLJyGK2QnQVry3FByKb6gHa0VBJ8HKZGnB4PnmDcqNc/31q+QsMrW2JH0zzTBT/NKObbtQ5qn9xrt6iR+Be8vtEWN23Gvh4I0PIp1e1hg7Y/9PSQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(86362001)(8936002)(6636002)(478600001)(186003)(66446008)(4326008)(64756008)(66556008)(66476007)(33656002)(316002)(71200400001)(76116006)(66946007)(5660300002)(110136005)(54906003)(26005)(2906002)(55016002)(83380400001)(9686003)(52536014)(53546011)(6506007)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Sjj1Ez5CfF0B8948NZFIyLCE28ICR9SP/+KGfDrZCekdlPJWFsQQ6JD9SHv/meOyyCA8mnARZYlteZNxXyBLPeNTH4DSRa7O+SS9U4AtvNucSH/L42qOrgaDWfwhQDMd7I3vw764zuuzgw/9IH6KR2YUnR95P1nojXxp4EsVV/sf1HShLIQOV0FLy/JUiJGFpPa0rR+o8nQigUAefNym8MOXiOIReLTiqxlQ93vXq7gtPz/0pk/kdbFLxYMqhO4aotCJpsLVEOrjnmfCiyp33+9ClIcY6mAQc6B5il2VusX077bwL5Q+tc5Dpl4X9eNeu9EuFx6LLzR0PhwA2owwagoCdJ0F647fl6wy6iP73D3VwKcLQAwWYhLAEotyzwwbMPW423Se36X4pL0wbfImkFrhSVIy6qaQa84nD4AUqCEWuZ201gY0TFlIowkYX+j8N049ZzmkLCRxJLbOj2i8MYakijHCwY+myb81vmm+YLO8ZeoSG9EgXxuZExl1XANSlMvQJSHa0DavJWQzTccM/KnfS4kH37YlNPDqnPpvzprQjfQxLWmxkpd2ky7E88ZfR2jKfqvmzYWb+v3BAdnDVQkYNhkza2Qe5lz60KLeKQHKIOm7mcn/LuDxA/o/fTubcuo8FZTAJMUM1k1LEegzvA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e809a78e-a53b-4b2e-5b13-08d863a607cf X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2020 12:00:01.8216 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vsaVw2sMNyJ/rEthmEsgUJduy0rxWQCio6MUuRMfDnkRNN6ZKDK0kNsnUjAkwLhaOT0wPWYu8kfd3BgM84Y6JSMLeRn62+K89rxThi2mtxM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3671 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH V5 1/2] dpdk: resolve compiling errors for per-queue stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 28/09/2020 10:59, Ferruh Yigit: > > On 9/27/2020 4:16 AM, Min Hu (Connor) wrote: > > > From: Huisong Li > > > > > > Currently, only statistics of rx/tx queues with queue_id less than > > > RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain > > > application scenario that it needs to use 256 or more than 256 queues > > > and display all statistics of rx/tx queue. At this moment, we have to > > > change the macro to be equaled to the queue number. > > > > > > However, modifying the macro to be greater than 256 will trigger > > > many errors and warnings from test-pmd, PMD drivers and librte_ethdev > > > during compiling dpdk project. But it is possible and permitted that > > > rx/tx queue number is greater than 256 and all statistics of rx/tx > > > queue need to be displayed. In addition, the data type of rx/tx queue > > > number in rte_eth_dev_configure API is 'uint16_t'. So It is unreasona= ble > > > to use the 'uint8_t' type for variables that control which per-queue > > > statistics can be displayed. >=20 > The explanation is too much complex and misleading. > You mean you cannot increase RTE_ETHDEV_QUEUE_STAT_CNTRS > above 256 because it is an 8-bit type? >=20 > [...] > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id, > > > - uint16_t tx_queue_id, uint8_t stat_idx); > > > + uint16_t tx_queue_id, uint16_t stat_idx); > [...] > > > int rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id, > > > uint16_t rx_queue_id, > > > - uint8_t stat_idx); > > > + uint16_t stat_idx); > [...] > > cc'ed tech-board, > > > > The patch breaks the ethdev ABI without a deprecation notice from previ= ous > > release(s). > > > > It is mainly a fix to the port_id storage type, which we have updated f= rom > > uint8_t to uint16_t in past but some seems remained for > > 'rte_eth_dev_set_tx_queue_stats_mapping()' & > > 'rte_eth_dev_set_rx_queue_stats_mapping()' APIs. >=20 > No, it is not related to the port id, but the number of limited stats.it > it is not limited. In this case, we probably don't need the API > *_queue_stats_mapping which was invented for a limitation of ixgbe. It is probably a bit unusual specially for modern NICs, but I think it still possible in principle. Let say NIC has up to 16K queues, but can map stats only for 1K, or so. So formally - yes, I think both queue_idx and stats_idx have to be same typ= e. Also I can't foresee problems such change could introduce (except formal AP= I/ABI break). So: Acked-by: Konstantin Ananyev >=20 > The problem is probably somewhere else (in testpmd), > that's why I am against this patch. >=20