From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93B31A00C2; Thu, 23 Apr 2020 02:13:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EACF1D167; Thu, 23 Apr 2020 02:13:01 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 512661D151 for ; Thu, 23 Apr 2020 02:12:59 +0200 (CEST) IronPort-SDR: qZG2DfX3FSXgHM8AKaQq20DB7sZcRlm0aw3+t2wbA+Mlw3qkyAcVTwNmS0L3PUZZC90NLjjxNx K7dRSgRfIKwA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 17:12:58 -0700 IronPort-SDR: 59dD0gzQn5HgZFJiIEQE59oiZSjtHOhlCD6wGVIQm47PIz8hBLVs9ZG5jnVMUIGWFv4tetPZg4 zxrIHGHGovcw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,305,1583222400"; d="scan'208";a="301070065" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by FMSMGA003.fm.intel.com with ESMTP; 22 Apr 2020 17:12:58 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 17:12:57 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Apr 2020 17:12:57 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 22 Apr 2020 17:12:57 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 17:12:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UYjH+9UrgTJ1UxEfz6exSY+M/zPCrK8wPkqnOpwSadzurwAzqMH3FVHx+ytFRAqk4mvhlJG4JcMejpouGFrZOXyrEm8VumM6NMTgzUh/5ehtlyyVLF1rvw8yQReJ39zVDkWuZTOpkLDEHGtX8lqrOFehNOKgFb1B732TrouZozrMBiXVo2hUgDJITJ2xsq2x5uvrXKOazteRZLLPzKICW/x0PfYCnxNAsUJx8MdrUjI8Dyjca1CUQ94sodSyEh2rwUJwzkCSeBsyotcqLi8rokGJH3ZyFPmmk17coX+kMuJxDeUl6UaRtnRX/3gY4OStXWSqGpcAzJgw93xm8dL3Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LO7y4WLe2BKk2J1tOeANxOqeaoi5jyHFn1X5FjwyBXg=; b=N6R/+sl1yq7HPYpuVz4/AIj7eEeY76hRgSxL0xqNJsDHGv9OtGfLgHlFTMEI1fzSV78vXVqHWKeTrzJdIzWkySIevx8F1UTjb9lZ/RAO6Sd8vo1G8RjfXz8aQczJTyNfrbzfuFMf/GIpcyFkNeJ2mA6T2B9HwiK93Yd9qluNy75i3A942cglCHDYRwnpblurlYVV+N0oHKfmJC/dUkNOxBORHylCTL6NTi0mOTYIrahdOwTjNo1jGUHJkPt6yS6mKSs/ITr9qjpqNol2GRkVY1inJakOPFgRDk69d0chx9M3uqJdefCI0I/etOFYtS0LOmCz77vZwyhLZ/mHfZsPiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LO7y4WLe2BKk2J1tOeANxOqeaoi5jyHFn1X5FjwyBXg=; b=sYB9COR7P1NQxwAwr1TQNzS9ds56wCtRUMWae+X5fmaQTIXxviJIIhfjbScBQiHZhgtPcw34KWjjTr/wpi96wDyayItcDudNW58+83mAIezGcnn0V+fej4l3VLLTCYh4gj+csdC7QfpTqCqicrKWxwd9XJ7xRWQ4DHAWi7PJUNw= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3077.namprd11.prod.outlook.com (2603:10b6:a03:90::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Thu, 23 Apr 2020 00:12:52 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2937.012; Thu, 23 Apr 2020 00:12:52 +0000 From: "Ananyev, Konstantin" To: "Medvedkin, Vladimir" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" Thread-Topic: [PATCH v3] examples/ipsec-secgw: remove limitation for crypto sessions Thread-Index: AQHWF0haYCA5Pi5Gfk6o0TbhVsEjgKiF2RjQ Date: Thu, 23 Apr 2020 00:12:51 +0000 Message-ID: References: <6001e9c347d26c4e2f80765c8abc7f74fcf8bbf2.1586873664.git.vladimir.medvedkin@intel.com> <134a692052e2017bcb0312b3d572e68cd2f7d1e9.1587410155.git.vladimir.medvedkin@intel.com> In-Reply-To: <134a692052e2017bcb0312b3d572e68cd2f7d1e9.1587410155.git.vladimir.medvedkin@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.180] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 180382a4-6b9f-4f7d-d0a6-08d7e71b106e x-ms-traffictypediagnostic: BYAPR11MB3077: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:213; x-forefront-prvs: 03827AF76E x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(396003)(366004)(39860400002)(136003)(346002)(376002)(478600001)(2906002)(8676002)(81156014)(186003)(66556008)(76116006)(55016002)(5660300002)(71200400001)(66476007)(9686003)(64756008)(66446008)(86362001)(4326008)(66946007)(52536014)(316002)(110136005)(6506007)(8936002)(7696005)(33656002)(26005); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +DbOPSH18x5UloMNLQpWsyyzeAurL4WtcFwIipMMahQzunYcLwkUNPxCL6/24klWJ5fU8gF+SSxJc6B8oUsS0oKjPbjUWBOwEwcA4fRpnlDrfueAHQvywbGQTzXOLWWQjjGQUNYtyPi1J9dSwdYrY5XR39nllgQzJylt4VfkHdPpaVPBs5zIkAH65Pw2j+BTvj2x2PHL8v/TqVK4RuC5vePuMMaiJRqaUYNCpdtF3F7zgFiWEyaJsXIvHwONpceMLu9vwKsKlrWBS+YMJ+SQvC65SFn3nNXPBngDiU+katbz8IzRdjbC3LSt645t1KYhwmfPFwHNyMHPpkf9CCDjHzYZ3YoXRO448YEHHQlgn1ELq+Bygf3JlLVIuoZrvAAwKiO7jIrTSRiknpV57ZwYd5ZmCFRQdvRpt4KahrE5jPYGIfSJWrGiUAWwT8W85F8n x-ms-exchange-antispam-messagedata: 3Ap+IwCwyGnkHm6wF5PkL5qpvsZmRyGxSGcHU47456jDV8z7hoZ8jzAJR7qnjFrq8agE3WuaEL4vIQSauzKXhMj+HgPWCwuNVKVVF63rw3Ce2O8Fpqcyz+P4/lbhuHA7rlStz0T1aFq2LwtwkP/vqA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 180382a4-6b9f-4f7d-d0a6-08d7e71b106e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2020 00:12:51.9786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ocgifzTaLuVPQyHDqH9GmKPSpsmtDQnVnSkG8gqsKsVsmuOO6m8j5GvYCbKlS69jnofzx3t+Hyrfboc66TnOzfTUYonbEuxzS7tz0+k9qc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3077 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: remove limitation for crypto sessions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Get rid of hardcoded limit of cryptodev sessions. >=20 > Fixes: e1143d7dbbf4 ("examples/ipsec-secgw: get rid of maximum SA limitat= ion") > Cc: vladimir.medvedkin@intel.com >=20 > Signed-off-by: Vladimir Medvedkin > --- > examples/ipsec-secgw/ipsec-secgw.c | 25 +++++++++++++++++++------ > examples/ipsec-secgw/ipsec.h | 3 +++ > examples/ipsec-secgw/sa.c | 9 +++++++++ > 3 files changed, 31 insertions(+), 6 deletions(-) >=20 > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ip= sec-secgw.c > index 5fde4f7..30fc985 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.c > +++ b/examples/ipsec-secgw/ipsec-secgw.c > @@ -62,7 +62,6 @@ volatile bool force_quit; >=20 > #define CDEV_QUEUE_DESC 2048 > #define CDEV_MAP_ENTRIES 16384 > -#define CDEV_MP_NB_OBJS 1024 > #define CDEV_MP_CACHE_SZ 64 > #define MAX_QUEUE_PAIRS 1 >=20 > @@ -2003,10 +2002,11 @@ cryptodevs_init(uint16_t req_queue_num) > dev_conf.ff_disable =3D RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO; >=20 > uint32_t dev_max_sess =3D cdev_info.sym.max_nb_sessions; > - if (dev_max_sess !=3D 0 && dev_max_sess < CDEV_MP_NB_OBJS) > + if (dev_max_sess !=3D 0 && > + dev_max_sess < get_nb_crypto_sessions()) > rte_exit(EXIT_FAILURE, > "Device does not support at least %u " > - "sessions", CDEV_MP_NB_OBJS); > + "sessions", get_nb_crypto_sessions()); >=20 > if (rte_cryptodev_configure(cdev_id, &dev_conf)) > rte_panic("Failed to initialize cryptodev %u\n", > @@ -2258,12 +2258,18 @@ session_pool_init(struct socket_ctx *ctx, int32_t= socket_id, size_t sess_sz) > { > char mp_name[RTE_MEMPOOL_NAMESIZE]; > struct rte_mempool *sess_mp; > + uint32_t nb_sess; >=20 > snprintf(mp_name, RTE_MEMPOOL_NAMESIZE, > "sess_mp_%u", socket_id); > + /* > + * Doubled due to rte_security_session_create() uses one mempool for > + * session and for session private data. > + */ > + nb_sess =3D (get_nb_crypto_sessions() + CDEV_MP_CACHE_SZ * > + rte_lcore_count()) * 2; > sess_mp =3D rte_cryptodev_sym_session_pool_create( > - mp_name, CDEV_MP_NB_OBJS, > - sess_sz, CDEV_MP_CACHE_SZ, 0, > + mp_name, nb_sess, sess_sz, CDEV_MP_CACHE_SZ, 0, > socket_id); > ctx->session_pool =3D sess_mp; >=20 > @@ -2280,11 +2286,18 @@ session_priv_pool_init(struct socket_ctx *ctx, in= t32_t socket_id, > { > char mp_name[RTE_MEMPOOL_NAMESIZE]; > struct rte_mempool *sess_mp; > + uint32_t nb_sess; >=20 > snprintf(mp_name, RTE_MEMPOOL_NAMESIZE, > "sess_mp_priv_%u", socket_id); > + /* > + * Doubled due to rte_security_session_create() uses one mempool for > + * session and for session private data. > + */ > + nb_sess =3D (get_nb_crypto_sessions() + CDEV_MP_CACHE_SZ * > + rte_lcore_count()) * 2; > sess_mp =3D rte_mempool_create(mp_name, > - CDEV_MP_NB_OBJS, > + nb_sess, > sess_sz, > CDEV_MP_CACHE_SZ, > 0, NULL, NULL, NULL, > diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h > index 1f264c0..8ad3082 100644 > --- a/examples/ipsec-secgw/ipsec.h > +++ b/examples/ipsec-secgw/ipsec.h > @@ -409,4 +409,7 @@ int > create_inline_session(struct socket_ctx *skt_ctx, struct ipsec_sa *sa, > struct rte_ipsec_session *ips); >=20 > +uint32_t > +get_nb_crypto_sessions(void); > + > #endif /* __IPSEC_H__ */ > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > index a6bf5e8..2063db8 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -135,6 +135,7 @@ const struct supported_aead_algo aead_algos[] =3D { >=20 > #define SA_INIT_NB 128 >=20 > +static uint32_t nb_crypto_sessions; > struct ipsec_sa *sa_out; > uint32_t nb_sa_out; > static uint32_t sa_out_sz; > @@ -680,6 +681,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > } >=20 > rule->fallback_sessions =3D 1; > + nb_crypto_sessions++; > fallback_p =3D 1; > continue; > } > @@ -724,6 +726,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens, > rule->portid =3D -1; > } >=20 > + nb_crypto_sessions++; > *ri =3D *ri + 1; > } >=20 > @@ -1542,3 +1545,9 @@ sa_sort_arr(void) > qsort(sa_in, nb_sa_in, sizeof(struct ipsec_sa), sa_cmp); > qsort(sa_out, nb_sa_out, sizeof(struct ipsec_sa), sa_cmp); > } > + > +uint32_t > +get_nb_crypto_sessions(void) > +{ > + return nb_crypto_sessions; > +} > -- Tested-by: Konstantin Ananyev Acked-by: Konstantin Ananyev > 2.7.4