From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBD95A034F; Wed, 13 May 2020 14:13:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5C661D55A; Wed, 13 May 2020 14:13:04 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 8171B1D546 for ; Wed, 13 May 2020 14:13:02 +0200 (CEST) IronPort-SDR: nUv8uW2c64lcEG/6NxRGAbEvF5JEkfhxNCgJ3xZRcyoMzSy6apLjvIP8Nwqcu6PK4e+yKMKjoZ yooAHbYXdMFg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 05:13:01 -0700 IronPort-SDR: c+M9eoG9xHSNh6MmaKIc1z7NUX34EGVWOU0N5YKdamHxg9bBtZ1BXhPc6QjiswvRocB9B6GZ8i RTwOHdya1SWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,387,1583222400"; d="scan'208";a="297649408" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 13 May 2020 05:13:01 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 05:13:01 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 05:13:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BFFnkCjnWMvPaVmng4OwardWJdNMbFJ7t6UsWLCfuDaLVmr93H6pbhy1pqdxj6acwcYoZNm2L6hIVN30dWi293M6JNqtjhHvK8a17/6yPPwYjBMFiXa/QEOaRuzuf7P/Le4dNFoWjo8Zqe56BBjBr7OSwdraxCOinWf7wf7/vsahTv0N6IuFDdgWm71y1XeczG2HLnB/Dl+SKmd6zqGFe9smnY7CXQwHLSmsySQKAiUri1P9o0aDnOztJtwQCJNGjMJM4f4y/50po0TW8L/zaKBe9adyxyMpgAa0e0qhfvPqvDrDh147rHqxUN6yMVkNwyMF07V+VId5Dz64hZVolQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwQlmP9ZCd3M4WjPMGkwh+O9XfXPLcDqQlp3S4K/TA8=; b=jJ58lQiXz+UjzEvmIdtpo4usj64C8iQ+IP8WMjSHuHpPV1sjKOK/30tPKJ7/CnNWVOtRwIMcZvzqVej/qTNzAvcCkwi4j/Rc27FNKVqUq9aH/WafRuYP6EVbsAwVBztRzbNV1Gea4/6i9I/k0G9ldlQA1XiWEFcVGRUgQUYie0daDB5QXFaRUhlvDYvu7JXdyWj9nIU2jDfu5M5SNr/SkGVRj39RklIKt7+mZM0addCSvRu7B6NHv5Qm/0M/jtDqSYYbU6YCjA7GmshbZz8n2OV0ezNoifP7z23j/BY8SDJZDF+aHMRD8Dka6ak41SzrptIDym1/h+vHq4aKv7yzXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwQlmP9ZCd3M4WjPMGkwh+O9XfXPLcDqQlp3S4K/TA8=; b=xjCOzuLLYREiutby9NF/nXTri0SNHnmccxHmnMxI6WEHC9Q1PZ3SV/+2+k8Q/z0sdr/2GgfL64RpWjIqgKXjkLWCzUp9lauaC3KWAYYW5rGhiV7WZJyjw8BcykvqIn2XySxPKzWpkQmh7K3zcdcNqFAsqtURrUoiavsalQ4eCe8= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3606.namprd11.prod.outlook.com (2603:10b6:a03:b5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Wed, 13 May 2020 12:12:59 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2979.033; Wed, 13 May 2020 12:12:59 +0000 From: "Ananyev, Konstantin" To: Anoob Joseph , Akhil Goyal , "Nicolau, Radu" CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" Thread-Topic: [PATCH v3] examples/ipsec-secgw: add per core packet stats Thread-Index: AQHWI6SkbuuME/sCGUWlN/0x2cLQmKid16cQgAaPhYCAAY0WQA== Date: Wed, 13 May 2020 12:12:59 +0000 Message-ID: References: <1587647245-10524-1-git-send-email-anoobj@marvell.com> <1588769253-10405-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47a1d270-2d41-40ee-f9a8-08d7f736fa85 x-ms-traffictypediagnostic: BYAPR11MB3606: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vp5bYXZAm2DLc/jyDIOvq6fDxMBEDiCTphafoI/t4BsoqPvBiX5z0OelucuwhlPDyJRiqTL9f4daFfuGTm782RbCVh+vtjbh/HoX1ktsXzxBpCLdortJw7u18l1tZLynrG/Oo34ue5h/J1fOlee6/rv9Hbc8Q/zsvDpiAmezFpaWFO6Jt2nXi9JrAnTtpMPwuvn7zEoor81dhUtgHUP6h9lsfI14K6mZ7mbWxTqePUXvMsSK0DMwzGosdvK3AmnBYZUBoo5OorlUPQB3vuKORbGYiq8HySrjUvyuv+0z68I6vkrIzF2XlRLtsplHttF0+oOp7MlPZbgYwufZxf1rOLd+NCAVqJ/ro5fnHnJqF5CC1Qsou6aqd15QD4J3eKi5vYDiSaQ6VgC+9x9psyt+95GJQ/EYEvFrAe/Iby49zeBYt1mA1SwWDss+eP9AFPXgUK05CyraTNGudrri3fWpppTf4EzbtRPUrltiN3TlZIhO4Xr8mlGh5CMEMgxiclrPcl6/phN9AJVn70lkP1qL7w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(346002)(376002)(366004)(39860400002)(396003)(33430700001)(6636002)(71200400001)(33440700001)(6506007)(8936002)(5660300002)(186003)(478600001)(7696005)(8676002)(316002)(64756008)(2906002)(54906003)(30864003)(26005)(55016002)(86362001)(66476007)(66446008)(66556008)(52536014)(4326008)(110136005)(33656002)(76116006)(66946007)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: KstlUmR5cX7FyL5Ny0gSOn+tHq3ZkDmxKRH4AnnT30rI8WSHCgcztjMKjd0qs0cVxJYJa9SDcBrTrbs4hUu3uACFabOg+kp8i0TrYhJyIdj+3rVhbPUyLA26YUUXuB3wxDaN7R3/TvUZMBbS3BeTVrnaEe3EAO1mYPKboBnPfcLFC4xgfKXi0ifc1wbFyJNKIeQey3Bzjza4BCrAFtusCAfRPgOtAUKrXoy4mAAwKLrgmSIUem7lmL8graP5TT2MAybk5yapcuT8cbMA11YVgRXRu/8gz16U4muzwyl3lozv504/AaKhXLgS+/5bgAwPvJOJYYw1I0GHEJnmHkTNAruHQx9kBtC+RZ9/nilVjcK7vBGUiviLhfCRRjpcOj+kWJ2d2Lz0ImzYxa2exOHR/Ay9ij/6lJHQd9BDAOB+uMbdMyXW8uP9A14rFp2yLzIxXMzjUtEfjsesoNkdppJK1FEabJs++e+vhcg2HoUuYL6tC5HmvdhpLILYMfvI2as4 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 47a1d270-2d41-40ee-f9a8-08d7f736fa85 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 12:12:59.7924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bE98BAxLmfKBNiCNhZfOxfBGqtpeOAAgfLIoCdKZxuBagZPDvhb2q4Tokl/lHIpRQ7XZQxbIm8RquVUUZsjHRfC90M2YY2erCZUm6pE6X/w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3606 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > +#if (STATS_INTERVAL > 0) > > > + > > > +/* Print out statistics on packet distribution */ static void > > > +print_stats(void) > > > +{ > > > + uint64_t total_packets_dropped, total_packets_tx, total_packets_rx; > > > + unsigned int coreid; > > > + float burst_percent; > > > + > > > + total_packets_dropped =3D 0; > > > + total_packets_tx =3D 0; > > > + total_packets_rx =3D 0; > > > + > > > + const char clr[] =3D { 27, '[', '2', 'J', '\0' }; > > > + > > > + /* Clear screen and move to top left */ > > > + printf("%s", clr); > > > + > > > + printf("\nCore statistics =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D"); > > > + > > > + for (coreid =3D 0; coreid < RTE_MAX_LCORE; coreid++) { > > > + /* skip disabled cores */ > > > + if (rte_lcore_is_enabled(coreid) =3D=3D 0) > > > + continue; > > > + burst_percent =3D (float)(core_statistics[coreid].burst_rx * 100)/ > > > + core_statistics[coreid].rx; > > > + printf("\nStatistics for core %u ------------------------------" > > > + "\nPackets received: %20"PRIu64 > > > + "\nPackets sent: %24"PRIu64 > > > + "\nPackets dropped: %21"PRIu64 > > > + "\nBurst percent: %23.2f", > > > + coreid, > > > + core_statistics[coreid].rx, > > > + core_statistics[coreid].tx, > > > + core_statistics[coreid].dropped, > > > + burst_percent); > > > > > > As one more comment: > > Can we also collect number of calls and display average pkt/call (for b= oth rx and > > tx)? > > >=20 > [Anoob] Can you describe which "call" you meant? We can capture more logs= if required. I meant something like that: +static inline void +core_stats_update_rx(int n) +{ +#if (STATS_INTERVAL > 0) + int lcore_id =3D rte_lcore_id(); + core_statistics[lcore_id].rx +=3D n; + core_statistics[lcore_id].rx_call++; + if (n =3D=3D MAX_PKT_BURST) + core_statistics[lcore_id].burst_rx +=3D n; +#else + RTE_SET_USED(n); +#endif /* STATS_INTERVAL */ +} And then in print_stats(): "\nPackets received: %20"PRIu64 ",RX calls: %" PRIu64 "RX packets/call: %.2f" core_statistics[coreid].rx, core_statistics[coreid].rx_call, (double)core_statistics[coreid].rx / core_statistics[coreid].rx_call >=20 > > > + > > > + total_packets_dropped +=3D core_statistics[coreid].dropped; > > > + total_packets_tx +=3D core_statistics[coreid].tx; > > > + total_packets_rx +=3D core_statistics[coreid].rx; > > > + } > > > + printf("\nAggregate statistics =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D" > > > + "\nTotal packets received: %14"PRIu64 > > > + "\nTotal packets sent: %18"PRIu64 > > > + "\nTotal packets dropped: %15"PRIu64, > > > + total_packets_rx, > > > + total_packets_tx, > > > + total_packets_dropped); > > > + > > printf("\n=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > =3D\n"); > > > +} > > > +#endif /* STATS_INTERVAL */ > > > + > > > static inline void > > > prepare_one_packet(struct rte_mbuf *pkt, struct ipsec_traffic *t) { > > > @@ -333,7 +386,7 @@ prepare_one_packet(struct rte_mbuf *pkt, struct > > > ipsec_traffic *t) > > > > > > /* drop packet when IPv6 header exceeds first segment length > > */ > > > if (unlikely(l3len > pkt->data_len)) { > > > - rte_pktmbuf_free(pkt); > > > + free_pkt(pkt); > > > return; > > > } > > > > > > @@ -350,7 +403,7 @@ prepare_one_packet(struct rte_mbuf *pkt, struct > > ipsec_traffic *t) > > > /* Unknown/Unsupported type, drop the packet */ > > > RTE_LOG(ERR, IPSEC, "Unsupported packet type 0x%x\n", > > > rte_be_to_cpu_16(eth->ether_type)); > > > - rte_pktmbuf_free(pkt); > > > + free_pkt(pkt); > > > return; > > > } > > > > > > @@ -477,9 +530,12 @@ send_burst(struct lcore_conf *qconf, uint16_t n, > > uint16_t port) > > > prepare_tx_burst(m_table, n, port, qconf); > > > > > > ret =3D rte_eth_tx_burst(port, queueid, m_table, n); > > > + > > > + core_stats_update_tx(ret); > > > + > > > if (unlikely(ret < n)) { > > > do { > > > - rte_pktmbuf_free(m_table[ret]); > > > + free_pkt(m_table[ret]); > > > } while (++ret < n); > > > } > > > > > > @@ -525,7 +581,7 @@ send_fragment_packet(struct lcore_conf *qconf, > > struct rte_mbuf *m, > > > "error code: %d\n", > > > __func__, m->pkt_len, rte_errno); > > > > > > - rte_pktmbuf_free(m); > > > + free_pkt(m); > > > return len; > > > } > > > > > > @@ -550,7 +606,7 @@ send_single_packet(struct rte_mbuf *m, uint16_t > > port, uint8_t proto) > > > } else if (frag_tbl_sz > 0) > > > len =3D send_fragment_packet(qconf, m, port, proto); > > > else > > > - rte_pktmbuf_free(m); > > > + free_pkt(m); > > > > > > /* enough pkts to be sent */ > > > if (unlikely(len =3D=3D MAX_PKT_BURST)) { @@ -584,19 +640,19 @@ > > > inbound_sp_sa(struct sp_ctx *sp, struct sa_ctx *sa, struct traffic_ty= pe *ip, > > > continue; > > > } > > > if (res =3D=3D DISCARD) { > > > - rte_pktmbuf_free(m); > > > + free_pkt(m); > > > continue; > > > } > > > > > > /* Only check SPI match for processed IPSec packets */ > > > if (i < lim && ((m->ol_flags & PKT_RX_SEC_OFFLOAD) =3D=3D 0)) { > > > - rte_pktmbuf_free(m); > > > + free_pkt(m); > > > continue; > > > } > > > > > > sa_idx =3D res - 1; > > > if (!inbound_sa_check(sa, m, sa_idx)) { > > > - rte_pktmbuf_free(m); > > > + free_pkt(m); > > > continue; > > > } > > > ip->pkts[j++] =3D m; > > > @@ -631,7 +687,7 @@ split46_traffic(struct ipsec_traffic *trf, struct= rte_mbuf > > *mb[], uint32_t num) > > > offsetof(struct ip6_hdr, ip6_nxt)); > > > n6++; > > > } else > > > - rte_pktmbuf_free(m); > > > + free_pkt(m); > > > } > > > > > > trf->ip4.num =3D n4; > > > @@ -683,7 +739,7 @@ outbound_sp(struct sp_ctx *sp, struct traffic_typ= e *ip, > > > m =3D ip->pkts[i]; > > > sa_idx =3D ip->res[i] - 1; > > > if (ip->res[i] =3D=3D DISCARD) > > > - rte_pktmbuf_free(m); > > > + free_pkt(m); > > > else if (ip->res[i] =3D=3D BYPASS) > > > ip->pkts[j++] =3D m; > > > else { > > > @@ -702,8 +758,7 @@ process_pkts_outbound(struct ipsec_ctx *ipsec_ctx= , > > > uint16_t idx, nb_pkts_out, i; > > > > > > /* Drop any IPsec traffic from protected ports */ > > > - for (i =3D 0; i < traffic->ipsec.num; i++) > > > - rte_pktmbuf_free(traffic->ipsec.pkts[i]); > > > + free_pkts(traffic->ipsec.pkts, traffic->ipsec.num); > > > > > > traffic->ipsec.num =3D 0; > > > > > > @@ -743,14 +798,12 @@ process_pkts_inbound_nosp(struct ipsec_ctx > > *ipsec_ctx, > > > uint32_t nb_pkts_in, i, idx; > > > > > > /* Drop any IPv4 traffic from unprotected ports */ > > > - for (i =3D 0; i < traffic->ip4.num; i++) > > > - rte_pktmbuf_free(traffic->ip4.pkts[i]); > > > + free_pkts(traffic->ip4.pkts, traffic->ip4.num); > > > > > > traffic->ip4.num =3D 0; > > > > > > /* Drop any IPv6 traffic from unprotected ports */ > > > - for (i =3D 0; i < traffic->ip6.num; i++) > > > - rte_pktmbuf_free(traffic->ip6.pkts[i]); > > > + free_pkts(traffic->ip6.pkts, traffic->ip6.num); > > > > > > traffic->ip6.num =3D 0; > > > > > > @@ -786,8 +839,7 @@ process_pkts_outbound_nosp(struct ipsec_ctx > > *ipsec_ctx, > > > struct ip *ip; > > > > > > /* Drop any IPsec traffic from protected ports */ > > > - for (i =3D 0; i < traffic->ipsec.num; i++) > > > - rte_pktmbuf_free(traffic->ipsec.pkts[i]); > > > + free_pkts(traffic->ipsec.pkts, traffic->ipsec.num); > > > > > > n =3D 0; > > > > > > @@ -901,7 +953,7 @@ route4_pkts(struct rt_ctx *rt_ctx, struct rte_mbu= f > > *pkts[], uint8_t nb_pkts) > > > } > > > > > > if ((pkt_hop & RTE_LPM_LOOKUP_SUCCESS) =3D=3D 0) { > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > } > > > send_single_packet(pkts[i], pkt_hop & 0xff, IPPROTO_IP); @@ - > > 953,7 > > > +1005,7 @@ route6_pkts(struct rt_ctx *rt_ctx, struct rte_mbuf *pkts[]= , > > uint8_t nb_pkts) > > > } > > > > > > if (pkt_hop =3D=3D -1) { > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > } > > > send_single_packet(pkts[i], pkt_hop & 0xff, IPPROTO_IPV6); > > @@ > > > -1099,6 +1151,10 @@ ipsec_poll_mode_worker(void) > > > const uint64_t drain_tsc =3D (rte_get_tsc_hz() + US_PER_S - 1) > > > / US_PER_S * BURST_TX_DRAIN_US; > > > struct lcore_rx_queue *rxql; > > > +#if (STATS_INTERVAL > 0) > > > + const uint64_t timer_period =3D STATS_INTERVAL * rte_get_timer_hz()= ; > > > + uint64_t timer_tsc =3D 0; > > > +#endif /* STATS_INTERVAL */ > > > > > > prev_tsc =3D 0; > > > lcore_id =3D rte_lcore_id(); > > > @@ -1159,6 +1215,19 @@ ipsec_poll_mode_worker(void) > > > drain_tx_buffers(qconf); > > > drain_crypto_buffers(qconf); > > > prev_tsc =3D cur_tsc; > > > +#if (STATS_INTERVAL > 0) > > > + if (lcore_id =3D=3D rte_get_master_lcore()) { > > > + /* advance the timer */ > > > + timer_tsc +=3D diff_tsc; > > > + > > > + /* if timer has reached its timeout */ > > > + if (unlikely(timer_tsc >=3D timer_period)) { > > > + print_stats(); > > > + /* reset the timer */ > > > + timer_tsc =3D 0; > > > + } > > > + } > > > +#endif /* STATS_INTERVAL */ > > > } > > > > > > for (i =3D 0; i < qconf->nb_rx_queue; ++i) { @@ -1169,8 +1238,10 > > @@ > > > ipsec_poll_mode_worker(void) > > > nb_rx =3D rte_eth_rx_burst(portid, queueid, > > > pkts, MAX_PKT_BURST); > > > > > > - if (nb_rx > 0) > > > + if (nb_rx > 0) { > > > + core_stats_update_rx(nb_rx); > > > process_pkts(qconf, pkts, nb_rx, portid); > > > + } > > > > > > /* dequeue and process completed crypto-ops */ > > > if (is_unprotected_port(portid)) > > > diff --git a/examples/ipsec-secgw/ipsec-secgw.h > > > b/examples/ipsec-secgw/ipsec-secgw.h > > > index 4b53cb5..5b3561f 100644 > > > --- a/examples/ipsec-secgw/ipsec-secgw.h > > > +++ b/examples/ipsec-secgw/ipsec-secgw.h > > > @@ -6,6 +6,8 @@ > > > > > > #include > > > > > > +#define STATS_INTERVAL 0 > > > + > > > #define NB_SOCKETS 4 > > > > > > #define MAX_PKT_BURST 32 > > > @@ -69,6 +71,17 @@ struct ethaddr_info { > > > uint64_t src, dst; > > > }; > > > > > > +#if (STATS_INTERVAL > 0) > > > +struct ipsec_core_statistics { > > > + uint64_t tx; > > > + uint64_t rx; > > > + uint64_t dropped; > > > + uint64_t burst_rx; > > > +} __rte_cache_aligned; > > > + > > > +struct ipsec_core_statistics core_statistics[RTE_MAX_LCORE]; #endif > > > +/* STATS_INTERVAL */ > > > + > > > extern struct ethaddr_info ethaddr_tbl[RTE_MAX_ETHPORTS]; > > > > > > /* Port mask to identify the unprotected ports */ @@ -85,4 +98,59 @@ > > > is_unprotected_port(uint16_t port_id) > > > return unprotected_port_mask & (1 << port_id); } > > > > > > +static inline void > > > +core_stats_update_rx(int n) > > > +{ > > > +#if (STATS_INTERVAL > 0) > > > + int lcore_id =3D rte_lcore_id(); > > > + core_statistics[lcore_id].rx +=3D n; > > > + if (n =3D=3D MAX_PKT_BURST) > > > + core_statistics[lcore_id].burst_rx +=3D n; #else > > > + RTE_SET_USED(n); > > > +#endif /* STATS_INTERVAL */ > > > +} > > > + > > > +static inline void > > > +core_stats_update_tx(int n) > > > +{ > > > +#if (STATS_INTERVAL > 0) > > > + int lcore_id =3D rte_lcore_id(); > > > + core_statistics[lcore_id].tx +=3D n; > > > +#else > > > + RTE_SET_USED(n); > > > +#endif /* STATS_INTERVAL */ > > > +} > > > + > > > +static inline void > > > +core_stats_update_drop(int n) > > > +{ > > > +#if (STATS_INTERVAL > 0) > > > + int lcore_id =3D rte_lcore_id(); > > > + core_statistics[lcore_id].dropped +=3D n; #else > > > + RTE_SET_USED(n); > > > +#endif /* STATS_INTERVAL */ > > > +} > > > + > > > +/* helper routine to free bulk of packets */ static inline void > > > +free_pkts(struct rte_mbuf *mb[], uint32_t n) { > > > + uint32_t i; > > > + > > > + for (i =3D 0; i !=3D n; i++) > > > + rte_pktmbuf_free(mb[i]); > > > + > > > + core_stats_update_drop(n); > > > +} > > > + > > > +/* helper routine to free single packet */ static inline void > > > +free_pkt(struct rte_mbuf *mb) { > > > + rte_pktmbuf_free(mb); > > > + core_stats_update_drop(1); > > > +} > > > + > > > #endif /* _IPSEC_SECGW_H_ */ > > > diff --git a/examples/ipsec-secgw/ipsec.c > > > b/examples/ipsec-secgw/ipsec.c index bf88d80..351f1f1 100644 > > > --- a/examples/ipsec-secgw/ipsec.c > > > +++ b/examples/ipsec-secgw/ipsec.c > > > @@ -500,7 +500,7 @@ enqueue_cop_burst(struct cdev_qp *cqp) > > > cqp->id, cqp->qp, ret, len); > > > /* drop packets that we fail to enqueue */ > > > for (i =3D ret; i < len; i++) > > > - rte_pktmbuf_free(cqp->buf[i]->sym->m_src); > > > + free_pkt(cqp->buf[i]->sym->m_src); > > > } > > > cqp->in_flight +=3D ret; > > > cqp->len =3D 0; > > > @@ -528,7 +528,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > > ipsec_ctx *ipsec_ctx, > > > > > > for (i =3D 0; i < nb_pkts; i++) { > > > if (unlikely(sas[i] =3D=3D NULL)) { > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > } > > > > > > @@ -549,7 +549,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > > ipsec_ctx *ipsec_ctx, > > > > > > if ((unlikely(ips->security.ses =3D=3D NULL)) && > > > create_lookaside_session(ipsec_ctx, sa, ips)) { > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > } > > > > > > @@ -563,7 +563,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > ipsec_ctx *ipsec_ctx, > > > case RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO: > > > RTE_LOG(ERR, IPSEC, "CPU crypto is not supported by > > the" > > > " legacy mode."); > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > > > > case RTE_SECURITY_ACTION_TYPE_NONE: > > > @@ -575,7 +575,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > > ipsec_ctx *ipsec_ctx, > > > > > > if ((unlikely(ips->crypto.ses =3D=3D NULL)) && > > > create_lookaside_session(ipsec_ctx, sa, ips)) { > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > } > > > > > > @@ -584,7 +584,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > > ipsec_ctx *ipsec_ctx, > > > > > > ret =3D xform_func(pkts[i], sa, &priv->cop); > > > if (unlikely(ret)) { > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > } > > > break; > > > @@ -608,7 +608,7 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > > > ipsec_ctx *ipsec_ctx, > > > > > > ret =3D xform_func(pkts[i], sa, &priv->cop); > > > if (unlikely(ret)) { > > > - rte_pktmbuf_free(pkts[i]); > > > + free_pkt(pkts[i]); > > > continue; > > > } > > > > > > @@ -643,7 +643,7 @@ ipsec_inline_dequeue(ipsec_xform_fn xform_func, > > struct ipsec_ctx *ipsec_ctx, > > > sa =3D priv->sa; > > > ret =3D xform_func(pkt, sa, &priv->cop); > > > if (unlikely(ret)) { > > > - rte_pktmbuf_free(pkt); > > > + free_pkt(pkt); > > > continue; > > > } > > > pkts[nb_pkts++] =3D pkt; > > > @@ -690,13 +690,13 @@ ipsec_dequeue(ipsec_xform_fn xform_func, struct > > ipsec_ctx *ipsec_ctx, > > > RTE_SECURITY_ACTION_TYPE_NONE) { > > > ret =3D xform_func(pkt, sa, cops[j]); > > > if (unlikely(ret)) { > > > - rte_pktmbuf_free(pkt); > > > + free_pkt(pkt); > > > continue; > > > } > > > } else if (ipsec_get_action_type(sa) =3D=3D > > > > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > > if (cops[j]->status) { > > > - rte_pktmbuf_free(pkt); > > > + free_pkt(pkt); > > > continue; > > > } > > > } > > > diff --git a/examples/ipsec-secgw/ipsec_process.c > > > b/examples/ipsec-secgw/ipsec_process.c > > > index bb2f2b8..4748299 100644 > > > --- a/examples/ipsec-secgw/ipsec_process.c > > > +++ b/examples/ipsec-secgw/ipsec_process.c > > > @@ -12,22 +12,13 @@ > > > #include > > > > > > #include "ipsec.h" > > > +#include "ipsec-secgw.h" > > > > > > #define SATP_OUT_IPV4(t) \ > > > ((((t) & RTE_IPSEC_SATP_MODE_MASK) =3D=3D > > RTE_IPSEC_SATP_MODE_TRANS && \ > > > (((t) & RTE_IPSEC_SATP_IPV_MASK) =3D=3D RTE_IPSEC_SATP_IPV4)) || \ > > > ((t) & RTE_IPSEC_SATP_MODE_MASK) =3D=3D > > RTE_IPSEC_SATP_MODE_TUNLV4) > > > > > > -/* helper routine to free bulk of packets */ -static inline void > > > -free_pkts(struct rte_mbuf *mb[], uint32_t n) -{ > > > - uint32_t i; > > > - > > > - for (i =3D 0; i !=3D n; i++) > > > - rte_pktmbuf_free(mb[i]); > > > -} > > > - > > > /* helper routine to free bulk of crypto-ops and related packets */ > > > static inline void free_cops(struct rte_crypto_op *cop[], uint32_t n= ) > > > -- > > > 2.7.4