From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"Dharmappa, Savinay" <savinay.dharmappa@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance
Date: Tue, 21 Apr 2020 11:07:46 +0000 [thread overview]
Message-ID: <BYAPR11MB3301EA77473E6D4D39FCDCEC9AD50@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <42905568.fMDQidcC6G@thomas>
>
> 21/04/2020 12:21, Ananyev, Konstantin:
> > > 21/04/2020 04:29, Thomas Monjalon:
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -1259,6 +1259,8 @@ F: lib/librte_ipsec/
> > > > > M: Bernard Iremonger <bernard.iremonger@intel.com>
> > > > > F: app/test/test_ipsec.c
> > > > > F: doc/guides/prog_guide/ipsec_lib.rst
> > > > > +M: Savinay Dharmappa <savinay.dharmappa@intel.com>
> > > > > +F: app/test/test_ipsec_perf.c
> > > > > M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > > > > F: app/test/test_ipsec_sad.c
> > > > > F: app/test-sad/
> > > >
> > > > Repeating what I said on v3:
> > > > Having one different maintainer per test file is quite ridiculous.
> > > > The maintainers of a lib are expected to maintain the related tests.
> [...]
> > About having separate MAINTAINER for the test -
> > honestly I don't understand why it is a problem for you.
> > Obviously we would like to spread the load - what's wrong with it?
>
> This is a problem of ownership.
> Maintaining a library means you take care of every aspect, including tests.
> That's why I would like to see you as a global maintainer of IPsec.
>
> It doesn't prevent you to delegate workload, of course.
> But at the end it is more convenient to know there is a limited number
> of persons responsible for the global quality of a component,
> a person which is accountable and answering questions on the topic,
> no matter which exact file we are talking about.
Just talked with Bernard, he kindly agreed to be a maintainer for all ipsec UT:
app/test/test_ipsec*
Hope that will fulfil your concern?
next prev parent reply other threads:[~2020-04-21 11:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 10:53 [dpdk-dev] [PATCH v1] app: test: " Savinay Dharmappa
2020-03-02 11:43 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
2020-03-02 12:51 ` David Marchand
2020-03-02 14:40 ` Medvedkin, Vladimir
2020-03-03 15:34 ` Ananyev, Konstantin
2020-03-05 7:15 ` [dpdk-dev] [PATCH v3] " Savinay Dharmappa
2020-03-05 11:45 ` Ananyev, Konstantin
2020-03-05 17:11 ` Thomas Monjalon
2020-03-05 22:51 ` Ananyev, Konstantin
2020-03-06 8:58 ` Thomas Monjalon
2020-03-10 13:24 ` Ananyev, Konstantin
2020-03-10 20:14 ` Thomas Monjalon
2020-03-06 7:08 ` [dpdk-dev] [PATCH v4] test/ipsec: " Savinay Dharmappa
2020-04-19 21:43 ` Akhil Goyal
2020-04-21 2:29 ` Thomas Monjalon
2020-04-21 2:35 ` Thomas Monjalon
2020-04-21 10:21 ` Ananyev, Konstantin
2020-04-21 10:28 ` Thomas Monjalon
2020-04-21 11:07 ` Ananyev, Konstantin [this message]
2020-04-21 11:49 ` Thomas Monjalon
2020-04-21 12:04 ` Ananyev, Konstantin
2020-04-21 12:58 ` Thomas Monjalon
2020-04-23 15:25 ` [dpdk-dev] [PATCH v5] " Savinay Dharmappa
2020-04-24 10:06 ` Ananyev, Konstantin
2020-05-09 21:46 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3301EA77473E6D4D39FCDCEC9AD50@BYAPR11MB3301.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=savinay.dharmappa@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).