DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Feifei Wang <Feifei.Wang2@arm.com>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] test/ring: add stress test for ST peek API
Date: Wed, 1 Jul 2020 10:34:41 +0000	[thread overview]
Message-ID: <BYAPR11MB3301FB0F79D1AF167F7FA1FA9A6C0@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <AM4PR0802MB221204A9A54A94EC8462A633986F0@AM4PR0802MB2212.eurprd08.prod.outlook.com>


Hi Honnappa,

> 
> Hi Konstantin,
> 	It looks fine overall, few comments inline.
> 
> <snip>
> 
> > Subject: [PATCH] test/ring: add stress test for ST peek API
> >
> > Introduce new test case to test ST peek API.
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > ---
> >
> > This patch depends on the following patch:
> > "ring: fix error vlaue of tail in the peek API for ST mode"
> > (http://patches.dpdk.org/patch/72374/)
> > to run successfully.
> >
> >  app/test/Makefile                   |  1 +
> >  app/test/meson.build                |  1 +
> >  app/test/test_ring_st_peek_stress.c | 54 +++++++++++++++++++++++++++++
> >  app/test/test_ring_stress.c         |  3 ++
> >  app/test/test_ring_stress.h         |  1 +
> >  5 files changed, 60 insertions(+)
> >  create mode 100644 app/test/test_ring_st_peek_stress.c
> >
> > diff --git a/app/test/Makefile b/app/test/Makefile index
> > 7b96a03a6..37bdaf891 100644
> > --- a/app/test/Makefile
> > +++ b/app/test/Makefile
> > @@ -83,6 +83,7 @@ SRCS-y += test_ring_hts_stress.c  SRCS-y +=
> > test_ring_perf.c  SRCS-y += test_ring_peek_stress.c  SRCS-y +=
> > test_ring_rts_stress.c
> > +SRCS-y += test_ring_st_peek_stress.c
> >  SRCS-y += test_ring_stress.c
> >  SRCS-y += test_pmd_perf.c
> >
> > diff --git a/app/test/meson.build b/app/test/meson.build index
> > 5233ead46..4ec7da6b2 100644
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> > @@ -108,6 +108,7 @@ test_sources = files('commands.c',
> >  	'test_ring_peek_stress.c',
> >  	'test_ring_perf.c',
> >  	'test_ring_rts_stress.c',
> > +	'test_ring_st_peek_stress.c',
> I think we should rename test_ring_peek_stress.c to test_ring_mpmc_hts_peek_stress.c to be consistent with this?

Ok, maybe then:
'test_ring_st_peek_stress.c' and 'test_ring_mt_peek_stress.c'
to keep naming convention the same?

> 
> >  	'test_ring_stress.c',
> >  	'test_rwlock.c',
> >  	'test_sched.c',


  reply	other threads:[~2020-07-01 10:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 16:21 Konstantin Ananyev
2020-06-30 23:01 ` Honnappa Nagarahalli
2020-07-01 10:34   ` Ananyev, Konstantin [this message]
2020-07-01 14:05     ` Honnappa Nagarahalli
2020-07-02 14:10 ` [dpdk-dev] [PATCH v2 0/2] extend test coverage for ring PEEK API Konstantin Ananyev
2020-07-02 14:10   ` [dpdk-dev] [PATCH v2 1/2] test/ring: add stress test for ST peek API Konstantin Ananyev
2020-07-02 16:18     ` Honnappa Nagarahalli
2020-07-02 14:10   ` [dpdk-dev] [PATCH v2 2/2] test/ring: rearrange names for ring stress tests Konstantin Ananyev
2020-07-02 16:18     ` Honnappa Nagarahalli
2020-07-03  1:46     ` [dpdk-dev] 回复: " Feifei Wang
2020-07-03  2:37       ` [dpdk-dev] " Honnappa Nagarahalli
2020-07-03  3:01         ` [dpdk-dev] 回复: " Feifei Wang
2020-07-03 10:40   ` [dpdk-dev] [PATCH v2 0/2] extend test coverage for ring PEEK API David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3301FB0F79D1AF167F7FA1FA9A6C0@BYAPR11MB3301.namprd11.prod.outlook.com \
    --to=konstantin.ananyev@intel.com \
    --cc=Feifei.Wang2@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).