From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B92D6A0093; Mon, 7 Nov 2022 10:17:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A613240156; Mon, 7 Nov 2022 10:17:50 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 5841E40151 for ; Mon, 7 Nov 2022 10:17:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667812669; x=1699348669; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IaPtEkVW1QrVprO2pWusox2hQKB1KTS8u143jeGhcgA=; b=PevyLTVsW86tmLliNmQTowgXPBHd8jv8jyNJa7+sYVKTTHlqEguL4f1u EC4FvX0H+LPMvquyVbBryD+kMzbQflCbSFF7otj4WpsPU3xiQh/ljp5jh /Msu8N+POwinUFewMwI++7GvvK+gHGV21ktR/U7/f2XzL3yMjaQ/5B6Ec F/f6iW41sG2x1zwf0wEO0V4zsfgO0LLeo23ymYpR4WQeZxU52snNLMWmj 3rqajHgnbxaPe7FeGuU1vL0BfQNIT8D40ktM9cxJ+9KyeDDDXEb6y1her mrJpi2Ujzmzue+G4ahdb0Jwpf3mmT+s+BNh4UsSStDBuHOVXE9ADsuPDO w==; X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="309076727" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="309076727" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 01:17:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10523"; a="778416171" X-IronPort-AV: E=Sophos;i="5.96,143,1665471600"; d="scan'208";a="778416171" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 07 Nov 2022 01:17:25 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 01:17:25 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 01:17:25 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 01:17:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D+AoeSN3rLxqMIYK+kCheMiU31ozgu5S4kJt9ckBOJXGq3BAZHO+gZYE1C3ZkFcpuqwDt9mrQnzrg8mc5b4IIY4/l9XN/mAMNzpbs0dVcSCqz30vXX4Gzaj3WzuNzChcx3APmCBJv/+Z23f9U8D3pdHIs/XdyKcXsabS/XMYOLeLByjErvTHzLseQF3NhjYGTnUQqAZhY5XKq3Dr1zeIufClmQYsu7x5hy5nTXQ6j1CiSGN60tuE3qPbymKPLKrKeaVtqb68FBE4TbjmUdvh5tc254xl3jWosowRbD8eSW2imr3JWdAvgCTYbNsMConRrP+PQGa4T32hvIOp13ycAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IaPtEkVW1QrVprO2pWusox2hQKB1KTS8u143jeGhcgA=; b=ic/ldWy8ZN21dMjf9d1XmgQuOqO9hbjCcPtfKdqozxkEtDCOwY3IFz2mwj1Fx4nqhObd1TeW55icTbVNKGPcLk+HzoTHLyRG2d5lwhQV0MlVWmqm9iu4rTucQ2WjMqSkIP9VniiRChe7RAmibbZmibFGH9vYF6tzzSCFJsAiwzP0c+X7NwISkhkK4txZivVCKMTD5UVbDyJ10lbKVa+W5hZnl7spSTu6DR0P+VFY/JmgYBHYh2CVF45bHND59Qv5ztPQsur7kDEp8qJZxPWUDw1Lh9UtO6vJ22kapUnZmqoLV3Skr7PZY044qlbH85ri6IRU+1qyflPR1SZzo+uixg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by CY5PR11MB6139.namprd11.prod.outlook.com (2603:10b6:930:29::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Mon, 7 Nov 2022 09:17:22 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::3929:1ad6:fdc4:2691]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::3929:1ad6:fdc4:2691%4]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 09:17:22 +0000 From: "Pattan, Reshma" To: "Kearney, Tadhg" , "dev@dpdk.org" CC: "Hunt, David" , "Burakov, Anatoly" , "Macnamara, Chris" Subject: RE: [PATCH] power: fix double free of opened files Thread-Topic: [PATCH] power: fix double free of opened files Thread-Index: AQHY8GnbSHvGM1w5P0qyMGTkKIaLGK4zMcpA Date: Mon, 7 Nov 2022 09:17:22 +0000 Message-ID: References: <20221012082928.2171562-1-tadhg.kearney@intel.com> <20221104162353.187145-1-tadhg.kearney@intel.com> In-Reply-To: <20221104162353.187145-1-tadhg.kearney@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|CY5PR11MB6139:EE_ x-ms-office365-filtering-correlation-id: bb076dc7-c138-4576-8307-08dac0a0e098 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BYKiFglTvRaUf/mNauKiSHp+6kq3u8caoTfjDMNki40He4nYQMdvhiwMKDKsjB14x0ID8lr1/y1mNT29+R+NZig4Kn+ehPeMnrqm5g4iCKu8PF4uCSb5qNjKXj5t3dYeM/2Xx3C+NHlIZSdzAeSjvbvjS50Lvr1XIsCiIlkpatmnIEAkrhdHutu5LpiZymkBRt5PZ+/+RV/VfaUJXfhFsHVGYkOCavYcFXE5JvMe1O1jymnRbKl/5yzIF+jXonG5kHLE8m5ZeAi1TLmuVp53VHDE8n2EoZGJaswg0W4FGKTwdTeVHzytXhHCKrVzA69Rl26oKJ9tA33arD2kv/SQqZnWs/USGEpH1YOp2w1xPhYsO83lGR7HNv4jIeMiy7zhXyJECMYtwQrgKkhIwAQGvp/14rpCz3nLCkvV9VEJzRA9VUlgg7ZLpISi65fC/fK3AodUBL8Kn/5fykK0DASQde3h7UfkPop4Iq3pIqwr6n+hvdRD30wlUkfWIO55yG/xgOWWp3ee8w1EfLrN1i75PK4XlSmiP6dcCzVOe4VbKXHgS0Q4iQ6HOAiQGRumhqU405aOtKZLsDOshdCLOF9H0gxsEiKm/aibOSFUkKnK9WBwAs7pkv9BCAKG70VfVWTBXf/rPxZqAWnwVYos5tf1QceQWvgZHvZWHKWmV6BxOEWt0gw5RpAWnaI2xfl6Ew/hDw9cdYmHrtUFyLNzGJ4FxFUin7pBOL7OV61MuTwaIf8T7arpIMfX5IiVlRZ4S2A1/L4XSu2QYQEwhJ3oxWvT0g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(396003)(376002)(136003)(346002)(451199015)(2906002)(478600001)(33656002)(9686003)(26005)(107886003)(6506007)(7696005)(8936002)(41300700001)(38100700002)(316002)(122000001)(54906003)(4326008)(8676002)(110136005)(38070700005)(66556008)(66946007)(76116006)(82960400001)(66446008)(64756008)(66476007)(4744005)(71200400001)(86362001)(52536014)(55016003)(5660300002)(83380400001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0HoQsU9Hssh+pghLV3VIEjjQ5Oblh0cBHBlV09Z1r6ALNCKWov2N7haQrCre?= =?us-ascii?Q?4RtkWkn+/mjTkEwe1H0yhWgvJp8PRrS6UzKJDkDLNC+fixdOsFy6d6MZ3VMw?= =?us-ascii?Q?pi78XRMf14XmHKi4uMz30TYNrP1KBO+2brd2qu9ftT7ntGhDbR88NXmAn520?= =?us-ascii?Q?GNpWU9rMKeky8RoLIStshjD/J6+YDD7gHv5xwhca2l0WzHAnSMhmL0dhCnmL?= =?us-ascii?Q?RZkoYBzVQ/TWjatWT8IGfBjDUoiblEE/IeBSDLuwZ6u3FSsge6H0vghxUCI/?= =?us-ascii?Q?p7bseDHdsXUXjLCwqfFs3o+zKCTuFc05wLAfqM7YTo6qokqAP9SvXrBb0olh?= =?us-ascii?Q?7576XJFTUZYPRFaCxcw3rQZ3NheosHm9UG7iaMTh7LmE/Ty6mCq9mckGMKbl?= =?us-ascii?Q?OHOztKMkagz0Z5MOwNeH5GdH4yAzPpcDIGZVhf6f32so11cwoxslNgjGVCfB?= =?us-ascii?Q?/FwsSMjX5BzTdspzRhT5Tlbxi0DoL/ZfNFjeZKQRV2QU1QqS/rvZwMRqrSaE?= =?us-ascii?Q?lh8SAAa66K9LFHqbKky1aiZG65F8vs26nV79/tYaKgbQIGR1PZAxmI1r6rim?= =?us-ascii?Q?LFu/xuASTvlon9b85cEoS9k9yzmt4r/XJ6nfCISWd3fqxIYVXl1/u/Cy55qm?= =?us-ascii?Q?QyVCVGAzcdJsZYD3nF+iybZRLkZrQPJu2a22pSN1E99aqX6wu/GC7x0/GH0S?= =?us-ascii?Q?BAWm6s0hDkC5c9w+VCi7Qy8yLVHcFB8G8x2DetwArODaOrTkaTmq+EwtFR2U?= =?us-ascii?Q?NObSx1Az7kdtX7aaOSzvfnAtY5t/t1phiFvE+rtRtm6tNGai0ylZyy4/iy57?= =?us-ascii?Q?8o26DbniPgQx36EBjVdTGGA/AAyMZgAgXNPkjr8vLGA7iFxorepTuVtLa8SR?= =?us-ascii?Q?NZ3jVBs7PaOfIdqDKaqGOfrJ+WXh4HohDeVYucBLKofuYhJWhBMDZ3/ecbA5?= =?us-ascii?Q?IYpZh3Uk9EMdxwxf3s1MLr4EgPMmQ+0a5tvmTphBgX2YHuZbnDCIJipiPwEI?= =?us-ascii?Q?+UhGfudtUwjWvANmda+jnMrhH0T7wqGLGnHkDu7OvP2aVpKHEAgAKm0kS8q2?= =?us-ascii?Q?bTaA2wqKzAnVowDrJMEzZhPozW7yJJri6sGjXMgh8gJKb3uRiRuDsn09qFuS?= =?us-ascii?Q?+cPfAl9C/lmdxZMqxvh8zL3jqr0bis5vescEaHMRH9BBR4DKH9vrqYEjQR/P?= =?us-ascii?Q?ckGq7QF+6+uccxCIZwwT3su/LrpKuhbglUm+bi85DJ4kCq6Zp0awfIAJ8PCw?= =?us-ascii?Q?GK1vBG1J1Ko7OF71Ss6d7x3N8TMjVv9JLPZ40Sff8YUQ+Oxp9OyefJRBbMs0?= =?us-ascii?Q?q4mGct6t5NKTaVRUN++LRHWb+UAUVe756W6BPFgUXJSNQCNMH7PKI9TABUXc?= =?us-ascii?Q?97qskVmC9dQBS5leobKeuHxroGA6BOzrFt7H9Q0oFugzJHu05g442xyRNwhu?= =?us-ascii?Q?xLdxq4GErUahVO0Y9+MbY57qJhJlGeUKr/EC60EzZ8OlqtovUzCi9kx58bwc?= =?us-ascii?Q?3H6tokFRu7LVSHkyVFwzQDrs6CstwTU1IzB5vETyv/nvW1q2Uw49kxrySIva?= =?us-ascii?Q?Bm/eMM8YHGHI5VD2AIZDAlo9ijAzoeXQ+1Bl5y3b?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb076dc7-c138-4576-8307-08dac0a0e098 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 09:17:22.1269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1On8no95yY0NLNCQtHz7qqq0MiJIEGz8SMA2wqdxyUFABB1aPa8NGVf7PxlzMC/mcOv+/95HgClQ4rRltoSZOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6139 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kearney, Tadhg > Subject: [PATCH] power: fix double free of opened files >=20 > Fix double free of f_min and f_max by reverting the flcose() for f_min an= d > f_max. As f_min and f_max are stored for further use and closed in uncore > deinitialization. >=20 > Fixes: b127e74 ("power: fix open file descriptors leak") >=20 > Signed-off-by: Tadhg Kearney > --- Acked-by: Reshma Pattan