From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03D0D42588; Wed, 13 Sep 2023 13:48:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3483402CF; Wed, 13 Sep 2023 13:48:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 4EC0340293 for ; Wed, 13 Sep 2023 13:48:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694605707; x=1726141707; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dysMQatzziAxaPEkwxLR1zfiemds24xXmkiPuvYfjIg=; b=lK/L1YYNwaC03HNnfyrzYwz+FSvMbIByfGy24K4raEH3EzeHnXOT/DMn W4No7AdUsrSFQFee5XFnf4gW+LkSz37ORfgftcdBTxInebHU5JOFW3jjp aY9B1pj7KVaAHXqmjmfFZJHMeRjbn9bymqTMGFSQwgXDPCxtn9WX8uzff 0vH6kV90TVytzd8e2lggKOWruLYq8utoZBRCmVK8Z7V63a7tAuKniWx3O kIURiTk/RMlz40cDq/Z4ryN00j8OPBH/1DqjMmCOhUYO/LMkivm3SPwvu pAomrf1xGpi1nvzuY+0mwFgLzCuJAcugOZb6aElmqKv7FcRvc9FWrzc9v w==; X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="382440560" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="382440560" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2023 04:48:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10831"; a="867764127" X-IronPort-AV: E=Sophos;i="6.02,143,1688454000"; d="scan'208";a="867764127" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Sep 2023 04:48:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 13 Sep 2023 04:48:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 13 Sep 2023 04:48:20 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 13 Sep 2023 04:48:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 13 Sep 2023 04:48:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G8PZqWcSG8BVHaiLydbEO9hrttptmBfge1e11x6ndDsXyQ1VFUmsRFFLwUkfpuwCaBzAmQa2rSsw4Sso+4SV0oxZsLllOm+4chS1oqZx2xivfxMsmgOb3T4gNWWLrghM73VHHEWSkVEiUOpOxcPiiKdXBfceIXyvRPCwz5x56JCbqKHcMaeUP5XhtUJA4ej0TtjBlFicyHmWifDLKClGuoG5Pzi8M/42YzqKL7eiET9RlWGsRqjbdqp3WdxipBNLifmGUJ3nf1S+iFXWWBcbnWPLaaoSe3V1eg+13YiBKWRjmtkgY3wFk5hRB1qEQBru65pURw/3R6U3u4gUtKkCnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dysMQatzziAxaPEkwxLR1zfiemds24xXmkiPuvYfjIg=; b=WrAPj9AM4DqHRZqnZaw4QNIl8HmCIFPtOk9ZfGv1w1RlnCD8jwtrxWZEUadnVq+nhSC4PbL+gNWhk0mcDdVe2dmqRSs8Oc5MYfaGaAzxZkRGchwVZcn0Ki3a+rbJVZQekbJeX5aQCvaIqCKSQABHlCWKioKmUo/jkxe+3rJSEeaqAxG1jcxD+V+zQIYpTwLnVQve2q/tAb25UpKswzmh6oMUSgTNwUzfjp0JCLCpteu0KwL1VkLmvQTpV0iWJrye76x7pcHQ3AX176+xis+n1Y58EDuHefaPanGnhzPE0uVdA4SJVDW3GJT8mCBqU0NaKdbjLRJGxrn8VaNC6l+AGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by SJ2PR11MB7545.namprd11.prod.outlook.com (2603:10b6:a03:4cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.34; Wed, 13 Sep 2023 11:48:18 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::1f83:8715:507c:7a6d]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::1f83:8715:507c:7a6d%4]) with mapi id 15.20.6768.036; Wed, 13 Sep 2023 11:48:18 +0000 From: "Pattan, Reshma" To: Jie Hai , "dev@dpdk.org" , "Vipin Varghese" , "Mcnamara, John" CC: "lihuisong@huawei.com" Subject: RE: [PATCH v4 4/7] app/proc-info: fix never show RSS info Thread-Topic: [PATCH v4 4/7] app/proc-info: fix never show RSS info Thread-Index: AQHZ4isvvggHql2910ydYCey5tQcK7AYq5MA Date: Wed, 13 Sep 2023 11:48:18 +0000 Message-ID: References: <20230904072851.7384-1-haijie1@huawei.com> <20230908080030.3837515-1-haijie1@huawei.com> <20230908080030.3837515-5-haijie1@huawei.com> In-Reply-To: <20230908080030.3837515-5-haijie1@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|SJ2PR11MB7545:EE_ x-ms-office365-filtering-correlation-id: e623feda-ef6a-4a92-4b7c-08dbb44f5268 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: whtPejxL7dIoq2KaEoc7tS4xz0rRdbqwEhsvHbXlDxG+alUz4YpqiXA9jcmrsggz5R/N3a4+p+QAjSSAe6V59Ygp0A32zYwv7sefsbEOBV00Skl1GCJGFATUPx+Ui86zD/kiYT589anYrNLWe3zgR73zC1IwjfRB7ATkugpYxWJM+Jbn9WHwes9b5dOW1QmW/uA1j/Tcolzy1n2/BNoQkPw1VrkTj7xFwoZgmUlZ7GJbub/1Q1tazi9njTANkk5fD4vMs+s3xrVKYNBgbu9BLRPp/BTFjO7Mx5pV6nO0OAuuw0dY1q6BZPPOkE/TD9PTBeG9PqItKhsLVWxshIMepe4kYySc441UdkII+kM2tSrQSGFlCiuZDqm/mecSA+JL7JPL5Q4+UXLhoC7/LMmdBmrdfJ2DtTeJ2W2C0fLBy3/DRQQ3wThZXXz9qqawlDEkfq4rtm62etuCjbCZheG4FwId9XN3BIE30BSs+fJGFs/v8EE4XIeJQXLyaqpX6xAYqdqTI2dL0Tdb82U3BlJV4nfHTEEdohsPwvYDq19Op1jjXVcHdOuhejOiqbjg84kpeYb7WnC/ZRHNIWrCWwOLtVuX+JFYI+/6Sq3c0+yM48NhEYfAEDIy4tCJrB+mbDad x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(346002)(366004)(376002)(396003)(186009)(1800799009)(451199024)(8676002)(83380400001)(4326008)(8936002)(52536014)(9686003)(71200400001)(76116006)(6636002)(66446008)(66946007)(64756008)(66556008)(66476007)(53546011)(26005)(110136005)(316002)(7696005)(6506007)(2906002)(122000001)(38070700005)(55016003)(82960400001)(38100700002)(5660300002)(41300700001)(4744005)(86362001)(33656002)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1/RTxnl2J+KIJUysNPaEvdBFHP7T2Try3KgIhl2axdNVLi+GaAGiQgtSKfeG?= =?us-ascii?Q?Ek/3XEKzPUjzdxxS4K2a/gtMbF1XyWATO9P5/2Dqg+jlVDfyUop7uecqLM54?= =?us-ascii?Q?QVssiMMBfcPjYQyjxlTTqOy/9L+q0/neMMm0gq43+QYkVwdMa1eIn7wrOyDY?= =?us-ascii?Q?YoOnQyb0BxP1u6PsAsv5SqjdJifdJ0Knhqb8B6iQskAOnRrn87ADwUPudSMV?= =?us-ascii?Q?uNzOd3MiJJ5affNu4rn6qPH6RMWHnKqjF+dE/ODnCtzcqWav62oK9vJZcp6J?= =?us-ascii?Q?5cr+impA60aHABKmrPS99BDyDexw7tUzGzZXtR4/ItUoxoShK5hgRFLiwag1?= =?us-ascii?Q?OjIj16dRbYvadB/cUbdHMaVUmWnDT1gtrTDczOi6ziv+hHyPABhCPRoyUbyJ?= =?us-ascii?Q?1IURpeNTAg5u+QyX8lSUH13pU0rSygKwd6/dLV/RfuS/pAJvHgXaDV8/dSmE?= =?us-ascii?Q?TTMmV+2lBdgkt9+iz6IGWw9Fj7694d+Kc7OR3C0FOvAqYgfjSccmjzFWQzrJ?= =?us-ascii?Q?K139g/CUse+VTDHql7bEr1SwX92P5TTiMWowJvwK6m+lHIMUOrLlOauFh2+A?= =?us-ascii?Q?mblSybICVZ1dMwv6Q7M7zqWiIrXxNyBICyr789OfsFQXW1gmL13BldIN2gdS?= =?us-ascii?Q?lMP/hJV61EuZDiGfYJOLZJI3G7TnvHiBBdqLWE3+Q7FTaiWwArZmeQlq0hQy?= =?us-ascii?Q?RV+Q3uyTj6DRPxXcWyRdqfGBYV5ZXird/NO1JdUcR3kMK1jueteyHL7JQnyz?= =?us-ascii?Q?q2cxi1vsHwqd9LBI8OR1MfOFJ8jKHcLRdR2ewvjt/zXcw0BfkxGiK6E1d85z?= =?us-ascii?Q?WKOmSVG0IFqnsgR8I1G79s8VrMWN4HRIhLWkdDVme3bE6bXGaIeVloqvfrp9?= =?us-ascii?Q?bK152Te2iOedWFjvCdZ/kRJ37oSLvm4wTxu6eIKYq/leBQbMNxQZFYutpdcq?= =?us-ascii?Q?7RNIpmol57B3J7WvsywFl1DJqF4Nvb0suDLdDrOZAC8NV2eHeJrdN/ySuXAx?= =?us-ascii?Q?PwzeT89dEtvqHKRiNsHXHcZOe38Pv171mdTug6KSrdu7CXtqi3zzS+e34weI?= =?us-ascii?Q?AEXSsLZRv+K8NzIexBuBQPFP4EjUAlVKrJMQIqYZaCTDuRbE/PIxMiDE3lmy?= =?us-ascii?Q?GJv9FPatL2P5HqSHvYVHIJbzrojbKU2bLbU8RLqya0C0OzIxycQsWgHte7+d?= =?us-ascii?Q?Fw8Sdv04OGjBZWROBYbRdqf5fPDSFC36Yng6LsJ3uKjSeuvuwsagPz0qGtjf?= =?us-ascii?Q?D4RrIGTtMIIEEvBvzyHLbWEaKsFu2Az7wxOf8oZeKUmX+d2X3Joq0cruP3iG?= =?us-ascii?Q?bLmZmsepbB3UY5XXKKNJJ7elDvcHzbXcjifur7KRgTGOJsggqSTYfnFwN1PA?= =?us-ascii?Q?4klI5+ZaTIe1U5zpM6wvw8HwtZqmk9MtGufKY9AnjHpuJd3LZDShKsY2qk7F?= =?us-ascii?Q?f02REGI00sTtd22dpNnKpmMY5SsUKubOdVG1w+3F2XHMqCVWL0holIpE+OLR?= =?us-ascii?Q?9FDiScDwpU8nvBqCaTJ3Mdg8q7IlVgthBlyd0etiSUfIsYwmhhg5I6TYSoPC?= =?us-ascii?Q?dndNgytZXfClo8Q7GKH+PnwkG+jwX5B/7wv49rRV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e623feda-ef6a-4a92-4b7c-08dbb44f5268 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2023 11:48:18.0503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Bec6zrjUjCLsvKqBwpPQteLxPu/9aTuuwjerxwYV+KRZPrUZqIWblFu1f+78jJEOwKvHSAUgI7eI5hfWmJYozQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7545 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jie Hai > Sent: Friday, September 8, 2023 9:00 AM > To: dev@dpdk.org; Pattan, Reshma ; Vipin > Varghese ; Mcnamara, John > > Cc: haijie1@huawei.com; lihuisong@huawei.com > Subject: [PATCH v4 4/7] app/proc-info: fix never show RSS info >=20 > Command show-port should show RSS info (rss_key, len and rss_hf), However= , > the information is shown only when rss_conf.rss_key is not NULL. Since no > memory is allocated for rss_conf.rss_key, rss_key will always be NULL and= the > rss_info will never show. This patch allocates memory for rss_conf.rss_ke= y and > makes it possible to show RSS info. >=20 Nitpick: You have to change the commit message as malloc and free not used now. Acked-by: Reshma Pattan